GNU bug report logs - #47333
[PATCH 2/2] Enable test of minetest

Previous Next

Package: guix-patches;

Reported by: la snesne <lasnesne <at> lagunposprasihopre.org>

Date: Tue, 23 Mar 2021 00:07:02 UTC

Severity: normal

Tags: patch

Done: la snesne <lasnesne <at> lagunposprasihopre.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47333 in the body.
You can then email your comments to 47333 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#47333; Package guix-patches. (Tue, 23 Mar 2021 00:07:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to la snesne <lasnesne <at> lagunposprasihopre.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 23 Mar 2021 00:07:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: la snesne <lasnesne <at> lagunposprasihopre.org>
To: guix-patches <at> gnu.org
Cc: la snesne <lasnesne <at> lagunposprasihopre.org>
Subject: [PATCH 2/2] Enable test of minetest
Date: Tue, 23 Mar 2021 09:06:34 +0900
---
 gnu/packages/games.scm | 12 ++++++++++--
 1 file changed, 10 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index f1ee7e9971..0ccbde636a 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3482,7 +3482,7 @@ match, cannon keep, and grave-itation pit.")
                   #t))))
     (build-system cmake-build-system)
     (arguments
-     '(#:configure-flags
+     `(#:configure-flags
        (list "-DRUN_IN_PLACE=0"
              "-DENABLE_FREETYPE=1"
              "-DENABLE_GETTEXT=1"
@@ -3493,7 +3493,15 @@ match, cannon keep, and grave-itation pit.")
              (string-append "-DCURL_INCLUDE_DIR="
                             (assoc-ref %build-inputs "curl")
                             "/include/curl"))
-       #:tests? #f))                    ;no check target
+       #:phases
+       (modify-phases %standard-phases
+         (replace 'check
+           (lambda _
+             (setenv "HOME" "/tmp")
+             (invoke (string-append "../" ,name "-" ,version
+                                    "-checkout/bin/minetest")
+                     "--run-unittests")
+             #t)))))
     (native-search-paths
      (list (search-path-specification
             (variable "MINETEST_SUBGAME_PATH")
-- 
2.31.0





Reply sent to la snesne <lasnesne <at> lagunposprasihopre.org>:
You have taken responsibility. (Tue, 23 Mar 2021 00:24:02 GMT) Full text and rfc822 format available.

Notification sent to la snesne <lasnesne <at> lagunposprasihopre.org>:
bug acknowledged by developer. (Tue, 23 Mar 2021 00:24:02 GMT) Full text and rfc822 format available.

Message #10 received at 47333-done <at> debbugs.gnu.org (full text, mbox):

From: la snesne <lasnesne <at> lagunposprasihopre.org>
To: 47333-done <at> debbugs.gnu.org
Subject: oops
Date: Tue, 23 Mar 2021 09:22:54 +0900
[Message part 1 (text/plain, inline)]

[OpenPGP_0x3DCFB2469F9A726F.asc (application/pgp-keys, attachment)]
[OpenPGP_signature (application/pgp-signature, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#47333; Package guix-patches. (Tue, 23 Mar 2021 07:32:02 GMT) Full text and rfc822 format available.

Message #13 received at 47333 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: la snesne <lasnesne <at> lagunposprasihopre.org>, 47333 <at> debbugs.gnu.org
Subject: Re: [bug#47333] [PATCH 2/2] Enable test of minetest
Date: Tue, 23 Mar 2021 08:31:36 +0100
[Message part 1 (text/plain, inline)]
On Tue, 2021-03-23 at 09:06 +0900, la snesne wrote:
> -       #:tests? #f))                    ;no check target
> +       #:phases
> +       (modify-phases %standard-phases
> +         (replace 'check
> +           (lambda _
> +             (setenv "HOME" "/tmp")
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests")
> +             #t)))))

For most packages, this is unlikely to work when cross-compiling.
I suggest replacing it with something like

> +           (unless ,(%current-target-system)
> +             (invoke (string-append "../" ,name "-" ,version
> +                                    "-checkout/bin/minetest")
> +                     "--run-unittests"))
> +           #t

Well, cross-compiling minetest won't work anyway as a dependency is not
cross-compilable:

$ guix build minetest --target=aarch64-linux-gnu
$ guix build: error: gnu/packages/gl.scm:236:2: mesa <at> 20.2.4: build system `meson' does not support cross builds

(and I see little reason to cross-compilable minetest)
... but it still seems a good idea to avoid introducing new
cross-compilation issues when we can avoid it.

Greetings,
Maxime
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 20 Apr 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 344 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.