GNU bug report logs - #47345
perl-mode: Fix some regexps for fontification [PATCH]

Previous Next

Package: emacs;

Reported by: haj <at> posteo.de (Harald Jörg)

Date: Tue, 23 Mar 2021 14:58:02 UTC

Severity: minor

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47345 in the body.
You can then email your comments to 47345 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#47345; Package emacs. (Tue, 23 Mar 2021 14:58:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to haj <at> posteo.de (Harald Jörg):
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 23 Mar 2021 14:58:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: bug-gnu-emacs <at> gnu.org
Subject: perl-mode: Fix some regexps for fontification [PATCH]
Date: Tue, 23 Mar 2021 15:57:36 +0100

[Message part 1 (text/plain, inline)]
Severity: minor

Following a discussion with Stefan Monnier on the developer list:

 - In "use Package;" the package name is now captured for fontifying
   as intended

 - The declarators "my" etc. now use font-lock-keyword-face for better
   consistency with other programming modes

 - As a by-catch, now all components of package names like
   "Long::Package::Name" are fontified.  This was a known issue of
   little importance, not yet reported as a bug.

 - A test is included as well.
-- 
Cheers,
haj


[0001-perl-mode-Fix-regexps-for-fontification.patch (text/x-diff, attachment)]
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#47345; Package emacs. (Wed, 24 Mar 2021 16:07:02 GMT) Full text and rfc822 format available.

Message #8 received at 47345 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 47345 <at> debbugs.gnu.org
Subject: Re: bug#47345: perl-mode: Fix some regexps for fontification [PATCH]
Date: Wed, 24 Mar 2021 17:06:44 +0100

haj <at> posteo.de (Harald Jörg) writes:

> Following a discussion with Stefan Monnier on the developer list:
>
>  - In "use Package;" the package name is now captured for fontifying
>    as intended
>
>  - The declarators "my" etc. now use font-lock-keyword-face for better
>    consistency with other programming modes
>
>  - As a by-catch, now all components of package names like
>    "Long::Package::Name" are fontified.  This was a known issue of
>    little importance, not yet reported as a bug.
>
>  - A test is included as well.

Thanks; looks good to me.  Pushed now to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 24 Mar 2021 16:07:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 47345 <at> debbugs.gnu.org and haj <at> posteo.de (Harald Jörg) Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Wed, 24 Mar 2021 16:07:03 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 22 Apr 2021 11:24:06 GMT) Full text and rfc822 format available.
This bug report was last modified 3 years and 4 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.