Jacob Bachmeyer <jcb62281@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.
Received: (at 47385) by debbugs.gnu.org; 27 Mar 2021 04:18:37 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 27 00:18:37 2021
Received: from localhost ([127.0.0.1]:43114 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lQ0PF-00056q-HS
for submit <at> debbugs.gnu.org; Sat, 27 Mar 2021 00:18:37 -0400
Received: from mail-ot1-f46.google.com ([209.85.210.46]:46954)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <jcb62281@HIDDEN>) id 1lQ0PE-00056d-A6
for 47385 <at> debbugs.gnu.org; Sat, 27 Mar 2021 00:18:36 -0400
Received: by mail-ot1-f46.google.com with SMTP id
68-20020a9d0f4a0000b02901b663e6258dso7133462ott.13
for <47385 <at> debbugs.gnu.org>; Fri, 26 Mar 2021 21:18:36 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
h=message-id:date:from:reply-to:user-agent:mime-version:to:cc:subject
:references:in-reply-to:content-transfer-encoding;
bh=xVEBmPN4AzEFza9RcJcwhx1S/hkBV7Ta7MEuV+5IEhA=;
b=CSrRs9Ss9N3MdaummTb2evyldSgcus2gid/Ru1Gxz/819K+2XoDEUUJqyh27ORcKI1
F2SPlZ5nIQNBeKlL84JN/4Wwfpuk3dLMs3tVLNjZ1RsAp+gztMaMp9hcBCAtQistYi9w
tiu6v36q9trnIy4lTgcCOCfeR+Av2iIgio0w7jF0BVs20FD/uk4oxdnfrXxo4rhViCFG
kz4XhtPAfY++in5FnVe1SZ8YdX/Bw2H8yjysaR2cYGmDw8fzNngj+yLm4Dp+qU47XcLf
kcJ944xbHwgxmSCPXKoZmdS8Atudg4Nkj0IvLIhVAuKTE91xd+tW8GHW7ddKqarjD7HI
ZYkw==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
d=1e100.net; s=20161025;
h=x-gm-message-state:message-id:date:from:reply-to:user-agent
:mime-version:to:cc:subject:references:in-reply-to
:content-transfer-encoding;
bh=xVEBmPN4AzEFza9RcJcwhx1S/hkBV7Ta7MEuV+5IEhA=;
b=scLfBsso3zFbW6y1fIH0NqLtMd/5D9SO7bMvVaPs+3fr5lVw+AAX7zEmRcNBn9ytog
Q8ZvNpkL//OjUCDpu764JqJm1yLq/Z9gb+9jQQN4CbCLIb2lUG4AD2a2J2EcLx/pdeVf
jorQm6Y4Si0uqinuTwrkqcXBoek8EGpWXKK0UNMU+KqQ2WCMJdYhtdK+WEs6Kk6yNFPJ
kyao+mLp26iygxyHbW3Y1C1R0AWrSS7uzJAkWxTXDX4nspDtZBD/7oNS58O9xvm+sf6H
5JglrmRCnyyP7zM2ItAys6Q/+YVv+4xE68ghL8bgNE7o079cMP5d/fRfsvGZVrohqxhZ
XuzA==
X-Gm-Message-State: AOAM531jhKDgh2sxzkcfCAIy/0UECFpshoEiwcRlSal5oJm3KNlwufCk
PYvS66hbug5keRxwcdPTIaC98aJ9zJ0=
X-Google-Smtp-Source: ABdhPJxtKTHqVsHlQ+vMk5pbLzcQkC3fGQmk5yonMMzpJnuEikGs5US/Y8/0dgZm+bwYEFJ+Gf67Nw==
X-Received: by 2002:a05:6830:158c:: with SMTP id
i12mr14236926otr.7.1616818710327;
Fri, 26 Mar 2021 21:18:30 -0700 (PDT)
Received: from [192.168.2.42] (adsl-70-133-144-213.dsl.ablntx.sbcglobal.net.
[70.133.144.213])
by smtp.gmail.com with ESMTPSA id 3sm2542477otw.58.2021.03.26.21.18.29
(version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128);
Fri, 26 Mar 2021 21:18:29 -0700 (PDT)
Message-ID: <605EB215.3060308@HIDDEN>
Date: Fri, 26 Mar 2021 23:18:29 -0500
From: Jacob Bachmeyer <jcb62281@HIDDEN>
User-Agent: Mozilla/5.0 (X11; U; Linux x86_64; en-US;
rv:1.8.1.22) Gecko/20090807 MultiZilla/1.8.3.4e SeaMonkey/1.1.17
Mnenhy/0.7.6.0
MIME-Version: 1.0
To: Rainer Orth <ro@HIDDEN>
Subject: Re: bug#47385: make check confused by ../../expect/expect directory
References: <yddh7kzpgiv.fsf@HIDDEN>
In-Reply-To: <yddh7kzpgiv.fsf@HIDDEN>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 47385
Cc: 47385 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Reply-To: jcb62281@HIDDEN
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)
Rainer Orth wrote:
> When running make check on Solaris, I initially got lots of failures
> like the following:
>
> Running /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.exp .
> ..
> ERROR: tcl error sourcing /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runte
> st.libs/libs.exp.
> ERROR: tcl error code POSIX EACCES {permission denied}
> ERROR: couldn't execute "/vol/gcc/obj/dejagnu/dejagnu-1.6.3-rc1/../../expect/exp
> ect": permission denied
> while executing
> "spawn $EXPECT"
> (procedure "start_expect" line 10)
> invoked from within
> "start_expect"
> (file "/vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.ex
> p" line 99)
> invoked from within
> "source /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.exp"
> ("uplevel" body line 1)
> invoked from within
> "uplevel #0 source /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs
> /libs.exp"
> invoked from within
> "catch "uplevel #0 source $test_file_name" msg"
>
> It turns out that there I happened to have a ../../expect/expect
> directory there.
>
> Unfortunately, lib/runtest.exp (findfile), which is called from at the
> beginning of testsuite/lib/runtest.exp, only uses "file exists" which
> also works for directories, thus the diagnosis.
You are correct that code in DejaGnu that expects to locate an
executable can incorrectly accept a directory with search permission.
The immediate cause for these test failures is some very old code that
had been unused for years and was updated and used as part of the new
internal testsuite infrastructure in 1.6.3. The support for
automatically locating an Expect executable in the old Cygnus layout was
misfiring on the ../../expect/expect directory you had, and this support
will be removed in 1.6.3-rc2 and replaced with better handling of the
EXPECT variable. Users wishing to use a special Expect binary with
DejaGnu's internal testsuite will need to pass EXPECT=/path/to/expect
explicitly to either runtest or make check; additional code now ensures
that the latter case is supported. An entry for this change has been
added to NEWS.
However, this will also be a known bug in the 1.6.3 release as it has
uncovered a larger issue: a later check in testsuite/lib/runtest.exp is
supposed to immediately throw a fatal error if the EXPECT variable does
not refer to an executable, but utils.exp:which has the same problem of
accepting a directory with search permission as valid. While
runtest.exp:findfile is likely to be deprecated or revised, it is an
undocumented procedure, while utils.exp:which is in the manual and is
specified to locate executable files.
The initial fix that should allow tests to complete is in commit
ed6511a32895f6af1451adcdd42815adcde7341a and will be included in release
candidate 2.
-- Jacob
bug-dejagnu@HIDDEN:bug#47385; Package dejagnu.
Full text available.
Received: (at submit) by debbugs.gnu.org; 25 Mar 2021 12:25:06 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Thu Mar 25 08:25:06 2021
Received: from localhost ([127.0.0.1]:37390 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lPP2w-0005b4-50
for submit <at> debbugs.gnu.org; Thu, 25 Mar 2021 08:25:06 -0400
Received: from lists.gnu.org ([209.51.188.17]:43718)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <ro@HIDDEN>) id 1lPP2u-0005ax-LM
for submit <at> debbugs.gnu.org; Thu, 25 Mar 2021 08:25:04 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:45290)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ro@HIDDEN>)
id 1lPP2t-0004Sd-Mb
for bug-dejagnu@HIDDEN; Thu, 25 Mar 2021 08:25:04 -0400
Received: from smtp.cebitec.uni-bielefeld.de ([129.70.160.84]:45990)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <ro@HIDDEN>)
id 1lPP2q-0004l0-EK
for bug-dejagnu@HIDDEN; Thu, 25 Mar 2021 08:25:03 -0400
Received: from localhost (localhost [127.0.0.1])
by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTP id 0B8F447C2
for <bug-dejagnu@HIDDEN>; Thu, 25 Mar 2021 13:24:57 +0100 (CET)
X-Virus-Scanned: amavisd-new at CeBiTec.Uni-Bielefeld.DE
Received: from smtp.CeBiTec.Uni-Bielefeld.DE ([127.0.0.1])
by localhost (smtp.cebitec.uni-bielefeld.de [127.0.0.1]) (amavisd-new,
port 10024) with ESMTP id Qf8SZIhZ1s-W for <bug-dejagnu@HIDDEN>;
Thu, 25 Mar 2021 13:24:56 +0100 (CET)
Received: from manam.CeBiTec.Uni-Bielefeld.DE (p50854142.dip0.t-ipconnect.de
[80.133.65.66])
by smtp.CeBiTec.Uni-Bielefeld.DE (Postfix) with ESMTPSA id ADCE543F5
for <bug-dejagnu@HIDDEN>; Thu, 25 Mar 2021 13:24:56 +0100 (CET)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple;
d=CeBiTec.Uni-Bielefeld.DE; s=20200306; t=1616675096;
bh=TdTTUPAO5/3+kyjSzLtCxoJSKYTa6iDD/XGtR4g/nrE=;
h=From:To:Subject:Date:From;
b=ZrHfwWdPWO+5XVYBRh3qFR7TZ+Luf17emCFCH1A4kwjJlbalvO8d6+m1bjq4+DtwB
kQ1Y127yAIQnvhrYQtI7OKiodI5uiA8/KbK4YhWdggdNtSFE3+do3cUxzZ44I7Fl9k
m5gLlC2YLHF2lDtyD5/p+SC+Bop8nUB4Z4QEIsvdOFCZPw+5q1fGgv8TJS2ZbGrtbW
g6DztCc2YClomL6ZHFks3rDyHN/r6nV2GmhGyiQQCDRRIn3bvYEkhdviRB8nDnEv1/
GF7dDoEpn8n/CtNmAtbA0VS83q8QtWEvxaArTzDGLQxjyvEoYSXp30UQw6qwo2fsM0
Eb2c4/j3W9oGQ==
From: Rainer Orth <ro@HIDDEN>
To: bug-dejagnu@HIDDEN
Subject: make check confused by ../../expect/expect directory
Date: Thu, 25 Mar 2021 13:24:56 +0100
Message-ID: <yddh7kzpgiv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1.90 (usg-unix-v)
MIME-Version: 1.0
Content-Type: text/plain
Received-SPF: none client-ip=129.70.160.84;
envelope-from=ro@HIDDEN; helo=smtp.CeBiTec.Uni-Bielefeld.DE
X-Spam_score_int: -42
X-Spam_score: -4.3
X-Spam_bar: ----
X-Spam_report: (-4.3 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, RCVD_IN_DNSWL_MED=-2.3,
SPF_HELO_NONE=0.001, SPF_NONE=0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)
When running make check on Solaris, I initially got lots of failures
like the following:
Running /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.exp .
..
ERROR: tcl error sourcing /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runte
st.libs/libs.exp.
ERROR: tcl error code POSIX EACCES {permission denied}
ERROR: couldn't execute "/vol/gcc/obj/dejagnu/dejagnu-1.6.3-rc1/../../expect/exp
ect": permission denied
while executing
"spawn $EXPECT"
(procedure "start_expect" line 10)
invoked from within
"start_expect"
(file "/vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.ex
p" line 99)
invoked from within
"source /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs/libs.exp"
("uplevel" body line 1)
invoked from within
"uplevel #0 source /vol/src/gnu/dejagnu/dejagnu-1.6.3-rc1/testsuite/runtest.libs
/libs.exp"
invoked from within
"catch "uplevel #0 source $test_file_name" msg"
It turns out that there I happened to have a ../../expect/expect
directory there.
Unfortunately, lib/runtest.exp (findfile), which is called from at the
beginning of testsuite/lib/runtest.exp, only uses "file exists" which
also works for directories, thus the diagnosis.
Rainer
--
-----------------------------------------------------------------------------
Rainer Orth, Center for Biotechnology, Bielefeld University
Rainer Orth <ro@HIDDEN>:bug-dejagnu@HIDDEN.
Full text available.bug-dejagnu@HIDDEN:bug#47385; Package dejagnu.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.