GNU bug report logs - #47399
[PATCH] Add Google's Highway library.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47399 in the body.
You can then email your comments to 47399 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Isaac Young <isyoung <at> pm.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH] Add Google's Highway library.
Date: Fri, 26 Mar 2021 00:54:05 +0000

[Message part 1 (text/plain, inline)]

Hello,

I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.

Thank you,
Isaac Young

[Message part 2 (text/html, inline)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Isaac Young <isyoung <at> pm.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Re: [PATCH] Add Google's Highway library.
Date: Fri, 26 Mar 2021 01:56:04 +0000

[Message part 1 (text/plain, inline)]

Oops, I didn't include the patch.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, March 25, 2021 6:54 PM, Isaac Young <isyoung <at> pm.me> wrote:

> Hello,
>
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.
>
> Thank you,
> Isaac Young

[Message part 2 (text/html, inline)]

[0001-google-highway.patch (text/x-patch, attachment)]

Message #11 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Isaac Young <isyoung <at> pm.me>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: Re: [PATCH] Add Google's Highway library.
Date: Fri, 26 Mar 2021 02:28:47 +0000

[Message part 1 (text/plain, inline)]

Sorry, I didn't include the patch.

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Thursday, March 25, 2021 6:54 PM, Isaac Young <isyoung <at> pm.me> wrote:

> Hello,
>
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.
>
> Thank you,
> Isaac Young

[Message part 2 (text/html, inline)]

[0001-google-highway.patch (text/x-patch, attachment)]

Message #14 received at 47399 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Isaac Young <isyoung <at> pm.me>, 47399 <at> debbugs.gnu.org
Subject: Re: [bug#47399] [PATCH] Add Google's Highway library.
Date: Fri, 26 Mar 2021 10:17:24 +0100

[Message part 1 (text/plain, inline)]

On Fri, 2021-03-26 at 00:54 +0000, Isaac Young via Guix-patches via wrote:
> Hello, 
> 
> I would like to add Google's highway library (https://github.com/google/highway) to guix officially. Any feedback will be greately apperciated as this is my first public package.

A commit message is missing from the patch.  E.g. something like

commit b09967bc587dd61c638da3d6fb5bbda7e87ed85c
Author: Raghav Gururajan <rg <at> raghavgururajan.name>
Date:   Sun Mar 7 01:47:19 2021 -0500

    gnu: Add psi-plus.
    
    * gnu/packages/messaging.scm (psi-plus): New variable.

(See 16.1 ‘Submitting Patches’ in the manual.)

You should add a ‘Copyright YEAR your-name’ as well at the top of the file.
There is no need to add ‘#:tests? #t’ as tests are enabled by default.

What's HWY_SYSTEM_GTEST=ON for?  Maybe add a comment

;; Prevent the configuration script from trying to download googletest
;; from the network.

or something like that.  Run "./pre-inst-env guix lint google-highway"
if you haven't already.

The "googletest" input does not make much sense when cross-compiling;
maybe move it to native-inputs with something like

  (native-inputs
   ,@(if (%current-target-system)
         '()
         ;; only used by the test suite
         `(("googletest" ,googletest))))

(See 8.2.1 ‘‘package’ reference’.)

(Admittedly, we don't focus much on making packages cross-compilable,
except for packages like gcc, bash, binutils ..., so no big problem
if this package isn't cross-compilable.)

Assuming you're on a system different from "aarch64-linux-gnu",
you can test cross-compilability with
"./pre-inst-env guix build --target=aarch64-linux-gnu google-highway".
(See 9.3.1 ‘Additional Build Options’)

Otherwise no comments, assuming it builds!

> Thank you,
> Isaac Young

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #19 received at 47399-done <at> debbugs.gnu.org (full text, mbox):

From: Vinicius Monego <monego <at> posteo.net>
To: 47399-done <at> debbugs.gnu.org
Subject: [PATCH] Add Google's Highway library.
Date: Mon, 07 Feb 2022 15:30:25 +0000

Hello,

I packaged highway in f2059169039561ae3b676e50443c14077d1e03db as a
dependency of libjxl. I'll close this issue, but feel free to submit
more packages in the future.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.