GNU bug report logs - #47402
gnu: Add emacs-sdcv

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47402 in the body.
You can then email your comments to 47402 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: Guix-patches <guix-patches <at> gnu.org>
Subject: gnu: Add emacs-sdcv
Date: Fri, 26 Mar 2021 06:18:50 +0000

[Message part 1 (text/plain, inline)]

I submitted two patches, emacs-showtip is a dependency of emacs-sdcv.

[0001-gnu-Add-emacs-showtip.patch (text/x-patch, attachment)]

[0002-gnu-Add-emacs-sdcv.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: qblade via Guix-patches via <guix-patches <at> gnu.org>
Cc: 47402 <at> debbugs.gnu.org, qblade <qblade <at> protonmail.com>
Subject: Re: [bug#47402] gnu: Add emacs-sdcv
Date: Fri, 26 Mar 2021 15:03:27 +0100

Hello,

qblade via Guix-patches via <guix-patches <at> gnu.org> writes:

> I submitted two patches, emacs-showtip is a dependency of emacs-sdcv.

Thank you. Some comments follow.

> +(define-public emacs-showtip
> +  (package
> +    (name "emacs-showtip")
> +    (version "20090830.1040")

This is not the correct version number. Main file indicates "0.01".

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/emacsorphanage/showtip")
> +             (commit
> +              "930da302809a4257e8d69425455b29e1cc91949b")))
> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "01zak0zhha6dp7a2hm28d065gjnc462iwpsfyxhbxgfzcdlicqc7"))))
> +    (build-system emacs-build-system)
> +    (home-page "https://github.com/emacsorphanage/showtip")
> +    (synopsis "Show tip at cursor")
> +    (description
> +     "This library export one function for elisp programer to show
> +tooltip near the cursor not the mouse.")

export -> exports or even, provides

I would also drop the "for Elisp programmer" part.

> +(define-public emacs-sdcv
> +  (package
> +    (name "emacs-sdcv")
> +    (version "20190610.732")

The correct version number seems to be 1.5.2 on the GitHub repository,
and 2.9 on emacswiki. However, using Emacswiki as a source is not an
option, since there is no archival for outdated releases there, AFAICT.

Are we stuck with an old release?

> +    (source
> +     (origin
> +       (method git-fetch)
> +       (uri (git-reference
> +             (url "https://github.com/stardiviner/sdcv.el")
> +             (commit
> +              "943ae3e90cc9a0a88a37cc710acd7424fd4defc4")))

Since you're targetting a specific commit, you need to add a commit and
a revision binding at the top of the definition. See, e.g.,
emacs-vterm-toggle.

> +       (file-name (git-file-name name version))
> +       (sha256
> +        (base32
> +         "0i1ylvw7p46pkf3yyyzcdmdhsspzymnnnvx8s0i7vynngr5x0vzh"))))
> +    (build-system emacs-build-system)
> +    (propagated-inputs
> +     `(("emacs-popup" ,emacs-popup)
> +       ("emacs-showtip" ,emacs-showtip)
> +       ("emacs-pos-tip" ,emacs-pos-tip)))
> +    (home-page
> +     "https://www.emacswiki.org/emacs/download/sdcv.el")
> +    (synopsis
> +     "Emacs interface for sdcv")

Could you explain quickly what SDCV is in the synopsis?

> +    (description
> +     "Translate word by sdcv (console version of Stardict), and display
> +translation use popup tooltip or buffer.")

The description needs to consist of full sentences.


Could you send updated patches?

Regards,
-- 
Nicolas Goaziou

Message #14 received at submit <at> debbugs.gnu.org (full text, mbox):

From: qblade <qblade <at> protonmail.com>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: "47402 <at> debbugs.gnu.org" <47402 <at> debbugs.gnu.org>,
 qblade via Guix-patches via <guix-patches <at> gnu.org>
Subject: 回复： Re: [bug#47402] gnu: Add emacs-sdcv
Date: Sat, 27 Mar 2021 11:42:44 +0000

[Message part 1 (text/plain, inline)]

OK.

[0001-gnu-Add-emacs-showtip.patch (text/x-patch, attachment)]

[0002-gnu-Add-emacs-sdcv.patch (text/x-patch, attachment)]

Message #20 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: qblade <qblade <at> protonmail.com>
Cc: "47402 <at> debbugs.gnu.org" <47402-done <at> debbugs.gnu.org>,
 qblade via Guix-patches via <guix-patches <at> gnu.org>
Subject: Re: 回复： Re: [bug#47402] gnu: Add emacs-sdcv
Date: Thu, 01 Apr 2021 16:08:39 +0200

Hello,

qblade <qblade <at> protonmail.com> writes:

> OK.

Applied, with minor modifications.

Thank you.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.