GNU bug report logs - #47411
promotional: Add Flight of the Guix and GNU Guix Test Pilot art

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47411 in the body.
You can then email your comments to 47411 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Luis Felipe via Guix-patches <guix-patches <at> gnu.org>
Subject: promotional: Add Flight of the Guix and GNU Guix Test Pilot art
Date: Fri, 26 Mar 2021 14:10:26 +0000

[Message part 1 (text/plain, inline)]

Hi,

This commit adds the source SVGs of the illustration used for the release announcement of Guix 1.2.0, and a new illustration intended to be used to call for testing before the release of version 1.2.1.

---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/

[0001-promotional-Add-Flight-of-the-Guix-and-GNU-Guix-Test.patch (text/x-patch, attachment)]

Message #8 received at 47411 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>, 47411 <at> debbugs.gnu.org
Subject: Re: [bug#47411] promotional: Add Flight of the Guix and GNU Guix
 Test Pilot art
Date: Fri, 26 Mar 2021 19:55:12 +0100

[Message part 1 (text/plain, inline)]

On Fri, 2021-03-26 at 14:10 +0000, Luis Felipe via Guix-patches via wrote:
> Hi,
> 
> This commit adds the source SVGs of the illustration used for the release announcement of Guix 1.2.0, and a new illustration intended to be used to call for testing before the release of version 1.2.1.
> 
> ---
> Luis Felipe López Acevedo
> https://luis-felipe.gitlab.io/

A question about the color profiles:

+  <defs
+     id="defs2">
+    <color-profile
+       id="color-profile4"
+       name="Artifex-PS-CMYK-Profile"
+       xlink:href="file:///usr/share/color/icc/ghostscript/ps_cmyk.icc" />
+    <color-profile
+       id="color-profile6"
+       name="Artifex-PS-CMYK-Profile"
+       xlink:href="file:///usr/share/color/icc/ghostscript/ps_cmyk.icc" />
+    <color-profile
+       id="color-profile8"
+       name="Artifex-PS-CMYK-Profile"
+       xlink:href="file:///usr/share/color/icc/ghostscript/ps_cmyk.icc" />
+  </defs>

I don't think it makes sense to includes these file://usr/share/ URLs,
as they are rather useless on Guix System.  If these xlink:href
attributes were simply removed, would SVG-displaying applications still
automagically find the colour profiles? 

If not, then I guess we'll have to simply live with that
(and keep /usr/share for now).  Or maybe we could copy "ps_cmyk.icc"
to the "promotional" directory and use a relative link?
But then copying the SVG would break the link ...

Alternative solution: would converting to sRGB make the colours look bad?

Greetings,
Maxime

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 47411 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "47411 <at> debbugs.gnu.org" <47411 <at> debbugs.gnu.org>
Subject: Re: [bug#47411] promotional: Add Flight of the Guix and GNU Guix Test
 Pilot art
Date: Fri, 26 Mar 2021 20:53:16 +0000

[Message part 1 (text/plain, inline)]

Hi Maxime,


On Friday, March 26, 2021 6:55 PM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> On Fri, 2021-03-26 at 14:10 +0000, Luis Felipe via Guix-patches via wrote:
>
> A question about the color profiles:
>
> -   <defs
>
> -       id="defs2">
>
>
> -   <color-profile
>
> -         id="color-profile4"
>
>
> -         name="Artifex-PS-CMYK-Profile"
>
>
> -         xlink:href="file:///usr/share/color/icc/ghostscript/ps_cmyk.icc" />
>
>
> -   <color-profile
>
> -         id="color-profile6"
>
>
> -         name="Artifex-PS-CMYK-Profile"
>
>
> -         xlink:href="file:///usr/share/color/icc/ghostscript/ps_cmyk.icc" />
>
>
> -   <color-profile
>
> -         id="color-profile8"
>
>
> -         name="Artifex-PS-CMYK-Profile"
>
>
> -         xlink:href="file:///usr/share/color/icc/ghostscript/ps_cmyk.icc" />
>
>
> -   </defs>
>
>
> I don't think it makes sense to includes these file://usr/share/ URLs,
> as they are rather useless on Guix System. If these xlink:href
> attributes were simply removed, would SVG-displaying applications still
> automagically find the colour profiles?

You're right. These color profiles are residues from the SVG template I used to start the designs. They are not necessary. So please use the attached patch instead where I removed them and tested that things worked as expected.


> Alternative solution: would converting to sRGB make the colours look bad?

I actually designed in the standar RGB range, so there shouldn't be any problem.

[0001-promotional-Add-Flight-of-the-Guix-and-GNU-Guix-Test.patch (text/x-patch, attachment)]

Message #14 received at 47411 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: "47411 <at> debbugs.gnu.org" <47411 <at> debbugs.gnu.org>
Subject: Re: [bug#47411] promotional: Add Flight of the Guix and GNU Guix
 Test Pilot art
Date: Fri, 26 Mar 2021 22:07:20 +0100

[Message part 1 (text/plain, inline)]

On Fri, 2021-03-26 at 20:53 +0000, Luis Felipe wrote:
> [...]
> So please use the attached patch instead where I removed them
> and tested that things worked as expected.

They look nice in Eye of MATE, IceCat, ungoogled-chromium and the GNOME
image viewer.  You'll have to wait for someone else to actually merge them
though.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 47411 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "47411 <at> debbugs.gnu.org" <47411 <at> debbugs.gnu.org>
Subject: Re: [bug#47411] promotional: Add Flight of the Guix and GNU Guix Test
 Pilot art
Date: Fri, 26 Mar 2021 21:18:13 +0000

On Friday, March 26, 2021 9:07 PM, Maxime Devos <maximedevos <at> telenet.be> wrote:

> On Fri, 2021-03-26 at 20:53 +0000, Luis Felipe wrote:
>
> > [...]
> > So please use the attached patch instead where I removed them
> > and tested that things worked as expected.
>
> They look nice in Eye of MATE, IceCat, ungoogled-chromium and the GNOME
> image viewer. You'll have to wait for someone else to actually merge them
> though.

Thanks for reviewing, Maxime :)

Message #20 received at 47411 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 47411 <at> debbugs.gnu.org
Cc: luis.felipe.la <at> protonmail.com
Subject: promotional: Add Flight of the Guix and GNU Guix Test Pilot art
Date: Thu, 01 Apr 2021 09:10:48 +0200

Hi,

is this meant to be applied to the guix-artwork repository?  (I’m missing
some context to apply the patch.)

-- 
Ricardo

Message #23 received at 47411 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Ricardo Wurmus <rekado <at> elephly.net>
Cc: "47411 <at> debbugs.gnu.org" <47411 <at> debbugs.gnu.org>
Subject: Re: promotional: Add Flight of the Guix and GNU Guix Test Pilot art
Date: Thu, 01 Apr 2021 13:54:00 +0000

On Thursday, April 1, 2021 7:10 AM, Ricardo Wurmus <rekado <at> elephly.net> wrote:

> Hi,
>
> is this meant to be applied to the guix-artwork repository? (I’m missing
> some context to apply the patch.)

Yes, guix-artwork.

Message #28 received at 47411-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 47411-done <at> debbugs.gnu.org, Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: bug#47411: promotional: Add Flight of the Guix and GNU Guix
 Test Pilot art
Date: Mon, 05 Apr 2021 17:19:19 +0200

Hello Luis & Maxime,

Nice work! Pushed as 5ce877dac69f1ae67c5a9c88835c04155e2734a4.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.