GNU bug report logs - #47434
[PATCH] Added Go 1.16.2

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Reported by: Néfix Estrada <nefixestrada@HIDDEN>; Keywords: patch; dated Sat, 27 Mar 2021 16:50:02 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.

Message received at 47434 <at> debbugs.gnu.org:


Received: (at 47434) by debbugs.gnu.org; 27 Mar 2021 19:56:49 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 27 15:56:49 2021
Received: from localhost ([127.0.0.1]:44993 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lQF3A-0005Xk-ON
	for submit <at> debbugs.gnu.org; Sat, 27 Mar 2021 15:56:49 -0400
Received: from albert.telenet-ops.be ([195.130.137.90]:43674)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maximedevos@HIDDEN>) id 1lQF38-0005Xb-Jd
 for 47434 <at> debbugs.gnu.org; Sat, 27 Mar 2021 15:56:47 -0400
Received: from ptr-bvsjgyjmffd7q9timvx.18120a2.ip6.access.telenet.be
 ([IPv6:2a02:1811:8c09:9d00:aaf1:9810:a0b8:a55d])
 by albert.telenet-ops.be with bizsmtp
 id lXwk240070mfAB406XwkRZ; Sat, 27 Mar 2021 20:56:44 +0100
Message-ID: <cf91e6e3120d04769ee9b890f6f9a6fecaf057c9.camel@HIDDEN>
Subject: Re: [bug#47434] [PATCH] Added Go 1.16.2
From: Maxime Devos <maximedevos@HIDDEN>
To: =?ISO-8859-1?Q?N=E9fix?= Estrada <nefixestrada@HIDDEN>, 
 47434 <at> debbugs.gnu.org
Date: Sat, 27 Mar 2021 20:56:06 +0100
In-Reply-To: <20210327162953.32278-1-nefixestrada@HIDDEN>
References: <20210327162953.32278-1-nefixestrada@HIDDEN>
Content-Type: multipart/signed; micalg="pgp-sha256";
 protocol="application/pgp-signature"; boundary="=-OgCPHJ+Y7OCky1/8riFL"
User-Agent: Evolution 3.34.2 
MIME-Version: 1.0
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=telenet.be; s=r21;
 t=1616875004; bh=sRiNfx78x4vfvhZQOduaxOvXio4XcY2irIuveXVwNew=;
 h=Subject:From:To:Date:In-Reply-To:References;
 b=qEBuCWlK0/a+/f/GhuVJ8RLPyg7xmLST50Lg75iryx0no9v7rA0cguaLqd1M+/Dxx
 0vjGgFKfAxi5w0YmZv0ni8Uvr/3pEdkMGPJrahQbE65+vBEHJgzsZiOA+enfYxmmY2
 xc+7c9EEOH+W9EyAhLVDCZrLpIEmXCoFjRIaXuSlY22t0WMg1Rs/YYDWC9iCjQ9oWL
 lHx96jLbICVVu15kpYO4ps6MddGForV5OUW8JEtsqdrrlIzW+bLE3S9GFYvo96z50x
 ZupSVGmNmEIkL5lqojYLDFV7X/JBvEJ2Giv6pZkqEtcPGxJU0crhokOqzy/+DkAPEf
 gQs8cz4LrD9UA==
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47434
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--=-OgCPHJ+Y7OCky1/8riFL
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Sat, 2021-03-27 at 17:29 +0100, N=C3=A9fix Estrada wrote:
> Signed-off-by: N=C3=A9fix Estrada <nefixestrada@HIDDEN>
> ---
>  gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++
>  1 file changed, 27 insertions(+)

A commit message is missing, see =E2=80=9816.6 Submitting Patches=E2=80=99 =
in
the manual (and there are plenty of examples in "git log").

There have been a few patches lately by new
contributers without commit messages; is this section of the
manual hard to find?  Is there some location where we could
prominently feature a link to the section?

Also, =E2=80=98we=E2=80=99 don't use =E2=80=98Signed-off-by=E2=80=99 like t=
hat.  From =E2=80=9816.8 Commit Access=E2=80=99:

   When pushing a commit on behalf of somebody else, please add a
=E2=80=98Signed-off-by=E2=80=99 line at the end of the commit log message=
=E2=80=94e.g., with
=E2=80=98git am --signoff=E2=80=99.  This improves tracking of who did what=
.

Thus, it is up to committers to add a line like that.  Perhaps a system
like the Linux kernel project uses could be useful in the future,
but I don't think =E2=80=98we=E2=80=99 are at that point yet

> diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
> index d9988cd7ad..df17955c93 100644
> --- a/gnu/packages/golang.scm
> +++ b/gnu/packages/golang.scm
> @@ -25,6 +25,7 @@
>  ;;; Copyright =C2=A9 2020 Martin Becze <mjbecze@HIDDEN>
>  ;;; Copyright =C2=A9 2021 Ricardo Wurmus <rekado@HIDDEN>
>  ;;; Copyright =C2=A9 2021 Guillaume Le Vaillant <glv@HIDDEN>
> +;;; Copyright =C2=A9 2021 N=C3=A9fix Estrada <nefixestrada@HIDDEN>
>  ;;;
>  ;;; This file is part of GNU Guix.
>  ;;;
> @@ -440,6 +441,32 @@ in the style of communicating sequential processes (=
@dfn{CSP}).")
>         ,@(package-native-inputs go-1.4)))
>      (supported-systems %supported-systems)))
> =20
> +(define-public go-1.16
> +  (package
> +    (inherit go-1.14)
> +    [...]

> +    (arguments
> +     (substitute-keyword-arguments (package-arguments go-1.14)
> +       ((#:phases phases)
> +        `(modify-phases ,phases

This part looks good to me.

> +	   (add-after 'prebuild 'prebuild-1-16
> +	     (lambda* (#:key inputs #:allow-other-keys)
> +	       (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib=
")))
> +		 (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt"
> +		   (("\\[\\!cgo\\] skip")
> +		    "[!exec:cc] skip")))))))))))
> +

What's this 'prebuild-1-16' phase for?  Please add a comment explaining!
And what's (let* ((gcclib ...) ...) doing there if gcclib isn't used afterw=
ards?

>  (define-public go go-1.14)

Something to consider for people who know the go situation in guix:
could this be replaced with (define-public go go-1.16) after this patch?
(And go-1.14 deleted as there are no uses of it anymore.)
The output of "guix refresh --list-dependent go" is:

Building the following 125 packages would ensure 440 dependent packages are=
 rebuilt:
[...]

so this shouldn't cause a world-rebuild (note go packages are (reportedly)
cheap to build).  But perhaps there are API incompatibilities between 1.16 =
and
1.14? idk.

Note: this patch should be reviewed by someone more knowledged about go
in guix than me.

Thanks for looking into this,
Greetings,
Maxime

--=-OgCPHJ+Y7OCky1/8riFL
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iI0EABYIADUWIQTB8z7iDFKP233XAR9J4+4iGRcl7gUCYF+N1xccbWF4aW1lZGV2
b3NAdGVsZW5ldC5iZQAKCRBJ4+4iGRcl7g+wAQDIuumSyfD/ULQ6MOVcveXlQVhm
dfdAg9AWgUPK6DMA7QD/dAWawD4s1WIrRlbWUv7OI0SMaSR4qdI7KJoMcTQbIww=
=k3hI
-----END PGP SIGNATURE-----

--=-OgCPHJ+Y7OCky1/8riFL--





Information forwarded to guix-patches@HIDDEN:
bug#47434; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 27 Mar 2021 16:49:44 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Mar 27 12:49:44 2021
Received: from localhost ([127.0.0.1]:44785 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lQC88-0000wB-5R
	for submit <at> debbugs.gnu.org; Sat, 27 Mar 2021 12:49:44 -0400
Received: from lists.gnu.org ([209.51.188.17]:53192)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <nefixestrada@HIDDEN>) id 1lQBp6-0000RL-0V
 for submit <at> debbugs.gnu.org; Sat, 27 Mar 2021 12:30:05 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:52770)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <nefixestrada@HIDDEN>)
 id 1lQBp5-0005wy-Nf
 for guix-patches@HIDDEN; Sat, 27 Mar 2021 12:30:03 -0400
Received: from mail-wm1-x32d.google.com ([2a00:1450:4864:20::32d]:55151)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128)
 (Exim 4.90_1) (envelope-from <nefixestrada@HIDDEN>)
 id 1lQBp3-0006ZN-RL
 for guix-patches@HIDDEN; Sat, 27 Mar 2021 12:30:03 -0400
Received: by mail-wm1-x32d.google.com with SMTP id k128so4470385wmk.4
 for <guix-patches@HIDDEN>; Sat, 27 Mar 2021 09:30:00 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=NJgRaxIEBBUU77Lj1ojHAAz9wkuH8WP7IQEcShqi3MM=;
 b=lGEJ8LCcgXiyUe3pK/9akcWudRZEve6r7ETq75O16QhN+7CbqB/X3c7RnHWrN6dJFb
 2XjcmTO4jssU7gEUufhhm/U1XoKZpQUYAe+DPRlZWSFqjoT9sTiDKwn7o+DoaldYICF0
 IM5uZPs4j9cghQyZhX12aHl2rnQtDqR4bC3qwMUOCesDeF8fsvIarZDF9kqP+M9gtjFo
 cARHKaq2lC2G1il7+SONTZ79fHVFirDOK/Pk29szhym8YtatPip2wg8D8b1UgnA63VIk
 raIxukUdJTk/nUEQ3WWH3nSm+Zid4YHPGf+SIFKFbU809qK91pdABqQQ5AssNJk3SNRK
 hVfQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version
 :content-transfer-encoding;
 bh=NJgRaxIEBBUU77Lj1ojHAAz9wkuH8WP7IQEcShqi3MM=;
 b=Py+aF9QxZRa1DhyMwMyJrSzrZruKuxP25ZfwXIMDn/huAyZeO6hE1gYTT3dtTTopue
 OgV37pqg6X23uJUVChc4EZKYbFZdRfc2un3XnUdv5+YvWs+69zR1nH665ETZt+oVOIYM
 gZnfkEAITmPDgJsIpcGf6Pl8bm0KYQdDxQd5sGfrS08aPSVMtgGkQ8s34miGntl7P+lM
 H808+5ibHUTXkXECh+ZNe68/DOycpaj1k4j1YUBVH7hSly8XBKATsuGWPp2VdLRYsSIY
 1feI/y8iV+LbC/T+++4Bk5Y03YQSqM3Xbv2aSa+8Jdg9eTqsbTsqGNrWH5r0ZzgFgVZz
 cFWg==
X-Gm-Message-State: AOAM530go3EoWr5mo9AQ9pSh++kL/vDQqNhF6Gw/82iNNTc8ad7Nl9Fg
 /GZ8UqP0xSMeejrxqZEjQw/SjBeJWEo=
X-Google-Smtp-Source: ABdhPJzW1JfC81a2rtMJD80xjzaClmtmDkSxSuKVn23VjHrQKZ6MGDwUG/O51H4PYwII2KyT65zl9w==
X-Received: by 2002:a05:600c:614:: with SMTP id
 o20mr17351226wmm.66.1616862599924; 
 Sat, 27 Mar 2021 09:29:59 -0700 (PDT)
Received: from localhost.localdomain ([213.195.111.200])
 by smtp.googlemail.com with ESMTPSA id
 q207sm17819245wme.36.2021.03.27.09.29.59
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 27 Mar 2021 09:29:59 -0700 (PDT)
From: =?UTF-8?q?N=C3=A9fix=20Estrada?= <nefixestrada@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] Added Go 1.16.2
Date: Sat, 27 Mar 2021 17:29:53 +0100
Message-Id: <20210327162953.32278-1-nefixestrada@HIDDEN>
X-Mailer: git-send-email 2.31.0
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=2a00:1450:4864:20::32d;
 envelope-from=nefixestrada@HIDDEN; helo=mail-wm1-x32d.google.com
X-Spam_score_int: -20
X-Spam_score: -2.1
X-Spam_bar: --
X-Spam_report: (-2.1 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, FREEMAIL_FROM=0.001,
 RCVD_IN_DNSWL_NONE=-0.0001, SPF_HELO_NONE=0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.3 (-)
X-Debbugs-Envelope-To: submit
X-Mailman-Approved-At: Sat, 27 Mar 2021 12:49:42 -0400
Cc: =?UTF-8?q?N=C3=A9fix=20Estrada?= <nefixestrada@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.3 (--)

Signed-off-by: Néfix Estrada <nefixestrada@HIDDEN>
---
 gnu/packages/golang.scm | 27 +++++++++++++++++++++++++++
 1 file changed, 27 insertions(+)

diff --git a/gnu/packages/golang.scm b/gnu/packages/golang.scm
index d9988cd7ad..df17955c93 100644
--- a/gnu/packages/golang.scm
+++ b/gnu/packages/golang.scm
@@ -25,6 +25,7 @@
 ;;; Copyright © 2020 Martin Becze <mjbecze@HIDDEN>
 ;;; Copyright © 2021 Ricardo Wurmus <rekado@HIDDEN>
 ;;; Copyright © 2021 Guillaume Le Vaillant <glv@HIDDEN>
+;;; Copyright © 2021 Néfix Estrada <nefixestrada@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -440,6 +441,32 @@ in the style of communicating sequential processes (@dfn{CSP}).")
        ,@(package-native-inputs go-1.4)))
     (supported-systems %supported-systems)))
 
+(define-public go-1.16
+  (package
+    (inherit go-1.14)
+    (name "go")
+    (version "1.16.2")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/golang/go")
+             (commit (string-append "go" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "1cvw81hgb7akqp53lqbgpk303km8a7xs7lcr8c8z30hr5ql2kz90"))))
+    (arguments
+     (substitute-keyword-arguments (package-arguments go-1.14)
+       ((#:phases phases)
+        `(modify-phases ,phases
+	   (add-after 'prebuild 'prebuild-1-16
+	     (lambda* (#:key inputs #:allow-other-keys)
+	       (let* ((gcclib (string-append (assoc-ref inputs "gcc:lib") "/lib")))
+		 (substitute* "cmd/go/testdata/script/link_syso_issue33139.txt"
+		   (("\\[\\!cgo\\] skip")
+		    "[!exec:cc] skip")))))))))))
+
 (define-public go go-1.14)
 
 (define-public go-github-com-alsm-ioprogress
-- 
2.31.0





Acknowledgement sent to Néfix Estrada <nefixestrada@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#47434; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Sat, 27 Mar 2021 20:00:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.