GNU bug report logs - #47460
[PATCH] gnu: Add python-plumbum.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47460 in the body.
You can then email your comments to 47460 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: lle-bout <at> zaclys.net, rprior <at> protonmail.com, a.pierre <at> zaclys.net
Subject: [PATCH] gnu: Add python-plumbum.
Date: Mon, 29 Mar 2021 04:25:53 +0000

[Message part 1 (text/plain, inline)]

Hi Guix!

Here is a patch for python-plumbum.

This was an effort of the today's Guix Packaging Meetup.

best regards,

jgart

libremiami.org

[0001-gnu-Add-python-plumbum.patch (application/octet-stream, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: a.pierre <at> zaclys.net, jgart <jgart <at> dismail.de>, lle-bout <at> zaclys.net,
 rprior <at> protonmail.com, 47460-done <at> debbugs.gnu.org
Subject: Re: [bug#47460] [PATCH] gnu: Add python-plumbum.
Date: Sun, 11 Apr 2021 11:47:03 +0200

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> * gnu/packages/python-xyz.scm (python-plumbum): New variable.

Applied. Thank you.

The patch didn't apply cleanly because the package definition was at the
end of the file. I moved it elsewhere.

Regards,
-- 
Nicolas Goaziou

Message #16 received at 47460 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: 47460 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: Add python-plumbum.
Date: Sun, 11 Apr 2021 15:21:46 +0000

Hi Nicolas, thank you for merging the patch! It is much appreciated. 

Should we not add packages at the end of files going forward? How do you recommend avoiding that in the future?
I'd like to relay the tip to the group.

Also, I noticed that you forgot to add the co-authors listed
in the patch commit message:

Co-authored-by:·Léo·Le·Bouter·<lle-bout <at> zaclys.net>
Co-authored-by:·jgart·<jgart <at> dismail.de>
Co-authored-by:·Ryan·Prior·<rprior <at> protonmail.com>
Co-authored-by:·Andrea·Pierré·<a.pierre <at> zaclys.net>

If it is too much hassle to add it at this point then don't worry but it would be much appreciated,
otherwise.

all the best,

jgart

libremiami.org

Message #19 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: jgart via Guix-patches via <guix-patches <at> gnu.org>
Cc: jgart <jgart <at> dismail.de>, 47460 <at> debbugs.gnu.org
Subject: Re: [bug#47460] [PATCH] gnu: Add python-plumbum.
Date: Sun, 11 Apr 2021 19:19:09 +0200

Hello,

jgart via Guix-patches via <guix-patches <at> gnu.org> writes:

> Should we not add packages at the end of files going forward? How do
> you recommend avoiding that in the future?

You can try adding them alphabetically, by topic, or even randomly
within the file. Anything but the end of the file is fine, actually,
unless your package is named "python-zzz".

> Also, I noticed that you forgot to add the co-authors listed
> in the patch commit message:
>
> Co-authored-by:·Léo·Le·Bouter·<lle-bout <at> zaclys.net>
> Co-authored-by:·jgart·<jgart <at> dismail.de>
> Co-authored-by:·Ryan·Prior·<rprior <at> protonmail.com>
> Co-authored-by:·Andrea·Pierré·<a.pierre <at> zaclys.net>
>
> If it is too much hassle to add it at this point then don't worry but it would be much appreciated,
> otherwise.

I don't think I can change a commit message without rewriting history.
That's not an option. Sorry.

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.