GNU bug report logs - #47465
[PATCH] Added wlrctl to xdisorg

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47465 in the body.
You can then email your comments to 47465 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: calum <calumirwin1 <at> gmail.com>
To: guix-patches <at> gnu.org
Cc: calum <calumirwin1 <at> gmail.com>
Subject: [PATCH] Added wlrctl to xdisorg
Date: Mon, 29 Mar 2021 23:56:22 +1300

---
 gnu/packages/xdisorg.scm | 31 +++++++++++++++++++++++++++++++
 1 file changed, 31 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 56ac53edec..6d936efee6 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -80,6 +80,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages flex)
@@ -2788,3 +2789,33 @@ and execute @file{.desktop} files of the Application type.")
      "The @command{hsetroot} command composes wallpapers for X.
 This package is the fork of hsetroot by Hyriand.")
     (license license:gpl2+)))
+
+(define-public wlrctl
+  (package
+    (name "wlrctl")
+    (version "0.2.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.sr.ht/~brocellous/wlrctl")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"))))
+    (build-system meson-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("cmake" ,cmake)
+       ("scdoc" ,scdoc)))
+    (inputs
+     `(("libxkbcommon" ,libxkbcommon)
+       ("wayland" ,wayland)))
+    (home-page "https://git.sr.ht/~brocellous/wlrctl")
+    (synopsis "Command line utility for wlroots automation and extensions")
+    (description
+     "wlrctl is a command line utility for miscellaneous wlroots Wayland
+extensions.  At this time, wlrctl supports the foreign-toplevel-mangement
+(window/toplevel command), virtual-keyboard (keyboard command),
+and virtual-pointer (pointer command) protocols.")
+    (license license:expat)))
-- 
2.31.1

Message #8 received at 47465 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: calum <calumirwin1 <at> gmail.com>, 47465 <at> debbugs.gnu.org
Subject: Re: [bug#47465] [PATCH] Added wlrctl to xdisorg
Date: Mon, 29 Mar 2021 15:50:31 +0200

[Message part 1 (text/plain, inline)]

Hi,

On Mon, 2021-03-29 at 23:56 +1300, calum wrote:
> ---
>  gnu/packages/xdisorg.scm | 31 +++++++++++++++++++++++++++++++
>  1 file changed, 31 insertions(+)

Please include a commit message.  There are plenty of examples
in the git history to base you on.  Also see section
16.6 ‘Submitting Patches’ of the manual.

> diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> index 56ac53edec..6d936efee6 100644
> --- a/gnu/packages/xdisorg.scm
> +++ b/gnu/packages/xdisorg.scm
> @@ -80,6 +80,7 @@

You should add a copyright line.

>    #:use-module (gnu packages base)
>    #:use-module (gnu packages bison)
>    #:use-module (gnu packages check)
> +  #:use-module (gnu packages cmake)
>    #:use-module (gnu packages compression)
>    #:use-module (gnu packages documentation)
>    #:use-module (gnu packages flex)
> @@ -2788,3 +2789,33 @@ and execute @file{.desktop} files of the Application type.")
>       "The @command{hsetroot} command composes wallpapers for X.
>  This package is the fork of hsetroot by Hyriand.")
>      (license license:gpl2+)))
> +
> +(define-public wlrctl
> +  (package
> +    (name "wlrctl")
> +    (version "0.2.1")
> +    (source (origin
> +              (method git-fetch)
> +              (uri (git-reference
> +                    (url "https://git.sr.ht/~brocellous/wlrctl")
> +                    (commit (string-append "v" version))))
> +              (file-name (git-file-name name version))
> +              (sha256
> +               (base32
> +                "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"))))
> +    (build-system meson-build-system)
> +    (native-inputs
> +     `(("pkg-config" ,pkg-config)
> +       ("cmake" ,cmake)
> +       ("scdoc" ,scdoc)))
> +    (inputs
> +     `(("libxkbcommon" ,libxkbcommon)
> +       ("wayland" ,wayland)))

If this is a wayland package, shouldn't this be in (gnu packages freedesktop)?
I'm not sure myself where it should be, but at least that's were the 'wayland'
package resides.

> +    (home-page "https://git.sr.ht/~brocellous/wlrctl")
> +    (synopsis "Command line utility for wlroots automation and extensions")
> +    (description
> +     "wlrctl is a command line utility for miscellaneous wlroots Wayland
> +extensions.  At this time, wlrctl supports the foreign-toplevel-mangement
> +(window/toplevel command), virtual-keyboard (keyboard command),
> +and virtual-pointer (pointer command) protocols.")
> +    (license license:expat)))

The package definition seems about right to me, but I don't have time to
actually test this.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 47465 <at> debbugs.gnu.org (full text, mbox):

From: calum <calumirwin1 <at> gmail.com>
To: 47465 <at> debbugs.gnu.org
Cc: calum <calumirwin1 <at> gmail.com>
Subject: [PATCH v2] gnu: Add wlrctl
Date: Tue, 30 Mar 2021 23:29:55 +1300

* gnu/packages/xdisorg.scm (wlrctl): New variables.
---
 gnu/packages/xdisorg.scm | 32 ++++++++++++++++++++++++++++++++
 1 file changed, 32 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index 56ac53edec..200515c045 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -45,6 +45,7 @@
 ;;; Copyright © 2020, 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;; Copyright © 2021 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
+;;; Copyright © 2021 Calum Irwin <calumirwin1 <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -80,6 +81,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages flex)
@@ -2788,3 +2790,33 @@ and execute @file{.desktop} files of the Application type.")
      "The @command{hsetroot} command composes wallpapers for X.
 This package is the fork of hsetroot by Hyriand.")
     (license license:gpl2+)))
+
+(define-public wlrctl
+  (package
+    (name "wlrctl")
+    (version "0.2.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.sr.ht/~brocellous/wlrctl")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"))))
+    (build-system meson-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("cmake" ,cmake)
+       ("scdoc" ,scdoc)))
+    (inputs
+     `(("libxkbcommon" ,libxkbcommon)
+       ("wayland" ,wayland)))
+    (home-page "https://git.sr.ht/~brocellous/wlrctl")
+    (synopsis "Command line utility for wlroots automation and extensions")
+    (description
+     "wlrctl is a command line utility for miscellaneous wlroots Wayland
+extensions.  At this time, wlrctl supports the foreign-toplevel-mangement
+(window/toplevel command), virtual-keyboard (keyboard command),
+and virtual-pointer (pointer command) protocols.")
+    (license license:expat)))
-- 
2.31.1

Message #14 received at 47465 <at> debbugs.gnu.org (full text, mbox):

From: Calum Irwin <calumirwin1 <at> gmail.com>
To: 47465 <at> debbugs.gnu.org
Cc: maximedevos <at> telnet.be
Subject: Re: [bug#47465] [PATCH] Added wlrctl to xdisorg
Date: Tue, 30 Mar 2021 23:32:05 +1300

freedesktop.scm seemed to be more for libraries while xdisorg was for
miscellaneous applications and there were already a number of wayland
specific applications in there (redshift-wayland, gammastep,
bemenu...)

As an aside, if you're a maintainer for the repo you may want to take
a quick look at the README and HACKING documents which mention a
doc/guix.info which looks to have been replaced with a texi file that
info doesn't support the MENU-ITEM jumping to, for example,
"Contributing" or "Building from git".

Apologies if the commit message is screwed up again. It's supposed to say:

gnu: Add wlrctl

* gnu/packages/xdisorg.scm (wlrctl): New variables.

On Tue, Mar 30, 2021 at 2:50 AM Maxime Devos <maximedevos <at> telenet.be> wrote:
>
> Hi,
>
> On Mon, 2021-03-29 at 23:56 +1300, calum wrote:
> > ---
> >  gnu/packages/xdisorg.scm | 31 +++++++++++++++++++++++++++++++
> >  1 file changed, 31 insertions(+)
>
> Please include a commit message.  There are plenty of examples
> in the git history to base you on.  Also see section
> 16.6 ‘Submitting Patches’ of the manual.
>
> > diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
> > index 56ac53edec..6d936efee6 100644
> > --- a/gnu/packages/xdisorg.scm
> > +++ b/gnu/packages/xdisorg.scm
> > @@ -80,6 +80,7 @@
>
> You should add a copyright line.
>
> >    #:use-module (gnu packages base)
> >    #:use-module (gnu packages bison)
> >    #:use-module (gnu packages check)
> > +  #:use-module (gnu packages cmake)
> >    #:use-module (gnu packages compression)
> >    #:use-module (gnu packages documentation)
> >    #:use-module (gnu packages flex)
> > @@ -2788,3 +2789,33 @@ and execute @file{.desktop} files of the Application type.")
> >       "The @command{hsetroot} command composes wallpapers for X.
> >  This package is the fork of hsetroot by Hyriand.")
> >      (license license:gpl2+)))
> > +
> > +(define-public wlrctl
> > +  (package
> > +    (name "wlrctl")
> > +    (version "0.2.1")
> > +    (source (origin
> > +              (method git-fetch)
> > +              (uri (git-reference
> > +                    (url "https://git.sr.ht/~brocellous/wlrctl")
> > +                    (commit (string-append "v" version))))
> > +              (file-name (git-file-name name version))
> > +              (sha256
> > +               (base32
> > +                "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"))))
> > +    (build-system meson-build-system)
> > +    (native-inputs
> > +     `(("pkg-config" ,pkg-config)
> > +       ("cmake" ,cmake)
> > +       ("scdoc" ,scdoc)))
> > +    (inputs
> > +     `(("libxkbcommon" ,libxkbcommon)
> > +       ("wayland" ,wayland)))
>
> If this is a wayland package, shouldn't this be in (gnu packages freedesktop)?
> I'm not sure myself where it should be, but at least that's were the 'wayland'
> package resides.
>
> > +    (home-page "https://git.sr.ht/~brocellous/wlrctl")
> > +    (synopsis "Command line utility for wlroots automation and extensions")
> > +    (description
> > +     "wlrctl is a command line utility for miscellaneous wlroots Wayland
> > +extensions.  At this time, wlrctl supports the foreign-toplevel-mangement
> > +(window/toplevel command), virtual-keyboard (keyboard command),
> > +and virtual-pointer (pointer command) protocols.")
> > +    (license license:expat)))
>
> The package definition seems about right to me, but I don't have time to
> actually test this.
>
> Greetings,
> Maxime.
>

Message #17 received at 47465 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Calum Irwin <calumirwin1 <at> gmail.com>
Cc: maximedevos <at> telnet.be, 47465 <at> debbugs.gnu.org
Subject: Re: [bug#47465] [PATCH] Added wlrctl to xdisorg
Date: Sun, 4 Apr 2021 13:49:27 -0400

On Tue, Mar 30, 2021 at 11:32:05PM +1300, Calum Irwin wrote:
> As an aside, if you're a maintainer for the repo you may want to take
> a quick look at the README and HACKING documents which mention a
> doc/guix.info which looks to have been replaced with a texi file that
> info doesn't support the MENU-ITEM jumping to, for example,
> "Contributing" or "Building from git".

Do you mean that, in the Git repo, you can only find the 'doc/guix.texi'
file, and that guix.info is missing?

If so, that's expected.

'guix.info' is built from 'guix.texi', by doing `make doc/guix.info`.

You can also do, for example, `make doc/guix.html`.

Message #20 received at 47465 <at> debbugs.gnu.org (full text, mbox):

From: calum <calumirwin1 <at> gmail.com>
To: 47465 <at> debbugs.gnu.org
Cc: calum <calumirwin1 <at> gmail.com>
Subject: [PATCH] gnu: Add wlrctl
Date: Sun, 27 Jun 2021 16:26:28 +1200

* gnu/packages/xdisorg.scm (wlrctl): New variable.
---
 gnu/packages/xdisorg.scm | 33 +++++++++++++++++++++++++++++++++
 1 file changed, 33 insertions(+)

diff --git a/gnu/packages/xdisorg.scm b/gnu/packages/xdisorg.scm
index b8c7a35a36..18f120bab5 100644
--- a/gnu/packages/xdisorg.scm
+++ b/gnu/packages/xdisorg.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2021 Renzo Poddighe <renzo <at> poddighe.nl>
 ;;; Copyright © 2021 Paul A. Patience <paul <at> apatience.com>
 ;;; Copyright © 2021 Niklas Eklund <niklas.eklund <at> posteo.net>
+;;; Copyright © 2021 Calum Irwin <calumirwin1 <at> gmail.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -83,6 +84,7 @@
   #:use-module (gnu packages base)
   #:use-module (gnu packages bison)
   #:use-module (gnu packages check)
+  #:use-module (gnu packages cmake)
   #:use-module (gnu packages compression)
   #:use-module (gnu packages documentation)
   #:use-module (gnu packages flex)
@@ -2957,3 +2959,34 @@ System.  This includes such features as MouseKeys, AccessX, StickyKeys,
 BounceKeys, and SlowKeys.  It includes a graphical program to help with
 MouseKeys-acceleration management.")
     (license license:bsd-3)))
+
+(define-public wlrctl
+  (package
+    (name "wlrctl")
+    (version "0.2.1")
+    (source (origin
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://git.sr.ht/~brocellous/wlrctl")
+                    (commit (string-append "v" version))))
+              (file-name (git-file-name name version))
+              (sha256
+               (base32
+                "039cxc82k7x473n6d65jray90rj35qmfdmr390zy0c7ic7vn4b78"))))
+    (build-system meson-build-system)
+    (native-inputs
+     `(("pkg-config" ,pkg-config)
+       ("cmake" ,cmake)
+       ("scdoc" ,scdoc)))
+    (inputs
+     `(("libxkbcommon" ,libxkbcommon)
+       ("wayland" ,wayland)))
+    (home-page "https://git.sr.ht/~brocellous/wlrctl")
+    (synopsis "Command line utility for wlroots automation and extensions")
+    (description
+     "wlrctl is a command line utility for miscellaneous wlroots Wayland
+extensions.  At this time, wlrctl supports the foreign-toplevel-mangement
+(window/toplevel command), virtual-keyboard (keyboard command),
+and virtual-pointer (pointer command) protocols.")
+    (license license:expat)))
+
-- 
2.32.0

Message #23 received at 47465 <at> debbugs.gnu.org (full text, mbox):

From: Calum Irwin <calumirwin1 <at> gmail.com>
To: 47465 <at> debbugs.gnu.org
Subject: [PATCH] Added wlrctl to xdisorg
Date: Sun, 27 Jun 2021 16:30:20 +1200

[Message part 1 (text/plain, inline)]

I've updated the patch to no longer conflict with the latest master.

[Message part 2 (text/html, inline)]

Message #28 received at 47465-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 47465-done <at> debbugs.gnu.org
Cc: Maxime Devos <maximedevos <at> telenet.be>, Calum Irwin <calumirwin1 <at> gmail.com>,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: [PATCH] Added wlrctl to xdisorg
Date: Wed, 12 Mar 2025 22:52:33 +0100

Hello,

> I've updated the patch to no longer conflict with the latest master.

I’ve updated wlrctl to 0.2.2 and applied your patch, finally… Thank you,
and sorry for the delay!

Regards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.