GNU bug report logs - #47467
[PATCH]: Fix Blender missing Voxel Remesher

Previous Next

Package: guix-patches;

Reported by: Ekaitz Zarraga <ekaitz <at> elenq.tech>

Date: Mon, 29 Mar 2021 14:18:01 UTC

Severity: normal

Tags: patch

Done: Leo Famulari <leo <at> famulari.name>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47467 in the body.
You can then email your comments to 47467 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#47467; Package guix-patches. (Mon, 29 Mar 2021 14:18:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Ekaitz Zarraga <ekaitz <at> elenq.tech>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 29 Mar 2021 14:18:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH]: Fix Blender missing Voxel Remesher
Date: Mon, 29 Mar 2021 14:17:20 +0000
[Message part 1 (text/plain, inline)]
Hi,

According to bug#47463[^1], Blender is missing a dependency that
doesn't allow to run the Voxel Remesher.

This series of patches solve that.

I have a comment on the first one. I'm not sure if I did it right.

I don't see a better way to set the `rpath` correcty. It should
find the lib by itself but the package has an executable as
ouput that doesn't find the library the package itself generates.
Removing the extra phase I added shows the RPATH is set to `lib`
instead to the absolute path of the library so the runpath check
fails to execute.

This is the best way I found to solve that but I'm sure whoever
that gets this patch knows a better way to handle that.

I tested Blender with this and it runs the Voxel Remesher as
expected.

Please, don't hesitate to send me any comment.

Thanks!


[^1]: https://lists.gnu.org/archive/html/bug-guix/2021-03/msg00647.html
[0001-gnu-Add-openvdb.patch (text/x-patch, attachment)]
[0002-gnu-blender-Update-dependencies.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#47467; Package guix-patches. (Mon, 29 Mar 2021 18:18:01 GMT) Full text and rfc822 format available.

Message #8 received at 47467 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "47467 <at> debbugs.gnu.org" <47467 <at> debbugs.gnu.org>
Subject: [PATCH]: Fix Blender missing Voxel Remesher (Follows)
Date: Mon, 29 Mar 2021 18:17:05 +0000
[Message part 1 (text/plain, inline)]
Looks like Nix package I used as a reference has unneeded inputs.

This is the updated OpenVDB package.

:)
[0001-gnu-Add-openvdb.patch (text/x-patch, attachment)]

Information forwarded to guix-patches <at> gnu.org:
bug#47467; Package guix-patches. (Mon, 12 Apr 2021 14:15:02 GMT) Full text and rfc822 format available.

Message #11 received at 47467 <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 47467 <at> debbugs.gnu.org
Subject: [PATCH]: Fix Blender missing Voxel Remesher
Date: Mon, 12 Apr 2021 16:14:15 +0200
I pushed a slightly modified version of your openvdb addition to the
“master” branch.

As for the second patch, I think it would be good to leave off the
addition of libxxf86vm, because it seems that it’s unrelated to enabling
the voxel remesher feature.

If you could confirm that, I’d be happy to apply a modified second
patch.  The commit message for that second patch should list the actual
changes like this:

--8<---------------cut here---------------start------------->8---
gnu: blender: Add and enable support for OpenVDB and TBB.

* gnu/packages/graphics.scm (blender)[arguments]: Enable OpenVDB and TBB.
[inputs]: Add openvdb.
--8<---------------cut here---------------end--------------->8---

Thanks for working on this!

-- 
Ricardo




Information forwarded to guix-patches <at> gnu.org:
bug#47467; Package guix-patches. (Wed, 21 Apr 2021 15:38:02 GMT) Full text and rfc822 format available.

Message #14 received at 47467 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "47467 <at> debbugs.gnu.org" <47467 <at> debbugs.gnu.org>,
 Ricardo Wurmus <rekado <at> elephly.net>
Subject: [PATCH]: Fix Blender missing Voxel Remesher
Date: Wed, 21 Apr 2021 15:36:59 +0000
Hi,

Sorry for the delay.

As I told Ricardo on IRC, I'm going to review all the inputs of
the package Blender because the official installation guide
proposes some inputs that we are not including specifically.

Until I do that, I'm compiling blender with the minimum changes
to make the voxel remesher work and I'll append the minimum patch
to this issue when it compiles (1h or so) and I test it.

Thanks for your time,
Ekaitz




Information forwarded to guix-patches <at> gnu.org:
bug#47467; Package guix-patches. (Wed, 21 Apr 2021 16:04:02 GMT) Full text and rfc822 format available.

Message #17 received at 47467 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "47467 <at> debbugs.gnu.org" <47467 <at> debbugs.gnu.org>,
 Ricardo Wurmus <rekado <at> elephly.net>
Subject: Re: [PATCH]: Fix Blender missing Voxel Remesher
Date: Wed, 21 Apr 2021 16:03:20 +0000
[Message part 1 (text/plain, inline)]
This is the new patch with the minimum changes.
I tested it and the voxel remesher works without issues.

Cheers!
[0001-gnu-blender-Update-dependencies.patch (text/x-patch, attachment)]

Reply sent to Leo Famulari <leo <at> famulari.name>:
You have taken responsibility. (Wed, 21 Apr 2021 16:20:02 GMT) Full text and rfc822 format available.

Notification sent to Ekaitz Zarraga <ekaitz <at> elenq.tech>:
bug acknowledged by developer. (Wed, 21 Apr 2021 16:20:02 GMT) Full text and rfc822 format available.

Message #22 received at 47467-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: Ricardo Wurmus <rekado <at> elephly.net>,
 "47467 <at> debbugs.gnu.org" <47467-done <at> debbugs.gnu.org>
Subject: Re: [bug#47467] [PATCH]: Fix Blender missing Voxel Remesher
Date: Wed, 21 Apr 2021 12:19:28 -0400
On Wed, Apr 21, 2021 at 04:03:20PM +0000, Ekaitz Zarraga wrote:
> This is the new patch with the minimum changes.
> I tested it and the voxel remesher works without issues.

Thanks!

> From 4c3705efbd24a63614ecfa964c661a503c8001a9 Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Wed, 21 Apr 2021 17:59:32 +0200
> Subject: [PATCH] gnu: blender: Update dependencies
> 
>     * gnu/packages/graphics.scm (blender):
>     [inputs]: Add openvdb
>     [arguments]: Add configure flags for openvdb

I pushed as 823752646f4992efdd4162724b46e04dda8b660a after rewriting the
commit message to 1) have a descriptive title, 2) use complete sentences
and 3) Describe the changes in terms of code. As well as re-indenting.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 20 May 2021 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 313 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.