GNU bug report logs - #47478
28.0.50; Provide customization option for nnimap-keepalive-timer

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47478 in the body.
You can then email your comments to 47478 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Provide customization option for nnimap-keepalive-timer
Date: Mon, 29 Mar 2021 09:22:40 -0700

[Message part 1 (text/plain, inline)]

Bob Newell requested the ability to customize the
`nnimap-keepalive-timer', and I've opened this bug report with a patch
that adds a new `nnimap-keepalive-times' customization option.

It lets you customize both function interval and period of inactivity,
or you can set it to nil to disable the keepalive altogether.

I also sneaked in a little extra change: since we provided the option to
use Dbus to close Gnus servers when your machine is going to sleep, I've
noticed that sometimes (more often than you'd think) I seem to be
sleeping the machine in between sending the keepalive NOOP and receiving
the response.

When the computer wakes, Emacs is hung while Gnus waits on an OK that
isn't coming, and I need to C-g to get out of it. I would have thought
this was a pretty small target to hit, particular since my imap servers
are all on this computer, but it happens quite often. So this patch also
lets `nnimap-streaming' to t around the keepalive command, so we don't
wait for the response. Semantically incorrect, but the effect is right.

If this is acceptable I can add a NEWS entry (and maybe the manual as
well?).

Eric

[nnimap-keepalive-customization.diff (text/x-patch, attachment)]

Message #8 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Wed, 28 Apr 2021 16:08:18 -0700

A gentle bump. Lars, do you have any thoughts on this? In the interim
I've started to dislike `nnimap-keepalives-times' as the option name,
but haven't come up with anything better.

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Bob Newell requested the ability to customize the
> `nnimap-keepalive-timer', and I've opened this bug report with a patch
> that adds a new `nnimap-keepalive-times' customization option.
>
> It lets you customize both function interval and period of inactivity,
> or you can set it to nil to disable the keepalive altogether.
>
> I also sneaked in a little extra change: since we provided the option to
> use Dbus to close Gnus servers when your machine is going to sleep, I've
> noticed that sometimes (more often than you'd think) I seem to be
> sleeping the machine in between sending the keepalive NOOP and receiving
> the response.
>
> When the computer wakes, Emacs is hung while Gnus waits on an OK that
> isn't coming, and I need to C-g to get out of it. I would have thought
> this was a pretty small target to hit, particular since my imap servers
> are all on this computer, but it happens quite often. So this patch also
> lets `nnimap-streaming' to t around the keepalive command, so we don't
> wait for the response. Semantically incorrect, but the effect is right.
>
> If this is acceptable I can add a NEWS entry (and maybe the manual as
> well?).
>
> Eric

Message #11 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Wed, 28 Apr 2021 16:29:16 -0700

A gentle bump. Lars, do you have any thoughts on this? In the interim
I've started to dislike `nnimap-keepalives-times' as the option name,
but haven't come up with anything better.

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Bob Newell requested the ability to customize the
> `nnimap-keepalive-timer', and I've opened this bug report with a patch
> that adds a new `nnimap-keepalive-times' customization option.
>
> It lets you customize both function interval and period of inactivity,
> or you can set it to nil to disable the keepalive altogether.
>
> I also sneaked in a little extra change: since we provided the option to
> use Dbus to close Gnus servers when your machine is going to sleep, I've
> noticed that sometimes (more often than you'd think) I seem to be
> sleeping the machine in between sending the keepalive NOOP and receiving
> the response.
>
> When the computer wakes, Emacs is hung while Gnus waits on an OK that
> isn't coming, and I need to C-g to get out of it. I would have thought
> this was a pretty small target to hit, particular since my imap servers
> are all on this computer, but it happens quite often. So this patch also
> lets `nnimap-streaming' to t around the keepalive command, so we don't
> wait for the response. Semantically incorrect, but the effect is right.
>
> If this is acceptable I can add a NEWS entry (and maybe the manual as
> well?).
>
> Eric

Message #14 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Sun, 02 May 2021 08:52:02 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Bob Newell requested the ability to customize the
> `nnimap-keepalive-timer', and I've opened this bug report with a patch
> that adds a new `nnimap-keepalive-times' customization option.
>
> It lets you customize both function interval and period of inactivity,
> or you can set it to nil to disable the keepalive altogether.

Sure; makes sense.

> I also sneaked in a little extra change: since we provided the option to
> use Dbus to close Gnus servers when your machine is going to sleep, I've
> noticed that sometimes (more often than you'd think) I seem to be
> sleeping the machine in between sending the keepalive NOOP and receiving
> the response.

I think that should be OK -- when we're looking for responses, we use
tags, so the response from the NOOP shouldn't confuse anything.
(Hopefully.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #17 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Sun, 02 May 2021 09:57:19 -0700

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Bob Newell requested the ability to customize the
>> `nnimap-keepalive-timer', and I've opened this bug report with a patch
>> that adds a new `nnimap-keepalive-times' customization option.
>>
>> It lets you customize both function interval and period of inactivity,
>> or you can set it to nil to disable the keepalive altogether.
>
> Sure; makes sense.

Cool. In the meantime I've come to prefer the name
`nnimap-keepalive-intervals', if that's all right.

I'll add this to the manual, as well. Do you think it should be a
defvoo, or a regular customization option?

>> I also sneaked in a little extra change: since we provided the option to
>> use Dbus to close Gnus servers when your machine is going to sleep, I've
>> noticed that sometimes (more often than you'd think) I seem to be
>> sleeping the machine in between sending the keepalive NOOP and receiving
>> the response.
>
> I think that should be OK -- when we're looking for responses, we use
> tags, so the response from the NOOP shouldn't confuse anything.
> (Hopefully.)

Hopefully!

Message #20 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Mon, 03 May 2021 11:01:50 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> Cool. In the meantime I've come to prefer the name
> `nnimap-keepalive-intervals', if that's all right.

Yes, even better.

> I'll add this to the manual, as well. Do you think it should be a
> defvoo, or a regular customization option?

Probably a defvoo -- it's possible that people would want different
timeouts for different servers.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #23 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Mon, 03 May 2021 09:16:40 -0700

[Message part 1 (text/plain, inline)]

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> Cool. In the meantime I've come to prefer the name
>> `nnimap-keepalive-intervals', if that's all right.
>
> Yes, even better.
>
>> I'll add this to the manual, as well. Do you think it should be a
>> defvoo, or a regular customization option?
>
> Probably a defvoo -- it's possible that people would want different
> timeouts for different servers.

Cool, here's what it looks like now.

Eric

[0001-Add-new-defvoo-nnimap-keepalive-intervals-to-Gnus-nn.patch (text/x-patch, attachment)]

Message #26 received at 47478 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Eric Abrahamsen <eric <at> ericabrahamsen.net>
Cc: 47478 <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Tue, 04 May 2021 10:01:01 +0200

Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:

> +By default, nnimap will send occasional ``NOOP'' signals to the
> +server, to keep the connection alive.

Perhaps this should say "sends a @samp{NOOP} (keepalive) command" to be
less obscure?

> +keepalive command.  Set to nil to disable keepalive commands altogether.

@code{nil}

Otherwise, looks good to me.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #31 received at 47478-done <at> debbugs.gnu.org (full text, mbox):

From: Eric Abrahamsen <eric <at> ericabrahamsen.net>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Bob Newell <bobnewell <at> bobnewell.net>, 47478-done <at> debbugs.gnu.org
Subject: Re: bug#47478: 28.0.50; Provide customization option for
 nnimap-keepalive-timer
Date: Tue, 04 May 2021 16:35:09 -0700

On 05/04/21 10:01 AM, Lars Ingebrigtsen wrote:
> Eric Abrahamsen <eric <at> ericabrahamsen.net> writes:
>
>> +By default, nnimap will send occasional ``NOOP'' signals to the
>> +server, to keep the connection alive.
>
> Perhaps this should say "sends a @samp{NOOP} (keepalive) command" to be
> less obscure?
>
>> +keepalive command.  Set to nil to disable keepalive commands altogether.
>
> @code{nil}
>
> Otherwise, looks good to me.

Thanks! Done and closing.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.