GNU bug report logs - #47499
[PATCH] Update waybar

Previous Next

Package: guix-patches;

Reported by: pricly_yellow <at> dismail.de

Date: Tue, 30 Mar 2021 14:47:02 UTC

Severity: normal

Tags: patch

Done: Efraim Flashner <efraim <at> flashner.co.il>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47499 in the body.
You can then email your comments to 47499 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#47499; Package guix-patches. (Tue, 30 Mar 2021 14:47:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to pricly_yellow <at> dismail.de:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 30 Mar 2021 14:47:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: pricly_yellow <at> dismail.de
To: guix-patches <at> gnu.org
Subject: [PATCH] Update waybar
Date: Tue, 30 Mar 2021 11:31:17 +0000
diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
index 6105a98f14..96e1527d5c 100644
--- a/gnu/packages/wm.scm
+++ b/gnu/packages/wm.scm
@@ -1569,7 +1569,7 @@ modules for building a Wayland compositor.")
 (define-public waybar
   (package
     (name "waybar")
-    (version "0.9.4")
+    (version "0.9.5")
     (source
      (origin
        (method git-fetch)
@@ -1578,10 +1578,10 @@ modules for building a Wayland compositor.")
              (commit version)))
        (file-name (git-file-name name version))
        (sha256
-        (base32 "038vnma7y7z81caywp45yr364bc1aq8d01j5vycyiyfv33nm76fy"))))
+        (base32 "1kzrgqaclfk6gcwhknxn28xl74gm5swipgn8kk8avacb4nsw1l9q"))))
     (build-system meson-build-system)
     (inputs `(("date" ,date)
-              ("fmt" ,fmt-6)
+              ("fmt" ,fmt)
               ("gtk-layer-shell" ,gtk-layer-shell)
               ("gtkmm" ,gtkmm)
               ("jsoncpp" ,jsoncpp)
@@ -1590,7 +1590,7 @@ modules for building a Wayland compositor.")
               ("libmpdclent" ,libmpdclient)
               ("libnl" ,libnl)
               ("pulseaudio" ,pulseaudio)
-              ("spdlog" ,spdlog-1.7)
+              ("spdlog" ,spdlog)
               ("wayland" ,wayland)))
     (native-inputs
      `(("gcc" ,gcc-8)                   ; for #include <filesystem>




Information forwarded to guix-patches <at> gnu.org:
bug#47499; Package guix-patches. (Wed, 31 Mar 2021 14:34:01 GMT) Full text and rfc822 format available.

Message #8 received at 47499 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: pricly_yellow <at> dismail.de
Cc: 47499 <at> debbugs.gnu.org
Subject: Re: [bug#47499] [PATCH] Update waybar
Date: Wed, 31 Mar 2021 17:32:32 +0300
[Message part 1 (text/plain, inline)]
Thanks for your patch. The commit message can use a bit more
information so it's easy to follow what happened by just reading it.

    gnu: waybar: Update to 0.9.5.

    * gnu/packages/wm.scm (waybar): Update to 0.9.5.
    [inputs]: Replace fmt-6 with fmt, spdlog-1.7 with spdlog.

Also, if this is the last package which needs fmt-6 and spdlog-1.7 those
can also be removed as part of this commit.

I don't run sway myself, does the new version work with the updated
dependencies?

On Tue, Mar 30, 2021 at 11:31:17AM +0000, pricly_yellow--- via Guix-patches via wrote:
> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> index 6105a98f14..96e1527d5c 100644
> --- a/gnu/packages/wm.scm
> +++ b/gnu/packages/wm.scm
> @@ -1569,7 +1569,7 @@ modules for building a Wayland compositor.")
>  (define-public waybar
>    (package
>      (name "waybar")
> -    (version "0.9.4")
> +    (version "0.9.5")
>      (source
>       (origin
>         (method git-fetch)
> @@ -1578,10 +1578,10 @@ modules for building a Wayland compositor.")
>               (commit version)))
>         (file-name (git-file-name name version))
>         (sha256
> -        (base32 "038vnma7y7z81caywp45yr364bc1aq8d01j5vycyiyfv33nm76fy"))))
> +        (base32 "1kzrgqaclfk6gcwhknxn28xl74gm5swipgn8kk8avacb4nsw1l9q"))))
>      (build-system meson-build-system)
>      (inputs `(("date" ,date)
> -              ("fmt" ,fmt-6)
> +              ("fmt" ,fmt)
>                ("gtk-layer-shell" ,gtk-layer-shell)
>                ("gtkmm" ,gtkmm)
>                ("jsoncpp" ,jsoncpp)
> @@ -1590,7 +1590,7 @@ modules for building a Wayland compositor.")
>                ("libmpdclent" ,libmpdclient)
>                ("libnl" ,libnl)
>                ("pulseaudio" ,pulseaudio)
> -              ("spdlog" ,spdlog-1.7)
> +              ("spdlog" ,spdlog)
>                ("wayland" ,wayland)))
>      (native-inputs
>       `(("gcc" ,gcc-8)                   ; for #include <filesystem>
> 
> 
> 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#47499; Package guix-patches. (Thu, 01 Apr 2021 06:11:02 GMT) Full text and rfc822 format available.

Message #11 received at 47499 <at> debbugs.gnu.org (full text, mbox):

From: pricly_yellow <at> dismail.de
To: "Efraim Flashner" <efraim <at> flashner.co.il>
Cc: 47499 <at> debbugs.gnu.org
Subject: Re: [bug#47499] [PATCH] Update waybar
Date: Thu, 01 Apr 2021 06:09:52 +0000
Thanks for your comments, I tested new version with different configurations, look's fine.

This patch for delete fmt-6 and spdlog-1.7, because this packages is not needs.

diff --git a/gnu/packages/pretty-print.scm b/gnu/packages/pretty-print.scm
index af02fd91a9..4662a1e717 100644
--- a/gnu/packages/pretty-print.scm
+++ b/gnu/packages/pretty-print.scm
@@ -189,19 +189,6 @@ to @code{IOStreams}.")
;; The library is bsd-2, but documentation and tests include other licenses.
(license (list bsd-2 bsd-3 psfl))))

-(define-public fmt-6
- (package
- (inherit fmt)
- (name "fmt")
- (version "6.2.1")
- (source
- (origin
- (method url-fetch)
- (uri (string-append "https://github.com/fmtlib/fmt/releases/download"
- version "/fmt-" version ".zip"))
- (sha256
- (base32 "06l8g59frbsbwj15kg6x2bbn6p8yidh6wzsigdhbdjncvm1agzll"))))))
-
(define-public source-highlight
(package
(name "source-highlight")

diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
index b879fecebc..6a4975e435 100644
--- a/gnu/packages/logging.scm
+++ b/gnu/packages/logging.scm
@@ -214,19 +214,3 @@ library.")
;; spdlog is under Expat license, but the bundled fmt library in
;; "include/spdlog/fmt/bundled" is under BSD 2 clause license.
(license (list license:expat license:bsd-2))))
-
-(define-public spdlog-1.7
- (package
- (inherit spdlog)
- (name "spdlog")
- (version "1.7.0")
- (source
- (origin
- (method git-fetch)
- (uri (git-reference
- (url "https://github.com/gabime/spdlog")
- (commit (string-append "v" version))))
- (file-name (git-file-name name version))
- (sha256
- (base32
- "1ryaa22ppj60461hcdb8nk7jwj84arp4iw4lyw594py92g4vnx3j"))))))

March 31, 2021 2:33 PM, "Efraim Flashner" <efraim <at> flashner.co.il> wrote:

> Thanks for your patch. The commit message can use a bit more
> information so it's easy to follow what happened by just reading it.
> 
> gnu: waybar: Update to 0.9.5.
> 
> * gnu/packages/wm.scm (waybar): Update to 0.9.5.
> [inputs]: Replace fmt-6 with fmt, spdlog-1.7 with spdlog.
> 
> Also, if this is the last package which needs fmt-6 and spdlog-1.7 those
> can also be removed as part of this commit.
> 
> I don't run sway myself, does the new version work with the updated
> dependencies?
> 
> On Tue, Mar 30, 2021 at 11:31:17AM +0000, pricly_yellow--- via Guix-patches via wrote:
> 
>> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
>> index 6105a98f14..96e1527d5c 100644
>> --- a/gnu/packages/wm.scm
>> +++ b/gnu/packages/wm.scm
>> @@ -1569,7 +1569,7 @@ modules for building a Wayland compositor.")
>> (define-public waybar
>> (package
>> (name "waybar")
>> - (version "0.9.4")
>> + (version "0.9.5")
>> (source
>> (origin
>> (method git-fetch)
>> @@ -1578,10 +1578,10 @@ modules for building a Wayland compositor.")
>> (commit version)))
>> (file-name (git-file-name name version))
>> (sha256
>> - (base32 "038vnma7y7z81caywp45yr364bc1aq8d01j5vycyiyfv33nm76fy"))))
>> + (base32 "1kzrgqaclfk6gcwhknxn28xl74gm5swipgn8kk8avacb4nsw1l9q"))))
>> (build-system meson-build-system)
>> (inputs `(("date" ,date)
>> - ("fmt" ,fmt-6)
>> + ("fmt" ,fmt)
>> ("gtk-layer-shell" ,gtk-layer-shell)
>> ("gtkmm" ,gtkmm)
>> ("jsoncpp" ,jsoncpp)
>> @@ -1590,7 +1590,7 @@ modules for building a Wayland compositor.")
>> ("libmpdclent" ,libmpdclient)
>> ("libnl" ,libnl)
>> ("pulseaudio" ,pulseaudio)
>> - ("spdlog" ,spdlog-1.7)
>> + ("spdlog" ,spdlog)
>> ("wayland" ,wayland)))
>> (native-inputs
>> `(("gcc" ,gcc-8) ; for #include <filesystem>
> 
> --
> Efraim Flashner <efraim <at> flashner.co.il> אפרים פלשנר
> GPG key = A28B F40C 3E55 1372 662D 14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypted




Information forwarded to guix-patches <at> gnu.org:
bug#47499; Package guix-patches. (Thu, 01 Apr 2021 07:55:01 GMT) Full text and rfc822 format available.

Message #14 received at 47499 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: pricly_yellow <at> dismail.de
Cc: 47499 <at> debbugs.gnu.org
Subject: Re: [bug#47499] [PATCH] Update waybar
Date: Thu, 1 Apr 2021 10:53:45 +0300
[Message part 1 (text/plain, inline)]
On Thu, Apr 01, 2021 at 06:09:52AM +0000, pricly_yellow <at> dismail.de wrote:
> Thanks for your comments, I tested new version with different configurations, look's fine.
> 
> This patch for delete fmt-6 and spdlog-1.7, because this packages is not needs.

Thanks. Patch applied!

> diff --git a/gnu/packages/pretty-print.scm b/gnu/packages/pretty-print.scm
> index af02fd91a9..4662a1e717 100644
> --- a/gnu/packages/pretty-print.scm
> +++ b/gnu/packages/pretty-print.scm
> @@ -189,19 +189,6 @@ to @code{IOStreams}.")
> ;; The library is bsd-2, but documentation and tests include other licenses.
> (license (list bsd-2 bsd-3 psfl))))
> 
> -(define-public fmt-6
> - (package
> - (inherit fmt)
> - (name "fmt")
> - (version "6.2.1")
> - (source
> - (origin
> - (method url-fetch)
> - (uri (string-append "https://github.com/fmtlib/fmt/releases/download"
> - version "/fmt-" version ".zip"))
> - (sha256
> - (base32 "06l8g59frbsbwj15kg6x2bbn6p8yidh6wzsigdhbdjncvm1agzll"))))))
> -
> (define-public source-highlight
> (package
> (name "source-highlight")
> 
> diff --git a/gnu/packages/logging.scm b/gnu/packages/logging.scm
> index b879fecebc..6a4975e435 100644
> --- a/gnu/packages/logging.scm
> +++ b/gnu/packages/logging.scm
> @@ -214,19 +214,3 @@ library.")
> ;; spdlog is under Expat license, but the bundled fmt library in
> ;; "include/spdlog/fmt/bundled" is under BSD 2 clause license.
> (license (list license:expat license:bsd-2))))
> -
> -(define-public spdlog-1.7
> - (package
> - (inherit spdlog)
> - (name "spdlog")
> - (version "1.7.0")
> - (source
> - (origin
> - (method git-fetch)
> - (uri (git-reference
> - (url "https://github.com/gabime/spdlog")
> - (commit (string-append "v" version))))
> - (file-name (git-file-name name version))
> - (sha256
> - (base32
> - "1ryaa22ppj60461hcdb8nk7jwj84arp4iw4lyw594py92g4vnx3j"))))))
> 
> March 31, 2021 2:33 PM, "Efraim Flashner" <efraim <at> flashner.co.il> wrote:
> 
> > Thanks for your patch. The commit message can use a bit more
> > information so it's easy to follow what happened by just reading it.
> > 
> > gnu: waybar: Update to 0.9.5.
> > 
> > * gnu/packages/wm.scm (waybar): Update to 0.9.5.
> > [inputs]: Replace fmt-6 with fmt, spdlog-1.7 with spdlog.
> > 
> > Also, if this is the last package which needs fmt-6 and spdlog-1.7 those
> > can also be removed as part of this commit.
> > 
> > I don't run sway myself, does the new version work with the updated
> > dependencies?
> > 
> > On Tue, Mar 30, 2021 at 11:31:17AM +0000, pricly_yellow--- via Guix-patches via wrote:
> > 
> >> diff --git a/gnu/packages/wm.scm b/gnu/packages/wm.scm
> >> index 6105a98f14..96e1527d5c 100644
> >> --- a/gnu/packages/wm.scm
> >> +++ b/gnu/packages/wm.scm
> >> @@ -1569,7 +1569,7 @@ modules for building a Wayland compositor.")
> >> (define-public waybar
> >> (package
> >> (name "waybar")
> >> - (version "0.9.4")
> >> + (version "0.9.5")
> >> (source
> >> (origin
> >> (method git-fetch)
> >> @@ -1578,10 +1578,10 @@ modules for building a Wayland compositor.")
> >> (commit version)))
> >> (file-name (git-file-name name version))
> >> (sha256
> >> - (base32 "038vnma7y7z81caywp45yr364bc1aq8d01j5vycyiyfv33nm76fy"))))
> >> + (base32 "1kzrgqaclfk6gcwhknxn28xl74gm5swipgn8kk8avacb4nsw1l9q"))))
> >> (build-system meson-build-system)
> >> (inputs `(("date" ,date)
> >> - ("fmt" ,fmt-6)
> >> + ("fmt" ,fmt)
> >> ("gtk-layer-shell" ,gtk-layer-shell)
> >> ("gtkmm" ,gtkmm)
> >> ("jsoncpp" ,jsoncpp)
> >> @@ -1590,7 +1590,7 @@ modules for building a Wayland compositor.")
> >> ("libmpdclent" ,libmpdclient)
> >> ("libnl" ,libnl)
> >> ("pulseaudio" ,pulseaudio)
> >> - ("spdlog" ,spdlog-1.7)
> >> + ("spdlog" ,spdlog)
> >> ("wayland" ,wayland)))
> >> (native-inputs
> >> `(("gcc" ,gcc-8) ; for #include <filesystem>
> > 

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

Reply sent to Efraim Flashner <efraim <at> flashner.co.il>:
You have taken responsibility. (Thu, 01 Apr 2021 07:56:01 GMT) Full text and rfc822 format available.

Notification sent to pricly_yellow <at> dismail.de:
bug acknowledged by developer. (Thu, 01 Apr 2021 07:56:02 GMT) Full text and rfc822 format available.

Message #19 received at 47499-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 47499-done <at> debbugs.gnu.org
Subject: Re: [bug#47499] [PATCH] Update waybar
Date: Thu, 1 Apr 2021 10:54:39 +0300
[Message part 1 (text/plain, inline)]
Forgot to close the bug.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Thu, 29 Apr 2021 11:24:08 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 335 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.