GNU bug report logs - #47501
[PATCH] Do not search the global keymap in project--keymap-prompt

Previous Next

Package: emacs;

Reported by: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>

Date: Tue, 30 Mar 2021 17:03:01 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47501 in the body.
You can then email your comments to 47501 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#47501; Package emacs. (Tue, 30 Mar 2021 17:03:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 30 Mar 2021 17:03:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: [PATCH] Do not search the global keymap in project--keymap-prompt
Date: Tue, 30 Mar 2021 19:02:34 +0200

[Message part 1 (text/plain, inline)]
Hi,

project--keymap-prompt searches project-prefix-map *plus* the global
keymap when constructing the prompt for project-switch-command.  This
can result in weird behavior; for example,

    (global-set-key (kbd "M-s r") 'rgrep)
    (require 'project)
    (define-key project-prefix-map (kbd "<f5>") 'rgrep)
    (push '(rgrep "rgrep") project-switch-commands)

might (or will?) cause project-switch-project to display "[M-s r] rgrep"
instead of the expected "[<f5>] rgrep".

The attached patch fixes the issue as per the documentation of
`where-is-internal'.

Best regards,
Dario


[0001-Do-not-search-the-global-keymap-in-project-keymap-pr.patch (text/x-diff, attachment)]
[Message part 3 (text/plain, inline)]
-- 
$ keyserver=hkps://hkps.pool.sks-keyservers.net
$ keyid=744A4F0B4F1C9371
$ gpg --keyserver $keyserver --search-keys $keyid
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#47501; Package emacs. (Mon, 05 Apr 2021 16:16:01 GMT) Full text and rfc822 format available.

Message #8 received at 47501 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com>
Cc: 47501 <at> debbugs.gnu.org
Subject: Re: bug#47501: [PATCH] Do not search the global keymap in
 project--keymap-prompt
Date: Mon, 05 Apr 2021 18:15:36 +0200

Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> writes:

> The attached patch fixes the issue as per the documentation of
> `where-is-internal'.

Makes sense to me; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 05 Apr 2021 16:16:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 47501 <at> debbugs.gnu.org and Dario Gjorgjevski <dario.gjorgjevski <at> gmail.com> Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Mon, 05 Apr 2021 16:16:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Tue, 04 May 2021 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 357 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.