GNU bug report logs - #47516
28.0.50; void-variable edebug-all-defs

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47516 in the body.
You can then email your comments to 47516 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Bug-Gnu-Emacs <bug-gnu-emacs <at> gnu.org>
Subject: 28.0.50; void-variable edebug-all-defs
Date: Wed, 31 Mar 2021 10:10:30 +0200

For decades I'm used to debug Lisp functions by calling `edebug-defun'.
To get rid of the debugging instrumentation I'm using `eval-buffer'.  In
the not so distant past Emacs started to complain about this habit as
follows:


Debugger entered--Lisp error: (void-variable edebug-all-defs)
  edebug-read-and-maybe-wrap-form1()
  edebug-read-and-maybe-wrap-form()
  edebug--read(read #<buffer window.el>)
  apply(edebug--read read #<buffer window.el>)
  #f(advice-wrapper :around read edebug--read)(#<buffer window.el>)
  eval-buffer()  ; Reading at buffer position 990
  funcall-interactively(eval-buffer)
  call-interactively(eval-buffer nil nil)
  command-execute(eval-buffer)


I neither understand the error message nor why I should not be allowed
to evaluate the buffer in this situation.

martin

Message #8 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Wed, 31 Mar 2021 13:16:09 +0200

Am Mi., 31. März 2021 um 10:11 Uhr schrieb martin rudalics <rudalics <at> gmx.at>:
>
> For decades I'm used to debug Lisp functions by calling `edebug-defun'.
> To get rid of the debugging instrumentation I'm using `eval-buffer'.  In
> the not so distant past Emacs started to complain about this habit as
> follows:
>
>
> Debugger entered--Lisp error: (void-variable edebug-all-defs)
>    edebug-read-and-maybe-wrap-form1()
>    edebug-read-and-maybe-wrap-form()
>    edebug--read(read #<buffer window.el>)
>    apply(edebug--read read #<buffer window.el>)
>    #f(advice-wrapper :around read edebug--read)(#<buffer window.el>)
>    eval-buffer()  ; Reading at buffer position 990
>    funcall-interactively(eval-buffer)
>    call-interactively(eval-buffer nil nil)
>    command-execute(eval-buffer)
>
>
> I neither understand the error message nor why I should not be allowed
> to evaluate the buffer in this situation.
>

 Not sure whether it's related, but there's a comment in edebug.el:

;; edebug-all-defs and edebug-all-forms need to be autoloaded
;; because the byte compiler binds them; as a result, if edebug
;; is first loaded for a require in a compilation, they will be left unbound.

But despite this explanation these two variables aren't autoloaded.

Message #11 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Michael Heerdegen <michael_heerdegen <at> web.de>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: martin rudalics <rudalics <at> gmx.at>, Philipp Stephani <p.stephani2 <at> gmail.com>,
 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Thu, 01 Apr 2021 02:03:52 +0200

Stefan,

You removed that autoload cookie in bae2cfe63c:

| * lisp/emacs-lisp/edebug.el (eval-defun): Simplify
|
| (edebug-all-defs, edebug-all-forms): Don't autoload since the problem
| it was working around has been fixed a while back.

Seems that was hasty - or not the only problem these autoload cured?

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

> > For decades I'm used to debug Lisp functions by calling `edebug-defun'.
> > To get rid of the debugging instrumentation I'm using `eval-buffer'.  In
> > the not so distant past Emacs started to complain about this habit as
> > follows:
> >
> > Debugger entered--Lisp error: (void-variable edebug-all-defs)
> >    edebug-read-and-maybe-wrap-form1()
> >    edebug-read-and-maybe-wrap-form()
> >    edebug--read(read #<buffer window.el>)
> >    apply(edebug--read read #<buffer window.el>)
> >    #f(advice-wrapper :around read edebug--read)(#<buffer window.el>)
> >    eval-buffer()  ; Reading at buffer position 990
> >    funcall-interactively(eval-buffer)
> >    call-interactively(eval-buffer nil nil)
> >    command-execute(eval-buffer)
> >
> > I neither understand the error message nor why I should not be allowed
> > to evaluate the buffer in this situation.
> >
>
>  Not sure whether it's related, but there's a comment in edebug.el:
>
> ;; edebug-all-defs and edebug-all-forms need to be autoloaded
> ;; because the byte compiler binds them; as a result, if edebug
> ;; is first loaded for a require in a compilation, they will be left
> unbound.
>
> But despite this explanation these two variables aren't autoloaded.


TIA,

Michael.

Message #14 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Thu, 01 Apr 2021 23:19:16 -0400

> Debugger entered--Lisp error: (void-variable edebug-all-defs)
>   edebug-read-and-maybe-wrap-form1()
>   edebug-read-and-maybe-wrap-form()
>   edebug--read(read #<buffer window.el>)
>   apply(edebug--read read #<buffer window.el>)
>   #f(advice-wrapper :around read edebug--read)(#<buffer window.el>)
>   eval-buffer()  ; Reading at buffer position 990
>   funcall-interactively(eval-buffer)
>   call-interactively(eval-buffer nil nil)
>   command-execute(eval-buffer)

Do you have some extra info about how to reproduce this?
I tried `M-x eval-buffer` inside `lisp/window.el` but that didn't signal
any problem, neither before nor after loading `edebug.el`.


        Stefan

Message #17 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Fri, 2 Apr 2021 08:49:31 +0200

> Do you have some extra info about how to reproduce this?
> I tried `M-x eval-buffer` inside `lisp/window.el` but that didn't signal
> any problem, neither before nor after loading `edebug.el`.

Suppose I put point within a function like `window-min-pixel-height' and
then type C-M-# which here

  runs the command edebug-defun (found in edebug-mode-map), which is
  an alias for ‘edebug-eval-top-level-form’ in ‘edebug.el’.

insert (window-min-pixel-height) into *scratch* and do C-x e and debug
that call.  When I now type M-# in window.el which here

  runs the command eval-buffer (found in edebug-mode-map), which is an
  interactive built-in function in ‘C source code’.

I get

Debugger entered--Lisp error: (void-variable edebug-all-defs)
  edebug-read-and-maybe-wrap-form1()
  edebug-read-and-maybe-wrap-form()
  edebug--read(read #<buffer window.el>)
  apply(edebug--read read #<buffer window.el>)
  #f(advice-wrapper :around read edebug--read)(#<buffer window.el>)
  eval-buffer()  ; Reading at buffer position 990
  funcall-interactively(eval-buffer)
  call-interactively(eval-buffer nil nil)
  command-execute(eval-buffer)

Quitting *Backtrace* - I have (debug-on-error t) - and typing M-# again
gets me that "error" again and again.

Three settings in my custom-set-variables section which might be related
are

 '(edebug-on-error nil)
 '(edebug-on-quit nil)
 '(edebug-print-level 50)

martin

Message #20 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Fri, 02 Apr 2021 09:17:29 -0400

> Suppose I put point within a function like `window-min-pixel-height' and
> then type C-M-# which here
>
>   runs the command edebug-defun (found in edebug-mode-map), which is
>   an alias for ‘edebug-eval-top-level-form’ in ‘edebug.el’.

Hmm... this is a bit odd: `edebug-mode-map` is the map used when we're
stepping through execution with Edebug, so are you saying that Edebug
was already in use before this `edebug-defun`?

> insert (window-min-pixel-height) into *scratch* and do C-x e and debug
> that call.  When I now type M-# in window.el which here
>
>   runs the command eval-buffer (found in edebug-mode-map), which is an
>   interactive built-in function in ‘C source code’.
>
> I get
>
> Debugger entered--Lisp error: (void-variable edebug-all-defs)

Hmm... still can't reproduce it here.  Can you reproduce it with `emacs -Q`?

Also (stab in the dark), could you check (boundp 'edebug-all-defs) in
a few different buffers?


        Stefan

Message #23 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Fri, 2 Apr 2021 16:15:52 +0200

> Hmm... still can't reproduce it here.  Can you reproduce it with `emacs -Q`?
>
> Also (stab in the dark), could you check (boundp 'edebug-all-defs) in
> a few different buffers?

Maybe I found it.  For whatever reson I have

    (make-local-variable 'edebug-all-defs)

in my emacs-lisp-mode-hook.  Apparently, I needed it many years ago and
it wasn't in the way till a couple of weeks or months ago.

martin

Message #26 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: martin rudalics <rudalics <at> gmx.at>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Fri, 02 Apr 2021 11:31:53 -0400

>> Hmm... still can't reproduce it here.  Can you reproduce it with `emacs -Q`?
>>
>> Also (stab in the dark), could you check (boundp 'edebug-all-defs) in
>> a few different buffers?
>
> Maybe I found it.  For whatever reson I have
>
>     (make-local-variable 'edebug-all-defs)
>
> in my emacs-lisp-mode-hook.  Apparently, I needed it many years ago and
> it wasn't in the way till a couple of weeks or months ago.

Oh, so it ends up making the variable buffer-local before it gets
initialized, so it's both globally unbound and buffer-locally unbound.
Hence when the `defvar` is processed the global value gets initialized
but the buffer-local value stays unbound.

Do you happen to remember why you "needed it many years ago"?

I'm leaning towards considering this a "pilot error".


        Stefan

Message #29 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Fri, 2 Apr 2021 20:24:03 +0200

> Oh, so it ends up making the variable buffer-local before it gets
> initialized, so it's both globally unbound and buffer-locally unbound.
> Hence when the `defvar` is processed the global value gets initialized
> but the buffer-local value stays unbound.
>
> Do you happen to remember why you "needed it many years ago"?

No.  But I just read the doc-string of `edebug-all-defs':

  edebug-all-defs is a variable defined in ‘edebug.el’.

  You can use the command ‘edebug-all-defs’ to toggle the value of this
  variable.  You may wish to make it local to each buffer with
  (make-local-variable 'edebug-all-defs) in your
  ‘emacs-lisp-mode-hook’.

and that's what I've apparently done.

> I'm leaning towards considering this a "pilot error".

Objection, your honor!

martin

Message #32 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: martin rudalics <rudalics <at> gmx.at>
Cc: Stefan Monnier <monnier <at> iro.umontreal.ca>, 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Sat, 08 May 2021 14:14:52 +0200

martin rudalics <rudalics <at> gmx.at> writes:

> No.  But I just read the doc-string of `edebug-all-defs':
>
>   edebug-all-defs is a variable defined in ‘edebug.el’.
>
>   You can use the command ‘edebug-all-defs’ to toggle the value of this
>   variable.  You may wish to make it local to each buffer with
>   (make-local-variable 'edebug-all-defs) in your
>   ‘emacs-lisp-mode-hook’.
>
> and that's what I've apparently done.
>
>> I'm leaning towards considering this a "pilot error".
>
> Objection, your honor!

Skimming this thread, it seems like this is indeed a bug...  so is the
right fix here just to reintroduce the autoloads removed by bae2cfe63c?

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #37 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: martin rudalics <rudalics <at> gmx.at>, 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Sat, 08 May 2021 19:31:41 -0400

Lars Ingebrigtsen [2021-05-08 14:14:52] wrote:
> martin rudalics <rudalics <at> gmx.at> writes:
>> No.  But I just read the doc-string of `edebug-all-defs':
>>
>>   edebug-all-defs is a variable defined in ‘edebug.el’.
>>
>>   You can use the command ‘edebug-all-defs’ to toggle the value of this
>>   variable.  You may wish to make it local to each buffer with
>>   (make-local-variable 'edebug-all-defs) in your
>>   ‘emacs-lisp-mode-hook’.
>>
>> and that's what I've apparently done.
>>
>>> I'm leaning towards considering this a "pilot error".
>>
>> Objection, your honor!
>
> Skimming this thread, it seems like this is indeed a bug...  so is the
> right fix here just to reintroduce the autoloads removed by bae2cfe63c?

I think so, sadly.  I think the suggestion to put
(make-local-variable 'edebug-all-defs) is a bad one, but that boat
has sailed, apparently.


        Stefan

Message #40 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: martin rudalics <rudalics <at> gmx.at>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>,
 Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Sun, 9 May 2021 10:41:19 +0200

> I think so, sadly.  I think the suggestion to put
> (make-local-variable 'edebug-all-defs) is a bad one, but that boat
> has sailed, apparently.

You can still remove the suggestion.

martin

Message #43 received at 47516 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: martin rudalics <rudalics <at> gmx.at>, 47516 <at> debbugs.gnu.org
Subject: Re: bug#47516: 28.0.50; void-variable edebug-all-defs
Date: Sun, 09 May 2021 11:47:46 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> Skimming this thread, it seems like this is indeed a bug...  so is the
>> right fix here just to reintroduce the autoloads removed by bae2cfe63c?
>
> I think so, sadly.  I think the suggestion to put
> (make-local-variable 'edebug-all-defs) is a bad one, but that boat
> has sailed, apparently.

OK; I've now reintroduced the autoloads, which I think should fix the
reported problem here, and I'm closing this bug report.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.