GNU bug report logs - #47569
‘qt-build-system’ retains too many references via wrappers

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix; Severity: important; Reported by: Ludovic Courtès <ludo@HIDDEN>; dated Fri, 2 Apr 2021 20:12:01 UTC; Maintainer for guix is bug-guix@HIDDEN.
Added indication that bug 47569 blocks47297 Request was from Leo Famulari <leo@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 6 Apr 2021 17:45:24 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 06 13:45:24 2021
Received: from localhost ([127.0.0.1]:41696 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lTplT-0008VA-RP
	for submit <at> debbugs.gnu.org; Tue, 06 Apr 2021 13:45:24 -0400
Received: from wout4-smtp.messagingengine.com ([64.147.123.20]:51719)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1lTplN-0008JY-PI
 for 47569 <at> debbugs.gnu.org; Tue, 06 Apr 2021 13:45:22 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.west.internal (Postfix) with ESMTP id E03ED1313;
 Tue,  6 Apr 2021 13:45:11 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute5.internal (MEProxy); Tue, 06 Apr 2021 13:45:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:content-transfer-encoding:in-reply-to; s=mesmtp;
 bh=CtNSsyFnZ63u40LSND5XHfN+qE/oVfiQc7mcoPq/LyA=; b=WJgA9jy5rG5d
 /TySn9KPGYr6dGyZraIK9CKPsKqkDdbO+rDhIl91oF7jcm2h23O6qTTzDcdwwRV4
 cwkLYhSRduioR7dB9SVQ/By+95z28x+ImIcwY9AAIx+7XU77DYLbCYjAJcreInI2
 shT6Yloc+I0htE0Lh0Utp08F1Pjpdvs=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-transfer-encoding:content-type
 :date:from:in-reply-to:message-id:mime-version:references
 :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender
 :x-sasl-enc; s=fm2; bh=CtNSsyFnZ63u40LSND5XHfN+qE/oVfiQc7mcoPq/L
 yA=; b=w1521d8CMBCofW/jAiClKfG5TxgXAmr5ChWcolrDSxLlCYBKv1viJNNp5
 XVedecp0k7/GZnDKut32LPWieqo7NAEAEMElsXB6OyQoobpJsn0P8+wG3L/9vapP
 Cc2lggbdjVoxRY0bEAgEnBYrQlssAGrp9BSXXwPuMQb8NnACjQVfm4OZOJotFNyg
 WD+oIit/L0MQlig4HIoJ3yuphhUqzbPJcaReyVlxekBqVr4fNyBWtaYyI/mmPv7h
 uO5XVHiVw9YnMdd5UKSHivElimm2on5+LZ8v9z4x2gtiw2PHTTkDO+cZZdtOnkwW
 L/c3Iu+hEDGb9+EetEc9eucI81kCg==
X-ME-Sender: <xms:J55sYO7hlxRsLXOltf18UQLas1P2C1sENLPUJsp1ngBwQmQ2PkV57A>
 <xme:J55sYAVh0i0mhL2hoE3NwpytGV6Vqv3k0K6CelIfuEh9x8oJU7aGXTw8cqOBxQb6I
 c3jh8UIUyK9Jj6lgw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrudejhedgieegucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtugfgjgesthekredttddtjeenucfhrhhomhepnfgvohcu
 hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth
 htvghrnhepgeejgeeghedtudfgffdutddvffefffejkeffffevffehgedvvdeutdffkeej
 jeejnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe
 dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:J55sYN48RzCqsOQmCC8edU8lGbbiQCRQZzWE8B4zNCqYSpBxOvy7hw>
 <xmx:J55sYLotIpYg3cIXhEOc6UhgMzJtfzbwET9Z1VrDQeBx6chvzvhCAQ>
 <xmx:J55sYAmzSqQ5ui2nWU5V6itjzAHC4sQ4GW1n2RRy6OIPK9O7SvlFAw>
 <xmx:J55sYN1RFXE2WURPuIUMHmFJVHkLjuy6dAecmB3HrV4SziIPI2UHLQ>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118])
 by mail.messagingengine.com (Postfix) with ESMTPA id F249224005A;
 Tue,  6 Apr 2021 13:45:10 -0400 (EDT)
Date: Tue, 6 Apr 2021 13:45:09 -0400
From: Leo Famulari <leo@HIDDEN>
To: Ludovic =?iso-8859-1?Q?Court=E8s?= <ludo@HIDDEN>
Subject: Re: bug#47569: =?utf-8?B?4oCYcXQtYnVpbGQt?= =?utf-8?B?c3lzdGVt4oCZ?=
 retains too many references via wrappers
Message-ID: <YGyeJU+RLk+2SQks@HIDDEN>
References: <87czvczbsv.fsf@HIDDEN> <87blaurbya.fsf@HIDDEN>
 <878s5wseaz.fsf@HIDDEN> <87r1jnmu0v.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <87r1jnmu0v.fsf@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Tue, Apr 06, 2021 at 03:17:52PM +0200, Ludovic Courtès wrote:
> Hi,
> 
> For the record, changing ‘qt-build-system’ would trigger a rebuild of
> less than 400 packages according to the back-of-the-envelope calculation
> below.  In that case, it’s tempting to fix on ‘master’ and include it in
> the release.
> 
> Thoughts?

Let's do it.

After the release, I think we should reconsider those numbers. Compared
to when we set those guidelines, we have a lot more packages and a lot
more computing power.




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 6 Apr 2021 17:43:52 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 06 13:43:52 2021
Received: from localhost ([127.0.0.1]:41686 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lTpjz-00085K-Nl
	for submit <at> debbugs.gnu.org; Tue, 06 Apr 2021 13:43:52 -0400
Received: from eggs.gnu.org ([209.51.188.92]:54366)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1lTpjw-000857-Os
 for 47569 <at> debbugs.gnu.org; Tue, 06 Apr 2021 13:43:50 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:55513)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1lTpjr-0008NY-Fd; Tue, 06 Apr 2021 13:43:43 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=39466 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1lTpjp-0001Ny-NX; Tue, 06 Apr 2021 13:43:42 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#47569: =?utf-8?Q?=E2=80=98qt-build-system=E2=80=99?=
 retains too many references via wrappers
References: <87czvczbsv.fsf@HIDDEN> <87blaurbya.fsf@HIDDEN>
 <878s5wseaz.fsf@HIDDEN> <87r1jnmu0v.fsf@HIDDEN>
Date: Tue, 06 Apr 2021 19:43:39 +0200
In-Reply-To: <87r1jnmu0v.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Tue, 06 Apr 2021 15:17:52 +0200")
Message-ID: <87zgybl35g.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="=-=-="
X-Spam-Score: -0.2 (/)
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.2 (-)

--=-=-=
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable

Hi again!

The attached patch fixes this problem AFAICS by filtering out of
XDG_DATA_DIRS directories that are unlikely to be of any use.  It
follows the same strategy as =E2=80=98glib-or-gtk-build-system=E2=80=99, wh=
ich is to
only include share/ sub-directories that also contain one of the given
=E2=80=9Cselectors=E2=80=9D: /glib-2.0/schemas, /sounds, /themes, etc.

It gives me a working ktouch, with a wrapper sets a much shorter
XDG_DATA_DIR:

--8<---------------cut here---------------start------------->8---
$ head -2 $(./pre-inst-env guix build --no-grafts ktouch)/bin/ktouch
#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash
export XDG_DATA_DIRS=3D"/gnu/store/mgzijzw7yn03pbk54zy0f81gyph9jh3k-ktouch-=
20.12.1/share:/gnu/store/5g95qdh0p46qszv199rmdd2lx4mninm7-kcoreaddons-5.70.=
0/share"
$ head -2 $(guix build --no-grafts ktouch)/bin/ktouch
#!/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcfyk72-bash-minimal-5.0.16/bin/bash
export XDG_DATA_DIRS=3D"/gnu/store/f821syw55jd0l04xkmnbvp562flrw6fm-ktouch-=
20.12.1/share:/gnu/store/3dsl2jalrcyldkrsqab1hc6sv8pyag9z-cmake-minimal-3.1=
6.5/share:/gnu/store/3x63j4ndhbzkjwr6mhnp4h86r550gs7q-extra-cmake-modules-5=
.70.0/share:/gnu/store/w08sglxbfpmcvz25pfgnq7v27m1rlkf9-kdoctools-5.70.0/sh=
are:/gnu/store/krpyb0zi700dcrg9cc8932w4v0qivdg9-pkg-config-0.29.2/share:/gn=
u/store/v6f44zccwh9z5zk3pjlywjybbi8n2hjh-tar-1.32/share:/gnu/store/ncydgq2z=
nms5n1d2k5yqshhf58nsixwv-gzip-1.10/share:/gnu/store/i8h2pcxqdq07ijm3ibkka8f=
4smn1w48v-bzip2-1.0.8/share:/gnu/store/9860f1abqj8wjjnwl8a9v54pdcc3bhgf-xz-=
5.2.4/share:/gnu/store/60g7r3l01fd7c58yjbm6krgcwj1jkpwg-file-5.38/share:/gn=
u/store/n4n560pfvvw50a9369axw5vj5rrqfj1n-diffutils-3.7/share:/gnu/store/cd5=
qf3kcnlq35p9k392pjdpdzpsnds70-patch-2.7.6/share:/gnu/store/hic7snhayfl7m6cp=
fqqr73nmm19bpqkg-findutils-4.7.0/share:/gnu/store/swqdvwri9dbv6zssg6v0by7l0=
5hd6wxp-gawk-5.0.1/share:/gnu/store/ishk7fswcs4gkwcp8mh788z4mvvl9bxh-sed-4.=
8/share:/gnu/store/bhs4rj58v8j1narb2454raan2ps38xd8-grep-3.4/share:/gnu/sto=
re/57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/share:/gnu/store/hm40bxn=
v8jxmbc1lpb7zfimii4xm9m81-make-4.3/share:/gnu/store/pwcp239kjf7lnj5i4lkdzcf=
cxwcfyk72-bash-minimal-5.0.16/share:/gnu/store/m1z7cdbqsqyp9xnjw5cvlb4a7gkc=
g3m4-binutils-2.34/share:/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.=
5.0/share:/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/share:/gnu=
/store/s3dcqzwqaakv1yx37by9chksdbkgih17-glibc-2.31-static/share:/gnu/store/=
5rj71g09qc9g20mv0lh5a28jhwa5d6dl-kcmutils-5.70.0/share:/gnu/store/3vdmy5gjn=
1a23ky6l907byc3917xfh2a-kcompletion-5.70.0/share:/gnu/store/ba8nl7wflsf1s95=
x72kpaj0rzval908b-kconfig-5.70.0/share:/gnu/store/r4120j3v7cnv5qlmp2kqb6xbc=
63gplpa-kconfigwidgets-5.70.0/share:/gnu/store/5g95qdh0p46qszv199rmdd2lx4mn=
inm7-kcoreaddons-5.70.0/share:/gnu/store/lbq73h2snwpn4wf9wkp8j0rxw0lyhyp4-k=
declarative-5.70.0/share:/gnu/store/k4k0mrgv31clkpl38zjnpb3l0nin2nnl-ki18n-=
5.70.0/share:/gnu/store/agmzjiqcv1lb77jmr7xwx0br4sy12i6d-kiconthemes-5.70.0=
/share:/gnu/store/0mbm58p5mybimbvv8ainkzz7mdpynd25-kitemviews-5.70.0/share:=
/gnu/store/yqpk8haa1z5plgb134f95vryjxghlyjv-kqtquickcharts-20.04.1/share:/g=
nu/store/5mfz0faj9lc9m1ppijgqkxz03j89dyil-ktextwidgets-5.70.0/share:/gnu/st=
ore/fwmp85k5hqy7fw0rnq5560pg4amiblz4-kwidgetsaddons-5.70.0/share:/gnu/store=
/xslnsy6sxjp66l99mvj67v1x30bh55xi-kwindowsystem-5.70.0/share:/gnu/store/n79=
ns6y3cc7ny4mkp5qidf57j1cxbg6p-kxmlgui-5.70.0/share:/gnu/store/3x6y8kpbwjmzp=
ndjfhdbn654g7dm85cp-libxcb-1.14/share:/gnu/store/zc9bpa1v46cnqc05xk8njm08bw=
k8a70m-libxkbfile-1.1.0/share:/gnu/store/j7110r2rhs9pdypx2x0h8nx4r082fbdk-q=
tbase-5.15.2/share:/gnu/store/8r5y5bnblc4s6w8j5sfxv06ra6lz12j8-qtdeclarativ=
e-5.15.2/share:/gnu/store/c020rcd650ikq7gqfnkga46kzis3v2hi-qtgraphicaleffec=
ts-5.15.2/share:/gnu/store/2iwman5hbgg15r99rshl6lsxz35dq2b2-qtquickcontrols=
2-5.15.2/share:/gnu/store/n7dbg5cgcpslrym4zmsimps1ch1p0q8w-qtx11extras-5.15=
.2/share:/gnu/store/7yjd1h08li3dr2188pfwfnwlq0p3av9p-qtxmlpatterns-5.15.2/s=
hare:/gnu/store/gfapkk5c6hvl1d94m4sqnhn7f9l5gqyh-linux-libre-headers-5.4.20=
/share:/gnu/store/kvdrfyi50zsmy0ykmc9p8qzjlahqfa4p-kservice-5.70.0/share:/g=
nu/store/yk425lbm0wnjpqm1z964l9l6li5x0wbn-kcodecs-5.70.0/share:/gnu/store/2=
z5nfmzxhqaalcrswp8nn3yk5ys8q261-kauth-5.70.0/share:/gnu/store/vhmyxywsdy92b=
gqxy6fnmcpr81xsfcys-kpackage-5.70.0/share:/gnu/store/rz42ba0my9vrgbkjpkzr2d=
rmnjk5ah50-python-3.8.2/share:/gnu/store/n9wx4dp68bfsw9bb1bwmklzl34ggrmgm-g=
ettext-minimal-0.20.1/share:/gnu/store/yqs5mkp20m58sr744cs2pn8sqb5m59sq-son=
net-5.70.0/share:/gnu/store/6cdl970wcv4jhvpgbh8sdj54a5gwhmwj-libxdmcp-1.1.3=
/share:/gnu/store/h7sy4hr7arjknbyy1aq0xwv6fksnzw9n-libxau-1.0.9/share:/gnu/=
store/klk98l8czl05lvanrr7xl7a9hksac4ak-libpthread-stubs-0.4/share:/gnu/stor=
e/k30a2pgmc6b3ifmq3rn0dr5ng9gr8w81-which-2.21/share:/gnu/store/7disnxqw8i3n=
4zhw5s0xj9kkdckkmr1p-mesa-20.2.4/share:/gnu/store/wxl57nkbqgamfp73b7v62kk3f=
1hiv0cz-xorgproto-2019.2/share:/gnu/store/c3zbbynb590yxrpwcxrkll80mn66h3kf-=
libxxf86vm-1.1.4/share:/gnu/store/jwga98k68l0h5c45jx7z4jdjzhfc34vm-libxshmf=
ence-1.3/share:/gnu/store/9z9gd76la5bww3sqgg2ax0h00msl28k6-libxfixes-5.0.3/=
share:/gnu/store/2wysr1lr7b5mc444m39qz107n92xm5xq-libxdamage-1.1.5/share:/g=
nu/store/fx3979c88s9yxdbchyf36qryawgzpwb5-libx11-1.6.10/share:/gnu/store/kx=
58xc3hxa9b0mp1hl7pzz43bl7gh18h-libdrm-2.4.103/share:/gnu/store/lc8irxnwazq3=
40ygkbqh0ask446jzy9k-util-macros-1.19.2/share:/gnu/store/qrs0p8j3wq6q5a4dm0=
ndjdavk9gyal5q-libxext-1.3.4/share"
--8<---------------cut here---------------end--------------->8---

The closure is still awfully big but smaller:

--8<---------------cut here---------------start------------->8---
$ ./pre-inst-env guix size ktouch | tail -1
total: 1298.0 MiB
$ guix size ktouch | tail -1
total: 1752.4 MiB
--8<---------------cut here---------------end--------------->8---

Thoughts?

Ludo=E2=80=99.


--=-=-=
Content-Type: text/x-patch; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

diff --git a/guix/build/qt-build-system.scm b/guix/build/qt-build-system.scm
index 005157b0a4..bb17c362d1 100644
--- a/guix/build/qt-build-system.scm
+++ b/guix/build/qt-build-system.scm
@@ -1,6 +1,6 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright =C2=A9 2014 Federico Beffa <beffa@HIDDEN>
-;;; Copyright =C2=A9 2014, 2015 Ludovic Court=C3=A8s <ludo@HIDDEN>
+;;; Copyright =C2=A9 2014, 2015, 2021 Ludovic Court=C3=A8s <ludo@HIDDEN>
 ;;; Copyright =C2=A9 2018 Mark H Weaver <mhw@HIDDEN>
 ;;; Copyright =C2=A9 2019, 2020 Hartmut Goebel <h.goebel@HIDDEN=
om>
 ;;;
@@ -49,25 +49,44 @@
=20
 (define (variables-for-wrapping base-directories)
=20
-  (define (collect-sub-dirs base-directories subdirectory)
-    (filter-map
-     (lambda (dir)
-       (let ((directory (string-append dir subdirectory)))
-         (if (directory-exists? directory) directory #f)))
-     base-directories))
+  (define (collect-sub-dirs base-directories subdirectory
+                            selectors)
+    ;; Append SUBDIRECTORY and each of BASE-DIRECTORIES, and return the su=
bset
+    ;; that exists and has at least one of the SELECTORS sub-directories,
+    ;; unless SELECTORS is the empty list.
+    (filter-map (lambda (dir)
+                  (let ((directory (string-append dir subdirectory)))
+                    (and (directory-exists? directory)
+                         (or (null? selectors)
+                             (any (lambda (selector)
+                                    (directory-exists?
+                                     (string-append directory selector)))
+                                  selectors))
+                         directory)))
+                base-directories))
=20
-  (filter
-   (lambda (var-to-wrap) (not (null? (last var-to-wrap))))
-   (map
-    (lambda (var-spec)
-      `(,(first var-spec) =3D ,(collect-sub-dirs base-directories (last va=
r-spec))))
-    (list
-     ;; these shall match the search-path-specification for Qt and KDE
-     ;; libraries
-     '("XDG_DATA_DIRS" "/share")
-     '("XDG_CONFIG_DIRS" "/etc/xdg")
-     '("QT_PLUGIN_PATH" "/lib/qt5/plugins")
-     '("QML2_IMPORT_PATH" "/lib/qt5/qml")))))
+  (filter-map
+   (match-lambda
+     ((variable directory selectors ...)
+      (match (collect-sub-dirs base-directories directory
+                               selectors)
+        (()
+         #f)
+        (directories
+         `(,variable =3D ,directories)))))
+
+   ;; These shall match the search-path-specification for Qt and KDE
+   ;; libraries.
+   (list '("XDG_DATA_DIRS" "/share"
+
+           ;; These are "selectors": consider /share if and only if these
+           ;; sub-directories exist.  This avoids adding irrelevant packag=
es
+           ;; to XDG_DATA_DIRS just because they have a /share sub-directo=
ry.
+           "/glib-2.0/schemas" "/sounds" "/themes"
+           "/cursors" "/wallpapers" "/icons" "/mime")
+         '("XDG_CONFIG_DIRS" "/etc/xdg")
+         '("QT_PLUGIN_PATH" "/lib/qt5/plugins")
+         '("QML2_IMPORT_PATH" "/lib/qt5/qml"))))
=20
 (define* (wrap-all-programs #:key inputs outputs
                             (qt-wrap-excluded-outputs '())

--=-=-=--




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 6 Apr 2021 13:58:15 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 06 09:58:15 2021
Received: from localhost ([127.0.0.1]:41307 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lTmDf-0008VP-Ci
	for submit <at> debbugs.gnu.org; Tue, 06 Apr 2021 09:58:15 -0400
Received: from flashner.co.il ([178.62.234.194]:45834)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <efraim@HIDDEN>) id 1lTmDd-0008VB-PN
 for 47569 <at> debbugs.gnu.org; Tue, 06 Apr 2021 09:58:14 -0400
Received: from localhost (unknown [31.210.177.71])
 by flashner.co.il (Postfix) with ESMTPSA id 7E1FE4007B;
 Tue,  6 Apr 2021 13:58:07 +0000 (UTC)
Date: Tue, 6 Apr 2021 16:57:35 +0300
From: Efraim Flashner <efraim@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#47569: =?utf-8?B?4oCYcXQtYnVpbGQt?= =?utf-8?B?c3lzdGVt4oCZ?=
 retains too many references via wrappers
Message-ID: <YGxoz3E8EJd+N7Am@3900XT>
References: <87czvczbsv.fsf@HIDDEN> <87blaurbya.fsf@HIDDEN>
 <878s5wseaz.fsf@HIDDEN> <87r1jnmu0v.fsf@HIDDEN>
 <YGxlkh56q8qFj+dn@3900XT>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="7LLluKf8gMSjDwxj"
Content-Disposition: inline
In-Reply-To: <YGxlkh56q8qFj+dn@3900XT>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--7LLluKf8gMSjDwxj
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 06, 2021 at 04:43:46PM +0300, Efraim Flashner wrote:
> On Tue, Apr 06, 2021 at 03:17:52PM +0200, Ludovic Court=C3=A8s wrote:
> > Hi,
> >=20
> > For the record, changing =E2=80=98qt-build-system=E2=80=99 would trigge=
r a rebuild of
> > less than 400 packages according to the back-of-the-envelope calculation
> > below.  In that case, it=E2=80=99s tempting to fix on =E2=80=98master=
=E2=80=99 and include it in
> > the release.
> >=20
> > Thoughts?
> >=20
>=20
> There are a couple of other things we want to change with the
> qt-build-system and the wrappers. Another one is changing the wrappers
> so they prefix (or was it suffix?) QT_QPA_PLUGIN (and I think others) so
> they can run natively on wayland. I think it would be a good
> improvement and worth it.

A quick search pulls up the following bugs: 43446 44982 45193 45221 45784.
Looks like there's a lot of desire to see it adjusted.

> > Ludo=E2=80=99.
> >=20
> > --8<---------------cut here---------------start------------->8---
> > scheme@(guile-user)> ,use(gnu)
> > scheme@(guile-user)> ,use(guix build-system qt)
> > scheme@(guile-user)> ,use(guix)
> > scheme@(guile-user)> (define qtpkgs (fold-packages (lambda (pkg lst)
> > 						     (if (eq? (package-build-system pkg) qt-build-system)
> > 							 (cons pkg lst)
> > 							 lst))
> > 						   '()))
> > scheme@(guile-user)> (length qtpkgs)
> > $78 =3D 186
> > scheme@(guile-user)> ,use(guix graph)
> > scheme@(guile-user)> ,run-in-store (node-edges (@ (guix scripts graph) =
%reverse-package-node-type) (fold-packages cons '()))
> > $79 =3D #<procedure 7fe494f11520 at guix/graph.scm:94:17 (node)>
> > scheme@(guile-user)> (node-reachable-count qtpkgs $79)
> > $80 =3D 180
> > scheme@(guile-user)> (+ 186 180)
> > $81 =3D 366
> > --8<---------------cut here---------------end--------------->8---
> >=20
> >=20
> >=20
>=20
> --=20
> Efraim Flashner   <efraim@HIDDEN>   =D7=90=D7=A4=D7=A8=D7=99=D7=
=9D =D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
> GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
> Confidentiality cannot be guaranteed on emails sent or received unencrypt=
ed



--=20
Efraim Flashner   <efraim@HIDDEN>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--7LLluKf8gMSjDwxj
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmBsaMwACgkQQarn3Mo9
g1F1/w/8C9uvydcmqmu8FnHdqVAsr4Kfqfs6oakHt5EyW6h6DbLxkfhTwWTUIxg+
kQFisBNF07RNwfkEHf/tVOg2cyiLNlQZVyMv1HHcqAs2hpbyxJimb1gra1VSHLVH
G1NM9O2KsKuyyLHhmJP5TFrHhPWWPVkW0fcKzxgeSbheYMdyJHbjCjr4XJbylezZ
6eWFnh3tTNpcDdZQAS2NsQdvsevcUu7hWIFD6lkkIebmN/BVJKhIs18Stk9ppWsU
FAL60Jtg8MjK56YkIiOJQGIxpw6u2982oxYnKPe6fyxdQB5Oa7qsn/7VQxZOrYKj
QUZk1P7b8RJ2dY/RYOJ146laKRrQvwPzHrrTgGhIQTMQfrpxB4QtxH/QrAoPkS//
E1WE9XC7y778jVjhwYviR7f8sKlh/7UQbuecRVZ7vdq82XGp7YDj2HzopNkteY2I
EpWMtVcHSb5J7OOhooQ9EfsUzTmES4NOQv4W4ET6PpMrBXvyketpHrDxnjzjvYnb
A1V5DVgJjTR8tmsp6fSV547HroBZqaoIKo/qsc4DkeSh5A/3p5YuHMarsJ02Gk3h
o6HOzmzndAiclZxeekvGfpX1IuHe7XO83jYKD/mMsoTkNaZN8r5Y1prvKDzqouqG
GCPlSR6jal+4ysFdb6GunsbHiguaJBZN0uZszjvAfmcavJ/KgB0=
=FG5I
-----END PGP SIGNATURE-----

--7LLluKf8gMSjDwxj--




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 6 Apr 2021 13:44:29 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 06 09:44:29 2021
Received: from localhost ([127.0.0.1]:39599 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lTm0L-0007kh-3s
	for submit <at> debbugs.gnu.org; Tue, 06 Apr 2021 09:44:29 -0400
Received: from flashner.co.il ([178.62.234.194]:45788)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <efraim@HIDDEN>) id 1lTm0H-0007kR-4C
 for 47569 <at> debbugs.gnu.org; Tue, 06 Apr 2021 09:44:28 -0400
Received: from localhost (unknown [31.210.177.71])
 by flashner.co.il (Postfix) with ESMTPSA id DF08B4007B;
 Tue,  6 Apr 2021 13:44:18 +0000 (UTC)
Date: Tue, 6 Apr 2021 16:43:46 +0300
From: Efraim Flashner <efraim@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#47569: =?utf-8?B?4oCYcXQtYnVpbGQt?= =?utf-8?B?c3lzdGVt4oCZ?=
 retains too many references via wrappers
Message-ID: <YGxlkh56q8qFj+dn@3900XT>
References: <87czvczbsv.fsf@HIDDEN> <87blaurbya.fsf@HIDDEN>
 <878s5wseaz.fsf@HIDDEN> <87r1jnmu0v.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha512;
 protocol="application/pgp-signature"; boundary="ZWyBqA00FRKF32hE"
Content-Disposition: inline
In-Reply-To: <87r1jnmu0v.fsf@HIDDEN>
X-PGP-Key-ID: 0x41AAE7DCCA3D8351
X-PGP-Key: https://flashner.co.il/~efraim/efraim_flashner.asc
X-PGP-Fingerprint: A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
X-Spam-Score: -0.0 (/)
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org, Maxim Cournoyer <maxim.cournoyer@HIDDEN>
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.0 (-)


--ZWyBqA00FRKF32hE
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Tue, Apr 06, 2021 at 03:17:52PM +0200, Ludovic Court=C3=A8s wrote:
> Hi,
>=20
> For the record, changing =E2=80=98qt-build-system=E2=80=99 would trigger =
a rebuild of
> less than 400 packages according to the back-of-the-envelope calculation
> below.  In that case, it=E2=80=99s tempting to fix on =E2=80=98master=E2=
=80=99 and include it in
> the release.
>=20
> Thoughts?
>=20

There are a couple of other things we want to change with the
qt-build-system and the wrappers. Another one is changing the wrappers
so they prefix (or was it suffix?) QT_QPA_PLUGIN (and I think others) so
they can run natively on wayland. I think it would be a good
improvement and worth it.

> Ludo=E2=80=99.
>=20
> --8<---------------cut here---------------start------------->8---
> scheme@(guile-user)> ,use(gnu)
> scheme@(guile-user)> ,use(guix build-system qt)
> scheme@(guile-user)> ,use(guix)
> scheme@(guile-user)> (define qtpkgs (fold-packages (lambda (pkg lst)
> 						     (if (eq? (package-build-system pkg) qt-build-system)
> 							 (cons pkg lst)
> 							 lst))
> 						   '()))
> scheme@(guile-user)> (length qtpkgs)
> $78 =3D 186
> scheme@(guile-user)> ,use(guix graph)
> scheme@(guile-user)> ,run-in-store (node-edges (@ (guix scripts graph) %r=
everse-package-node-type) (fold-packages cons '()))
> $79 =3D #<procedure 7fe494f11520 at guix/graph.scm:94:17 (node)>
> scheme@(guile-user)> (node-reachable-count qtpkgs $79)
> $80 =3D 180
> scheme@(guile-user)> (+ 186 180)
> $81 =3D 366
> --8<---------------cut here---------------end--------------->8---
>=20
>=20
>=20

--=20
Efraim Flashner   <efraim@HIDDEN>   =D7=90=D7=A4=D7=A8=D7=99=D7=9D =
=D7=A4=D7=9C=D7=A9=D7=A0=D7=A8
GPG key =3D A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

--ZWyBqA00FRKF32hE
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEoov0DD5VE3JmLRT3Qarn3Mo9g1EFAmBsZY8ACgkQQarn3Mo9
g1F8OBAAjTfTmSpnKkqHu7eXiKi8PSP52FocsGGtjyphqee1xIlXEyMVHv+k/i/g
eZaTRy0s78E/YO80eofpn1rdlGm+covnEwa3Edgi/dsQKgqaWQYuVzdMU1NeplAZ
6B7w4GFtCnhOvVDKj24QZ8u/IrD4pm6Ef5PFWfiTOHJ4gbx2HXarwXXnvZACYVaB
vx0ciofodEkO2P/PHzPnZQ9XgR7bpi6EKd/pV4IfTzhmDTvaogN0+cyFJTJ4n/aw
IfMzg3R4wTP6I7Quk9oQNmux3KqfYl3OzkqyaMB7xT3GpS8l4gfqsMARhGYv+Fbq
seBObZMRJMIDnDTQ1a9oHSXAHODQBRA5YoSewZgV3UuzfaK/OIkcSAkyeHHUXZBV
CjV1eRTPsCYTve0sC5ZAFt9cLw8C96oRqWC/v4ECMsw1b/e/o8qXi+RRWRgMaVzd
gKAY4KjPmC5BTc27Rtg/wLY+6cpD1Mt7RHRUGPcn6A6QLqafTyHWlBVX36BHc7wL
CosngEaOEsCbsyaSIEevCId/MSwuONYEMMTh+O2xS5125lEOW0rNkOjvJS/Edur4
LP2Kp3Q4tRlcfbm9PSBK1KagjC9qDsyyy6nVaicuSPSP41+F0yEZ+Gcm5B6piFQa
kPCePrXtDwQaIe3nsF7EkbX9WvGuzL1FPcO5qa9slMYqXYprLTU=
=aCQF
-----END PGP SIGNATURE-----

--ZWyBqA00FRKF32hE--




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 6 Apr 2021 13:18:02 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 06 09:18:02 2021
Received: from localhost ([127.0.0.1]:39530 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lTlak-0004yM-9N
	for submit <at> debbugs.gnu.org; Tue, 06 Apr 2021 09:18:02 -0400
Received: from eggs.gnu.org ([209.51.188.92]:56374)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1lTlai-0004xs-CK
 for 47569 <at> debbugs.gnu.org; Tue, 06 Apr 2021 09:18:00 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:50004)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1lTlad-0002VP-6K; Tue, 06 Apr 2021 09:17:55 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=37808 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1lTlac-0002tP-3l; Tue, 06 Apr 2021 09:17:54 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#47569: =?utf-8?Q?=E2=80=98qt-build-system=E2=80=99?=
 retains too many references via wrappers
References: <87czvczbsv.fsf@HIDDEN> <87blaurbya.fsf@HIDDEN>
 <878s5wseaz.fsf@HIDDEN>
Date: Tue, 06 Apr 2021 15:17:52 +0200
In-Reply-To: <878s5wseaz.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22'?=
 =?utf-8?Q?s?= message of "Mon, 05 Apr 2021 21:48:36 +0200")
Message-ID: <87r1jnmu0v.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 1.8 (+)
X-Spam-Report: Spam detection software, running on the system "debbugs.gnu.org",
 has NOT identified this incoming email as spam.  The original
 message has been attached to this so you can view it or label
 similar future email.  If you have any questions, see
 the administrator of that system for details.
 
 Content preview:  Hi, For the record, changing ‘qt-build-system’ would trigger
    a rebuild of less than 400 packages according to the back-of-the-envelope
    calculation below. In that case, it’s tempting to fix on ‘mas [...] 
 
 Content analysis details:   (1.8 points, 10.0 required)
 
  pts rule name              description
 ---- ---------------------- --------------------------------------------------
 -0.0 SPF_HELO_PASS          SPF: HELO matches SPF record
 -0.0 SPF_PASS               SPF: sender matches SPF record
 -0.7 RCVD_IN_DNSWL_LOW      RBL: Sender listed at https://www.dnswl.org/,
                             low trust
                             [209.51.188.92 listed in list.dnswl.org]
  0.0 LOTS_OF_MONEY          Huge... sums of money
  2.5 MONEY_NOHTML           Lots of money in plain text
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: 0.8 (/)

Hi,

For the record, changing =E2=80=98qt-build-system=E2=80=99 would trigger a =
rebuild of
less than 400 packages according to the back-of-the-envelope calculation
below.  In that case, it=E2=80=99s tempting to fix on =E2=80=98master=E2=80=
=99 and include it in
the release.

Thoughts?

Ludo=E2=80=99.

--8<---------------cut here---------------start------------->8---
scheme@(guile-user)> ,use(gnu)
scheme@(guile-user)> ,use(guix build-system qt)
scheme@(guile-user)> ,use(guix)
scheme@(guile-user)> (define qtpkgs (fold-packages (lambda (pkg lst)
						     (if (eq? (package-build-system pkg) qt-build-system)
							 (cons pkg lst)
							 lst))
						   '()))
scheme@(guile-user)> (length qtpkgs)
$78 =3D 186
scheme@(guile-user)> ,use(guix graph)
scheme@(guile-user)> ,run-in-store (node-edges (@ (guix scripts graph) %rev=
erse-package-node-type) (fold-packages cons '()))
$79 =3D #<procedure 7fe494f11520 at guix/graph.scm:94:17 (node)>
scheme@(guile-user)> (node-reachable-count qtpkgs $79)
$80 =3D 180
scheme@(guile-user)> (+ 186 180)
$81 =3D 366
--8<---------------cut here---------------end--------------->8---




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 5 Apr 2021 19:48:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Mon Apr 05 15:48:47 2021
Received: from localhost ([127.0.0.1]:38622 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lTVDL-0003PY-KR
	for submit <at> debbugs.gnu.org; Mon, 05 Apr 2021 15:48:47 -0400
Received: from eggs.gnu.org ([209.51.188.92]:35450)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1lTVDK-0003Oz-1D
 for 47569 <at> debbugs.gnu.org; Mon, 05 Apr 2021 15:48:46 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:36247)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>)
 id 1lTVDD-0008Oo-En; Mon, 05 Apr 2021 15:48:39 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=46776 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>)
 id 1lTVDB-00025o-Ul; Mon, 05 Apr 2021 15:48:39 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
Subject: Re: bug#47569: =?utf-8?Q?=E2=80=98qt-build-system=E2=80=99?=
 retains too many references via wrappers
References: <87czvczbsv.fsf@HIDDEN> <87blaurbya.fsf@HIDDEN>
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 16 Germinal an 229 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Mon, 05 Apr 2021 21:48:36 +0200
In-Reply-To: <87blaurbya.fsf@HIDDEN> (Maxim Cournoyer's message of "Sat, 03
 Apr 2021 23:00:13 -0400")
Message-ID: <878s5wseaz.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Hi Maxim!

Maxim Cournoyer <maxim.cournoyer@HIDDEN> skribis:

> I'm not sure why a wrapper is needed in the first place; these
> environment variables are honored by qtbase and defined as search path
> specifications.  It seems if we were to fix '22138 important Search
> paths of dependencies are not honored' we might not have to wrap at all,
> unless we really want to be able to run things outside of a profile
> (directly from the store) -- which is a nice property, but comes at the
> cost of wrappers ugliness (e.g., running 'gdb --args sh
> /path/to/wrapper', then having to load the symbols with 'file
> /path/to/.the-binary-real; or that wrapper's name appearing in manpages
> or other places).
>
> But for the short term, perhaps it's best to copy that strategy?

Agreed on all points.  :-)  Wrappers are ugly, but they=E2=80=99re necessar=
y,
often independently of whether #22138 is fixed.  In this case, they=E2=80=
=99re
needed so that GLib, Qt, and all their friends find the files they care
about.

Ludo=E2=80=99.




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.

Message received at 47569 <at> debbugs.gnu.org:


Received: (at 47569) by debbugs.gnu.org; 4 Apr 2021 03:00:26 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 03 23:00:26 2021
Received: from localhost ([127.0.0.1]:34714 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lSszx-0007X3-JQ
	for submit <at> debbugs.gnu.org; Sat, 03 Apr 2021 23:00:26 -0400
Received: from mail-qt1-f177.google.com ([209.85.160.177]:41975)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <maxim.cournoyer@HIDDEN>) id 1lSszv-0007Wo-33
 for 47569 <at> debbugs.gnu.org; Sat, 03 Apr 2021 23:00:23 -0400
Received: by mail-qt1-f177.google.com with SMTP id x9so6283931qto.8
 for <47569 <at> debbugs.gnu.org>; Sat, 03 Apr 2021 20:00:22 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025;
 h=from:to:cc:subject:references:date:in-reply-to:message-id
 :user-agent:mime-version:content-transfer-encoding;
 bh=bQhSjNDgiF09dLUS3Rlglec/gj1o4MaUElvd32PTOMA=;
 b=FOJd9PYvZELHdflya4D1hFkpEzBk2VgkQPZ5ZCJKnHQ++4XQB0eIEHzt3MTUZOiZO9
 qxi0JcwnN7+OTVnHP6BztXYQOB5AbL7L+P8fDn4mzPdsYOmP5yJFBo5SEK95WiDgslvu
 wnCU98njQPgw7gYbjZ49lZYs35gjYR4MJkHsW1P0K8+Dhgt4j08h/jagi+m6Ikh0uEuG
 Z/AGDOawDS5cUA6WI1S/aA7nUh98eqKPuV1AvIUvMV9i3pYnSRKP10CoEQYnS+6PZ2Ry
 rMR7AZ54IGSvaWF53LBog6f+MwVYJ+reb2Rge3wr2EaBQ5tYVvz0WJB4mkJaw56qFBZs
 e/BQ==
X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed;
 d=1e100.net; s=20161025;
 h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to
 :message-id:user-agent:mime-version:content-transfer-encoding;
 bh=bQhSjNDgiF09dLUS3Rlglec/gj1o4MaUElvd32PTOMA=;
 b=qhRHpiApXGLXyUgAjKCn6TGRSPlCVqwkjvkVV4R4Hqfe9iJ9AJM5ryBvvGVtGEEzv/
 yLJ2HUvaH/Kz0c90AYTWzi2SJxl+slIOQKiTFye/FayhRPnlTJlRxHZeKow2Et8Anhfr
 o8rVje1qr5gkScrD734sRaQIWbOi9YRCDf0baPm8YOMCDezuCWCL15CoBC6R7N5EEZ9S
 VI3VNulHq3IN+lwVBqdHIj6ZlbIFr3aTVu+qem9d20WVIt06Ig2nmzHfvFQISM1JdfVp
 47ux7ObDSdgM1Of/CHvxd8u0sEECWVT2v3mEYQUuKyBbVzOQETj/3qqyPceMxxEiA84Y
 6jbQ==
X-Gm-Message-State: AOAM530rd6rxD0NrZyvdyoirBLX3bNgnwjW6yu4UXLgdBwBb1phf5Rl+
 lRthW9cz0aTRkgNV9hbUI7086CiTyKA=
X-Google-Smtp-Source: ABdhPJxmdWIN/872NiKiKWnWZX/coiANk2ELvRlT9ntYG20ll6RqCjHb2bTtY3BY9q3MA0B+mLWGEw==
X-Received: by 2002:ac8:1301:: with SMTP id e1mr6339074qtj.100.1617505217198; 
 Sat, 03 Apr 2021 20:00:17 -0700 (PDT)
Received: from hurd (dsl-149-42.b2b2c.ca. [66.158.149.42])
 by smtp.gmail.com with ESMTPSA id u11sm9127250qta.91.2021.04.03.20.00.16
 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256);
 Sat, 03 Apr 2021 20:00:16 -0700 (PDT)
From: Maxim Cournoyer <maxim.cournoyer@HIDDEN>
To: Ludovic =?utf-8?Q?Court=C3=A8s?= <ludo@HIDDEN>
Subject: Re: bug#47569: =?utf-8?Q?=E2=80=98qt-build-system=E2=80=99?=
 retains too many references via wrappers
References: <87czvczbsv.fsf@HIDDEN>
Date: Sat, 03 Apr 2021 23:00:13 -0400
In-Reply-To: <87czvczbsv.fsf@HIDDEN> ("Ludovic =?utf-8?Q?Court=C3=A8s=22?=
 =?utf-8?Q?'s?= message of "Fri, 02 Apr 2021 22:11:44 +0200")
Message-ID: <87blaurbya.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.5 (/)
X-Debbugs-Envelope-To: 47569
Cc: 47569 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.5 (/)

Hi Ludovic!

Ludovic Court=C3=A8s <ludo@HIDDEN> writes:

> I just noticed this:
>
> $ guix size ktouch | tail -1
> total: 1752.4 MiB
>
>
> Sounds a lot for a touch typing tutor.
>
> Turns out ktouch references all its build-time dependencies: gcc,
> glibc:static, binutils, findutils, everything.  It comes from the
> wrapper:
>
> $ grep -r s3dcqzwqaakv1yx37by9chksdbkgih17  /gnu/store/w8i63ghrq64r7f1nxz=
w50b0j32f2n8v1-ktouch-20.12.1
> /gnu/store/w8i63ghrq64r7f1nxzw50b0j32f2n8v1-ktouch-20.12.1/bin/ktouch:exp=
ort XDG_DATA_DIRS=3D"/gnu/store/w8i63ghrq64r7f1nxzw50b0j32f2n8v1-ktouch-20.=
12.1/share:/gnu/store/ah4az84vjkrssdws7ydvdk1f1mcs70i6-cmake-minimal-3.16.5=
/share:/gnu/store/3x63j4ndhbzkjwr6mhnp4h86r550gs7q-extra-cmake-modules-5.70=
.0/share:/gnu/store/qcqghpj3550p94pyqwqmwyd3nqcwflpq-kdoctools-5.70.0/share=
:/gnu/store/krpyb0zi700dcrg9cc8932w4v0qivdg9-pkg-config-0.29.2/share:/gnu/s=
tore/v6f44zccwh9z5zk3pjlywjybbi8n2hjh-tar-1.32/share:/gnu/store/ncydgq2znms=
5n1d2k5yqshhf58nsixwv-gzip-1.10/share:/gnu/store/i8h2pcxqdq07ijm3ibkka8f4sm=
n1w48v-bzip2-1.0.8/share:/gnu/store/9860f1abqj8wjjnwl8a9v54pdcc3bhgf-xz-5.2=
.4/share:/gnu/store/60g7r3l01fd7c58yjbm6krgcwj1jkpwg-file-5.38/share:/gnu/s=
tore/n4n560pfvvw50a9369axw5vj5rrqfj1n-diffutils-3.7/share:/gnu/store/cd5qf3=
kcnlq35p9k392pjdpdzpsnds70-patch-2.7.6/share:/gnu/store/hic7snhayfl7m6cpfqq=
r73nmm19bpqkg-findutils-4.7.0/share:/gnu/store/swqdvwri9dbv6zssg6v0by7l05hd=
6wxp-gawk-5.0.1/share:/gnu/store/ishk7fswcs4gkwcp8mh788z4mvvl9bxh-sed-4.8/s=
hare:/gnu/store/bhs4rj58v8j1narb2454raan2ps38xd8-grep-3.4/share:/gnu/store/=
57xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/share:/gnu/store/hm40bxnv8j=
xmbc1lpb7zfimii4xm9m81-make-4.3/share:/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxw=
cfyk72-bash-minimal-5.0.16/share:/gnu/store/m1z7cdbqsqyp9xnjw5cvlb4a7gkcg3m=
4-binutils-2.34/share:/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0=
/share:/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/share:/gnu/st=
ore/s3dcqzwqaakv1yx37by9chksdbkgih17-glibc-2.31-static/share:/gnu/store/nnr=
i2x0mdfm2y2ci0p5jhlf6xkdsf6i6-kcmutils-5.70.0/share:/gnu/store/ybh1br5ghs1b=
rnwvacfj04jx3203m87p-kcompletion-5.70.0/share:/gnu/store/bnfcann370ad38g7v4=
pzgklmizk69f7j-kconfig-5.70.0/share:/gnu/store/4w9v0jnx74n542v11ikzxbf352xq=
rpwy-kconfigwidgets-5.70.0/share:/gnu/store/9nr52vkhj99g4mx1rr349wwsm2aflnv=
4-kcoreaddons-5.70.0/share:/gnu/store/9ln7cv5s813nf4ny5l56qadq0vnkx5g0-kdec=
larative-5.70.0/share:/gnu/store/fg8npcm84k5bii5jpmdypqdwq10k5xrf-ki18n-5.7=
0.0/share:/gnu/store/0b7xb35ihp5h5qzfcdymzi7yn5lngsgf-kiconthemes-5.70.0/sh=
are:/gnu/store/gdch1j5vjjzzx9qq29zca2w83h8nz9rj-kitemviews-5.70.0/share:/gn=
u/store/q8wrlw1g0m35syx5sr3hq44sx6fsxicj-kqtquickcharts-20.04.1/share:/gnu/=
store/xhcgpv14llkcdcdn39vrm12mbl4b4y07-ktextwidgets-5.70.0/share:/gnu/store=
/f4ibdx1ldiifdjbpyh75py4q8i24b05w-kwidgetsaddons-5.70.0/share:/gnu/store/x2=
7qq3i8c3vifrj1q5y9p8840k5dvk40-kwindowsystem-5.70.0/share:/gnu/store/ybdzlp=
nswajsq1acp3l768h21bvzif16-kxmlgui-5.70.0/share:/gnu/store/3x6y8kpbwjmzpndj=
fhdbn654g7dm85cp-libxcb-1.14/share:/gnu/store/c7vrkq864hsxfvll74wlrxv71arkc=
d5q-libxkbfile-1.1.0/share:/gnu/store/sbf77k7xzwhkx4ygqjzgkviz9vy4qhf6-qtba=
se-5.15.2/share:/gnu/store/k6kk02q27nbymwajkvzhlil8c7sym74k-qtdeclarative-5=
.15.2/share:/gnu/store/hpirydj1mlmhj199z1ng3yn9sb0f1jc1-qtgraphicaleffects-=
5.15.2/share:/gnu/store/8165pcgy2d1l30vipkv5qz40nkg9qdp3-qtquickcontrols2-5=
.15.2/share:/gnu/store/63g70yiyvz08v16hdxsnj3c2pqdq9bm0-qtx11extras-5.15.2/=
share:/gnu/store/9hpw67pf9px9zx75nb8bm21pc0gqwyx9-qtxmlpatterns-5.15.2/shar=
e:/gnu/store/gfapkk5c6hvl1d94m4sqnhn7f9l5gqyh-linux-libre-headers-5.4.20/sh=
are:/gnu/store/lfizifxrrbmb9dd1wdm5yy7rlqp7mmfp-kservice-5.70.0/share:/gnu/=
store/yqaafdggah0hac4n6dkw69ib94v03w69-kcodecs-5.70.0/share:/gnu/store/1syz=
h2ky8qgxzg59g0g97pqn1gb6xm1r-kauth-5.70.0/share:/gnu/store/s7a55hh8gd8r9dr6=
m04sqxg5kgngnqcj-kpackage-5.70.0/share:/gnu/store/cizh7vg0w09izkv07pxdv8csi=
r8p4sdd-python-3.8.2/share:/gnu/store/n9wx4dp68bfsw9bb1bwmklzl34ggrmgm-gett=
ext-minimal-0.20.1/share:/gnu/store/rqsn0is9frgi7jz1633l4ipa07xfgsbx-sonnet=
-5.70.0/share:/gnu/store/6cdl970wcv4jhvpgbh8sdj54a5gwhmwj-libxdmcp-1.1.3/sh=
are:/gnu/store/h7sy4hr7arjknbyy1aq0xwv6fksnzw9n-libxau-1.0.9/share:/gnu/sto=
re/klk98l8czl05lvanrr7xl7a9hksac4ak-libpthread-stubs-0.4/share:/gnu/store/k=
30a2pgmc6b3ifmq3rn0dr5ng9gr8w81-which-2.21/share:/gnu/store/14qgm67plbh8d3m=
6lc87b9j6s9296vwn-mesa-20.2.4/share:/gnu/store/wxl57nkbqgamfp73b7v62kk3f1hi=
v0cz-xorgproto-2019.2/share:/gnu/store/qv7x7pz7gi724lkdz8049mjhy1ryg511-lib=
xxf86vm-1.1.4/share:/gnu/store/jwga98k68l0h5c45jx7z4jdjzhfc34vm-libxshmfenc=
e-1.3/share:/gnu/store/1v6vap6jaf3hf4ypjx261k44xmc48drc-libxfixes-5.0.3/sha=
re:/gnu/store/b67b0a5vda7pv7yqyjjb9736s96hhybi-libxdamage-1.1.5/share:/gnu/=
store/rwkqxykm91a75w9afhb41saj0dmf30hw-libx11-1.6.12/share:/gnu/store/kx58x=
c3hxa9b0mp1hl7pzz43bl7gh18h-libdrm-2.4.103/share:/gnu/store/lc8irxnwazq340y=
gkbqh0ask446jzy9k-util-macros-1.19.2/share:/gnu/store/3rmazp46f6g8w9qs8n3w7=
qcg8hhs1lig-libxext-1.3.4/share"
>
> This is bad for the closure size and probably not good for application
> startup time either.

Oh!  Good finding!  That probably explains why my experiments producing
a guix pack for jami-qt was yielding an archive that'd decompress to 2.7
GiB!

> The problem seems that =E2=80=98variables-for-wrapping=E2=80=99 in qt-bui=
ld-system.scm
> is too naive: it collects in XDG_DATA_DIRS all the /share directories.
> Conversely, =E2=80=98data-directories=E2=80=99 in glib-or-gtk-build-syste=
m.scm is a bit
> more subtle, keeping only meaningful share/ directories.
>
> I think qt-build-system.scm should copy that strategy.
>
> Thoughts?

I'm not sure why a wrapper is needed in the first place; these
environment variables are honored by qtbase and defined as search path
specifications.  It seems if we were to fix '22138 important Search
paths of dependencies are not honored' we might not have to wrap at all,
unless we really want to be able to run things outside of a profile
(directly from the store) -- which is a nice property, but comes at the
cost of wrappers ugliness (e.g., running 'gdb --args sh
/path/to/wrapper', then having to load the symbols with 'file
/path/to/.the-binary-real; or that wrapper's name appearing in manpages
or other places).

But for the short term, perhaps it's best to copy that strategy?

Thanks for the report!

Maxim




Information forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.
Severity set to 'important' from 'normal' Request was from Ludovic Courtès <ludo@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 2 Apr 2021 20:11:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 02 16:11:50 2021
Received: from localhost ([127.0.0.1]:32904 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lSQ90-0002d1-0g
	for submit <at> debbugs.gnu.org; Fri, 02 Apr 2021 16:11:50 -0400
Received: from lists.gnu.org ([209.51.188.17]:34680)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <ludo@HIDDEN>) id 1lSQ8y-0002cu-Vo
 for submit <at> debbugs.gnu.org; Fri, 02 Apr 2021 16:11:49 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:48908)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <ludo@HIDDEN>) id 1lSQ8y-00053Y-Or
 for bug-guix@HIDDEN; Fri, 02 Apr 2021 16:11:48 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:38701)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <ludo@HIDDEN>) id 1lSQ8y-0006oi-Gc
 for bug-guix@HIDDEN; Fri, 02 Apr 2021 16:11:48 -0400
Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=35010 helo=ribbon)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <ludo@HIDDEN>) id 1lSQ8w-0000pg-Rn
 for bug-guix@HIDDEN; Fri, 02 Apr 2021 16:11:47 -0400
From: =?utf-8?Q?Ludovic_Court=C3=A8s?= <ludo@HIDDEN>
To: <bug-guix@HIDDEN>
Subject: =?utf-8?Q?=E2=80=98qt-build-system=E2=80=99?= retains too many
 references via wrappers
X-URL: http://www.fdn.fr/~lcourtes/
X-Revolutionary-Date: 13 Germinal an 229 de la =?utf-8?Q?R=C3=A9volution?=
X-PGP-Key-ID: 0x090B11993D9AEBB5
X-PGP-Key: http://www.fdn.fr/~lcourtes/ludovic.asc
X-PGP-Fingerprint: 3CE4 6455 8A84 FDC6 9DB4  0CFB 090B 1199 3D9A EBB5
X-OS: x86_64-pc-linux-gnu
Date: Fri, 02 Apr 2021 22:11:44 +0200
Message-ID: <87czvczbsv.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -1.8 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.8 (--)

I just noticed this:

--8<---------------cut here---------------start------------->8---
$ guix size ktouch | tail -1
total: 1752.4 MiB
--8<---------------cut here---------------end--------------->8---

Sounds a lot for a touch typing tutor.

Turns out ktouch references all its build-time dependencies: gcc,
glibc:static, binutils, findutils, everything.  It comes from the
wrapper:

--8<---------------cut here---------------start------------->8---
$ grep -r s3dcqzwqaakv1yx37by9chksdbkgih17  /gnu/store/w8i63ghrq64r7f1nxzw5=
0b0j32f2n8v1-ktouch-20.12.1
/gnu/store/w8i63ghrq64r7f1nxzw50b0j32f2n8v1-ktouch-20.12.1/bin/ktouch:expor=
t XDG_DATA_DIRS=3D"/gnu/store/w8i63ghrq64r7f1nxzw50b0j32f2n8v1-ktouch-20.12=
.1/share:/gnu/store/ah4az84vjkrssdws7ydvdk1f1mcs70i6-cmake-minimal-3.16.5/s=
hare:/gnu/store/3x63j4ndhbzkjwr6mhnp4h86r550gs7q-extra-cmake-modules-5.70.0=
/share:/gnu/store/qcqghpj3550p94pyqwqmwyd3nqcwflpq-kdoctools-5.70.0/share:/=
gnu/store/krpyb0zi700dcrg9cc8932w4v0qivdg9-pkg-config-0.29.2/share:/gnu/sto=
re/v6f44zccwh9z5zk3pjlywjybbi8n2hjh-tar-1.32/share:/gnu/store/ncydgq2znms5n=
1d2k5yqshhf58nsixwv-gzip-1.10/share:/gnu/store/i8h2pcxqdq07ijm3ibkka8f4smn1=
w48v-bzip2-1.0.8/share:/gnu/store/9860f1abqj8wjjnwl8a9v54pdcc3bhgf-xz-5.2.4=
/share:/gnu/store/60g7r3l01fd7c58yjbm6krgcwj1jkpwg-file-5.38/share:/gnu/sto=
re/n4n560pfvvw50a9369axw5vj5rrqfj1n-diffutils-3.7/share:/gnu/store/cd5qf3kc=
nlq35p9k392pjdpdzpsnds70-patch-2.7.6/share:/gnu/store/hic7snhayfl7m6cpfqqr7=
3nmm19bpqkg-findutils-4.7.0/share:/gnu/store/swqdvwri9dbv6zssg6v0by7l05hd6w=
xp-gawk-5.0.1/share:/gnu/store/ishk7fswcs4gkwcp8mh788z4mvvl9bxh-sed-4.8/sha=
re:/gnu/store/bhs4rj58v8j1narb2454raan2ps38xd8-grep-3.4/share:/gnu/store/57=
xj5gcy1jbl9ai2lnrqnpr0dald9i65-coreutils-8.32/share:/gnu/store/hm40bxnv8jxm=
bc1lpb7zfimii4xm9m81-make-4.3/share:/gnu/store/pwcp239kjf7lnj5i4lkdzcfcxwcf=
yk72-bash-minimal-5.0.16/share:/gnu/store/m1z7cdbqsqyp9xnjw5cvlb4a7gkcg3m4-=
binutils-2.34/share:/gnu/store/rn75fm7adgx3pw5j8pg3bczfqq1y17lk-gcc-7.5.0/s=
hare:/gnu/store/fa6wj5bxkj5ll1d7292a70knmyl7a0cr-glibc-2.31/share:/gnu/stor=
e/s3dcqzwqaakv1yx37by9chksdbkgih17-glibc-2.31-static/share:/gnu/store/nnri2=
x0mdfm2y2ci0p5jhlf6xkdsf6i6-kcmutils-5.70.0/share:/gnu/store/ybh1br5ghs1brn=
wvacfj04jx3203m87p-kcompletion-5.70.0/share:/gnu/store/bnfcann370ad38g7v4pz=
gklmizk69f7j-kconfig-5.70.0/share:/gnu/store/4w9v0jnx74n542v11ikzxbf352xqrp=
wy-kconfigwidgets-5.70.0/share:/gnu/store/9nr52vkhj99g4mx1rr349wwsm2aflnv4-=
kcoreaddons-5.70.0/share:/gnu/store/9ln7cv5s813nf4ny5l56qadq0vnkx5g0-kdecla=
rative-5.70.0/share:/gnu/store/fg8npcm84k5bii5jpmdypqdwq10k5xrf-ki18n-5.70.=
0/share:/gnu/store/0b7xb35ihp5h5qzfcdymzi7yn5lngsgf-kiconthemes-5.70.0/shar=
e:/gnu/store/gdch1j5vjjzzx9qq29zca2w83h8nz9rj-kitemviews-5.70.0/share:/gnu/=
store/q8wrlw1g0m35syx5sr3hq44sx6fsxicj-kqtquickcharts-20.04.1/share:/gnu/st=
ore/xhcgpv14llkcdcdn39vrm12mbl4b4y07-ktextwidgets-5.70.0/share:/gnu/store/f=
4ibdx1ldiifdjbpyh75py4q8i24b05w-kwidgetsaddons-5.70.0/share:/gnu/store/x27q=
q3i8c3vifrj1q5y9p8840k5dvk40-kwindowsystem-5.70.0/share:/gnu/store/ybdzlpns=
wajsq1acp3l768h21bvzif16-kxmlgui-5.70.0/share:/gnu/store/3x6y8kpbwjmzpndjfh=
dbn654g7dm85cp-libxcb-1.14/share:/gnu/store/c7vrkq864hsxfvll74wlrxv71arkcd5=
q-libxkbfile-1.1.0/share:/gnu/store/sbf77k7xzwhkx4ygqjzgkviz9vy4qhf6-qtbase=
-5.15.2/share:/gnu/store/k6kk02q27nbymwajkvzhlil8c7sym74k-qtdeclarative-5.1=
5.2/share:/gnu/store/hpirydj1mlmhj199z1ng3yn9sb0f1jc1-qtgraphicaleffects-5.=
15.2/share:/gnu/store/8165pcgy2d1l30vipkv5qz40nkg9qdp3-qtquickcontrols2-5.1=
5.2/share:/gnu/store/63g70yiyvz08v16hdxsnj3c2pqdq9bm0-qtx11extras-5.15.2/sh=
are:/gnu/store/9hpw67pf9px9zx75nb8bm21pc0gqwyx9-qtxmlpatterns-5.15.2/share:=
/gnu/store/gfapkk5c6hvl1d94m4sqnhn7f9l5gqyh-linux-libre-headers-5.4.20/shar=
e:/gnu/store/lfizifxrrbmb9dd1wdm5yy7rlqp7mmfp-kservice-5.70.0/share:/gnu/st=
ore/yqaafdggah0hac4n6dkw69ib94v03w69-kcodecs-5.70.0/share:/gnu/store/1syzh2=
ky8qgxzg59g0g97pqn1gb6xm1r-kauth-5.70.0/share:/gnu/store/s7a55hh8gd8r9dr6m0=
4sqxg5kgngnqcj-kpackage-5.70.0/share:/gnu/store/cizh7vg0w09izkv07pxdv8csir8=
p4sdd-python-3.8.2/share:/gnu/store/n9wx4dp68bfsw9bb1bwmklzl34ggrmgm-gettex=
t-minimal-0.20.1/share:/gnu/store/rqsn0is9frgi7jz1633l4ipa07xfgsbx-sonnet-5=
.70.0/share:/gnu/store/6cdl970wcv4jhvpgbh8sdj54a5gwhmwj-libxdmcp-1.1.3/shar=
e:/gnu/store/h7sy4hr7arjknbyy1aq0xwv6fksnzw9n-libxau-1.0.9/share:/gnu/store=
/klk98l8czl05lvanrr7xl7a9hksac4ak-libpthread-stubs-0.4/share:/gnu/store/k30=
a2pgmc6b3ifmq3rn0dr5ng9gr8w81-which-2.21/share:/gnu/store/14qgm67plbh8d3m6l=
c87b9j6s9296vwn-mesa-20.2.4/share:/gnu/store/wxl57nkbqgamfp73b7v62kk3f1hiv0=
cz-xorgproto-2019.2/share:/gnu/store/qv7x7pz7gi724lkdz8049mjhy1ryg511-libxx=
f86vm-1.1.4/share:/gnu/store/jwga98k68l0h5c45jx7z4jdjzhfc34vm-libxshmfence-=
1.3/share:/gnu/store/1v6vap6jaf3hf4ypjx261k44xmc48drc-libxfixes-5.0.3/share=
:/gnu/store/b67b0a5vda7pv7yqyjjb9736s96hhybi-libxdamage-1.1.5/share:/gnu/st=
ore/rwkqxykm91a75w9afhb41saj0dmf30hw-libx11-1.6.12/share:/gnu/store/kx58xc3=
hxa9b0mp1hl7pzz43bl7gh18h-libdrm-2.4.103/share:/gnu/store/lc8irxnwazq340ygk=
bqh0ask446jzy9k-util-macros-1.19.2/share:/gnu/store/3rmazp46f6g8w9qs8n3w7qc=
g8hhs1lig-libxext-1.3.4/share"
--8<---------------cut here---------------end--------------->8---

This is bad for the closure size and probably not good for application
startup time either.

The problem seems that =E2=80=98variables-for-wrapping=E2=80=99 in qt-build=
-system.scm
is too naive: it collects in XDG_DATA_DIRS all the /share directories.
Conversely, =E2=80=98data-directories=E2=80=99 in glib-or-gtk-build-system.=
scm is a bit
more subtle, keeping only meaningful share/ directories.

I think qt-build-system.scm should copy that strategy.

Thoughts?

Ludo=E2=80=99.




Acknowledgement sent to Ludovic Courtès <ludo@HIDDEN>:
New bug report received and forwarded. Copy sent to bug-guix@HIDDEN. Full text available.
Report forwarded to bug-guix@HIDDEN:
bug#47569; Package guix. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Tue, 6 Apr 2021 18:00:02 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.