GNU bug report logs - #47577
[core-updates] gnu: meson-for-build: Remove it again

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47577 in the body.
You can then email your comments to 47577 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: guix-patches <at> gnu.org, Efraim Flashner <efraim <at> flashner.co.il>
Subject: [core-updates] gnu: meson-for-build: Remove it again
Date: Sat, 03 Apr 2021 12:38:02 +0800

[Message part 1 (text/plain, inline)]

Hello, on our core-updates branch, meson-for-build was remmoved in
f2b228010873a, but then a merge 2aab587f842908 added it again..

So here is a patch to remove it, also update the FIXME in meson:

[0001-gnu-meson-for-build-Remove-package.patch (text/x-patch, inline)]

From 3219f0b132c8ae16e319a57a91834ec8be393afc Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?=E5=AE=8B=E6=96=87=E6=AD=A6?= <iyzsong <at> member.fsf.org>
Date: Sat, 3 Apr 2021 12:26:03 +0800
Subject: [PATCH] gnu: meson-for-build: Remove package.

It was removed in commit f2b22801, but a merge (2aab587f) add it wrongly
again.
---
 gnu/packages/build-tools.scm | 16 ++--------------
 1 file changed, 2 insertions(+), 14 deletions(-)

diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
index 5e25c60f3b..b47a790f75 100644
--- a/gnu/packages/build-tools.scm
+++ b/gnu/packages/build-tools.scm
@@ -278,9 +278,8 @@ files and generates build instructions for the Ninja build system.")
                 "1x47vc7023w8w90r6jda5hk2jsh68i66x49gckdgixw32fwvvf1w"))))
     (build-system python-build-system)
     (arguments
-     `(;; FIXME: Tests require many additional inputs, a fix for the RUNPATH
-       ;; patch in meson-for-build, and patching many hard-coded file system
-       ;; locations in "run_unittests.py".
+     `(;; FIXME: Tests require many additional inputs and patching many
+       ;; hard-coded file system locations in "run_unittests.py".
        #:tests? #f
        #:phases (modify-phases %standard-phases
                   ;; Meson calls the various executables in out/bin through the
@@ -327,17 +326,6 @@ resembles Python.")
                (base32
                 "19n8alcpzv6npgp27iqljkmvdmr7s2c7zm8y997j1nlvpa1cgqbj"))))))
 
-(define-public meson-for-build
-  (package
-    (inherit meson)
-    (name "meson-for-build")
-    (source (origin
-              (inherit (package-source meson))
-              (patches (search-patches "meson-for-build-rpath.patch"))))
-
-    ;; People should probably install "meson", not "meson-for-build".
-    (properties `((hidden? . #t)))))
-
 (define-public premake4
   (package
     (name "premake")
-- 
2.30.0

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: 宋文武 <iyzsong <at> outlook.com>
Cc: guix-patches <at> gnu.org
Subject: Re: [core-updates] gnu: meson-for-build: Remove it again
Date: Mon, 5 Apr 2021 11:05:53 +0300

[Message part 1 (text/plain, inline)]

On Sat, Apr 03, 2021 at 12:38:02PM +0800, 宋文武 wrote:
> Hello, on our core-updates branch, meson-for-build was remmoved in
> f2b228010873a, but then a merge 2aab587f842908 added it again..
> 

I thought that meson-for-build was like cmake-minimal and some others,
it was more useful for building and regular meson (or cmake) was for
installing as the end user. It also lets us update meson if we want
newer features if we want them.

Then again, I didn't mean to un-delete it, so go ahead and push the
patch if that's the way it was supposed to be.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #13 received at 47577-done <at> debbugs.gnu.org (full text, mbox):

From: 宋文武 <iyzsong <at> outlook.com>
To: Efraim Flashner <efraim <at> flashner.co.il>
Cc: 47577-done <at> debbugs.gnu.org
Subject: Re: bug#47577: [core-updates] gnu: meson-for-build: Remove it again
Date: Sat, 10 Apr 2021 15:34:54 +0800

Efraim Flashner <efraim <at> flashner.co.il> writes:

> On Sat, Apr 03, 2021 at 12:38:02PM +0800, 宋文武 wrote:
>> Hello, on our core-updates branch, meson-for-build was remmoved in
>> f2b228010873a, but then a merge 2aab587f842908 added it again..
>> 
>
> I thought that meson-for-build was like cmake-minimal and some others,
> it was more useful for building and regular meson (or cmake) was for
> installing as the end user. It also lets us update meson if we want
> newer features if we want them.
>
> Then again, I didn't mean to un-delete it, so go ahead and push the
> patch if that's the way it was supposed to be.

Okay, pushed, thank you!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.