GNU bug report logs - #47591
[PATCH] import: go: Replace underscores with hyphens in package names.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47591 in the body.
You can then email your comments to 47591 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: go: Replace underscores with hyphens in package names.
Date: Sun, 04 Apr 2021 11:52:03 +0200

As per section '16.4.2 Package Naming' in the manual, use hypens instead
of underscores in package names.

* guix/import/go.scm (go-module->guix-package-name): Replace underscores
with hyphens.
---
Maybe we should also make the linter check for underscores in package
names, and give a warning if it finds any underscores?

 guix/import/go.scm | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/guix/import/go.scm b/guix/import/go.scm
index 7452b4c903..6c0231e113 100644
--- a/guix/import/go.scm
+++ b/guix/import/go.scm
@@ -4,6 +4,7 @@
 ;;; Copyright © 2021 François Joulaud <francois.joulaud <at> radiofrance.com>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 Ludovic Courtès <ludo <at> gnu.org>
+;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -380,9 +381,11 @@ hence the need to derive this information."
   "Converts a module's path to the canonical Guix format for Go packages."
   (string-downcase (string-append "go-" (string-replace-substring
                                          (string-replace-substring
-                                          module-path
-                                          "." "-")
-                                         "/" "-"))))
+                                          (string-replace-substring
+                                           module-path
+                                           "." "-")
+                                          "/" "-")
+                                         "_" "-"))))
 
 (define-record-type <module-meta>
   (make-module-meta import-prefix vcs repo-root)

base-commit: 86617c92c6a795668b2eca3d3c3b285cb742cb24
-- 
2.31.1

Message #8 received at 47591 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 47591 <at> debbugs.gnu.org
Subject: Re: [bug#47591] [PATCH] import: go: Replace underscores with hyphens
 in package names.
Date: Sun, 4 Apr 2021 13:43:45 -0400

On Sun, Apr 04, 2021 at 11:52:03AM +0200, Xinglu Chen wrote:
> As per section '16.4.2 Package Naming' in the manual, use hypens instead
> of underscores in package names.
> 
> * guix/import/go.scm (go-module->guix-package-name): Replace underscores
> with hyphens.

Thanks! Pushed as 426ade6c8bdab243da719e369a887284368179bb

> Maybe we should also make the linter check for underscores in package
> names, and give a warning if it finds any underscores?

Definitely!

I would leave existing packages alone, however, unless they are causing
some problem.

Message #13 received at 47591 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Leo Famulari <leo <at> famulari.name>
Cc: 47591 <at> debbugs.gnu.org
Subject: Re: [bug#47591] [PATCH] import: go: Replace underscores with
 hyphens in package names.
Date: Mon, 05 Apr 2021 23:27:45 +0200

On Sun, Apr 04 2021, Leo Famulari wrote:

>> Maybe we should also make the linter check for underscores in package
>> names, and give a warning if it finds any underscores?
>
> Definitely!
>
> I would leave existing packages alone, however, unless they are causing
> some problem.

Do you mean that there should be a whitelist for all the packages that
already have underscores in their names, or?

Also, there has been some discussion about replacing underscores in
package names[1].

[1]: https://yhetil.org/guix-devel/87v991vkpi.fsf <at> nckx

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.