GNU bug report logs - #47598
cperl-mode: Highlighting confused with ternary and -x

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47598 in the body.
You can then email your comments to 47598 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "E. Choroba" <choroba <at> matfyz.cz>
To: bug-gnu-emacs <at> gnu.org
Subject: cperl-mode: Highlighting confused with ternary and -x
Date: Mon, 5 Apr 2021 02:04:56 +0200 (CEST)

When combining the ternary operator with file tests using the default 
argument, cperl-mode gets confused.

For example:

my $f = -f ? 'file'
      : -l ? [readlink]
      : -d ? 'dir'
           : 'unknown';

It seems to think the ?'s are not part of a ternary operator, but rather a 
match-once operator. Note that m?? without m results in a syntax error since 
Perl 5.22.

Ch.

Message #8 received at 47598 <at> debbugs.gnu.org (full text, mbox):

From: haj <at> posteo.de (Harald Jörg)
To: "E. Choroba" <choroba <at> matfyz.cz>
Cc: 47598 <at> debbugs.gnu.org
Subject: Re: bug#47598: cperl-mode: Highlighting confused with ternary and -x
 [PATCH]
Date: Tue, 06 Apr 2021 20:33:07 +0200

[Message part 1 (text/plain, inline)]

E. Choroba writes:

> When combining the ternary operator with file tests using the default
> argument, cperl-mode gets confused.
>
> For example:
>
> my $f = -f ? 'file'
>       : -l ? [readlink]
>       : -d ? 'dir'
>            : 'unknown';
>
> It seems to think the ?'s are not part of a ternary operator, but
> rather a match-once operator. ...

Exactly, that is what is happening here.

> ... Note that m?? without m results in a
> syntax error since Perl 5.22.

Because of that it seems appropriate to stop dealing with bare ?foo?
altogether.  So, the patch eliminates the recognition of bare ?foo?, and
also deletes the corresponding lines from CPerl's builtin short
documentation.  The test in the patch uses the text from the bug report,
and also checks that m?foo? is still processed as a regular expression,
and a bare ?foo?  isn't.
-- 
Cheers,
haj

[0001-cperl-mode-Eliminate-bad-interpretation-of-foo-bug-4.patch (text/x-diff, attachment)]

Message #13 received at 47598 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: haj <at> posteo.de (Harald Jörg)
Cc: 47598 <at> debbugs.gnu.org, "E. Choroba" <choroba <at> matfyz.cz>
Subject: Re: bug#47598: cperl-mode: Highlighting confused with ternary and -x
Date: Thu, 06 May 2021 12:34:00 +0200

haj <at> posteo.de (Harald Jörg) writes:

> Because of that it seems appropriate to stop dealing with bare ?foo?
> altogether.  So, the patch eliminates the recognition of bare ?foo?, and
> also deletes the corresponding lines from CPerl's builtin short
> documentation.  The test in the patch uses the text from the bug report,
> and also checks that m?foo? is still processed as a regular expression,
> and a bare ?foo?  isn't.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.