GNU bug report logs - #47606
postgresql man and info pages are not included

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47606 in the body.
You can then email your comments to 47606 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jesús Gómez <jgomo3 <at> gmail.com>
To: bug-guix <at> gnu.org
Subject: postgresql man and info pages are not included
Date: Mon, 5 Apr 2021 17:40:25 -0230

[Message part 1 (text/plain, inline)]

After installing the package, I noticed I can't read the man and info pages
of Postgres.

I was told in the IRC channel that the package doesn't include them
currently, and we think those pages should be included (also updating the
`.guix-profile/etx/profile` file as needed).

Thanks for Guix!

[Message part 2 (text/html, inline)]

Message #8 received at 47606 <at> debbugs.gnu.org (full text, mbox):

From: Brice Waegeneire <brice <at> waegenei.re>
To: 47606 <at> debbugs.gnu.org
Subject: [PATCH] gnu: postgresql: Add manuals.
Date: Sun, 12 Dec 2021 19:31:34 +0100

Fixes <https://issues.guix.gnu.org/47606>.

* gnu/packages/databases.scm (postgresql)[arguments]: Add configure flag
  '--mandir'.  Add phase 'install-man'.
---
 gnu/packages/databases.scm | 20 +++++++++++++-------
 1 file changed, 13 insertions(+), 7 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index 7cff0f99c5..76e99283ed 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -54,6 +54,7 @@
 ;;; Copyright © 2021 Alexandre Hannud Abdo <abdo <at> member.fsf.org>
 ;;; Copyright © 2021 Simon Tournier <zimon.toutoune <at> gmail.com>
 ;;; Copyright © 2021 jgart <jgart <at> dismail.de>
+;;; Copyright © 2021 Brice Waegeneire <brice <at> waegenei.re>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -1118,12 +1119,14 @@ (define-public postgresql-13
               (patches (search-patches "postgresql-disable-resolve_symlinks.patch"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:configure-flags '("--with-uuid=e2fs" "--with-openssl"
-                           ;; PostgreSQL installs its own Makefile (should it?).
-                           ;; Prevent it from retaining needless references to
-                           ;; the build tools in order to save size.
-                           "MKDIR_P=mkdir -p" "INSTALL_BIN=install -c"
-                           "LD=ld" "TAR=tar")
+     `(#:configure-flags
+       (list "--with-uuid=e2fs" "--with-openssl"
+             (string-append "--mandir=" (assoc-ref %outputs "out") "/share/man")
+             ;; PostgreSQL installs its own Makefile (should it?).
+             ;; Prevent it from retaining needless references to
+             ;; the build tools in order to save size.
+             "MKDIR_P=mkdir -p" "INSTALL_BIN=install -c"
+             "LD=ld" "TAR=tar")
        #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'patch-/bin/sh
@@ -1138,7 +1141,10 @@ (define-public postgresql-13
              (invoke "make" "-C" "contrib")))
          (add-after 'install 'install-contrib
            (lambda _
-             (invoke "make" "-C" "contrib" "install"))))))
+             (invoke "make" "-C" "contrib" "install")))
+         (add-after 'install 'install-man
+           (lambda _
+             (invoke "make" "-C" "doc/src/sgml" "install-man"))))))
     (inputs
      `(("readline" ,readline)
        ("libuuid" ,util-linux "lib")

base-commit: 604880ae22e1a7662acb1d3f282242470de0cd03
prerequisite-patch-id: ecd20aaded80566551ed0bd654517209ad239de5
prerequisite-patch-id: 96a62566ab07f5d80f2edd43cd0f89c7191e7ee6
prerequisite-patch-id: 5f8c05b16a80862bfc759169d05d1b03d48284a6
prerequisite-patch-id: 4a455af71d83d984fe88b3cdbc1f8f477b27f2a9
-- 
2.34.0

Message #13 received at 47606-done <at> debbugs.gnu.org (full text, mbox):

From: Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
To: Brice Waegeneire <brice <at> waegenei.re>
Cc: 47606-done <at> debbugs.gnu.org
Subject: Re: bug#47606: postgresql man and info pages are not included
Date: Fri, 18 Mar 2022 00:56:52 -0400

Hi,

Brice Waegeneire <brice <at> waegenei.re> writes:

> Fixes <https://issues.guix.gnu.org/47606>.
>
> * gnu/packages/databases.scm (postgresql)[arguments]: Add configure flag
>   '--mandir'.  Add phase 'install-man'.

I pushed a superset of this which also builds an info manual as
f0227a18c2, to the staging branch along an update to the v13 package.

Thank you!

Maxim

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.