GNU bug report logs - #47608
adds emacs-lockstep

Previous Next

To reply to this bug, email your comments to 47608 AT debbugs.gnu.org.
There is no need to reopen the bug first.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: rdes <rdes <at> protonmail.com>
To: rdes via Guix-patches via <guix-patches <at> gnu.org>
Subject: adds emacs-lockstep
Date: Tue, 06 Apr 2021 02:18:03 +0000

[Message part 1 (text/plain, inline)]

Hello,

The attached patch adds emacs-lockstep.

Sent with [ProtonMail](https://protonmail.com) Secure Email.

[Message part 2 (text/html, inline)]

[0001-gnu-packages-emacs-xyz.scm-emacs-lockstep-New-variab.patch (text/x-patch, attachment)]

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: rdes via Guix-patches via <guix-patches <at> gnu.org>
Cc: 47608 <at> debbugs.gnu.org, rdes <rdes <at> protonmail.com>
Subject: Re: [bug#47608] adds emacs-lockstep
Date: Sun, 11 Apr 2021 11:00:32 +0200

Hello,

rdes via Guix-patches via <guix-patches <at> gnu.org> writes:

> The attached patch adds emacs-lockstep.

Thank you. Some comments follow.

> +(define-public emacs-lockstep
> +  (let ((commit "5fe78e94533c4a050d3fce23685040ac754c2e54"))

A comment should explain why we're using a commit hash instead of a tag.

> +    (package
> +      (name "emacs-lockstep")
> +      (version "0.1")

This is not the correct version. Actually, I couldn't find any reference
to a version at all in the file, so it should be "0", with a comment.

> +      (synopsis
> +       "Pair program in Emacs")

Nitpick: Pair programming in Emacs

> +      (description
> +       "Lockstep is a package for pair programming in Emacs.  It synchronizes
> +the windows and points of two or more Emacs frames, so that a team of
> +programmers can share an editing session.
> +
> +BE CAREFUL: any programmer in the session will be able to control the Emacs
> +process running as the user who started the Emacs server.")

Nitpick:

  Be careful!  All programmers see the same buffers and live edits, and
  any programmer can take over the editing session.

> +      (license license:gpl3+))))

Unfortunately, I see no reference whatsoever to a license in the code
base. I don't think we can infer this is GPL3+. What makes you think so?

Regards,
-- 
Nicolas Goaziou

Message #16 received at 47608-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: 47608-done <at> debbugs.gnu.org
Cc: rdes <rdes <at> protonmail.com>
Subject: Re: adds emacs-lockstep
Date: Wed, 12 Mar 2025 22:58:19 +0100

Hello,

> > +      (license license:gpl3+))))
> 
> Unfortunately, I see no reference whatsoever to a license in the code
> base. I don't think we can infer this is GPL3+. What makes you think
> so?

Considering the license issue is not solved, I’m closing this
report. Feel free to re-open it if needed.

Rsgards,
-- 
Nicolas Goaziou

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.