GNU bug report logs - #47640
[PATCH v2] Add sqlitebrowser.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47640 in the body.
You can then email your comments to 47640 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Allan Adair <allan <at> adair.no>
To: guix-patches <at> gnu.org
Cc: Allan Adair <allan <at> adair.no>
Subject: [PATCH v2] Add sqlitebrowser.
Date: Wed,  7 Apr 2021 13:09:53 +0200

---
 gnu/packages/databases.scm | 28 ++++++++++++++++++++++++++++
 1 file changed, 28 insertions(+)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index ce7afa82d0..ca80099254 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -48,6 +48,7 @@
 ;;; Copyright © 2020 Vincent Legoll <vincent.legoll <at> gmail.com>
 ;;; Copyright © 2021 Sharlatan Hellseher <sharlatanus <at> gmail.com>
 ;;; Copyright © 2021 Greg Hogan <code <at> greghogan.com>
+;;; Copyright © 2021 Allan Adair <allan <at> adair.no>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -3829,3 +3830,30 @@ PostreSQL, SQLite, ODBC and MySQL.")
      "FreeTDS is an implementation of the Tabular DataStream protocol, used for
 connecting to MS SQL and Sybase servers over TCP/IP.")
     (license license:lgpl2.0+)))
+
+(define-public sqlitebrowser
+  (package
+    (name "sqlitebrowser")
+    (version "3.12.1")
+    (source
+     (origin
+       (method git-fetch)
+       (uri (git-reference
+             (url "https://github.com/sqlitebrowser/sqlitebrowser")
+             (commit (string-append "v" version))))
+       (file-name (git-file-name name version))
+       (sha256
+        (base32
+         "0ray6cscx2qil1dfi7hmpijmq3kba49wn430ih1q4fkz9psjvrz1"))))
+    (build-system cmake-build-system)
+    (inputs
+     `(("qtbase" ,qtbase)
+       ("qttools" ,qttools)
+       ("sqlite" ,sqlite)))
+    (arguments
+     `(#:configure-flags '("-DENABLE_TESTING=ON")))
+    (home-page "https://sqlitebrowser.org/")
+    (synopsis "DB Browser for SQLite (DB4S) is a high quality, visual, open source tool to create, design, and edit database files compatible with SQLite.")
+    (description
+     "DB4S is for users and developers who want to create, search, and edit databases. DB4S uses a familiar spreadsheet-like interface, and complicated SQL commands do not have to be learned.")
+    (license (list license:gpl3+ license:mpl2.0))))
-- 
2.31.1

Message #8 received at 47640 <at> debbugs.gnu.org (full text, mbox):

From: Nicolò Balzarotti <anothersms <at> gmail.com>
To: Allan Adair <allan <at> adair.no>, 47640 <at> debbugs.gnu.org
Cc: Allan Adair <allan <at> adair.no>
Subject: Re: [bug#47640] [PATCH v2] Add sqlitebrowser.
Date: Wed, 07 Apr 2021 17:56:33 +0200

Hi, thanks for the contribution!

A few comments below

Allan Adair <allan <at> adair.no> writes:

> +    (description
> +     "DB4S is for users and developers who want to create, search, and edit databases. DB4S uses a familiar spreadsheet-like interface, and complicated SQL commands do not have to be learned.")
I think the linter here will complain about the single space after the
period, and for the really long line.

Did you run ./pre-inst-env guix lint sqlitebrowser ?  This should tell
you if something is wrong

> +    (license (list license:gpl3+ license:mpl2.0))))
I see that there are bundled dependencies (under /libs), could you try
unbundle them (remove the lib folder with a source snippet) and build
using guix dependencies?  There are only four of them, two of which
(nlohmann-json-cpp and qscintilla) are already in guix.  Else it might
be needed to fix the licence.

There are the cmake flags FORCE_INTERNAL_QSCINTILLA,
FORCE_INTERNAL_QCUSTOMPLOT, FORCE_INTERNAL_QHEXEDIT which suggest this
should be possible.

Thanks, Nicolò

Message #11 received at 47640 <at> debbugs.gnu.org (full text, mbox):

From: Allan Adair <allan <at> adair.no>
To: Nicolò Balzarotti <anothersms <at> gmail.com>,
 47640 <at> debbugs.gnu.org
Subject: Re: [bug#47640] [PATCH v2] Add sqlitebrowser.
Date: Fri, 9 Apr 2021 13:07:52 +0200

Hi Nicolò.

On 4/7/21 5:56 PM, Nicolò Balzarotti wrote:

> Did you run ./pre-inst-env guix lint sqlitebrowser ?  This should tell
> you if something is wrong 

Thanks! I really appreciate this guidance! It was an oversight on my part.

>> +    (license (list license:gpl3+ license:mpl2.0))))
> I see that there are bundled dependencies (under /libs), could you try
> unbundle them (remove the lib folder with a source snippet) and build
> using guix dependencies?  There are only four of them, two of which
> (nlohmann-json-cpp and qscintilla) are already in guix.  Else it might
> be needed to fix the licence.

I have been trying over the past couple of days with some difficulty. I 
will continue with some more effort next week, but since I am not an 
expert on the codebase (or cmake!) I may beg for fixing the licenses 
instead.

Message #16 received at 47640-done <at> debbugs.gnu.org (full text, mbox):

From: Guillaume Le Vaillant <glv <at> posteo.net>
To: 34612-done <at> debbugs.gnu.org, 47640-done <at> debbugs.gnu.org
Subject: Re: Add sqlitebrowser
Date: Mon, 21 Feb 2022 13:53:13 +0000

[Message part 1 (text/plain, inline)]

sqlitebrowser is in Guix (9183b8142b43082fee55a2730399243dea47ad0a).
Closing.

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.