GNU bug report logs -
#47652
28.0.50; completion-at-point fails in verilog-mode
Previous Next
Reported by: Simon McFarlane <sm <at> desu.ne.jp>
Date: Thu, 8 Apr 2021 11:29:01 UTC
Severity: normal
Tags: fixed
Found in version 28.0.50
Fixed in version 28.1
Done: Lars Ingebrigtsen <larsi <at> gnus.org>
Bug is archived. No further changes may be made.
To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47652 in the body.
You can then email your comments to 47652 AT debbugs.gnu.org in the normal way.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#47652
; Package
emacs
.
(Thu, 08 Apr 2021 11:29:01 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
Simon McFarlane <sm <at> desu.ne.jp>
:
New bug report received and forwarded. Copy sent to
bug-gnu-emacs <at> gnu.org
.
(Thu, 08 Apr 2021 11:29:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
M-x completion-at-point throws a failed assertion in
verilog-mode. After some digging I believe this is because
verilog-toggle-completions is missing a save-excursion somewhere. Sadly
I'm not a true Emacs guru so I couldn't figure out exactly where.
completion-in-region: Assertion failed: (<= start (point)), #<marker at 14 in *new*>, 12
This is reproducible with a very simple verilog file consisting of only
"module test();".
This is very similar to bug #41740 reported by Shinichi Sakata.
In GNU Emacs 28.0.50 (build 2, x86_64-pc-linux-gnu, GTK+ Version 3.24.28, cairo version 1.17.4)
of 2021-04-06 built on 120af952437f
Repository revision: 8c80289348aa95884bb9263a643e3f873ed4bfda
Repository branch: pgtk-nativecomp
Windowing system distributor 'System Description: Arch Linux
Configured using:
'configure --prefix=/usr --sysconfdir=/etc --libexecdir=/usr/lib
--localstatedir=/var --mandir=/usr/share/man --with-gameuser=:games
--with-sound=alsa --with-modules --with-x-toolkit=gtk3 --with-cairo
--with-xwidgets --with-native-compilation --with-pgtk
--without-compress-install --without-gconf --without-gsettings
--without-m17n-flt --enable-autodepend --enable-link-time-optimization
CC=/usr/bin/clang 'CFLAGS=-march=x86-64 -mtune=generic -O2 -pipe
-fno-plt -g -flto'
LDFLAGS=-Wl,-O1,--sort-common,--as-needed,-z,relro,-z,now
CPPFLAGS=-D_FORTIFY_SOURCE=2 'CPP=/usr/bin/clang -E''
Configured features:
ACL CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GPM HARFBUZZ JPEG JSON LCMS2
LIBOTF LIBSYSTEMD LIBXML2 MODULES NATIVE_COMP NOTIFY INOTIFY PDUMPER
PGTK PNG RSVG SOUND THREADS TIFF TOOLKIT_SCROLL_BARS XIM XWIDGETS GTK3
ZLIB
Important settings:
value of $LANG: en_US.UTF-8
value of $XMODIFIERS: @im=fcitx
locale-coding-system: utf-8-unix
Major mode: Verilog
Minor modes in effect:
tooltip-mode: t
global-eldoc-mode: t
electric-indent-mode: t
mouse-wheel-mode: t
tool-bar-mode: t
menu-bar-mode: t
file-name-shadow-mode: t
global-font-lock-mode: t
font-lock-mode: t
blink-cursor-mode: t
auto-composition-mode: t
auto-encryption-mode: t
auto-compression-mode: t
line-number-mode: t
transient-mark-mode: t
Load-path shadows:
None found.
Features:
(shadow sort mail-extr cl-print debug backtrace find-func cus-edit pp
wid-edit cus-start cus-load thingatpt help-fns radix-tree help-mode
emacsbug message rmc puny dired dired-loaddefs rfc822 mml mml-sec epa
derived epg epg-config gnus-util rmail rmail-loaddefs mm-decode
mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils mailheader
sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr mail-utils
time-date verilog-mode compile text-property-search comint ansi-color
ring diff company edmacro kmacro pcase easy-mmode finder-inf package
browse-url url url-proxy url-privacy url-expand url-methods url-history
url-cookie url-domsuf url-util mailcap url-handlers url-parse
auth-source cl-seq eieio eieio-core cl-macs eieio-loaddefs
password-cache json subr-x map url-vars seq byte-opt gv bytecomp
byte-compile cconv cl-loaddefs cl-lib iso-transl tooltip eldoc electric
uniquify ediff-hook vc-hooks lisp-float-type mwheel term/pgtk-win
pgtk-win term/common-win tool-bar dnd fontset image regexp-opt fringe
tabulated-list replace newcomment text-mode elisp-mode lisp-mode
prog-mode register page tab-bar menu-bar rfn-eshadow isearch easymenu
timer select scroll-bar mouse jit-lock font-lock syntax font-core
term/tty-colors frame minibuffer cl-generic cham georgian utf-8-lang
misc-lang vietnamese tibetan thai tai-viet lao korean japanese eucjp-ms
cp51932 hebrew greek romanian slovak czech european ethiopic indian
cyrillic chinese composite charscript charprop case-table epa-hook
jka-cmpr-hook help simple abbrev obarray cl-preloaded nadvice button
loaddefs faces cus-face macroexp files window text-properties overlay
sha1 md5 base64 format env code-pages mule custom widget
hashtable-print-readable backquote threads xwidget-internal dbusbind
inotify dynamic-setting font-render-setting cairo move-toolbar gtk
x-toolkit pgtk lcms2 multi-tty make-network-process nativecomp emacs)
Memory information:
((conses 16 142467 8669)
(symbols 48 12266 0)
(strings 32 36962 2160)
(string-bytes 1 1193201)
(vectors 16 20597)
(vector-slots 8 396489 15323)
(floats 8 55 22)
(intervals 56 1040 0)
(buffers 992 16))
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#47652
; Package
emacs
.
(Fri, 09 Apr 2021 09:51:01 GMT)
Full text and
rfc822 format available.
Message #8 received at 47652 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi,
After a very pleasant evening with Edebug (seriously, debugging Emacs is such a smooth experience) I found what I believe to be the culprit and have attached a patch that fixes the issue for me. This is my first time contributing to Emacs so I apologize if I've violated the mailing list convention or etiquette.
Happy to make adjustments if my patch isn't quite right.
Thanks,
Simon
[0001-verilog-mode-add-save-excursion-to-fix-completion-at.patch (text/x-patch, attachment)]
Information forwarded
to
bug-gnu-emacs <at> gnu.org
:
bug#47652
; Package
emacs
.
(Mon, 12 Apr 2021 09:48:02 GMT)
Full text and
rfc822 format available.
Message #11 received at 47652 <at> debbugs.gnu.org (full text, mbox):
Simon McFarlane <sm <at> desu.ne.jp> writes:
> After a very pleasant evening with Edebug (seriously, debugging Emacs
> is such a smooth experience) I found what I believe to be the culprit
> and have attached a patch that fixes the issue for me. This is my
> first time contributing to Emacs so I apologize if I've violated the
> mailing list convention or etiquette.
It's a perfect bug report. :-)
> Happy to make adjustments if my patch isn't quite right.
[...]
> - (verilog-func-completion 'module)
> + (save-excursion (verilog-func-completion 'module))
I used your general idea here, but I moved the save-excursion into the
function instead of wrapping the call sites in Emacs 28.
--
(domestic pets only, the antidote for overdose, milk.)
bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed.
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Mon, 12 Apr 2021 09:48:02 GMT)
Full text and
rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to
47652 <at> debbugs.gnu.org and Simon McFarlane <sm <at> desu.ne.jp>
Request was from
Lars Ingebrigtsen <larsi <at> gnus.org>
to
control <at> debbugs.gnu.org
.
(Mon, 12 Apr 2021 09:48:02 GMT)
Full text and
rfc822 format available.
bug archived.
Request was from
Debbugs Internal Request <help-debbugs <at> gnu.org>
to
internal_control <at> debbugs.gnu.org
.
(Mon, 10 May 2021 11:24:06 GMT)
Full text and
rfc822 format available.
This bug report was last modified 2 years and 323 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.