GNU bug report logs - #47659
[PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.

Previous Next

Package: guix-patches;

Reported by: Masaya Tojo <masaya <at> tojo.tokyo>

Date: Thu, 8 Apr 2021 17:33:01 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47659 in the body.
You can then email your comments to 47659 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#47659; Package guix-patches. (Thu, 08 Apr 2021 17:33:01 GMT) Full text and rfc822 format available.

Acknowledgement sent to Masaya Tojo <masaya <at> tojo.tokyo>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Thu, 08 Apr 2021 17:33:01 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: guix-patches <at> gnu.org
Cc: Masaya Tojo <masaya <at> tojo.tokyo>
Subject: [PATCH] gnu: guile-cv: Use guile2.2 version of guile-lib.
Date: Fri,  9 Apr 2021 02:25:26 +0900
* gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
guile-lib to guile2.2-lib.
---
 gnu/packages/guile-xyz.scm | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/guile-xyz.scm b/gnu/packages/guile-xyz.scm
index e2ee5454a0..75256e0f11 100644
--- a/gnu/packages/guile-xyz.scm
+++ b/gnu/packages/guile-xyz.scm
@@ -28,7 +28,7 @@
 ;;; Copyright © 2020 Jack Hill <jackhill <at> jackhill.us>
 ;;; Copyright © 2020 Julien Lepiler <julien <at> lepiller.eu>
 ;;; Copyright © 2020 Marius Bakke <marius <at> gnu.org>
-;;; Copyright © 2020 Masaya Tojo <masaya <at> tojo.tokyo>
+;;; Copyright © 2020, 2021 Masaya Tojo <masaya <at> tojo.tokyo>
 ;;; Copyright © 2020 Jesse Gibbons <jgibbons2357 <at> gmail.com>
 ;;; Copyright © 2020 Mike Rosset <mike.rosset <at> gmail.com>
 ;;; Copyright © 2020 Leo Prikler <leo.prikler <at> student.tugraz.at>
@@ -3519,7 +3519,7 @@ feature-set, fully programmable in Guile Scheme.")
                                         texlive-fonts-iwona)))
        ("pkg-config" ,pkg-config)))
     (propagated-inputs
-     `(("guile-lib" ,guile-lib)))
+     `(("guile-lib" ,guile2.2-lib)))
     (home-page "https://www.gnu.org/software/guile-cv/")
     (synopsis "Computer vision library for Guile")
     (description "Guile-CV is a Computer Vision functional programming library
-- 
2.31.1





Information forwarded to guix-patches <at> gnu.org:
bug#47659; Package guix-patches. (Thu, 08 Apr 2021 20:06:02 GMT) Full text and rfc822 format available.

Message #8 received at 47659 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Masaya Tojo <masaya <at> tojo.tokyo>, 47659 <at> debbugs.gnu.org
Subject: Re: [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of
 guile-lib.
Date: Thu, 08 Apr 2021 22:05:44 +0200
[Message part 1 (text/plain, inline)]
On Fri, 2021-04-09 at 02:25 +0900, Masaya Tojo wrote:
> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
> guile-lib to guile2.2-lib.

I believe the current naming convention for guile packages is:

* guile1.8-PACKAGE: for guile <at> 1.8
* guile2.0-PACKAGE: for guile <at> 2.0
* guile2.2-PACKAGE: for guile <at> 2.2
* guile-PACKAGE: for guile <at> 3.0

... though this is not always adhered to.  Basically, ‘we’ want to use
the latest version of guile by default.

So I would suggest:

A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'.  But perhaps
  guile-cv does not (yet) support guile-3.0 (there have been a few incompatible
  2.2 -> 3.0 changes)
or
B: your patch, and rename guile-cv to guile2.2-cv.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#47659; Package guix-patches. (Fri, 09 Apr 2021 14:38:02 GMT) Full text and rfc822 format available.

Message #11 received at 47659 <at> debbugs.gnu.org (full text, mbox):

From: Masaya Tojo <masaya <at> tojo.tokyo>
To: Maxime Devos <maximedevos <at> telenet.be>, 47659 <at> debbugs.gnu.org
Subject: Re: [bug#47659] [PATCH] gnu: guile-cv: Use guile2.2 version of
 guile-lib.
Date: Fri, 09 Apr 2021 23:36:51 +0900
Hello,

> A (preferred): replace guile-2.2 with guile-3.0 in 'inputs'.  But perhaps
>   guile-cv does not (yet) support guile-3.0 (there have been a few incompatible
>   2.2 -> 3.0 changes)
> or
> B: your patch, and rename guile-cv to guile2.2-cv.

I tested to build guile-cv with guile-3.0.  But guile-cv's test is
failed, so your suggesion A is not easy.

Therefore, I think suggesion B is better.

Best Regards,

--
Masaya Tojo




Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Fri, 09 Apr 2021 15:29:02 GMT) Full text and rfc822 format available.

Notification sent to Masaya Tojo <masaya <at> tojo.tokyo>:
bug acknowledged by developer. (Fri, 09 Apr 2021 15:29:02 GMT) Full text and rfc822 format available.

Message #16 received at 47659-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Masaya Tojo <masaya <at> tojo.tokyo>
Cc: Maxime Devos <maximedevos <at> telenet.be>, 47659-done <at> debbugs.gnu.org
Subject: Re: bug#47659: [PATCH] gnu: guile-cv: Use guile2.2 version of
 guile-lib.
Date: Fri, 09 Apr 2021 17:28:44 +0200
Hi,

Masaya Tojo <masaya <at> tojo.tokyo> skribis:

> * gnu/packages/guile-xyz.scm (guile-cv)[propagated-inputs]: Change from
> guile-lib to guile2.2-lib.

I agree with Maxime that Guile 3.0 would be best, but in the meantime,
your patch looks like the right thing.

Applied, thanks!

Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 08 May 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 325 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.