GNU bug report logs - #47663
[PATCH] website: Add Help dropdown menu

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47663 in the body.
You can then email your comments to 47663 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Luis Felipe via Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] website: Add Help dropdown menu
Date: Thu, 08 Apr 2021 19:49:07 +0000

[Message part 1 (text/plain, inline)]

Hi,

This patch converts the Help item of the navigation bar into a dropdown menu as proposed in the thread "Document our WIP" (https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00532.html).


---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/

[0001-website-Add-Help-dropdown-menu.patch (text/x-patch, attachment)]

Message #8 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: Vincent Legoll <vincent.legoll <at> gmail.com>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: guix-devel <guix-devel <at> gnu.org>,
 Léo Le Bouter <lle-bout <at> zaclys.net>, 47663 <at> debbugs.gnu.org,
 Leo Famulari <leo <at> famulari.name>
Subject: Re: Document our WIP
Date: Thu, 8 Apr 2021 23:06:32 +0200

Hi,

On Thu, Apr 8, 2021 at 9:55 PM Luis Felipe
<luis.felipe.la <at> protonmail.com> wrote:
> > I just sent a patch to include a link to the wiki in the Help page (https://issues.guix.gnu.org/47555).

I'm sorry to not have given feedback, the Help page addition is great
! Nice wiki icon too.

> > If the patch is applied, I can send a separate patch to update the Help menu as Vincent suggested:
> >
> > Help
> > • GNU Guix Manual
> > • Videos
> > • Cookbook
> > • GNU Manuals
> > • Wiki
> > • IRC Chat
> > • Mailing lists
>
> I've just sent a patch to add this menu (https://issues.guix.gnu.org/47663).

I'm not sure if I can help, but this LGTM (untrained eyes)...

Thanks a lot

-- 
Vincent Legoll

Message #11 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 47663 <at> debbugs.gnu.org
Subject: Re: bug#47663: [PATCH] website: Add Help dropdown menu
Date: Fri, 09 Apr 2021 08:51:27 +0200

Hello Luis,

> This patch converts the Help item of the navigation bar into a dropdown menu
> as proposed in the thread "Document our WIP"
> (https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00532.html).

I find that this new dropdown provides an easier access to the Help
links which is nice!

What do we do with the old help/index.html page, that is now not
accessible? Maybe we need to remove this file:
artwork/website/apps/base/templates/help.scm?

Also I noticed that left clicking directly on the "Help" menu causes
some undesired wrapping on the Help items.

Thanks,

Mathieu

Message #14 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: "47663 <at> debbugs.gnu.org" <47663 <at> debbugs.gnu.org>
Subject: Re: bug#47663: [PATCH] website: Add Help dropdown menu
Date: Fri, 09 Apr 2021 13:32:34 +0000

Hey Mathieu,

‐‐‐‐‐‐‐ Original Message ‐‐‐‐‐‐‐
On Friday, April 9, 2021 6:51 AM, Mathieu Othacehe <othacehe <at> gnu.org> wrote:

> Hello Luis,
>
> > This patch converts the Help item of the navigation bar into a dropdown menu
> > as proposed in the thread "Document our WIP"
> > (https://lists.gnu.org/archive/html/guix-devel/2021-03/msg00532.html).
>
> I find that this new dropdown provides an easier access to the Help
> links which is nice!
>
> What do we do with the old help/index.html page, that is now not
> accessible? Maybe we need to remove this file:
> artwork/website/apps/base/templates/help.scm?

Oh, I completely forgot about that, and I'd actually like to keep that page and link to it from the menu too. So let me think how to solve that.


> Also I noticed that left clicking directly on the "Help" menu causes
> some undesired wrapping on the Help items.

I'll take a look at this too, and send another patch.

Thanks for your help so far, Mathieu.

Best,

Message #17 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: "47663 <at> debbugs.gnu.org" <47663 <at> debbugs.gnu.org>
Subject: Re: bug#47663: [PATCH] website: Add Help dropdown menu
Date: Fri, 09 Apr 2021 20:55:50 +0200

Hey Luis,

> Oh, I completely forgot about that, and I'd actually like to keep that page and link to it from the menu too. So let me think how to solve that.

Yes keeping it is fine to me. At first I thought that left clicking the
"Help" menu would open it. Adding a dedicated item in the list also
seems fine.

> I'll take a look at this too, and send another patch.

Great :)

Thanks,

Mathieu

Message #20 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Mathieu Othacehe <othacehe <at> gnu.org>
Cc: Luis Felipe <luis.felipe.la <at> protonmail.com>,
 "47663 <at> debbugs.gnu.org" <47663 <at> debbugs.gnu.org>
Subject: Re: [bug#47663] [PATCH] website: Add Help dropdown menu
Date: Fri, 9 Apr 2021 21:12:43 +0200

Thank you for working on this.

On Fri, Apr 09, 2021 at 08:55:50PM +0200, Mathieu Othacehe wrote:
> At first I thought that left clicking the
> "Help" menu would open it. Adding a dedicated item in the list also
> seems fine.

In commit 571e1a416e1148139923418bf801ddb6b11723c3 I made left-click
toggle the dropdown instead because touch devices cannot otherwise
access the dropdown, I think.  Am I mistaken?

Regards,
Florian

Message #23 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>,
 "47663 <at> debbugs.gnu.org" <47663 <at> debbugs.gnu.org>
Subject: Re: [bug#47663] [PATCH] website: Add Help dropdown menu
Date: Fri, 09 Apr 2021 19:51:50 +0000

On Friday, April 9, 2021 7:12 PM, pelzflorian (Florian Pelz) <pelzflorian <at> pelzflorian.de> wrote:

> Thank you for working on this.
>
> On Fri, Apr 09, 2021 at 08:55:50PM +0200, Mathieu Othacehe wrote:
>
> > At first I thought that left clicking the
> > "Help" menu would open it. Adding a dedicated item in the list also
> > seems fine.
>
> In commit 571e1a416e1148139923418bf801ddb6b11723c3 I made left-click
> toggle the dropdown instead because touch devices cannot otherwise
> access the dropdown, I think. Am I mistaken?

I think that is the right behavior, Florian. So I'll add the missing link as a new item, like so:

Help
+ All  ← Links to /help/
+ Etc.
+ Etc.

And fix any remaining style issues for pointing and touch devices (cursor shouldn't be pointer (it wasn't before), and dropdown menu width should not shrink on click).

Message #26 received at 47663 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: Mathieu Othacehe <othacehe <at> gnu.org>,
 "47663 <at> debbugs.gnu.org" <47663 <at> debbugs.gnu.org>
Subject: Re: [bug#47663] [PATCH] website: Add Help dropdown menu
Date: Sat, 10 Apr 2021 15:24:17 +0000

[Message part 1 (text/plain, inline)]

On Friday, April 9, 2021 7:51 PM, Luis Felipe <luis.felipe.la <at> protonmail.com> wrote:

> I think that is the right behavior, Florian. So I'll add the missing link as a new item, like so:
>
> Help
>
> -   All ← Links to /help/
> -   Etc.
> -   Etc.

The attached patched does this.


>     And fix any remaining style issues for pointing and touch devices (cursor shouldn't be pointer (it wasn't before), and dropdown menu width should not shrink on click).
>

I'd like to address this separately, so I'll file a new issue and provide a patch once I have something.

[0001-website-Add-Help-dropdown-menu.patch (text/x-patch, attachment)]

Message #29 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Luis Felipe via Guix-patches via <guix-patches <at> gnu.org>
Cc: Luis Felipe <luis.felipe.la <at> protonmail.com>,
 "pelzflorian \(Florian Pelz\)" <pelzflorian <at> pelzflorian.de>,
 47663-done <at> debbugs.gnu.org
Subject: Re: [bug#47663] [PATCH] website: Add Help dropdown menu
Date: Sat, 10 Apr 2021 20:51:32 +0200

Hello,

> I'd like to address this separately, so I'll file a new issue and provide a patch once I have something.

Fine, pushed this one as 321813e88f06e1743c75a1a3b7fe9a0705514a80.

Thanks,

Mathieu

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.