GNU bug report logs - #47710
[PATCH] website: Fix dropdown menu shrinking when clicked

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47710 in the body.
You can then email your comments to 47710 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: Luis Felipe via Guix-patches <guix-patches <at> gnu.org>
Subject: [PATCH] website: Fix dropdown menu shrinking when clicked
Date: Sun, 11 Apr 2021 15:35:32 +0000

[Message part 1 (text/plain, inline)]

Hi,

This patch fixes dropdown menus shrinking when toggling dropdown buttons.

---
Luis Felipe López Acevedo
https://luis-felipe.gitlab.io/

[0001-website-Fix-dropdown-menu-shrinking-when-clicked.patch (text/x-patch, attachment)]

Message #10 received at 47710-done <at> debbugs.gnu.org (full text, mbox):

From: Mathieu Othacehe <othacehe <at> gnu.org>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 47710-done <at> debbugs.gnu.org
Subject: Re: bug#47710: [PATCH] website: Fix dropdown menu shrinking when
 clicked
Date: Sun, 11 Apr 2021 18:30:04 +0200

Hey,

> This patch fixes dropdown menus shrinking when toggling dropdown buttons.

Works great, thanks for fixing it. Pushed as
d3f524d4ea9502e216208b7c3d5f22b9045d4a5c.

Mathieu

Message #13 received at 47710 <at> debbugs.gnu.org (full text, mbox):

From: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
To: Luis Felipe <luis.felipe.la <at> protonmail.com>
Cc: 47710 <at> debbugs.gnu.org
Subject: Re: [bug#47710] [PATCH] website: Fix dropdown menu shrinking when
 clicked
Date: Sun, 11 Apr 2021 23:48:56 +0200

On Sun, Apr 11, 2021 at 03:35:32PM +0000, Luis Felipe via Guix-patches via wrote:
> Subject: [PATCH] website: Fix dropdown menu shrinking when clicked.
> […]
> This change fixes these problems by leaving the menu width as wide as
> its longest item when the button is toggled.

Thank you, this does the trick.  (Except on Microsoft Internet
Explorer, which we do not need to care about anymore.)

> * apps/base/templates/components.scm (menu-dropdown): Set width to
>   max-content on :checked.

The last line should not be indented, but it does not matter.

> ---
>  website/apps/base/templates/components.scm | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/website/apps/base/templates/components.scm b/website/apps/base/templates/components.scm
> index 5440408..f521436 100644
> --- a/website/apps/base/templates/components.scm
> +++ b/website/apps/base/templates/components.scm
> @@ -310,7 +310,7 @@ manual.
>  {
>      min-width: 150px;
>      /* reset to initial values: */
> -    width: auto;
> +    width: max-content;
>      height: auto;
>      overflow: visible;
>  }"))

The comment /* reset to initial values: */ is misplaced now;
max-content is not an initial value for width.  I have moved the
comment down one line in commit
81a6c477d92b2c4a206c390b97c9cb0159d79719.

Regards,
Florian

Message #16 received at 47710 <at> debbugs.gnu.org (full text, mbox):

From: Luis Felipe <luis.felipe.la <at> protonmail.com>
To: "pelzflorian (Florian Pelz)" <pelzflorian <at> pelzflorian.de>
Cc: "47710 <at> debbugs.gnu.org" <47710 <at> debbugs.gnu.org>
Subject: Re: [bug#47710] [PATCH] website: Fix dropdown menu shrinking when
 clicked
Date: Mon, 12 Apr 2021 02:05:31 +0000

Thank you for cleaning that up, Florian.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.