GNU bug report logs - #47726
[PATCH] gnu: Add vice emulator

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47726 in the body.
You can then email your comments to 47726 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: balbi <at> kernel.org
To: guix-patches <at> gnu.org
Cc: Felipe Balbi <balbi <at> kernel.org>
Subject: [PATCH] gnu: Add vice emulator
Date: Mon, 12 Apr 2021 11:11:26 +0300

From: Felipe Balbi <balbi <at> kernel.org>

* gnu/packages/emulators.scm (vice): New variable.

Signed-off-by: Felipe Balbi <balbi <at> kernel.org>
---
 gnu/packages/emulators.scm | 42 ++++++++++++++++++++++++++++++++++++++
 1 file changed, 42 insertions(+)

diff --git a/gnu/packages/emulators.scm b/gnu/packages/emulators.scm
index 8482f679e2c3..5c41e0fc22cb 100644
--- a/gnu/packages/emulators.scm
+++ b/gnu/packages/emulators.scm
@@ -13,6 +13,7 @@
 ;;; Copyright © 2019 David Wilson <david <at> daviwil.com>
 ;;; Copyright © 2020 Jakub Kądziołka <kuba <at> kadziolka.net>
 ;;; Copyright © 2020 Christopher Howard <christopher <at> librehacker.com>
+;;; Copyright © 2021 Felipe Balbi <balbi <at> kernel.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -44,6 +45,7 @@
   #:use-module (gnu packages autogen)
   #:use-module (gnu packages autotools)
   #:use-module (gnu packages base)
+  #:use-module (gnu packages bison)
   #:use-module (gnu packages boost)
   #:use-module (gnu packages backup)
   #:use-module (gnu packages cdrom)
@@ -53,6 +55,7 @@
   #:use-module (gnu packages curl)
   #:use-module (gnu packages digest)
   #:use-module (gnu packages elf)
+  #:use-module (gnu packages flex)
   #:use-module (gnu packages fonts)
   #:use-module (gnu packages fontutils)
   #:use-module (gnu packages freedesktop)
@@ -97,6 +100,45 @@
   #:use-module (guix build-system gnu)
   #:use-module (guix build-system python))
 
+(define-public vice
+  (package
+    (name "vice")
+    (version "3.5")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append "mirror://sourceforge/vice-emu/releases/"
+                           name "-" version ".tar.gz"))
+       (sha256
+        (base32
+         "03nwcldg2h7dxj6aa77ggqc0442hqc1lsq5x69h8kcmqmvx7ifan"))))
+    (build-system gnu-build-system)
+    (arguments
+     `(#:configure-flags '("--disable-pdf-docs")))
+    (native-inputs
+     `(("bison" ,bison)
+       ("dos2unix" ,dos2unix)
+       ("flex" ,flex)
+       ("glib" ,glib "bin")             ; for glib-genmarshal, etc.
+       ("pkg-config" ,pkg-config)))
+    (inputs
+     `(("alsa-lib" ,alsa-lib)
+       ("glew" ,glew)
+       ("glib" ,glib)
+       ("gtk+" ,gtk+)
+       ("pulseaudio" ,pulseaudio)
+       ("sdl" ,sdl)
+       ("sdl-image" ,sdl-image)
+       ("xa" ,xa)))
+    (home-page "https://vice-emu.sourceforge.io/")
+    (synopsis "The Versatile Commodore Emulator")
+    (description
+     "VICE is a program that emulates the C64, the C64DTV, the C128, the
+VIC20, practically all PET models, the PLUS4 and the CBM-II (aka
+C610/C510).  An extra emulator is provided for C64 expanded with the CMD
+SuperCPU.")
+    (license license:gpl2+)))
+
 (define-public desmume
   (package
     (name "desmume")
-- 
2.31.1

Message #10 received at 47726-done <at> debbugs.gnu.org (full text, mbox):

From: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
To: balbi <at> kernel.org
Cc: 47726-done <at> debbugs.gnu.org
Subject: Re: [bug#47726] [PATCH] gnu: Add vice emulator
Date: Mon, 26 Apr 2021 20:55:33 +0200

Hello,

balbi <at> kernel.org writes:

> From: Felipe Balbi <balbi <at> kernel.org>
>
> * gnu/packages/emulators.scm (vice): New variable.

Thank you! I applied it.

> Signed-off-by: Felipe Balbi <balbi <at> kernel.org>

We don't have the habit of signing our own patches.

> +       (uri (string-append "mirror://sourceforge/vice-emu/releases/"
> +                           name "-" version ".tar.gz"))

Nitpick: we hard-code the name in the URI.

Regards,
-- 
Nicolas Goaziou

Message #13 received at 47726-done <at> debbugs.gnu.org (full text, mbox):

From: Felipe Balbi <balbi <at> kernel.org>
To: Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
Cc: 47726-done <at> debbugs.gnu.org
Subject: Re: [bug#47726] [PATCH] gnu: Add vice emulator
Date: Mon, 26 Apr 2021 21:57:04 +0300

Hi,

On Mon, Apr 26, 2021 at 9:55 PM Nicolas Goaziou <mail <at> nicolasgoaziou.fr> wrote:
>
> Hello,
>
> balbi <at> kernel.org writes:
>
> > From: Felipe Balbi <balbi <at> kernel.org>
> >
> > * gnu/packages/emulators.scm (vice): New variable.
>
> Thank you! I applied it.

Awesome, thanks :-)

> > Signed-off-by: Felipe Balbi <balbi <at> kernel.org>
>
> We don't have the habit of signing our own patches.
>
> > +       (uri (string-append "mirror://sourceforge/vice-emu/releases/"
> > +                           name "-" version ".tar.gz"))
>
> Nitpick: we hard-code the name in the URI.

sure thing, I'll keep that in mind next time :-)

I did see a couple packages doing that, though.

-- 
balbi

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.