GNU bug report logs - #47756
[PATCH] gnu: guile-git: Update to 0.5.0.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47756 in the body.
You can then email your comments to 47756 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: guile-git: Update to 0.5.0.
Date: Tue, 13 Apr 2021 21:22:44 +0200

* gnu/packages/guile.scm (guile-git): Update to 0.5.0.
[source]: Use ‘git-fetch’ instead of ‘url-fetch’.
[native-inputs]: Add autoconf, automake, and texinfo.
---
I used ‘git-fetch’ because it is more flexible than ‘url-fetch’, users
can for example use package transformations to easily use a desired
commit/branch.  Because the distributed tarball includes files that are
generated by running ‘./configure’, users would then have to manually
add some native-inputs to make it build with a custom version of the
package (this has happened to me a few times).

 gnu/packages/guile.scm | 15 +++++++++------
 1 file changed, 9 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/guile.scm b/gnu/packages/guile.scm
index 0dad390275..76741504c8 100644
--- a/gnu/packages/guile.scm
+++ b/gnu/packages/guile.scm
@@ -776,21 +776,24 @@ type system, elevating types to first-class status.")
 (define-public guile-git
   (package
     (name "guile-git")
-    (version "0.4.0")
+    (version "0.5.0")
     (home-page "https://gitlab.com/guile-git/guile-git.git")
     (source (origin
-              (method url-fetch)
-              (uri (string-append "https://gitlab.com/guile-git/guile-git/uploads/"
-                                  "2600bb0dfdfb00bfbe46811dccad51d8/guile-git-"
-                                  version ".tar.gz"))
+              (method git-fetch)
+              (uri (git-reference
+                    (url "https://gitlab.com/guile-git/guile-git")
+                    (commit (string-append "v" version))))
               (sha256
                (base32
-                "1kxyg9x2aa1pg69cl48wysq0pbxvwfahy1xpl5ab6p8babhf7kic"))))
+                "1hqw3jy81cnsgybsbnfvwvhv1bajwq662hikkrr6dcgky6yspsxx"))))
     (build-system gnu-build-system)
     (arguments
      `(#:make-flags '("GUILE_AUTO_COMPILE=0")))     ; to prevent guild warnings
     (native-inputs
      `(("pkg-config" ,pkg-config)
+       ("autoconf" ,autoconf)
+       ("automake" ,automake)
+       ("texinfo" ,texinfo)
        ("guile" ,guile-3.0)
        ("guile-bytestructures" ,guile-bytestructures)))
     (inputs

base-commit: 82543e9649da2da9a5285ede4ec4f718fd740fcb
-- 
2.31.1

Message #8 received at 47756 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 47756 <at> debbugs.gnu.org
Subject: Re: bug#47756: [PATCH] gnu: guile-git: Update to 0.5.0.
Date: Tue, 13 Apr 2021 23:31:08 +0200

Hi!

I pushed that update independently as
c2e83b71054f953953711e027f863d6c75c6ddb2.

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> * gnu/packages/guile.scm (guile-git): Update to 0.5.0.
> [source]: Use ‘git-fetch’ instead of ‘url-fetch’.
> [native-inputs]: Add autoconf, automake, and texinfo.
> ---
> I used ‘git-fetch’ because it is more flexible than ‘url-fetch’, users
> can for example use package transformations to easily use a desired
> commit/branch.

I agree this is desirable.  I didn’t do that because I thought it might
be a case where we need Guile-Git for ‘git-fetch’, but I think I was
wrong (I was confusing with Guile-Zlib, which we cannot obtain via
‘git-fetch’ because ‘git-fetch’ uses it.)

So after all, maybe we can use ‘git-fetch’?

Ludo’.

Message #11 received at 47756 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 47756 <at> debbugs.gnu.org
Subject: Re: bug#47756: [PATCH] gnu: guile-git: Update to 0.5.0.
Date: Wed, 14 Apr 2021 14:53:09 +0200

On Tue, Apr 13 2021, Ludovic Courtès wrote:

> Hi!
>
> I pushed that update independently as
> c2e83b71054f953953711e027f863d6c75c6ddb2.

Oh, cool.

>> I used ‘git-fetch’ because it is more flexible than ‘url-fetch’, users
>> can for example use package transformations to easily use a desired
>> commit/branch.
>
> I agree this is desirable.  I didn’t do that because I thought it might
> be a case where we need Guile-Git for ‘git-fetch’, but I think I was
> wrong (I was confusing with Guile-Zlib, which we cannot obtain via
> ‘git-fetch’ because ‘git-fetch’ uses it.)

Yeah, ‘git-fetch’ in (guix build git) runs (invoke "git" args ...), it
doesn’t seem to have any dependency on Guile-Git.

> So after all, maybe we can use ‘git-fetch’?

I think that would a good idea. :)

Message #14 received at 47756 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 47756 <at> debbugs.gnu.org
Subject: Re: bug#47756: [PATCH] gnu: guile-git: Update to 0.5.0.
Date: Fri, 16 Apr 2021 23:54:58 +0200

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> On Tue, Apr 13 2021, Ludovic Courtès wrote:
>
>> Hi!
>>
>> I pushed that update independently as
>> c2e83b71054f953953711e027f863d6c75c6ddb2.
>
> Oh, cool.
>
>>> I used ‘git-fetch’ because it is more flexible than ‘url-fetch’, users
>>> can for example use package transformations to easily use a desired
>>> commit/branch.
>>
>> I agree this is desirable.  I didn’t do that because I thought it might
>> be a case where we need Guile-Git for ‘git-fetch’, but I think I was
>> wrong (I was confusing with Guile-Zlib, which we cannot obtain via
>> ‘git-fetch’ because ‘git-fetch’ uses it.)
>
> Yeah, ‘git-fetch’ in (guix build git) runs (invoke "git" args ...), it
> doesn’t seem to have any dependency on Guile-Git.
>
>> So after all, maybe we can use ‘git-fetch’?
>
> I think that would a good idea. :)

Done in 7a6625e83f68f6408ff0a82b12e7a95c6b0cc096!

Thanks,
Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.