GNU bug report logs - #47776
[PATCH] import: go: Fix goproxy option argument's format.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47776 in the body.
You can then email your comments to 47776 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Z572 <873216071 <at> qq.com>
To: guix-patches <at> gnu.org
Subject: [PATCH] import: go: Fix goproxy option argument's format.
Date: Wed, 14 Apr 2021 23:00:20 +0800

[0001-import-go-Fix-goproxy-option-argument-s-format.patch (text/x-patch, inline)]

From e34f281d39f9b1e247fa649a15657da70f2b548d Mon Sep 17 00:00:00 2001
From: Zheng Junjie <873216071 <at> qq.com>
Date: Wed, 14 Apr 2021 22:37:50 +0800
Subject: [PATCH] import: go: Fix goproxy option argument's format.

Commit a8b927a562 Added new procedure go-module-available-versions use
'string-append' to GOPROXY, but 'string->symbol' let GOPROXY is a symbol (it
must be a string), which would lead to wrong-type-arg errors in the
'string-append' procedure.

* guix/scripts/import/go.scm (%options)[goproxy]: Remove call to
'string->symbol'.
---
 guix/scripts/import/go.scm | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/guix/scripts/import/go.scm b/guix/scripts/import/go.scm
index 04b07f80cc..74e8e60cce 100644
--- a/guix/scripts/import/go.scm
+++ b/guix/scripts/import/go.scm
@@ -1,6 +1,7 @@
 ;;; GNU Guix --- Functional package management for GNU
 ;;; Copyright © 2020 Katherine Cox-Buday <cox.katherine.e <at> gmail.com>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2021 Zheng Junjie <873216071 <at> qq.com>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,9 +69,7 @@ that are not yet in Guix"))
                    (alist-cons 'recursive #t result)))
          (option '(#\p "goproxy") #t #f
                  (lambda (opt name arg result)
-                   (alist-cons 'goproxy
-                               (string->symbol arg)
-                               (alist-delete 'goproxy result))))
+                   (alist-cons 'goproxy arg (alist-delete 'goproxy result))))
          (option '("pin-versions") #f #f
                  (lambda (opt name arg result)
                    (alist-cons 'pin-versions? #t result)))
-- 
2.31.1

Message #10 received at 47776-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Z572 <873216071 <at> qq.com>
Cc: 47776-done <at> debbugs.gnu.org
Subject: Re: bug#47776: [PATCH] import: go: Fix goproxy option argument's
 format.
Date: Fri, 14 May 2021 12:41:22 +0200

Hi,

Z572 <873216071 <at> qq.com> skribis:

>>From e34f281d39f9b1e247fa649a15657da70f2b548d Mon Sep 17 00:00:00 2001
> From: Zheng Junjie <873216071 <at> qq.com>
> Date: Wed, 14 Apr 2021 22:37:50 +0800
> Subject: [PATCH] import: go: Fix goproxy option argument's format.
>
> Commit a8b927a562 Added new procedure go-module-available-versions use
> 'string-append' to GOPROXY, but 'string->symbol' let GOPROXY is a symbol (it
> must be a string), which would lead to wrong-type-arg errors in the
> 'string-append' procedure.
>
> * guix/scripts/import/go.scm (%options)[goproxy]: Remove call to
> 'string->symbol'.

Applied, thanks!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.