GNU bug report logs - #47778
[PATCH]: Update FreeCAD to 0.19.1

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47778 in the body.
You can then email your comments to 47778 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: [PATCH]: Update FreeCAD to 0.19.1
Date: Wed, 14 Apr 2021 15:59:28 +0000

[Message part 1 (text/plain, inline)]

Hi,

This set of patches update freecad from unstable to the 0.19.1 release.

More information in this help-guix thread:

https://lists.gnu.org/archive/html/help-guix/2021-04/msg00118.html

Thanks!

[0001-gnu-Add-vtk-8.patch (text/x-patch, attachment)]

[0002-gnu-freecad-Update-to-0.19.1.patch (text/x-patch, attachment)]

Message #8 received at 47778 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>, 47778 <at> debbugs.gnu.org
Subject: Re: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1
Date: Wed, 14 Apr 2021 23:39:14 +0200

[Message part 1 (text/plain, inline)]

On Wed, 2021-04-14 at 15:59 +0000, Ekaitz Zarraga wrote:
> Hi,
> 
> This set of patches update freecad from unstable to the 0.19.1 release.
> 
> More information in this help-guix thread:
> 
> https://lists.gnu.org/archive/html/help-guix/2021-04/msg00118.html
> 
> Thanks!

+       `(#:tests? #f
Why's that?  ‘We’ prefer to have tests enabled when possible.
Please document why tests are disabled here (with a comment
#:tests? #f ; no tests / tests require dependency X, which is not packaged ...).

+         (add-before 'configure 'restore-pythonpath
+           (lambda _
+             (substitute* "src/Main/MainGui.cpp"
+               (("_?putenv\\(\"PYTHONPATH=\"\\);") ""))
+             #t))

The #t can be removed.  The warning that results when #t is absent
has been removed on the core-updates branch; we might as well stop
introducing these silly #t now such that we don't have to remove them
later.

Greetings,
Maxme.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 47778 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "47778 <at> debbugs.gnu.org" <47778 <at> debbugs.gnu.org>
Subject: Re: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1
Date: Wed, 14 Apr 2021 21:44:47 +0000

Hi,

>
> -         `(#:tests? #f
>
> Why's that? ‘We’ prefer to have tests enabled when possible.
> Please document why tests are disabled here (with a comment
> #:tests? #f ; no tests / tests require dependency X, which is not packaged ...).

I'll try to test the package with the tests, but they were
disabled before too, so I didn't change that.

>
> -           (add-before 'configure 'restore-pythonpath
>
>
> -             (lambda _
>
>
> -               (substitute* "src/Main/MainGui.cpp"
>
>
> -                 (("_?putenv\\\\(\\"PYTHONPATH=\\"\\\\);") ""))
>
>
> -               #t))
>
>
>
> The #t can be removed. The warning that results when #t is absent
> has been removed on the core-updates branch; we might as well stop
> introducing these silly #t now such that we don't have to remove them
> later.
>
> Greetings,
> Maxme.

Ok, I'll remove that and update the patch.

Thanks!

Message #14 received at 47778 <at> debbugs.gnu.org (full text, mbox):

From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
To: Maxime Devos <maximedevos <at> telenet.be>
Cc: "47778 <at> debbugs.gnu.org" <47778 <at> debbugs.gnu.org>
Subject: Re: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1
Date: Wed, 14 Apr 2021 22:58:57 +0000

[Message part 1 (text/plain, inline)]

Hi,

As they are not functional changes, I updated inside
the same diff.

Hope it's ok.
Cheers,

Ekaitz

[0002-gnu-freecad-Update-to-0.19.1.patch (text/x-patch, attachment)]

Message #19 received at 47778-done <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Ekaitz Zarraga <ekaitz <at> elenq.tech>
Cc: "47778-done <at> debbugs.gnu.org" <47778-done <at> debbugs.gnu.org>,
 Maxime Devos <maximedevos <at> telenet.be>
Subject: Re: [bug#47778] [PATCH]: Update FreeCAD to 0.19.1
Date: Thu, 15 Apr 2021 22:26:03 -0400

On Wed, Apr 14, 2021 at 10:58:57PM +0000, Ekaitz Zarraga wrote:
> Hi,
> 
> As they are not functional changes, I updated inside
> the same diff.
> 
> Hope it's ok.
> Cheers,
> 
> Ekaitz

> From 5308c3eeda66262cf5427cf040589bdaa0b85cab Mon Sep 17 00:00:00 2001
> From: Ekaitz Zarraga <ekaitz <at> elenq.tech>
> Date: Wed, 14 Apr 2021 15:49:53 +0200
> Subject: [PATCH 2/2] gnu: freecad: Update to 0.19.1
> 
> * gnu/packages/engineering.scm (freecad): Update to 0.19.1
> [inputs]: Add new dependencies

Thanks! I filled out the commit message and pushed the patches as
ce2fe8bf34199e2b9788a7f77c0ad0bbdfa713bd.

Thanks for reviewing Maxime! I wanted to make sure this made it into the
upcoming release :)

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.