GNU bug report logs - #47807
TeX-view-program settings for Xreader

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47807 in the body.
You can then email your comments to 47807 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: bug-auctex <at> gnu.org
Subject: TeX-view-program settings for Xreader
Date: Thu, 15 Apr 2021 15:35:59 -0300

Hi All,

This is a simple one.  `tex.el' includes settings for the "Xreader" to 
be used in Linux systems as defined in `TeX-view-program-list-builtin'. 
After loading, the entry for "Xreader" in that variable will be: 
`("Xreader" TeX-reader-sync-view "xreader")'.  However, the function 
`TeX-reader-sync-view' is actually not defined, but rather 
`TeX-xreader-sync-view' is (with an "x").  Therefore, using "Xreader" 
for `output-pdf' in `TeX-view-program-selection' will throw us error 
"Wrong type argument: listp, TeX-reader-sync-view".

As far as I can tell, the problem does not lie in the definition of 
`TeX-view-program-list-builtin', because 
`TeX-view-program-select-evince' relies on `TeX-evince-dbus-p' which 
will query the DBUS path/scheme/method which is indeed "org.x.reader" 
(at least in my machine, I suppose that's default, but I really don't 
know).  Thus, it seems `TeX-xreader-sync-view' is incorrectly named, and 
should drop the "x".  It's docstring also seems to not have been 
adjusted as required after it was "inherited" from 
`TeX-evince-sync-view'.

Best regards,
Gustavo.

PS: Please keep me CC'd.

Message #8 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: bug-auctex <at> gnu.org, 47807-done <at> debbugs.gnu.org
Subject: Re: bug#47807: TeX-view-program settings for Xreader
Date: Fri, 16 Apr 2021 18:41:17 +0200

Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

Hi Gustavo,

> This is a simple one.  `tex.el' includes settings for the "Xreader" to
> be used in Linux systems as defined in
> `TeX-view-program-list-builtin'. After loading, the entry for
> "Xreader" in that variable will be: `("Xreader" TeX-reader-sync-view
> "xreader")'.  However, the function `TeX-reader-sync-view' is actually
> not defined, but rather `TeX-xreader-sync-view' is (with an "x").
> Therefore, using "Xreader" for `output-pdf' in
> `TeX-view-program-selection' will throw us error "Wrong type argument:
> listp, TeX-reader-sync-view".
>
> As far as I can tell, the problem does not lie in the definition of
> `TeX-view-program-list-builtin', because
> `TeX-view-program-select-evince' relies on `TeX-evince-dbus-p' which
> will query the DBUS path/scheme/method which is indeed "org.x.reader"
> (at least in my machine, I suppose that's default, but I really don't
> know).  Thus, it seems `TeX-xreader-sync-view' is incorrectly named,
> and should drop the "x".

I approve your analysis.  Fixed on git master.  Please give it a whirl.

> It's docstring also seems to not have been adjusted as required after
> it was "inherited" from `TeX-evince-sync-view'.

Indeed, also fixed.

Bye,
Tassilo

Message #16 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: bug-auctex <at> gnu.org, 47807-done <at> debbugs.gnu.org
Subject: Re: bug#47807: TeX-view-program settings for Xreader
Date: Fri, 16 Apr 2021 15:25:38 -0300

On Fri, 16 Apr 2021 at 13:41, Tassilo Horn <tsdh <at> gnu.org> wrote:

Hi Tassilo,

> Fixed on git master.

Thanks for the quick fix!

> Please give it a whirl.

I did (local definition on top of 13.0.6).  I had also been running, 
since yesterday with:

#+begin_src emacs-lisp
(unless (fboundp 'TeX-reader-sync-view)
 (defalias 'TeX-reader-sync-view 'TeX-xreader-sync-view))
#+end_src

Which is equivalent for all practical purposes.  And, as far as I can 
tell, things are working as expected.  Hence, it LGTM.

>> It's docstring also seems to not have been adjusted as required after
>> it was "inherited" from `TeX-evince-sync-view'.
>
> Indeed, also fixed.

The tiniest nitpick.  I usually see the name of the program as 
"Xreader", with a lowercase "r".  But I'm not sure it is even worth the 
amend.  I certainly won't pester you further about it. 

Best,
Gustavo.

Message #22 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Tassilo Horn <tsdh <at> gnu.org>
To: Gustavo Barros <gusbrs.2016 <at> gmail.com>
Cc: bug-auctex <at> gnu.org, 47807-done <at> debbugs.gnu.org
Subject: Re: bug#47807: TeX-view-program settings for Xreader
Date: Sat, 17 Apr 2021 09:57:26 +0200

Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:

Hi Gustavo,

>>> It's docstring also seems to not have been adjusted as required
>>> after it was "inherited" from `TeX-evince-sync-view'.
>>
>> Indeed, also fixed.
>
> The tiniest nitpick.  I usually see the name of the program as
> "Xreader", with a lowercase "r".  But I'm not sure it is even worth
> the amend.  I certainly won't pester you further about it.

I've just fixed that as well.  Thanks for the heads-up.

Bye,
Tassilo

Message #28 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Gustavo Barros <gusbrs.2016 <at> gmail.com>
To: Tassilo Horn <tsdh <at> gnu.org>
Cc: bug-auctex <at> gnu.org, 47807-done <at> debbugs.gnu.org
Subject: Re: bug#47807: TeX-view-program settings for Xreader
Date: Sat, 17 Apr 2021 07:45:41 -0300

On Sat, 17 Apr 2021 at 04:57, Tassilo Horn <tsdh <at> gnu.org> wrote:

> Gustavo Barros <gusbrs.2016 <at> gmail.com> writes:
>
> Hi Gustavo,
>
>>>> It's docstring also seems to not have been adjusted as required
>>>> after it was "inherited" from `TeX-evince-sync-view'.
>>>
>>> Indeed, also fixed.
>>
>> The tiniest nitpick.  I usually see the name of the program as
>> "Xreader", with a lowercase "r".  But I'm not sure it is even worth
>> the amend.  I certainly won't pester you further about it.
>
> I've just fixed that as well.  Thanks for the heads-up.

Thanks again!

Bye,
Gustavo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.