GNU bug report logs - #47810
28.0.50; pulse no longer accepts a face argument

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47810 in the body.
You can then email your comments to 47810 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; pulse no longer accepts a face argument
Date: Thu, 15 Apr 2021 22:35:35 +0300

Dear maintainers,

I would expect the following two expressions to produce pulse effects
that differ in colour (tried with emacs -Q):

    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)

Instead they use the background of pulse-highlight-start-face.  This
test confirms as much:

    (set-face-background 'pulse-highlight-start-face "red")
    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
    
    (set-face-background 'pulse-highlight-start-face "blue")
    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)

The following diff addresses the problem with the FACE argument, but
introduces a noticeable delay to the pulse effect:

     lisp/cedet/pulse.el | 2 +-
     1 file changed, 1 insertion(+), 1 deletion(-)

    diff --git a/lisp/cedet/pulse.el b/lisp/cedet/pulse.el
    index 1e4506713a..e4733ca007 100644
    --- a/lisp/cedet/pulse.el
    +++ b/lisp/cedet/pulse.el
    @@ -147,7 +147,7 @@ (defun pulse-momentary-highlight-overlay (o &optional face)
          (add-hook 'pre-command-hook
                #'pulse-momentary-unhighlight))
           ;; Pulse it.
    -      (overlay-put o 'face 'pulse-highlight-face)
    +      (overlay-put o 'face (or face 'pulse-highlight-start-face))
           ;; The pulse function puts FACE onto 'pulse-highlight-face.
           ;; Thus above we put our face on the overlay, but pulse
           ;; with a reference face needed for the color.

I am not sure what may be causing that delay.

Thank you for your attention!

-- 
Protesilaos Stavrou
protesilaos.com

Message #8 received at 47810 <at> debbugs.gnu.org (full text, mbox):

From: Gregory Heytings <gregory <at> heytings.org>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 47810 <at> debbugs.gnu.org
Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Fri, 16 Apr 2021 08:32:52 +0000

[Message part 1 (text/plain, inline)]

>
> I would expect the following two expressions to produce pulse effects 
> that differ in colour (tried with emacs -Q):
>
>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>
> Instead they use the background of pulse-highlight-start-face.
>

Indeed; patch attached.

[Use-correct-face-when-pulsing-Bug-47810.patch (text/x-diff, attachment)]

Message #11 received at 47810 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 47810 <at> debbugs.gnu.org
Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Fri, 16 Apr 2021 14:09:21 +0300

On 2021-04-16, 08:32 +0000, Gregory Heytings <gregory <at> heytings.org> wrote:

>>
>> I would expect the following two expressions to produce pulse effects
>> that differ in colour (tried with emacs -Q):
>>
>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>>
>> Instead they use the background of pulse-highlight-start-face.
>>
>
> Indeed; patch attached.

Thank you!  I can confirm that this works.

-- 
Protesilaos Stavrou
protesilaos.com

Message #16 received at 47810 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Kangas <stefan <at> marxist.se>
To: Protesilaos Stavrou <info <at> protesilaos.com>
Cc: 47810 <at> debbugs.gnu.org, Gregory Heytings <gregory <at> heytings.org>
Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Tue, 20 Apr 2021 19:02:36 -0500

Protesilaos Stavrou <info <at> protesilaos.com> writes:

> On 2021-04-16, 08:32 +0000, Gregory Heytings <gregory <at> heytings.org> wrote:
>
>>>
>>> I would expect the following two expressions to produce pulse effects
>>> that differ in colour (tried with emacs -Q):
>>>
>>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>>>
>>> Instead they use the background of pulse-highlight-start-face.
>>>
>>
>> Indeed; patch attached.
>
> Thank you!  I can confirm that this works.

I guess we are still waiting for Gregory's copyright papers to come
through before this can be applied?

Message #19 received at 47810 <at> debbugs.gnu.org (full text, mbox):

From: Protesilaos Stavrou <info <at> protesilaos.com>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 47810 <at> debbugs.gnu.org, Stefan Kangas <stefan <at> marxist.se>
Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Tue, 04 May 2021 07:33:37 +0300

On 2021-04-20, 19:02 -0500, Stefan Kangas <stefan <at> marxist.se> wrote:

> Protesilaos Stavrou <info <at> protesilaos.com> writes:
>
>> On 2021-04-16, 08:32 +0000, Gregory Heytings <gregory <at> heytings.org> wrote:
>>
>>>>
>>>> I would expect the following two expressions to produce pulse effects
>>>> that differ in colour (tried with emacs -Q):
>>>>
>>>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'highlight)
>>>>    (pulse-momentary-highlight-region (point-at-bol) (point-at-eol) 'region)
>>>>
>>>> Instead they use the background of pulse-highlight-start-face.
>>>>
>>>
>>> Indeed; patch attached.
>>
>> Thank you!  I can confirm that this works.
>
> I guess we are still waiting for Gregory's copyright papers to come
> through before this can be applied?

Hello Gregory!

Has your copyright assignment process been finalised?  Maybe Stefan can
help install your patches.  There is this bug report as well as #47960.

All the best,
Protesilaos or "Prot"

-- 
Protesilaos Stavrou
https://protesilaos.com

Message #22 received at 47810 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Gregory Heytings <gregory <at> heytings.org>
Cc: 47810 <at> debbugs.gnu.org, Protesilaos Stavrou <info <at> protesilaos.com>
Subject: Re: bug#47810: 28.0.50; pulse no longer accepts a face argument
Date: Tue, 25 May 2021 06:22:49 +0200

Gregory Heytings <gregory <at> heytings.org> writes:

>> Instead they use the background of pulse-highlight-start-face.
>>
>
> Indeed; patch attached.

Thanks; applied to Emacs 28.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.