GNU bug report logs - #47815
[PATCH 1/3] gnu: music: python-abjad: Abjad Improvements.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47815 in the body.
You can then email your comments to 47815 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: guix-patches <at> gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: [PATCH 1/3] gnu: music: python-abjad: Abjad Improvements.
Date: Fri, 16 Apr 2021 04:57:09 +0000

[Message part 1 (text/plain, inline)]

Hi Guix,

Below are some improvements to the python-abjad package that was merged the other day.

I changed the name to abjad, moved some inputs into their correct place, and improved its description.

best regards,

jgart

[0002-gnu-abjad-Move-python-ply-and-lilypond-to-propagated.patch (application/octet-stream, attachment)]

[0003-gnu-abjad-Improve-description.patch (application/octet-stream, attachment)]

[0001-gnu-Rename-python-abjad-to-abjad.patch (application/octet-stream, attachment)]

Message #8 received at 47815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 47815 <at> debbugs.gnu.org
Cc: Efraim Flashner <efraim <at> flashner.co.il>
Subject: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Fri, 16 Apr 2021 12:12:25 +0200

[Message part 1 (text/plain, inline)]

On Fri, 2021-04-16 at 04:57 +0000, jgart via Guix-patches via wrote:
> Hi Guix,
> 
> Below are some improvements to the python-abjad package that was merged the other day.
> 
> I changed the name to abjad, moved some inputs into their correct place,

Please move 'lilypond' from propagated-inputs to 'inputs', if sanely possible!
This avoids polluting the profile with packages the user did not
explicitely request.  Of course, abjad still somehow has to find
lilypond, so you might need to replace "lilypond" with

  (string-append (assoc-ref inputs "lilypond") "/bin/lilypond")

somewhere in python-abjad's source code.  You can use substitute*
for that.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 47815 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 47815 <at> debbugs.gnu.org
Cc: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>,
 Efraim Flashner <efraim <at> flashner.co.il>,
 "Bonface M. K." <bonfacemunyoki <at> gmail.com>
Subject: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Fri, 16 Apr 2021 17:59:41 +0000

[Message part 1 (text/plain, inline)]

Hi Maxime,

Thank you for the review! I attached a new patch set. 

I reverted to Bonface's original idea of having lilypond only as a native input in the package definition.

I prefer this solution in order to solve the problem since it follows upstream's instructions of installing lilypond separately (https://abjad.github.io/first_steps/linux.html), doesn't pollute a guix user's profile with lilypond as you mentioned, and seems a bit cleaner since I don't have to touch the python sources in order to make them find the lilypond input.

If the user wants to produce a pdf then they can just include lilypond in their profile.

What do you think?

best regards,

jgart

ps

This caused me to have to add lilypond as a native-input to abjad-ext-rmakers (47816), abjad-ext-nauert (47817), and abjad-ext-ipython (47818) since those where building successfully before because they had abjad as a propagated input and abjad had lilypond as a propagated input. The above mentioned packages require lilypond for the tests.




April 16, 2021 6:12 AM, "Maxime Devos" <maximedevos <at> telenet.be> wrote:

> On Fri, 2021-04-16 at 04:57 +0000, jgart via Guix-patches via wrote:
> 
>> Hi Guix,
>> 
>> Below are some improvements to the python-abjad package that was merged the other day.
>> 
>> I changed the name to abjad, moved some inputs into their correct place,
> 
> Please move 'lilypond' from propagated-inputs to 'inputs', if sanely possible!
> This avoids polluting the profile with packages the user did not
> explicitely request. Of course, abjad still somehow has to find
> lilypond, so you might need to replace "lilypond" with
> 
> (string-append (assoc-ref inputs "lilypond") "/bin/lilypond")
> 
> somewhere in python-abjad's source code. You can use substitute*
> for that.
> 
> Greetings,
> Maxime.

[0001-gnu-Rename-python-abjad-to-abjad.patch (application/octet-stream, attachment)]

[0002-gnu-abjad-Move-python-ply-to-propagated-inputs.patch (application/octet-stream, attachment)]

[0003-gnu-abjad-Improve-description.patch (application/octet-stream, attachment)]

Message #14 received at 47815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>, 47815 <at> debbugs.gnu.org
Cc: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>,
 Efraim Flashner <efraim <at> flashner.co.il>,
 "Bonface M. K." <bonfacemunyoki <at> gmail.com>
Subject: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Sat, 17 Apr 2021 11:12:25 +0200

[Message part 1 (text/plain, inline)]

jgart schreef op vr 16-04-2021 om 17:59 [+0000]:
> Hi Maxime,
> 
> Thank you for the review! I attached a new patch set. 
> 
> I reverted to Bonface's original idea of having lilypond only as a native input
> in the package definition.

If you do that, make sure "abjad" does not retain a reference to lilypond,
as otherwise when cross-compiling, "abjad" will use a lilypond built for the
incorrect architecture.  You can use #:disallowed-references ,lilypond for this.

(TODO: there should be a #:disallowed-refences/native variant.  But
#:disallowed-references will suffice for now.)

I'm currently occupied with some other things, so I can't review your revised
patches yet.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

Message #17 received at 47815 <at> debbugs.gnu.org (full text, mbox):

From: "jgart" <jgart <at> dismail.de>
To: "Maxime Devos" <maximedevos <at> telenet.be>, 47815 <at> debbugs.gnu.org
Cc: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>,
 Efraim Flashner <efraim <at> flashner.co.il>,
 "Bonface M. K." <bonfacemunyoki <at> gmail.com>
Subject: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Sat, 17 Apr 2021 16:10:25 +0000

Hi Maxime,

I tried your suggestion but it fails with the following exception:

Backtrace:

...
In guix/build-system/python.scm:
    162:0  3 (python-build _ _ _ #:tests? _ #:test-target _ # _ # _ # …)
In ice-9/boot-9.scm:
  1669:16  2 (raise-exception _ #:continuable? _)
  1669:16  1 (raise-exception _ #:continuable? _)
  1669:16  0 (raise-exception _ #:continuable? _)

ice-9/boot-9.scm:1669:16: In procedure raise-exception:
Unrecognized keyword: #:disallowed-references

It looks like python-build-system might not support #:disallowed-references.

Is that correct?

all the best,

jgart

ps

I did a quick search for it with ripgrep and it seems like only gnu, meson, and glib-or-gtk support it currently:

rg "\#:disallowed-references" -t lisp | rg build-system

guix/build-system/meson.scm:                              #:disallowed-references
guix/build-system/gnu.scm:                                #:disallowed-references
guix/build-system/gnu.scm:                                #:disallowed-references
guix/build-system/glib-or-gtk.scm:                        #:disallowed-references


April 17, 2021 5:12 AM, "Maxime Devos" <maximedevos <at> telenet.be> wrote:

> jgart schreef op vr 16-04-2021 om 17:59 [+0000]:
> 
>> Hi Maxime,
>> 
>> Thank you for the review! I attached a new patch set.
>> 
>> I reverted to Bonface's original idea of having lilypond only as a native input
>> in the package definition.
> 
> If you do that, make sure "abjad" does not retain a reference to lilypond,
> as otherwise when cross-compiling, "abjad" will use a lilypond built for the
> incorrect architecture. You can use #:disallowed-references ,lilypond for this.
> 
> (TODO: there should be a #:disallowed-refences/native variant. But
> #:disallowed-references will suffice for now.)
> 
> I'm currently occupied with some other things, so I can't review your revised
> patches yet.
> 
> Greetings,
> Maxime.

Message #20 received at 47815 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: 47815 <at> debbugs.gnu.org
Subject: Fwd: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Sat, 17 Apr 2021 18:19:20 +0200

[Message part 1 (text/plain, inline)]

I accidentally forgot to keep 47815 <at> debbugs.gnu.org in To:.

[Message part 2 (message/rfc822, inline)]

From: Maxime Devos <maximedevos <at> telenet.be>
To: jgart <jgart <at> dismail.de>
Subject: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Sat, 17 Apr 2021 18:18:22 +0200

[Message part 3 (text/plain, inline)]

jgart schreef op za 17-04-2021 om 16:10 [+0000]:
> Hi Maxime,
> 
> I tried your suggestion but it fails with the following exception:
> 
> Backtrace:
> 
> ...
> In guix/build-system/python.scm:
>     162:0  3 (python-build _ _ _ #:tests? _ #:test-target _ # _ # _ # …)
> In ice-9/boot-9.scm:
>   1669:16  2 (raise-exception _ #:continuable? _)
>   1669:16  1 (raise-exception _ #:continuable? _)
>   1669:16  0 (raise-exception _ #:continuable? _)
> 
> ice-9/boot-9.scm:1669:16: In procedure raise-exception:
> Unrecognized keyword: #:disallowed-references
> 
> It looks like python-build-system might not support #:disallowed-references.
> 
> Is that correct?

That indeed seems to be the case.
For now, you can run ‘guix gc --references $(guix build abjad)’.
The output should not contain lilypond.
I'll see about adding #:disallowed-references and #:disallowed-native-references
later.

Greetings,
Maxime.

[signature.asc (application/pgp-signature, inline)]

[signature.asc (application/pgp-signature, inline)]

Message #25 received at 47815-done <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: jgart <jgart <at> dismail.de>
Cc: "Bonface Munyoki K." <me <at> bonfacemunyoki.com>, 47815-done <at> debbugs.gnu.org,
 Maxime Devos <maximedevos <at> telenet.be>,
 "Bonface M. K." <bonfacemunyoki <at> gmail.com>
Subject: Re: [bug#47815] [PATCH 1/3] gnu: music: python-abjad: Abjad
 Improvements.
Date: Thu, 22 Jul 2021 11:53:55 +0300

[Message part 1 (text/plain, inline)]

Sorry for the long delay! I made a couple of changes:
I added python-abjad as a deprecated package, so it won't break for
anyone who already has it installed.
I sorted python-ply alphabetically when moving it to propagated-inputs.

I also moved lilypond to inputs and removed the now unnecessary
'patch-source phase.

Thanks! Patches pushed.

-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.