GNU bug report logs - #47822
[PATCH] gnu: Add r-naturalsort.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47822 in the body.
You can then email your comments to 47822 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add r-naturalsort.
Date: Fri, 16 Apr 2021 12:57:51 +0200

[Message part 1 (text/plain, inline)]

Hi Guix,

Here's a patch for r-naturalsort.

Also: is it OK to push patches like this ("another" fairly trivial R
package) directly?

Kind regards,
Roel Janssen

[0001-gnu-Add-r-naturalsort.patch (text/x-patch, attachment)]

Message #8 received at 47822 <at> debbugs.gnu.org (full text, mbox):

From: Efraim Flashner <efraim <at> flashner.co.il>
To: Roel Janssen <roel <at> gnu.org>
Cc: 47822 <at> debbugs.gnu.org
Subject: Re: [bug#47822] [PATCH] gnu: Add r-naturalsort.
Date: Tue, 4 May 2021 18:52:59 +0300

[Message part 1 (text/plain, inline)]

On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> Hi Guix,
> 
> Here's a patch for r-naturalsort.
> 
> Also: is it OK to push patches like this ("another" fairly trivial R
> package) directly?
> 
> Kind regards,
> Roel Janssen
> 

Probably. Plus it's been 2 weeks.


-- 
Efraim Flashner   <efraim <at> flashner.co.il>   אפרים פלשנר
GPG key = A28B F40C 3E55 1372 662D  14F7 41AA E7DC CA3D 8351
Confidentiality cannot be guaranteed on emails sent or received unencrypted

[signature.asc (application/pgp-signature, inline)]

Message #11 received at 47822 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Roel Janssen <roel <at> gnu.org>
Cc: 47822 <at> debbugs.gnu.org
Subject: Re: [bug#47822] [PATCH] gnu: Add r-naturalsort.
Date: Tue, 4 May 2021 12:31:48 -0400

On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> Here's a patch for r-naturalsort.
> 
> Also: is it OK to push patches like this ("another" fairly trivial R
> package) directly?

Yes. Quoting the manual section Commit Access:

------
For patches that just add a new package, and a simple one, it’s OK to
commit, if you’re confident (which means you successfully built it in a
chroot setup, and have done a reasonable copyright and license
auditing). Likewise for package upgrades, except upgrades that trigger a
lot of rebuilds (for example, upgrading GnuTLS or GLib). 
------

If you aren't feeling confident, just let us know what you'd like
someone else to check for you. Otherwise, feel free to push.

Message #16 received at 47822-done <at> debbugs.gnu.org (full text, mbox):

From: Roel Janssen <roel <at> gnu.org>
To: Leo Famulari <leo <at> famulari.name>, Efraim Flashner <efraim <at> flashner.co.il>
Cc: 47822-done <at> debbugs.gnu.org
Subject: Re: [bug#47822] [PATCH] gnu: Add r-naturalsort.
Date: Tue, 04 May 2021 21:36:49 +0200

On Tue, 2021-05-04 at 12:31 -0400, Leo Famulari wrote:
> On Fri, Apr 16, 2021 at 12:57:51PM +0200, Roel Janssen wrote:
> > Here's a patch for r-naturalsort.
> > 
> > Also: is it OK to push patches like this ("another" fairly trivial
> > R
> > package) directly?
> 
> Yes. Quoting the manual section Commit Access:
> 
> ------
> For patches that just add a new package, and a simple one, it’s OK to
> commit, if you’re confident (which means you successfully built it in
> a
> chroot setup, and have done a reasonable copyright and license
> auditing). Likewise for package upgrades, except upgrades that
> trigger a
> lot of rebuilds (for example, upgrading GnuTLS or GLib). 
> ------
> 
> If you aren't feeling confident, just let us know what you'd like
> someone else to check for you. Otherwise, feel free to push.
> 

Thanks Efraim and Leo.  I pushed this patch in
aa7eeabe9a782afc2535581298990050d16b1895.

I will push trivial patches like these directly from now on.  Please do
let me know if I pushed something that would've benefitted from review.

Kind regards,
Roel Janssen

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.