GNU bug report logs - #47863
[PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47863 in the body.
You can then email your comments to 47863 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: xfce4-settings: Add gsettings-desktop-schemas.
Date: Sun, 18 Apr 2021 16:23:26 +1000

* gnu/packages/xfce.scm (xfce4-settings):[propagated-inputs]: Add
gsettings-desktop-schemas. This makes it appear in the system profile
via the xfce service. This fixes a bug where changing icon theme causes
xfce4-appearance-settings to crash with the error:

GLib-GIO-ERROR **: 15:41:45.828: Settings schema 'org.gnome.desktop.interface' is not installed
Trace/breakpoint trap
---
 gnu/packages/xfce.scm | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/gnu/packages/xfce.scm b/gnu/packages/xfce.scm
index 38240d7b9f..ffac62af9e 100644
--- a/gnu/packages/xfce.scm
+++ b/gnu/packages/xfce.scm
@@ -755,6 +755,8 @@ allows you to shut down the computer from Xfce.")
        ("upower" ,upower) ;; TODO needs upower-glib
        ("python" ,python) ;; for xfce4-compose-mail
        ("xf86-input-libinput" ,xf86-input-libinput)))
+    (propagated-inputs
+     `(("gsettings-desktop-schemas" ,gsettings-desktop-schemas)))
     (home-page "https://www.xfce.org/")
     (synopsis "Xfce settings manager")
     (description
-- 
2.31.1

Message #8 received at 47863 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 47863 <at> debbugs.gnu.org
Subject: Re: bug#47863: [PATCH] gnu: xfce4-settings: Add
 gsettings-desktop-schemas.
Date: Thu, 29 Apr 2021 01:23:34 +0200

Hi,

Brendan Tildesley <mail <at> brendan.scot> skribis:

> * gnu/packages/xfce.scm (xfce4-settings):[propagated-inputs]: Add
> gsettings-desktop-schemas. This makes it appear in the system profile
> via the xfce service. This fixes a bug where changing icon theme causes
> xfce4-appearance-settings to crash with the error:
>
> GLib-GIO-ERROR **: 15:41:45.828: Settings schema 'org.gnome.desktop.interface' is not installed
> Trace/breakpoint trap

The patch LGTM but I can’t seem to reproduce the issue here.  Namely, if
I go to Settings → Appearance and switch from “GNOME Theme” to
“Adwaita”, it just works.

Am I missing something?

Thanks,
Ludo’.

Message #11 received at 47863 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: 47863 <at> debbugs.gnu.org
Cc: Ludovic Courtès <ludo <at> gnu.org>
Subject: Re: bug#47863: [PATCH] gnu: xfce4-settings: Add
 gsettings-desktop-schemas.
Date: Thu, 29 Apr 2021 07:53:05 +0200 (CEST)

> On 04/29/2021 1:23 AM Ludovic Courtès <ludo <at> gnu.org> wrote:
> 
>  
> Hi,
> 
> Brendan Tildesley <mail <at> brendan.scot> skribis:
> 
> > * gnu/packages/xfce.scm (xfce4-settings):[propagated-inputs]: Add
> > gsettings-desktop-schemas. This makes it appear in the system profile
> > via the xfce service. This fixes a bug where changing icon theme causes
> > xfce4-appearance-settings to crash with the error:
> >
> > GLib-GIO-ERROR **: 15:41:45.828: Settings schema 'org.gnome.desktop.interface' is not installed
> > Trace/breakpoint trap
> 
> The patch LGTM but I can’t seem to reproduce the issue here.  Namely, if
> I go to Settings → Appearance and switch from “GNOME Theme” to
> “Adwaita”, it just works.
> 
> Am I missing something?
> 
If you also have GNOME installed then it will work. GNOME provides them via propagated inputs in many packages.
For me, the theme changes, but then the settings window crashes.

BTW do you think the way the gnome package is made with propagated inputs is better than how the xfce is made by union-ing everything?

Message #14 received at 47863 <at> debbugs.gnu.org (full text, mbox):

From: Brendan Tildesley <mail <at> brendan.scot>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 47863 <at> debbugs.gnu.org
Subject: Re: bug#47863: [PATCH] gnu: xfce4-settings: Add
 gsettings-desktop-schemas.
Date: Thu, 29 Apr 2021 09:58:58 +0200 (CEST)

Run 
$(guix system vm ./xfce-os-test.scm) -m 1G
with this:

(use-modules (gnu)
             (srfi srfi-1))
(use-service-modules desktop xorg)
(operating-system
  (bootloader (grub-configuration))
  (file-systems %base-file-systems)
  (locale "en_AU.utf8")
  (timezone "Australia/Hobart")
  (keyboard-layout    (keyboard-layout "us" "colemak"))
  (host-name "jiu")
  (users (cons* (user-account
                 (name "b")
                 (password (crypt "b" "$6$abc")) ;; password "b"
                 (comment "Brendan")
                 (group "users")
                 (home-directory "/home/b")
                 (supplementary-groups
                  '("wheel" "netdev" "audio" "video" "kvm")))
                %base-user-accounts))
  (packages
   (append
    (map specification->package '("nss-certs"
                                  "gnome-themes-standard"))
    %base-packages))
  (services
   (append
    (list (set-xorg-configuration
           (xorg-configuration
            (keyboard-layout keyboard-layout)))

          (service xfce-desktop-service-type))

    (modify-services %desktop-services
      (gdm-service-type
       config => (gdm-configuration
                  (default-user "b")
                  (auto-login? #t)))))))

Message #19 received at 47863-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Brendan Tildesley <mail <at> brendan.scot>
Cc: 47863-done <at> debbugs.gnu.org
Subject: Re: bug#47863: [PATCH] gnu: xfce4-settings: Add
 gsettings-desktop-schemas.
Date: Fri, 30 Apr 2021 18:20:31 +0200

Hi,

Brendan Tildesley <mail <at> brendan.scot> skribis:

>> On 04/29/2021 1:23 AM Ludovic Courtès <ludo <at> gnu.org> wrote:

[...]

>> The patch LGTM but I can’t seem to reproduce the issue here.  Namely, if
>> I go to Settings → Appearance and switch from “GNOME Theme” to
>> “Adwaita”, it just works.
>> 
>> Am I missing something?
>> 
> If you also have GNOME installed then it will work. GNOME provides them via propagated inputs in many packages.
> For me, the theme changes, but then the settings window crashes.

OK.  So actually what happens is that changing themes works, but the
thing crashes right after changing themes (which I didn’t notice when
spawning xfce4-appearance-settings by clicking in the menu).

Applied, thanks!

> BTW do you think the way the gnome package is made with propagated inputs is better than how the xfce is made by union-ing everything?

No strong opinion, either way is fine with me.

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.