GNU bug report logs -
#47884
[PATCH] Add package: ibus-chewing
Previous Next
To reply to this bug, email your comments to 47884 AT debbugs.gnu.org.
Toggle the display of automated, internal messages from the tracker.
Report forwarded
to
guix-patches <at> gnu.org
:
bug#47884
; Package
guix-patches
.
(Mon, 19 Apr 2021 00:59:02 GMT)
Full text and
rfc822 format available.
Acknowledgement sent
to
"Guu, Jin-Cheng" <jin-cheng.guu <at> stonybrook.edu>
:
New bug report received and forwarded. Copy sent to
guix-patches <at> gnu.org
.
(Mon, 19 Apr 2021 00:59:02 GMT)
Full text and
rfc822 format available.
Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hello all,
Attached is my first patch to guix. It's for the package
`ibus-chewing`, an IBus front-end of Chewing, which is an intelligent
Chinese input method for Zhuyin (BoPoMoFo) users. A dependency `gob`
is also added. Hopefully, this will attract more Chinese users to
guix.
Special thanks for their patience and guides to nckx and
raghavgururajan on #guix. Most of the code work came from
raghavgururajan.
Regards,
Jin
[0001-gnu-Add-gob-and-ibus-chewing.patch (text/x-patch, attachment)]
Information forwarded
to
guix-patches <at> gnu.org
:
bug#47884
; Package
guix-patches
.
(Mon, 19 Apr 2021 12:22:02 GMT)
Full text and
rfc822 format available.
Message #8 received at 47884 <at> debbugs.gnu.org (full text, mbox):
[Message part 1 (text/plain, inline)]
Hi Jin-Cheng!
Congratulations on your first patch. \o/
You don't have to under-sell your work. I just cleaned up the pack-def
and fixed the glib schema error. All others are your work. :-)
Also, if anyone helps you with code/snippet in #guix, you don't have to
use the same code/snippet. You are free to adopt them in any way you see
fit. Folks usually share a code/snippet, purely for informational purposes.
REVIEW:
[1] As Julien mentioned in #guix, it is better to make two patches, one
for dependency package and one for the main package.
[2] Package gob appears to be a candidate for glib.scm. So its better to
move this package to glib.scm.
[3] In Guix, we try to avoid bundled stuff, for better security and
reproducibilty. It'd be great if you package cmake-fedora separately
(like gob) and remove the use of `recursive? #t`, in ibus-chewing.
As usual, if you have any questions, feel to free to ask around in
#guix. ;-)
Regards,
RG.
[OpenPGP_signature (application/pgp-signature, attachment)]
This bug report was last modified 3 years and 319 days ago.
Previous Next
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997,2003 nCipher Corporation Ltd,
1994-97 Ian Jackson.