GNU bug report logs - #47913
[PATCH] add netdiscover

Previous Next

Package: guix-patches;

Reported by: terramorpha <at> cock.li

Date: Tue, 20 Apr 2021 17:55:02 UTC

Severity: normal

Tags: patch

Done: Arun Isaac <arunisaac <at> systemreboot.net>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47913 in the body.
You can then email your comments to 47913 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Tue, 20 Apr 2021 17:55:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to terramorpha <at> cock.li:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Tue, 20 Apr 2021 17:55:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: guix-patches <at> gnu.org
Subject: [PATCH] add netdiscover
Date: Tue, 20 Apr 2021 13:47:52 -0400
---
 gnu/packages/networking.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f7557fc331..342621299b 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -4075,3 +4075,29 @@ IPv6 Internet connectivity - it also works over 
IPv4.")
      ;; version. This exception does not (and cannot) modify any 
license terms
      ;; which apply to the Application, with which you must still 
comply
      license:lgpl3)))
+
+(define-public netdiscover
+  (package
+   (name "netdiscover")
+   (version "0.7")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url 
"https://github.com/netdiscover-scanner/netdiscover")
+                  (commit version)))
+            (sha256 (base32 
"0g8w8rlg16dsibxi4dnyn7v7r8wwi5ypd51c4w59j0ps2id0w8yj"))
+            (file-name (string-append "netdiscover-" version))))
+   (arguments `(#:tests? #f)) ;; no tests
+   (build-system gnu-build-system)
+   (inputs `(("libpcap" ,libpcap)
+             ("libnet" ,libnet)))
+   (native-inputs `(("automake" ,automake)
+                    ("autoconf" ,autoconf)))
+   (synopsis "Network address discovery tool")
+   (description
+    "Netdiscover is a network address discovering tool, developed 
mainly for
+those wireless networks without dhcp server, it also works on 
hub/switched
+networks.  Its based on arp packets, it will send arp requests and 
sniff for
+replies.")
+   (home-page "https://github.com/netdiscover-scanner/netdiscover")
+   (license license:gpl3)))
-- 
2.31.1




Information forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Tue, 20 Apr 2021 18:30:02 GMT) Full text and rfc822 format available.

Message #8 received at 47913 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: terramorpha <at> cock.li, 47913 <at> debbugs.gnu.org
Subject: Re: [bug#47913] [PATCH] add netdiscover
Date: Tue, 20 Apr 2021 20:29:24 +0200
[Message part 1 (text/plain, inline)]
terramorpha <at> cock.li schreef op di 20-04-2021 om 13:47 [-0400]:
> [...]
> +   (home-page "https://github.com/netdiscover-scanner/netdiscover")
> +   (license license:gpl3)))
Fr-
om netdiscover/src/data_ai.h:

 *  This program is free software; you can redistribute it and/or modify
 *  it under the terms of the GNU General Public License as published by
 *  the Free Software Foundation; either version 3 of the License, or
 *  (at your option) any later version.

So this should perhaps be license:gpl3+?
 
Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Tue, 20 Apr 2021 20:57:03 GMT) Full text and rfc822 format available.

Message #11 received at 47913 <at> debbugs.gnu.org (full text, mbox):

From: Justin Veilleux <terramorpha <at> cock.li>
To: Maxime Devos <maximedevos <at> telenet.be>, 47913 <at> debbugs.gnu.org
Subject: Re: [bug#47913] [PATCH] add netdiscover
Date: Tue, 20 Apr 2021 16:26:13 -0400
[Message part 1 (text/plain, inline)]
That makes sense. Should I send another patch with this field fixed ?

On April 20, 2021 2:29:24 p.m. EDT, Maxime Devos <maximedevos <at> telenet.be> wrote:
>terramorpha <at> cock.li schreef op di 20-04-2021 om 13:47 [-0400]:
>> [...]
>> +   (home-page "https://github.com/netdiscover-scanner/netdiscover")
>> +   (license license:gpl3)))
>Fr-
>om netdiscover/src/data_ai.h:
>
> *  This program is free software; you can redistribute it and/or modify
> *  it under the terms of the GNU General Public License as published by
> *  the Free Software Foundation; either version 3 of the License, or
> *  (at your option) any later version.
>
>So this should perhaps be license:gpl3+?
> 
>Greetings,
>Maxime.

-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.
[Message part 2 (text/html, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Tue, 20 Apr 2021 20:57:03 GMT) Full text and rfc822 format available.

Message #14 received at 47913 <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: 47913 <at> debbugs.gnu.org
Subject: [PATCH v2] add netdiscover
Date: Tue, 20 Apr 2021 16:43:45 -0400
Here you go.


---
 gnu/packages/networking.scm | 26 ++++++++++++++++++++++++++
 1 file changed, 26 insertions(+)

diff --git a/gnu/packages/networking.scm b/gnu/packages/networking.scm
index f7557fc331..e973a1b26a 100644
--- a/gnu/packages/networking.scm
+++ b/gnu/packages/networking.scm
@@ -4075,3 +4075,29 @@ IPv6 Internet connectivity - it also works over 
IPv4.")
      ;; version. This exception does not (and cannot) modify any 
license terms
      ;; which apply to the Application, with which you must still 
comply
      license:lgpl3)))
+
+(define-public netdiscover
+  (package
+   (name "netdiscover")
+   (version "0.7")
+   (source (origin
+            (method git-fetch)
+            (uri (git-reference
+                  (url 
"https://github.com/netdiscover-scanner/netdiscover")
+                  (commit version)))
+            (sha256 (base32 
"0g8w8rlg16dsibxi4dnyn7v7r8wwi5ypd51c4w59j0ps2id0w8yj"))
+            (file-name (string-append "netdiscover-" version))))
+   (arguments `(#:tests? #f)) ;; no tests
+   (build-system gnu-build-system)
+   (inputs `(("libpcap" ,libpcap)
+             ("libnet" ,libnet)))
+   (native-inputs `(("automake" ,automake)
+                    ("autoconf" ,autoconf)))
+   (synopsis "Network address discovery tool")
+   (description
+    "Netdiscover is a network address discovering tool, developed 
mainly for
+those wireless networks without dhcp server, it also works on 
hub/switched
+networks.  Its based on arp packets, it will send arp requests and 
sniff for
+replies.")
+   (home-page "https://github.com/netdiscover-scanner/netdiscover")
+   (license license:gpl3+)))
-- 
2.31.1




Information forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Tue, 27 Apr 2021 15:53:02 GMT) Full text and rfc822 format available.

Message #17 received at 47913 <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: 47913 <at> debbugs.gnu.org
Cc: maximedevos <at> telenet.be
Subject: [PATCH v2] add netdiscover
Date: Tue, 27 Apr 2021 11:52:12 -0400
Are there still issues preventing the patch from being merged?




Information forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Tue, 27 Apr 2021 18:20:01 GMT) Full text and rfc822 format available.

Message #20 received at 47913 <at> debbugs.gnu.org (full text, mbox):

From: Maxime Devos <maximedevos <at> telenet.be>
To: terramorpha <at> cock.li, 47913 <at> debbugs.gnu.org
Subject: Re: [PATCH v2] add netdiscover
Date: Tue, 27 Apr 2021 20:19:34 +0200
[Message part 1 (text/plain, inline)]
terramorpha <at> cock.li schreef op di 27-04-2021 om 11:52 [-0400]:
> Are there still issues preventing the patch from being merged?

None that I know of.  You'll have to wait for a committer (which I am not)
to confirm and merge the patch.

Note: I reviewed the patch, but didn't test the package.

Greetings,
Maxime.
[signature.asc (application/pgp-signature, inline)]

Information forwarded to guix-patches <at> gnu.org:
bug#47913; Package guix-patches. (Fri, 09 Jul 2021 21:08:02 GMT) Full text and rfc822 format available.

Message #23 received at 47913 <at> debbugs.gnu.org (full text, mbox):

From: terramorpha <at> cock.li
To: 47913 <at> debbugs.gnu.org
Subject: is there anybody out there?
Date: Fri, 09 Jul 2021 17:07:38 -0400
Could someone with commit access take a look at my patch ?




Reply sent to Arun Isaac <arunisaac <at> systemreboot.net>:
You have taken responsibility. (Sat, 10 Jul 2021 09:53:02 GMT) Full text and rfc822 format available.

Notification sent to terramorpha <at> cock.li:
bug acknowledged by developer. (Sat, 10 Jul 2021 09:53:02 GMT) Full text and rfc822 format available.

Message #28 received at 47913-done <at> debbugs.gnu.org (full text, mbox):

From: Arun Isaac <arunisaac <at> systemreboot.net>
To: terramorpha <at> cock.li, 47913-done <at> debbugs.gnu.org
Subject: Re: [bug#47913] is there anybody out there?
Date: Sat, 10 Jul 2021 15:21:48 +0530
[Message part 1 (text/plain, inline)]
Hi Justin,

Thank you for contributing to Guix! I applied your patch with a few
corrections:

- changed commit message to conform to Guix conventions
- added a copyright header for you
- made some stylistic changes to the package description
- modified the description slightly

Thanks,
Arun
[signature.asc (application/pgp-signature, inline)]

bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sat, 07 Aug 2021 11:24:04 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 257 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.