GNU bug report logs - #47923
gnu: Add daemonize.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47923 in the body.
You can then email your comments to 47923 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Winter Hound <winterhound <at> yandex.com>
To: "guix-patches <at> gnu.org" <guix-patches <at> gnu.org>
Subject: gnu: Add daemonize.
Date: Wed, 21 Apr 2021 02:37:02 +0530

[0001-gnu-Add-daemonize.patch (text/x-diff, attachment)]

Message #8 received at 47923 <at> debbugs.gnu.org (full text, mbox):

From: Leo Famulari <leo <at> famulari.name>
To: Winter Hound <winterhound <at> yandex.com>
Cc: 47923 <at> debbugs.gnu.org
Subject: Re: [bug#47923] gnu: Add daemonize.
Date: Tue, 20 Apr 2021 21:05:32 -0400

On Wed, Apr 21, 2021 at 02:37:02AM +0530, Winter Hound wrote:
> From f9e100cf01ea72544996b54b78a08502ca33a413 Mon Sep 17 00:00:00 2001
> From: WinterHound <winterhound <at> yandex.com>
> Date: Wed, 21 Apr 2021 02:17:13 +0530
> Subject: [PATCH] gnu: Add daemonize.

Thanks for the patch!

Don't forget to add yourself to the list of authors of
gnu/packages/admin.scm. There's an example in commit
3ddece896fddc38a29ab7e69f7c74f35e5a381fb, which was your patch adding
kirc:

https://git.savannah.gnu.org/cgit/guix.git/commit/?id=3ddece896fddc38a29ab7e69f7c74f35e5a381fb

> +    (arguments
> +     `(#:tests? #f

I'm guessing this program doesn't have a test suite?

We prefer to document why #:tests? are #f. A code comment like "No test
suite" is sufficient.

> +       #:phases
> +       (modify-phases %standard-phases
> +         (add-after 'unpack 'patch-makefile
> +           (lambda _
> +             (substitute* "Makefile.in"
> +               (("/sbin") "/bin")) #t)))))

Why change this output directory? We usually respect the upstream
decision about whether executable binaries go in 'sbin' or 'bin'. Guix
will add both directories to $PATH, so it will work either way.

Otherwise, looks good! Can you send a revised patch or answer those
questions?

Message #11 received at 47923 <at> debbugs.gnu.org (full text, mbox):

From: Winter Hound <winterhound <at> yandex.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "47923 <at> debbugs.gnu.org" <47923 <at> debbugs.gnu.org>
Subject: Re: [bug#47923] gnu: Add daemonize.
Date: Wed, 21 Apr 2021 10:47:40 +0530

[Message part 1 (text/html, inline)]

Message #14 received at 47923 <at> debbugs.gnu.org (full text, mbox):

From: Winter Hound <winterhound <at> yandex.com>
To: Leo Famulari <leo <at> famulari.name>
Cc: "47923 <at> debbugs.gnu.org" <47923 <at> debbugs.gnu.org>
Subject: Re: [bug#47923] gnu: Add daemonize.
Date: Wed, 21 Apr 2021 10:48:40 +0530

[Message part 1 (text/html, inline)]

Message #17 received at 47923 <at> debbugs.gnu.org (full text, mbox):

From: Winter Hound <winterhound <at> yandex.com>
To: "47923 <at> debbugs.gnu.org" <47923 <at> debbugs.gnu.org>
Subject: gnu: Add daemonize.
Date: Wed, 21 Apr 2021 11:51:06 +0530

[0001-gnu-Add-daemonize.patch (text/x-diff, attachment)]

Message #22 received at 47923-done <at> debbugs.gnu.org (full text, mbox):

From: Ricardo Wurmus <rekado <at> elephly.net>
To: 47923-done <at> debbugs.gnu.org, winterhound <at> yandex.com
Subject: gnu: Add daemonize.
Date: Thu, 22 Apr 2021 10:37:20 +0200

Hi,

I squashed your two commits, edited the description, moved the 
home-page field up for consistency, remove an extra semicolon (we 
use only one semicolon for margin comments), and pushed the result 
as commit 296e230896babea785bb0f7cd34ab10645f146e8.

Thank you!

-- 
Ricardo

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.