GNU bug report logs - #47925
28.0.50; define-minor-mode without body results in false warning

Previous Next

Package: emacs;

Reported by: Jonas Bernoulli <jonas <at> bernoul.li>

Date: Tue, 20 Apr 2021 22:25:02 UTC

Severity: normal

Tags: fixed

Found in version 28.0.50

Done: Stefan Monnier <monnier <at> iro.umontreal.ca>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47925 in the body.
You can then email your comments to 47925 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#47925; Package emacs. (Tue, 20 Apr 2021 22:25:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Jonas Bernoulli <jonas <at> bernoul.li>:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Tue, 20 Apr 2021 22:25:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; define-minor-mode without body results in false warning
Date: Wed, 21 Apr 2021 00:24:06 +0200
I have a mode that leaves out all the optional arguments because its
sole purpose is the enable its minor-mode map:

  (define-minor-mode transient-resume-mode
    "Auxiliary minor-mode used to resume a transient after viewing help.")

which is supported:

  (define-minor-mode MODE DOC [KEYWORD VAL ... &rest BODY])

Unfortunately that results in a warning:

  transient.el:3318:20: Warning: Use keywords rather than deprecated positional
      arguments to `define-minor-mode'

because INIT-VALUE is nil in this case, not keywordp.




Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#47925; Package emacs. (Tue, 20 Apr 2021 23:42:02 GMT) Full text and rfc822 format available.

Message #8 received at 47925 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: 47925 <at> debbugs.gnu.org
Subject: Re: bug#47925: 28.0.50; define-minor-mode without body results in
 false warning
Date: Tue, 20 Apr 2021 19:41:02 -0400
>   (define-minor-mode transient-resume-mode
>     "Auxiliary minor-mode used to resume a transient after viewing help.")
[...]
> Unfortunately that results in a warning:
>
>   transient.el:3318:20: Warning: Use keywords rather than deprecated positional
>       arguments to `define-minor-mode'

I have pushed a patch to `master` which hopefully fixes this without
introducing regressions.


        Stefan





Added tag(s) fixed. Request was from Stefan Kangas <stefan <at> marxist.se> to control <at> debbugs.gnu.org. (Sun, 25 Apr 2021 11:18:02 GMT) Full text and rfc822 format available.

Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#47925; Package emacs. (Tue, 27 Apr 2021 07:29:01 GMT) Full text and rfc822 format available.

Message #13 received at 47925 <at> debbugs.gnu.org (full text, mbox):

From: Jonas Bernoulli <jonas <at> bernoul.li>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: 47925 <at> debbugs.gnu.org
Subject: Re: bug#47925: 28.0.50; define-minor-mode without body results in
 false warning
Date: Tue, 27 Apr 2021 09:28:25 +0200
Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

> I have pushed a patch to `master` which hopefully fixes this without
> introducing regressions.

That seems to be working.  Thanks!




Reply sent to Stefan Monnier <monnier <at> iro.umontreal.ca>:
You have taken responsibility. (Tue, 27 Apr 2021 13:28:01 GMT) Full text and rfc822 format available.

Notification sent to Jonas Bernoulli <jonas <at> bernoul.li>:
bug acknowledged by developer. (Tue, 27 Apr 2021 13:28:02 GMT) Full text and rfc822 format available.

Message #18 received at 47925-done <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Jonas Bernoulli <jonas <at> bernoul.li>
Cc: 47925-done <at> debbugs.gnu.org
Subject: Re: bug#47925: 28.0.50; define-minor-mode without body results in
 false warning
Date: Tue, 27 Apr 2021 09:27:45 -0400
>> I have pushed a patch to `master` which hopefully fixes this without
>> introducing regressions.
> That seems to be working.  Thanks!

Thanks, closing,


        Stefan





bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Wed, 26 May 2021 11:24:05 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 307 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.