GNU bug report logs - #47975
28.0.50; Project prefixed buffer name

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 47975 in the body.
You can then email your comments to 47975 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; Project prefixed buffer name
Date: Fri, 23 Apr 2021 19:32:17 +0300

[Message part 1 (text/plain, inline)]

It seems the commit 08fab316a1 calls for more changes:

[project-prefixed-buffer-name.patch (text/x-diff, inline)]

diff --git a/lisp/progmodes/project.el b/lisp/progmodes/project.el
index 5996a76488..914d7ce9e4 100644
--- a/lisp/progmodes/project.el
+++ b/lisp/progmodes/project.el
@@ -918,10 +918,7 @@ project-shell
 if one already exists."
   (interactive)
   (let* ((default-directory (project-root (project-current t)))
-         (default-project-shell-name
-           (concat "*" (file-name-nondirectory
-                        (directory-file-name default-directory))
-                   "-shell*"))
+         (default-project-shell-name (project-prefixed-buffer-name "shell"))
          (shell-buffer (get-buffer default-project-shell-name)))
     (if (and shell-buffer (not current-prefix-arg))
         (pop-to-buffer-same-window shell-buffer)
@@ -937,10 +934,7 @@ project-eshell
   (interactive)
   (defvar eshell-buffer-name)
   (let* ((default-directory (project-root (project-current t)))
-         (eshell-buffer-name
-          (concat "*" (file-name-nondirectory
-                       (directory-file-name default-directory))
-                  "-eshell*"))
+         (eshell-buffer-name (project-prefixed-buffer-name "eshell"))
          (eshell-buffer (get-buffer eshell-buffer-name)))
     (if (and eshell-buffer (not current-prefix-arg))
         (pop-to-buffer-same-window eshell-buffer)
@@ -1004,6 +998,7 @@ project-compilation-buffer-name-function
   "Function to compute the name of a project compilation buffer.
 If non-nil, it overrides `compilation-buffer-name-function' for
 `project-compile'."
+  :version "28.1"
   :group 'project
   :type '(choice (const :tag "Default" nil)
                  (const :tag "Prefixed with root directory name"

Message #8 received at 47975 <at> debbugs.gnu.org (full text, mbox):

From: Dmitry Gutov <dgutov <at> yandex.ru>
To: Juri Linkov <juri <at> linkov.net>, 47975 <at> debbugs.gnu.org
Subject: Re: bug#47975: 28.0.50; Project prefixed buffer name
Date: Sat, 24 Apr 2021 01:58:51 +0300

Hi Juri,

On 23.04.2021 19:32, Juri Linkov wrote:
> It seems the commit 08fab316a1 calls for more changes:

I stopped short of doing this keeping in mind the possibility for fixing 
and reusing uniquify not too far off in the future.

But please feel free to install, it shouldn't hurt either way.

Message #11 received at 47975 <at> debbugs.gnu.org (full text, mbox):

From: Juri Linkov <juri <at> linkov.net>
To: Dmitry Gutov <dgutov <at> yandex.ru>
Cc: 47975 <at> debbugs.gnu.org
Subject: Re: bug#47975: 28.0.50; Project prefixed buffer name
Date: Sun, 25 Apr 2021 00:54:27 +0300

tags 47975 fixed
close 47975 28.0.50
thanks

>> It seems the commit 08fab316a1 calls for more changes:
>
> I stopped short of doing this keeping in mind the possibility for fixing
> and reusing uniquify not too far off in the future.

Reusing uniquify is welcome, it could eliminate the need of redefining
the built-in commands to be able to generate unique compilation buffer names:

(defun my-project-compile ()
  (interactive)
  ;; Like ‘project-compile’ but generate unique buffer names:
  (let ((default-directory (project-root (project-current t)))
        (compilation-buffer-name-function
         (lambda (mode)
           (generate-new-buffer-name
            (project-prefixed-buffer-name mode)))))
    (compile (compilation-read-command (car compile-history)) nil)))

> But please feel free to install, it shouldn't hurt either way.

Now installed in master.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.