GNU bug report logs - #47979
[PATCH] installer: Recommend 'ntp-service-type' for non-graphical systems.

Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.

Package: guix-patches; Severity: important; Reported by: Leo Famulari <leo@HIDDEN>; Keywords: patch; dated Fri, 23 Apr 2021 18:54:01 UTC; Maintainer for guix-patches is guix-patches@HIDDEN.
Severity set to 'important' from 'normal' Request was from Ludovic Courtès <ludo@HIDDEN> to control <at> debbugs.gnu.org. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 1 Jun 2021 09:50:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Jun 01 05:50:20 2021
Received: from localhost ([127.0.0.1]:35782 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lo12R-0006OI-Qx
	for submit <at> debbugs.gnu.org; Tue, 01 Jun 2021 05:50:20 -0400
Received: from eggs.gnu.org ([209.51.188.92]:59108)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1lo12O-0006Nx-E2
 for 47979 <at> debbugs.gnu.org; Tue, 01 Jun 2021 05:50:17 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:51340)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1lo12I-0006w2-RE; Tue, 01 Jun 2021 05:50:10 -0400
Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=45336 helo=meije)
 by fencepost.gnu.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1lo127-0006tq-LU; Tue, 01 Jun 2021 05:50:10 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Leo Famulari <leo@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
 <YKgfsIih02iFbR6o@HIDDEN>
Date: Tue, 01 Jun 2021 11:49:55 +0200
In-Reply-To: <YKgfsIih02iFbR6o@HIDDEN> (Leo Famulari's message of "Fri,
 21 May 2021 17:01:36 -0400")
Message-ID: <87tumh6hj0.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey Leo,

> cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.2.8p15.drv': 1 dependencies couldn't be built 

The installation tests are run in a network isolated environment. This
means that we need to make sure that every single derivation that will
be needed during the installation is made available.

It is for sure a tricky business. If you have a look to the error line I
pasted above, you will see that the installer tries to build the ntp
package because the ntp-service-type is now included.

The following patch fixes the "gui-installed-os" test by making sure
that the ntp package is available in the installation environment. I did
not check for the other installation tests.

--8<---------------cut here---------------start------------->8---
diff --git a/gnu/tests/install.scm b/gnu/tests/install.scm
index b5263f5f0d..e9ebc63b64 100644
--- a/gnu/tests/install.scm
+++ b/gnu/tests/install.scm
@@ -1608,8 +1608,9 @@ build (current-guix) and then store a couple of full system images.")
     (swap-devices (if encrypted?
                       '()
                       (list (uuid "11111111-2222-3333-4444-123456789abc"))))
-    (services (cons (service dhcp-client-service-type)
-                    (operating-system-user-services %minimal-os-on-vda)))))
+    (services (cons* (service dhcp-client-service-type)
+                     (service ntp-service-type)
+                     (operating-system-user-services %minimal-os-on-vda)))))
 
 (define* (installation-target-desktop-os-for-gui-tests
           #:key (encrypted? #f))
--8<---------------cut here---------------end--------------->8---

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 21:44:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 17:44:46 2021
Received: from localhost ([127.0.0.1]:37958 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lkCwo-0004aA-OE
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 17:44:46 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:44887)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1lkCwm-0004Zv-HQ
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 17:44:45 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 67D7F5C0268;
 Fri, 21 May 2021 17:44:39 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Fri, 21 May 2021 17:44:39 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=hWdhPHlPfOVlFdvIj7DoY+qR
 hXpOx/YsuYdW8sLk1Z4=; b=uwaptQQvFV5iVMtw0TiIcZL3ZiDtwSaciVa1rYiN
 qCzH9yPcgBBAHVmRT7Su6TMPn+6vXMubeMrRvhmVJu8VIjY+mESq1OtQHVGWbE8s
 i54QP2BwV9bumHo/4aAUgxttiPXP159GKaUM8GDex1YmMpoIbGIJjyieDtkBHmB+
 sUI=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=hWdhPH
 lPfOVlFdvIj7DoY+qRhXpOx/YsuYdW8sLk1Z4=; b=dIt0LR4tiFyN2oO318s+9W
 jTieAqt/0HoEavdmvfw40bnkGS5Diz952HI8xALlHFMNAkGkCBu9xDtQQy9OABiY
 A5mQ4YQ5Yz1eYH7fJbFulYzdY3GA6143IOpp+ZYat8AnbqQvjAinIO7+sCcbPQB1
 xGJp/cwU1c/yjzPY16HjPAuOxGqPR2oY98Tt/e81obZVAlea8RsrZJhhc02b21dv
 mu9OF3fRPLzwTw3BuHNidwyvdOxrgduQuZftx88srDoCMSm+Gfp+kegUEtvZ+qqm
 teC9eNPHDuhnAqMCRBSmiXZFrq/OiAEyFc+a2+FSCv3w99UHGyJl7MPXH6cV6Tig
 ==
X-ME-Sender: <xms:xymoYBh-T4p2XmExtl-zJAQf7yjEjebevzfqhrzT_a3M0zwloPbs_g>
 <xme:xymoYGBcOKVdUKHbNY23Z_672IbGunL-Yxpum7koD3RfP9LoTeFb3r0Ltv16-IeuJ
 pgqa1mtgmDXcQ5Jbg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejgedgtddvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehgtderredttddvnecuhfhrohhmpefnvghoucfh
 rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth
 gvrhhnpedukeevgeetkeeltefgiedtjefgjeekffduteehvdfhueekudelieekjeefheff
 teenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd
 enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:xymoYBHt3Vv7r0GKFqVuav8D_qDAlylCCDu0NlbT-y5FAxJZBqHLvA>
 <xmx:xymoYGSiCg-D3UmjkQ3N-x5lc40B-0oIEZsmt9-LCtVrNlf77dgZ4g>
 <xmx:xymoYOzA4J0pVgZiOsI390kUK4QkeDTsnSKdFLdug-BFyagiqYTP5w>
 <xmx:xymoYDu7R7e7RBrgWoyjKu73ihqUAy0EA0_vT30sO7U7M3INhCfs2g>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA;
 Fri, 21 May 2021 17:44:39 -0400 (EDT)
Date: Fri, 21 May 2021 17:44:37 -0400
From: Leo Famulari <leo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YKgpxUpoZcU1IvPs@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
 <YKgfsIih02iFbR6o@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="c75BJIcHFU95R+h6"
Content-Disposition: inline
In-Reply-To: <YKgfsIih02iFbR6o@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--c75BJIcHFU95R+h6
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, May 21, 2021 at 05:01:36PM -0400, Leo Famulari wrote:
> I tried copying existing code, e.g. the choose-network-service?
> part of the tests.

The tests succeed when I amend the v4 patch to do "(choose-misc-service?
(const #f))" in (gnu installer tests).

I'm not really sure what it means :/

--c75BJIcHFU95R+h6
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCoKcUACgkQJkb6MLrK
fwgfvw/+IKIrxmjP/nRSn9pwy0XzRa7znPfm37IJXmuv5LfCvG05p2fkCsL4rN97
bBZJgY0Q5k1/T1PLRC8PmmRvEgkzmibwYn42HPkWsXng+DDnhptipUvvRvF74vqA
xnhV+R4D81oaox1bpwQd9aFJW0gOhXsMzz47t77RDSL1jxnYJK9LM7fBqKfIc3MU
KkaUofqZPs+8Xg5IkiHx2RZraqlhHeyijj+jtELoOQd6/3UCfcdY4Plqw29hYDNH
gmvdvufVIhBNFWvUJ96mFg7pgiJUSqL0M8AaKtUn6IdReQjreaPYPi+KwltPVoPg
scWRN6OlAxq8JItI8ghBM0V1RpNk5Ur/VlzDnxXtFdnU/ftlaTajAAtEIFjHAQdH
7UVCqbzTEfitzEXbmH1im93tv65Pce7Aouv9nqOq7QCvkd3WdfuhcYFsiEoSw42T
IeR9xtQDxdlqJe28lEowAUn1e/0KidhmhtL8mlndjbrMU+2R7iaVlZHfKloBKpi4
mTJBZDdiT3qzbrOWy1al6RREBD750W0BI5HzzRKnFj+JiVmv+ZFk7PvxnKwaukBa
6sku5SxO4y3nCANg72iI1snk0eUgbLurauNayFymsP+yXAfdGPr0M1G935V7EhBz
05b+KVw2UXnjUKAl9AOvdfORDf3c7vwfX/jsBW24QA14E9Sk1hM=
=2QD0
-----END PGP SIGNATURE-----

--c75BJIcHFU95R+h6--




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 21:01:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 17:01:50 2021
Received: from localhost ([127.0.0.1]:37872 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lkCHF-0003T9-M9
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 17:01:50 -0400
Received: from out3-smtp.messagingengine.com ([66.111.4.27]:60955)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1lkCHA-0003Sq-FA
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 17:01:47 -0400
Received: from compute6.internal (compute6.nyi.internal [10.202.2.46])
 by mailout.nyi.internal (Postfix) with ESMTP id 7BC195C0097;
 Fri, 21 May 2021 17:01:38 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute6.internal (MEProxy); Fri, 21 May 2021 17:01:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=K8gOh46n6CfCh2yqokan4D7q
 E715S4XI0Ui+TTKhbpE=; b=FsNjUIiDX0lgbp2qavGDCl+YkPsh9v3Ux6zA6VfD
 xorHg/Tt8adIW7PKtPEA9FyVx3Z6lwRcNwL7/Zq76vJMsCylSJWCyxymd6kito75
 xm06KgGFSNIPUv5V5IZD9AIqxpApTpsqDboz/rt7j5Gp63CfMRtCZGaer0mCktVj
 Of8=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=K8gOh4
 6n6CfCh2yqokan4D7qE715S4XI0Ui+TTKhbpE=; b=q0yweQqPHP09p+zokOVt1e
 qVq/MJ9wrLswa40el6HWIxE4U7m0AN58WNPBAMmaR5pxQz2DcLYEpgntsykAlKO6
 izZSBcqA7Et/tHZ12Obq98juU0JDzXrKdgzrOT0ZcjbiMhB7PJwvHno8DQJVscdm
 psGJEVBMdAZnieMEZE7AHKLc5JuiJKA0gW+dFD8IqCpWZvbKfhFiRZuZ0S46TVuD
 3Y3pnyrMzr9y8Pv2GSafjU92/AzYOblA9JR7iOQKnmTC08HxlVL9ASXwkK6w4dfu
 gNVxI8a/uqVPs7dWoUY+vIIt4YKUf9XWD2zbGj9+kEYaXCYLh9Jthi/D6SKuu/0g
 ==
X-ME-Sender: <xms:sh-oYH6sNpeSNxgG7Koc09fexjBwqzU2wFwZJnUdg8-nezryCiJUug>
 <xme:sh-oYM7BXhFxHnavzQHiNQliCgnz5Ap4GCvx-hqpf4vNSvqa9OfV05yRBlym9akE3
 XpSAW_dSW2cfFNXzg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgudehiecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggujgesghdtreertddtvdenucfhrhhomhepnfgvohcu
 hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth
 htvghrnhepudekveegteekleetgfeitdejgfejkeffudethedvhfeukeduleeikeejfeeh
 ffetnecukfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpe
 dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:sh-oYOfwv8xIRBlfBPtWum21QaQWqZ7yHuWy-sux8UySy4graX6wUQ>
 <xmx:sh-oYIKIAEyo2OOQdGxUN-v4XTFADFL2F3hLTCywNcclddR1zI_XrA>
 <xmx:sh-oYLKv-qY6TqEwtzMyVyi_Hb1FoeHyyS8j11eQMOl3cdhB1L--hQ>
 <xmx:sh-oYGkgIHygfI3nVjFzZ1Ki8yHQdG4vZLfNXVNbQ8R0m_MWgfm6pQ>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA;
 Fri, 21 May 2021 17:01:38 -0400 (EDT)
Date: Fri, 21 May 2021 17:01:36 -0400
From: Leo Famulari <leo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YKgfsIih02iFbR6o@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="QMnDj7+gJPBXmqal"
Content-Disposition: inline
In-Reply-To: <87lf88qm47.fsf_-_@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--QMnDj7+gJPBXmqal
Content-Type: multipart/mixed; boundary="M/5A9YxJzre/T287"
Content-Disposition: inline


--M/5A9YxJzre/T287
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
> Those patches are breaking the installer tests because they
> introduce a new dialog. You need to add something like:
>=20
> --8<---------------cut here---------------start------------->8---
>     ((checkbox-list (title "Miscellaneous services") (text _)
>                     (items ,services))
>      (filter choose-misc-service? services))
> --8<---------------cut here---------------end--------------->8---
>=20
> in the (gnu installer tests) module, to fix this error:

I started implementing this, in the attached v4 patch series.

I tried copying existing code, e.g. the choose-network-service?
part of the tests.

However, it now crashes in a different way when I do `guix environment
guix -- make check-system TESTS=3Dgui-installed-os -j1`:

------
[...]
building /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.dr=
v...
-builder for `/gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.=
xz.drv' failed to produce output path `/gnu/store/f99fblkzb6ip268sg096shhs7=
wzjyp55-Python-3.5.9.tar.xz'
build of /gnu/store/fr1m1ydzpylhm9psk4y9kavk8qb6maq5-Python-3.5.9.tar.xz.dr=
v failed
View build log at '/var/log/guix/drvs/fr/1m1ydzpylhm9psk4y9kavk8qb6maq5-Pyt=
hon-3.5.9.tar.xz.drv.bz2'.
cannot build derivation `/gnu/store/s7q1xs3mkld23v8541bvrzmq5j5xw5ad-Python=
-3.5.9.tar.xz.drv': 1 dependencies couldn't be built=20
building /gnu/store/1nnawddi9gw8k71figgphhrpn86dzsxl-activate-service.scm.d=
rv...
cannot build derivation `/gnu/store/l2f280iinh1hfp19k49r9vlhnbmbbss8-python=
-minimal-3.5.9.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/k43m6gi372wzwz0xir1axms8vp2jyv1c-glibc-=
2.31.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/20flyxbjjl8as5aca4gzf3b54as1gr9z-ntp-4.=
2.8p15.drv': 1 dependencies couldn't be built=20
cannot build derivation `/gnu/store/b1py4d1j3ym2k69zbzi0r3hh08afxkn9-shephe=
rd-ntpd.scm.drv': 1 dependencies couldn't be built=20
cannot build derivation `/gnu/store/mf7gj4cn0cb9ml3c4v1n1kg1293jjp57-shephe=
rd-ntpd.go.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/gs4kgf2x2syj64zf6s2r02sclffmf48n-shephe=
rd.conf.drv': 1 dependencies couldn't be built
cannot build derivation `/gnu/store/dy6w4vsvrxzsq9hg8pj7731k6p0z90cg-boot.d=
rv': 1 dependencies couldn't be built
building /gnu/store/15j31c7b2kc4hf03yxpqjsibgkyi40rv-module-import-compiled=
=2Edrv...
cannot build derivation `/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-system=
=2Edrv': 1 dependencies couldn't be built=20
guix system: error: build of `/gnu/store/5qkzfk7qmdnvhirsndj5n254y43yqgwz-s=
ystem.drv' failed
conversation expecting pCommand failed with exit code 1.          =20
                                                                           =
                    =20
Press Enter to continue.                                                   =
                    =20
attern ((quote installation-complete))                                     =
                    =20
May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been stopped=
=2E=20
May 21 22:47:26 localhost shepherd[1]: Service guix-daemon has been started=
=2E=20
May 21 22:47:27 localhost installer[219]: command ("guix" "system" "init" "=
--fallback" "--no-grafts" "--no-substitutes" "/mnt/etc/config.scm" "/mnt") =
failed with exit code 1                  =20
May 21 22:47:27 localhost installer[183]: unmounting "/mnt/"            =20
/gnu/store/5fwnbmlfq6bp37n94j36jdcfapm0mhbz-shepherd-marionette.scm:1:1718:=
 ERROR:                                                                    =
                                         =20
  1. &pattern-not-matched:                                                 =
                    =20
      pattern: ((quote installation-complete))                             =
                    =20
      sexp: (installation-failure)                                         =
                    =20
Backtrace:                                                                 =
                    =20
           2 (primitive-load "/gnu/store/gpxpcz96pdckj3a69q5cjzxaxq5?")    =
                  =20
In ice-9/eval.scm:                                                         =
                    =20
   191:35  1 (_ #f)                                                        =
                    =20
    619:8  0 (_ #(#<directory (guile-user) 7fffefbabf00> #<variabl?>))

ice-9/eval.scm:619:8: Throw to key `marionette-eval-failure' with args `((q=
uote (complete-installation installer-socket)))'.
note: keeping build directory `/tmp/guix-build-installation.drv-8'
builder for `/gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv' =
failed with exit code 1
build of /gnu/store/nphpbnbm3z6xaq8fvl91ihh66n9hhm9m-installation.drv failed
View build log at '/var/log/guix/drvs/np/hpbnbm3z6xaq8fvl91ihh66n9hhm9m-ins=
tallation.drv.gz'.
cannot build derivation `/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gui-in=
stalled-os.drv': 1 dependencies couldn't be built
guix build: error: build of `/gnu/store/50jjjmr51ml9p3qqd5f3kcpbjglmfv4s-gu=
i-installed-os.drv' failed
make: *** [Makefile:6859: check-system] Error 1
------

I'm a little lost...

--M/5A9YxJzre/T287
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: attachment;
	filename*0="v4-installer-Recommend-ntp-service-for-non-graphical-systems.";
	filename*1=patch
Content-Transfer-Encoding: quoted-printable

=46rom ef1dfe36130fa276ce1b2a4213cde14d649bfbf8 Mon Sep 17 00:00:00 2001
=46rom: Leo Famulari <leo@HIDDEN>
Date: Fri, 23 Apr 2021 14:50:15 -0400
Subject: [PATCH v4 1/2] installer: Recommend 'ntp-service-type' for
 non-graphical systems.

We had several bug reports with a root cause of "the clock was
incorrect" from users who used the installer to install a non-graphical
Guix System.

* gnu/installer/services.scm (%system-services): Add the ntp-service-type.
* gnu/installer/newt/services.scm (run-system-administration-cbt-page): New
variable.
(run-services-page): Use run-system-administration-cbt-page when not
installing a desktop.
* gnu/installer/tests.scm (choose-services): Add and use a
choose-misc-service?  procedure.
---
 gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++-
 gnu/installer/services.scm      |  8 ++++++++
 gnu/installer/tests.scm         | 11 +++++++++--
 3 files changed, 39 insertions(+), 3 deletions(-)

diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.=
scm
index 74f28e41ba..ee003b24b1 100644
--- a/gnu/installer/newt/services.scm
+++ b/gnu/installer/newt/services.scm
@@ -3,6 +3,7 @@
 ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s <ludo@HIDDEN>
 ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
 ;;; Copyright =A9 2021 Tobias Geerinckx-Rice <me@HIDDEN>
+;;; Copyright =A9 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,6 +69,25 @@ system.")
         (condition
          (&installer-step-abort)))))))
=20
+(define (run-system-administration-cbt-page)
+  "Run a page to select various system adminstration services."
+  (let ((items (filter (lambda (service)
+                         (eq? 'administration
+                              (system-service-type service)))
+                       %system-services)))
+    (run-checkbox-tree-page
+      #:title (G_ "Miscellaneous services")
+      #:info-text (G_ "Select miscellaneous services to run on your system=
=2E")
+      #:items items
+      #:selection (map system-service-recommended? items)
+      #:item->text (compose G_ system-service-name)
+      #:checkbox-tree-height 5
+      #:exit-button-callback-procedure
+      (lambda ()
+        (raise
+          (condition
+            (&installer-step-abort)))))))
+
 (define (run-network-management-page)
   "Run a page to select among several network management methods."
   (let ((title (G_ "Network management")))
@@ -99,5 +119,6 @@ client may be enough for a server.")
     (append desktop
             (run-networking-cbt-page)
             (if (null? desktop)
-                (list (run-network-management-page))
+                (cons (run-network-management-page)
+                      (run-system-administration-cbt-page))
                 '()))))
diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index ec5ea30594..1dae40daec 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -2,6 +2,7 @@
 ;;; Copyright =A9 2018 Mathieu Othacehe <m.othacehe@HIDDEN>
 ;;; Copyright =A9 2019 Ludovic Court=E8s <ludo@HIDDEN>
 ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
+;;; Copyright =A9 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -104,6 +105,13 @@
       (packages '((specification->package "nss-certs")))
       (recommended? #t))
=20
+     ;; Miscellaneous system administration services.
+     (system-service
+       (name (G_ "Network time service (NTP), to set the clock automatical=
ly"))
+       (type 'administration)
+       (recommended? #t)
+       (snippet '((service ntp-service-type))))
+
      ;; Network connectivity management.
      (system-service
       (name (G_ "NetworkManager network connection manager"))
diff --git a/gnu/installer/tests.scm b/gnu/installer/tests.scm
index 8ccd327a7c..7a4989ef88 100644
--- a/gnu/installer/tests.scm
+++ b/gnu/installer/tests.scm
@@ -220,7 +220,11 @@ ROOT-PASSWORD, and USERS."
                                  (string-contains service "NSS"))))
                           (choose-network-management-tool?
                            (lambda (service)
-                             (string-contains service "DHCP"))))
+                             (string-contains service "DHCP")))
+                          (choose-misc-service?
+                           (lambda (service)
+                             (string-contains service "NTP"))))
+
   "Converse over PORT to choose networking services."
   (define desktop-environments '())
=20
@@ -240,7 +244,10 @@ ROOT-PASSWORD, and USERS."
                      (multiple-choices? #f)
                      (items ,services))
      (null? desktop-environments)
-     (find choose-network-management-tool? services))))
+     (find choose-network-management-tool? services))
+    ((checkbox-list (title "Miscellaneous services") (text _)
+                     (items ,services))
+     (filter choose-misc-service? services))))
=20
 (define (edit-configuration-file file)
   "Edit FILE, an operating system configuration file generated by the
--=20
2.31.1


=46rom 8fa2cd50e36835358c0533ded36674d5499b76fe Mon Sep 17 00:00:00 2001
=46rom: Leo Famulari <leo@HIDDEN>
Date: Fri, 23 Apr 2021 20:42:28 -0400
Subject: [PATCH v4 2/2] installer: Offer 'gpm-service-type' for non-graphic=
al
 systems.

* gnu/installer/services.scm (%system-services): Add the gpm-service-type.
---
 gnu/installer/services.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index 1dae40daec..91b22c6f19 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -111,6 +111,10 @@
        (type 'administration)
        (recommended? #t)
        (snippet '((service ntp-service-type))))
+     (system-service
+       (name (G_ "GPM mouse daemon, to use the mouse in the console"))
+       (type 'administration)
+       (snippet '((service gpm-service-type))))
=20
      ;; Network connectivity management.
      (system-service
--=20
2.31.1


--M/5A9YxJzre/T287--

--QMnDj7+gJPBXmqal
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCoH6kACgkQJkb6MLrK
fwhtUA//SbL8Bvwk6597+T4davhVCnn2B3aGGdEog14jLZAKJaD7bvOcaj/S2yYo
QX1eQdaiYPJZbxYGx3DsgpqU4urlGb10XQGAhU6GGZs0yTYD8Ez0VLoNfMxL/1Oh
D8mNmE+EN/1e7mgl+n7QubQWvb0p2k9VVKly3WGwLITc9ZNCPlD947zu8GC1ILp2
6KLqtDF9mQs0Aa6tkcPtr13dxg5sad5i9AeQzCIB9CpN96XCZgP0/xrSYMmKkCIy
Vk5PC3yQ/gkf2SMx/kd+hEq5dvP/2MapAA5Fot3DaLGqQbi4AD1IbobJXPc6VfDQ
DsxoxjBkfRJ7FNf+BdPanMR7zkV/SgNf/r4dY4+t5U8hhVcN9qdXbYDJaOyt+k3h
T6gb3ETRTgUILPzb3VUS5AS6DKwTO0kvHgvB5lauSf7c/WLdJ74DVY4JNd62DjBr
KLB6ukoQ/JzeB6htlGgJZp7o8YxyibfjtX8aEsbtZ5lKzDs8S5kIPUB0QytcPeOK
rV3qDhrzOpgEbe85YVimvtbsTGoQzjLDfyXVAEXCCJqx1nlSepIglDQBSHdwylfL
DKRVOUukFTtEuu1LJ1FEhzSEpZxNrJFnxhy8f6NgIqgib0gBlWEDJoABQWqN8CjX
M9Wt8CTqvkssAzEasnciuG3MKkirpEQDjA/h+6dWDPW/4ilQyog=
=ZZo3
-----END PGP SIGNATURE-----

--QMnDj7+gJPBXmqal--




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 14:39:50 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 10:39:50 2021
Received: from localhost ([127.0.0.1]:37366 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lk6Ja-0005u9-0K
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 10:39:50 -0400
Received: from eggs.gnu.org ([209.51.188.92]:53120)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1lk6JW-0005tu-Fo
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 10:39:48 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:45516)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1lk6JR-0006dt-9B; Fri, 21 May 2021 10:39:41 -0400
Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=51890 helo=meije)
 by fencepost.gnu.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1lk6JQ-000139-RT; Fri, 21 May 2021 10:39:41 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Leo Famulari <leo@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
 <YKfB/hBQUwLPrWci@HIDDEN>
Date: Fri, 21 May 2021 16:39:39 +0200
In-Reply-To: <YKfB/hBQUwLPrWci@HIDDEN> (Leo Famulari's message of "Fri,
 21 May 2021 10:21:50 -0400")
Message-ID: <875yzcqhg4.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


> How do I run this test? I can never figure out the names of the tests
> used by `make check-system`...

The installer tests are defined in the (gnu tests install) module. You
can then search for "%test-gui" for all the graphical installation
tests.

You can run all of them by typing:

--8<---------------cut here---------------start------------->8---
make check-system TESTS="gui-installed-os gui-uefi-installed-os
gui-installed-os-encrypted gui-installed-desktop-os-encrypted"
--8<---------------cut here---------------end--------------->8---

Fixing the "gui-installed-os" test should be enough to fix all of them
though.

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 14:26:12 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 10:26:12 2021
Received: from localhost ([127.0.0.1]:37347 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lk66O-0005Yc-1D
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 10:26:12 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:40767)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1lk66L-0005YO-Hn
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 10:26:10 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id 786C35C013A;
 Fri, 21 May 2021 10:26:04 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Fri, 21 May 2021 10:26:04 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=MaDnaj3xHh95buBiAOq8pGGs
 lkjOH6s3RUzya82lzSw=; b=r7JzDchOBdJNQUcxVJfUXnuSoTjHYBCEWnQ2IVHV
 Nwog+Vxb8DZFU7PHy4tDlYIb7ThYgJ4A52qaTHDFxjEW7R/M3EGqTn2p1uEdtm1K
 YlDoaHhw+zMQ7sFMknKYcIwFAupvMSsW9oki0Z0FMc8r7gSg+fpIMLouHzFYWNVI
 Axo=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=MaDnaj
 3xHh95buBiAOq8pGGslkjOH6s3RUzya82lzSw=; b=Rm5BtIUH6eSiT2JB0g0Fga
 dIAZBbfu8+UYMrHGTQnvMK0k5AmHbW/ntCQjPJEK5+I9vSbrD6ugJYjRHiXdlXF1
 vIUmpW0Ak9AU86+t+kT+552MZ6KEQ1WxBbL8Z03eN18n0rxePzmLEXGXhtOAtQ5t
 iYUhCo6WCj11C8AbOr/nCbBf0yR3VJcguUEUTo3Q9ZDHs8O91X3UqCTUhwyeOIb8
 8ah4xunemr5SX1e8wdVUz8DlYt0jS0lwPu8N1DMx5ujbQBc1X3RyP669PMPq0wWO
 1pbVfgH5ZIfOfDCaIJvy+MSphazE3MTxjzkh0nLwD34Ev2qcRcHZ2u+lpiWUgjLg
 ==
X-ME-Sender: <xms:_MKnYEitKX_3_UMzFOy-xc2RKT5khauwxqMY7qtBVQ7_E-bmcwWr_Q>
 <xme:_MKnYNCTwwzfMtd4fK21N1hhDP7myrhKiBrU-RGT8IRubT4pm_g56zKgr7CzjYFga
 sy6JeMh586EBbuHGw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgjeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh
 rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth
 gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev
 gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd
 enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:_MKnYMEnM8ELMawT-n_FungeMpE3EFWNV4XDZ5Shd_T_bb_c-MIwfw>
 <xmx:_MKnYFS_ToH8wA8U5FSsn5G_TJUIP7RvheFRti5nrimEDiJaJi1dAg>
 <xmx:_MKnYByzIETQQgMayUKQbyT07gY02OmAdIiBkcvPR3NXCC3PnuvvjA>
 <xmx:_MKnYKtw2Br4KBOiPXydTaMe8bsxXMnOp62pe_j-mvI5ChrkcDCEng>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA;
 Fri, 21 May 2021 10:26:04 -0400 (EDT)
Date: Fri, 21 May 2021 10:26:02 -0400
From: Leo Famulari <leo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YKfC+mRQMycoW/4d@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
 <YKfB/hBQUwLPrWci@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YKfB/hBQUwLPrWci@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Fri, May 21, 2021 at 10:21:50AM -0400, Leo Famulari wrote:
> On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
> > Those patches are breaking the installer tests because they
> > introduce a new dialog. You need to add something like:
> > 
> > --8<---------------cut here---------------start------------->8---
> >     ((checkbox-list (title "Miscellaneous services") (text _)
> >                     (items ,services))
> >      (filter choose-misc-service? services))
> > --8<---------------cut here---------------end--------------->8---
> > 
> > in the (gnu installer tests) module, to fix this error:
> 
> How do I run this test? I can never figure out the names of the tests
> used by `make check-system`...

With informed use of grep I found it:

`make check-system TESTS=iso-image-installer`.




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 14:22:04 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 10:22:04 2021
Received: from localhost ([127.0.0.1]:37331 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lk62O-0005Rj-Fu
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 10:22:04 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:52233)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1lk62I-0005R7-AG
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 10:22:02 -0400
Received: from compute4.internal (compute4.nyi.internal [10.202.2.44])
 by mailout.nyi.internal (Postfix) with ESMTP id 234885C00E3;
 Fri, 21 May 2021 10:21:53 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute4.internal (MEProxy); Fri, 21 May 2021 10:21:53 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=+x9ToePeom6NI8RZLtXZw7Vs
 cKyQCZgQ33CXDnrOa18=; b=uD5YL8n0NEAzEMZDqfcIRH++o9hdpkNG4KlWoOoV
 KyqIvZzOe99btUqfA5YyHogX/HUFba6ZO7aXeqaedTR5t5JIai9yMnsI5j1mGeWD
 ToFVho2n3IGfCtt5Dz+2ufY9GJMUDxgbFLy1ZnTHXSQrqguNt9/BW89U4JOP1mLb
 4t0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=+x9Toe
 Peom6NI8RZLtXZw7VscKyQCZgQ33CXDnrOa18=; b=q6ihuvmWQmNIyohbRD3dw0
 g2zOk/zRNQfVx6JbuDFtwmMQn+fEed1CjDHt2LWFrHdiItPbRQ5r0+5XPi+/Ocse
 j4vrczOHyvE0+CI3UlmKMxwZh348DJr5uxWhQjz6gIKl3mkhOUv178ssT560OUoE
 vGmzAiarwkKSs02GsLbcQBkOYAy0Q4nvOnnggkumqpw41bU1UcitubnUDIYFQnh3
 VrKdbKx6cv+pBbRDyiDr6+7e2a9Esp+Vz7PeBvK14nZs+TPoNZMkSzeYMK3JWOBm
 lEqifCWnZbE/AHbypExkiopCz54FJqxHT2j1J4qhBr7gAuQ9zHixEhHWewEEOelw
 ==
X-ME-Sender: <xms:AMKnYO82aysxBdRMuddC_rX1wVe1CiU84iHGJUtRP0zvMmvSQGRx7Q>
 <xme:AMKnYOs5S_7ik4gEKBv_9UeZwfg68WGBJ-li4KVBZAA-357YCV3Mr5IrAj3dk1_cD
 rKIuhDmSsoeF3x2xA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgjeeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh
 rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth
 gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev
 gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd
 enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:AMKnYEAjFQLAFbPgfc5b9KY3TIjnn7kYBTdP4tB_TZ84-lnubfbepA>
 <xmx:AMKnYGfujiTtwB0AzI5asCN4Sc219hjelyjPXdpNTXYWytEuf7GYSw>
 <xmx:AMKnYDPQQ1BU3Cl9yP7MIgMrw3c5u9KxMT0q2ykaIoYDWEuDjFZVDw>
 <xmx:AcKnYCafZkTsFJblrg4VMt75HqKU8Lcjfu9yqgj-yKC1ItZQZDxLDA>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA;
 Fri, 21 May 2021 10:21:52 -0400 (EDT)
Date: Fri, 21 May 2021 10:21:50 -0400
From: Leo Famulari <leo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YKfB/hBQUwLPrWci@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87lf88qm47.fsf_-_@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
> Those patches are breaking the installer tests because they
> introduce a new dialog. You need to add something like:
> 
> --8<---------------cut here---------------start------------->8---
>     ((checkbox-list (title "Miscellaneous services") (text _)
>                     (items ,services))
>      (filter choose-misc-service? services))
> --8<---------------cut here---------------end--------------->8---
> 
> in the (gnu installer tests) module, to fix this error:

How do I run this test? I can never figure out the names of the tests
used by `make check-system`...




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 13:37:20 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 09:37:20 2021
Received: from localhost ([127.0.0.1]:36070 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lk5L5-0001t0-FI
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 09:37:19 -0400
Received: from out5-smtp.messagingengine.com ([66.111.4.29]:56413)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1lk5L3-0001so-Vv
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 09:37:18 -0400
Received: from compute5.internal (compute5.nyi.internal [10.202.2.45])
 by mailout.nyi.internal (Postfix) with ESMTP id B41415C00D7;
 Fri, 21 May 2021 09:37:12 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute5.internal (MEProxy); Fri, 21 May 2021 09:37:12 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=/BBDIU1GogR5BIWL8KYGK5Ks
 arMizOQq4sjoQX99CT4=; b=AJcGdRuIiUHafuVR2lhPuiY2dz0WmswH/ua7e3lk
 rqYOC0C46BCBU/2JAWv4E5aCTFXMoVbobOHlVIZ7zco/QbkEQIdWyMVA8skl0AeU
 wIlT8IX2quoKhfjHlrMv3PZ9E58IGIVADJ8lLA3w3cB0gQqowtsKyDS9Ci4mrGyK
 kj0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=/BBDIU
 1GogR5BIWL8KYGK5KsarMizOQq4sjoQX99CT4=; b=GQgLRi4kYn7lTY3QsmZlmw
 YvO4c6rrL03csXMTo4yvKyUgdqp1RUzlGFL4JCHZjcnj7OkNY90gL6/icnf7ZWpg
 TU1yn7tzNDw4S4697lxtKycJhoPVhWGg+OO4Lrp/ozQGyzPvmwGrtwNzCYxIvnDR
 xSnFBvc3cc28W+UjU9MQYQiL1ys0r0dM6C66ZRhr/bPgK49y4qEGrzetHL9Fd5yV
 CU7f9xd2ZmMuvjqQsoBJsYP8cpNPnAAd1IzWxcKioOYC2fRrAkEmDNLC5TB/4le4
 cwyhN6DvYMRIThHp5LZjDhDid3fVhqmnalC4NGz3ATTsVTJ58MIJX18RcmtqUpAQ
 ==
X-ME-Sender: <xms:iLenYIG9ib9NvIGXbq2YI_a2u8MltObS4_rEgNjOoE1reG-0nIu-rA>
 <xme:iLenYBWyySaiAYTMOc-heiAXFUjL8midsiq3PIx6SZjrfP8w8sx8wvW4TaBCgsZMl
 YOYDRYgmFGdVliHcA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdejfedgieejucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne
 cujfgurhepfffhvffukfhfgggtuggjsehttdertddttddvnecuhfhrohhmpefnvghoucfh
 rghmuhhlrghrihcuoehlvghosehfrghmuhhlrghrihdrnhgrmhgvqeenucggtffrrghtth
 gvrhhnpeeukeektdffvddtudegjeegtdevhfeufeeivdejiedtieegtdevjedvjeehffev
 gfenucfkphepuddttddruddurdduieelrdduudeknecuvehluhhsthgvrhfuihiivgeptd
 enucfrrghrrghmpehmrghilhhfrhhomheplhgvohesfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:iLenYCIJnBJqdX-YeHQhVEzLUuYtVfTnZ1R-N0D54EqKsc92m-4Rmw>
 <xmx:iLenYKHb30h8bM8P5UmtH8GsgI5g00gRaoGuAxSNnYNspzUUkEaXsA>
 <xmx:iLenYOXtUnmue9jcj3n2gmW9HBABzcnGJ_MN79Xm03OeR8hRM2YB_w>
 <xmx:iLenYJAyaH1Oy2fNhSX7LtCbte-KaWDWK5Z4iLGQAYF7jR3gt-E1lw>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118]) by mail.messagingengine.com (Postfix) with ESMTPA;
 Fri, 21 May 2021 09:37:12 -0400 (EDT)
Date: Fri, 21 May 2021 09:37:10 -0400
From: Leo Famulari <leo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YKe3hmapmNSvhemn@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <87lf88qm47.fsf_-_@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87lf88qm47.fsf_-_@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

Thanks for the review.

On Fri, May 21, 2021 at 02:58:48PM +0200, Mathieu Othacehe wrote:
> > +(define (run-system-administration-cbt-page)
> > +  "Run a page to select various system adminstration services."
> > +  (let ((items (filter (lambda (service)
> > +                         (eq? 'administration
> > +                              (system-service-type service)))
> > +                       %system-services)))
> > +    (run-checkbox-tree-page
> > +      #:title (G_ "Miscellaneous services")
> > +      #:info-text (G_ "Select miscellaneous services to run on your system.")
> > +      #:items items
> > +      #:selection (map system-service-recommended? items)
> > +      #:item->text (compose G_ system-service-name)
> > +      #:checkbox-tree-height 5
> > +      #:exit-button-callback-procedure
> > +      (lambda ()
> > +        (raise
> > +          (condition
> > +            (&installer-step-abort)))))))
> 
> Indentation is off here, 
> 
> > +     ;; Miscellaneous system administration services.
> > +     (system-service
> > +       (name (G_ "Network time service, to set the clock automatically"))
> > +       (type 'administration)
> > +       (recommended? #t)
> > +       (snippet '((service ntp-service-type))))
> > +
> 
> here, 
> 
> > +     (system-service
> > +       (name (G_ "GPM mouse daemon, to use the mouse in the console"))
> > +       (type 'administration)
> > +       (snippet '((service gpm-service-type))))
> 
> and here.

I don't see the problems. I copied from existing pieces of similar code
and I don't really have a sense of what's right and wrong for indenting
this kind of thing.

> Those patches are breaking the installer tests because they
> introduce a new dialog. You need to add something like:
> 
> --8<---------------cut here---------------start------------->8---
>     ((checkbox-list (title "Miscellaneous services") (text _)
>                     (items ,services))
>      (filter choose-misc-service? services))
> --8<---------------cut here---------------end--------------->8---
> 
> in the (gnu installer tests) module, to fix this error:

Okay, I'll work on that.




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 21 May 2021 12:59:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri May 21 08:59:03 2021
Received: from localhost ([127.0.0.1]:36028 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1lk4k2-0000wx-Pr
	for submit <at> debbugs.gnu.org; Fri, 21 May 2021 08:59:03 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60086)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1lk4jx-0000wQ-Po
 for 47979 <at> debbugs.gnu.org; Fri, 21 May 2021 08:59:01 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:40394)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1lk4js-0000Hf-6d; Fri, 21 May 2021 08:58:52 -0400
Received: from [2a01:e0a:19b:d9a0:f2f7:a404:c3d3:f8b4] (port=49936 helo=meije)
 by fencepost.gnu.org with esmtpsa
 (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1lk4jp-00080W-E1; Fri, 21 May 2021 08:58:52 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Leo Famulari <leo@HIDDEN>
Subject: Re: bug#47979: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN>
Date: Fri, 21 May 2021 14:58:48 +0200
In-Reply-To: <YINsy8LNhQd4NYmq@HIDDEN> (Leo Famulari's message of "Fri,
 23 Apr 2021 20:56:43 -0400")
Message-ID: <87lf88qm47.fsf_-_@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey Leo,

> +(define (run-system-administration-cbt-page)
> +  "Run a page to select various system adminstration services."
> +  (let ((items (filter (lambda (service)
> +                         (eq? 'administration
> +                              (system-service-type service)))
> +                       %system-services)))
> +    (run-checkbox-tree-page
> +      #:title (G_ "Miscellaneous services")
> +      #:info-text (G_ "Select miscellaneous services to run on your system.")
> +      #:items items
> +      #:selection (map system-service-recommended? items)
> +      #:item->text (compose G_ system-service-name)
> +      #:checkbox-tree-height 5
> +      #:exit-button-callback-procedure
> +      (lambda ()
> +        (raise
> +          (condition
> +            (&installer-step-abort)))))))

Indentation is off here, 

> +     ;; Miscellaneous system administration services.
> +     (system-service
> +       (name (G_ "Network time service, to set the clock automatically"))
> +       (type 'administration)
> +       (recommended? #t)
> +       (snippet '((service ntp-service-type))))
> +

here, 

> +     (system-service
> +       (name (G_ "GPM mouse daemon, to use the mouse in the console"))
> +       (type 'administration)
> +       (snippet '((service gpm-service-type))))

and here. Those patches are breaking the installer tests because they
introduce a new dialog. You need to add something like:

--8<---------------cut here---------------start------------->8---
    ((checkbox-list (title "Miscellaneous services") (text _)
                    (items ,services))
     (filter choose-misc-service? services))
--8<---------------cut here---------------end--------------->8---

in the (gnu installer tests) module, to fix this error:

--8<---------------cut here---------------start------------->8---
conversation expecting pattern ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))
/gnu/store/h38i2hvaqy9bd0sbn9isdfzl7m56mngr-shepherd-marionette.scm:1:1718: ERROR:
  1. &pattern-not-matched:
      pattern: ((quote list-selection) ((quote title) "Partitioning method") ((quote multiple-choices?) #f) ((quote items) (not-encrypted encrypted _ ...)))
      sexp: (checkbox-list (title "Miscellaneous services") (text "Select miscellaneous services to run on your system.") (items ("Network time service, to set the clock automatically" "GPM mouse daemon, to use the mouse in the console")))
May 21 14:53:11 localhost instaBacktrace:
ller[180]: running form #<newt-form 79dc20> ("Miscellaneous services") with 1 clients 
           2 (primitive-load "/gnu/store/9vzfy688gawwn2p06nn75kiqqz3?")
In ice-9/eval.scm:
   191:35  1 (_ #f)
    619:8  0 (_ #(#<directory (guile-user) 7ffff3bb3f00> #<variabl?>))
--8<---------------cut here---------------end--------------->8---

Otherwise, it looks fine :)

Thanks,

Mathieu




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 2 May 2021 15:22:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 02 11:22:23 2021
Received: from localhost ([127.0.0.1]:43295 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ldDvL-00043q-8A
	for submit <at> debbugs.gnu.org; Sun, 02 May 2021 11:22:23 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:47115)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1ldDvH-00043j-Ib
 for 47979 <at> debbugs.gnu.org; Sun, 02 May 2021 11:22:21 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 7A5065C00EE;
 Sun,  2 May 2021 11:22:13 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Sun, 02 May 2021 11:22:13 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:cc:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=n2T/4+fcvuzXbHSk7q9IIpKt
 JnyfOVInGLxioXeCWVU=; b=q0bprp9wp9PAsyL7ODLIhj31qpASCW0mvSS90Nzr
 RslBla4Y+2DCZudfm03b1x82siSR3eTNiaf6+4kbLCIEa+PSKjbRiq3N32TPkrZW
 VK2/PClVFThrbaVCjVaFK5bdE5xyNW31P8A7aNdLIIOyWobaRcqhXS9cokKcqMPi
 I9w=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=cc:content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=n2T/4+
 fcvuzXbHSk7q9IIpKtJnyfOVInGLxioXeCWVU=; b=Ix/fKqrmnwnStjzpTy5Kh8
 2Yy5bBv8dDIJrsD07saUNqYTGHLslRW6NAU9oJsuVLGNjCtLEryxc/7J1oLL+kkk
 lVXJkJQWmJtCpDZFABNl3WT5MSZV68lqKq4PJaHwYUU5dDrp3Qa187NF3Av99KIX
 rZyArHy/vCYlOLln0puMJC/Jl+Fd2dCFQZT2e7gRlDa1D4vr5vYAQQxzZq/Gm6KV
 3zKAIEaogkVOXlK7FN4l/fvtFJ1fWXVm7EkSyNdILERE+dkQOjCA/0dZx3HRRFEO
 7LC45itkvCZZ7B2AOOmORvmuMKqZnA39sfilFH/3p1gUBxRwk4n5ciX9j7/gv7Mg
 ==
X-ME-Sender: <xms:pcOOYMtQUJ_-DsillrxtAcFfiMR5iQMPmV4GtoVxbCZ75j5i1nWuHA>
 <xme:pcOOYJfk4sqGuqP7yVat271cXkZ-STsK9zgf4bbih2nrVjcXNOcJ8rHioHtJmRJQ2
 tr472hsXhNiw7c4fg>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefuddgudefkecutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd
 enucfjughrpeffhffvuffkfhggtggujgesthdtredttddtvdenucfhrhhomhepnfgvohcu
 hfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgrrhhirdhnrghmvgeqnecuggftrfgrth
 htvghrnhepueekkedtffdvtddugeejgedtvefhueefiedvjeeitdeigedtveejvdejheff
 vefgnecukfhppeduiedvrddvudejrdeffedrudduvdenucevlhhushhtvghrufhiiigvpe
 dunecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:pcOOYHxWj-A3L1i8cyE_NgRKna2-w5zwMnInUx4Ea5ENe5pfEsNzfQ>
 <xmx:pcOOYPOm7usvDMNsAPBhX7uW_hqDhKm96H9C3eZFOmxdaDP5nij5Zg>
 <xmx:pcOOYM8r47yrRtoH1l0qb2hceXeNIapOy6NYc5lScj24LHxm1iLJ1g>
 <xmx:pcOOYFJz0FWuUJOWlMzOgUVcUG7Fc4bHzt83WLvQfCvvYUfZyysUww>
Received: from localhost (d-162-217-33-112.ct.cpe.atlanticbb.net
 [162.217.33.112]) by mail.messagingengine.com (Postfix) with ESMTPA;
 Sun,  2 May 2021 11:22:13 -0400 (EDT)
Date: Sun, 2 May 2021 11:22:11 -0400
From: Leo Famulari <leo@HIDDEN>
To: Mathieu Othacehe <othacehe@HIDDEN>
Subject: Re: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type'
 for non-graphical systems.
Message-ID: <YI7Do9YQ7+gAsuh2@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <YI4sPu8mD8UKwG9d@HIDDEN>
 <87sg351o9a.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87sg351o9a.fsf@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Sun, May 02, 2021 at 11:25:05AM +0200, Mathieu Othacehe wrote:
> 
> Hey Leo,
> 
> > I suppose it's too late for 1.3.0, due to the string freeze.
> 
> It looks rather nice, but I'll test it more thoroughly after the
> release. Did you make sure that the installer tests are passing with:
> 
> make check-system TESTS="gui-installed-os gui-uefi-installed-os
> gui-installed-os-encrypted gui-installed-desktop-os-encrypted"

I tested it on "bare metal", but I will run the systems tests, too.




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 2 May 2021 09:25:25 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 02 05:25:25 2021
Received: from localhost ([127.0.0.1]:41777 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ld8Lt-0004kI-1M
	for submit <at> debbugs.gnu.org; Sun, 02 May 2021 05:25:25 -0400
Received: from eggs.gnu.org ([209.51.188.92]:60240)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <othacehe@HIDDEN>) id 1ld8Lr-0004kC-Am
 for 47979 <at> debbugs.gnu.org; Sun, 02 May 2021 05:25:23 -0400
Received: from fencepost.gnu.org ([2001:470:142:3::e]:58412)
 by eggs.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <othacehe@HIDDEN>)
 id 1ld8Lm-0007Wo-0a; Sun, 02 May 2021 05:25:18 -0400
Received: from [2a01:e0a:19b:d9a0:9576:8bbf:4795:82ee] (port=52506 helo=meije)
 by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256)
 (Exim 4.82) (envelope-from <othacehe@HIDDEN>)
 id 1ld8La-0002uQ-LZ; Sun, 02 May 2021 05:25:15 -0400
From: Mathieu Othacehe <othacehe@HIDDEN>
To: Leo Famulari <leo@HIDDEN>
Subject: Re: [bug#47979] [PATCH v3] installer: Recommend 'ntp-service-type'
 for non-graphical systems.
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN> <YI4sPu8mD8UKwG9d@HIDDEN>
Date: Sun, 02 May 2021 11:25:05 +0200
In-Reply-To: <YI4sPu8mD8UKwG9d@HIDDEN> (Leo Famulari's message of "Sun, 2
 May 2021 00:36:14 -0400")
Message-ID: <87sg351o9a.fsf@HIDDEN>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.2 (gnu/linux)
MIME-Version: 1.0
Content-Type: text/plain
X-Spam-Score: -2.3 (--)
X-Debbugs-Envelope-To: 47979
Cc: 47979 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -3.3 (---)


Hey Leo,

> I suppose it's too late for 1.3.0, due to the string freeze.

It looks rather nice, but I'll test it more thoroughly after the
release. Did you make sure that the installer tests are passing with:

make check-system TESTS="gui-installed-os gui-uefi-installed-os
gui-installed-os-encrypted gui-installed-desktop-os-encrypted"

Thanks,

Mathieu





Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 2 May 2021 04:36:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sun May 02 00:36:23 2021
Received: from localhost ([127.0.0.1]:40277 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1ld3qB-00017p-K4
	for submit <at> debbugs.gnu.org; Sun, 02 May 2021 00:36:23 -0400
Received: from out1-smtp.messagingengine.com ([66.111.4.25]:33301)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1ld3qA-00017h-3T
 for 47979 <at> debbugs.gnu.org; Sun, 02 May 2021 00:36:22 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.nyi.internal (Postfix) with ESMTP id 075A25C0068;
 Sun,  2 May 2021 00:36:17 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Sun, 02 May 2021 00:36:17 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=zdwX6918hI3ED4fnjf3NVADg
 xzIYMQipvYas7pW9R+8=; b=WRUmXM2fXlj97bV9NCHzl4rMSr2WSE/BS7lNokyY
 eMM+jZajQ9mGEi5Kb2dfkP00No3Fa8Ft0Xxx8z32BqevxAQSqyUB3ewqgTkWsyLL
 U+Ef35WSrm/20vLIx1u13e6+FmrrL3OpbQJaHK6qfcBb2tSvNYqfiq3lRmXE/AqD
 8zY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=zdwX69
 18hI3ED4fnjf3NVADgxzIYMQipvYas7pW9R+8=; b=j4L7gmDLvwSxeAVs5nBhcL
 wa+CMxhHlQZjZxN/XO9WZs/+Lt2P5+0+xbUDYw9X1ecabfTa4OziZ7w1BCHv2s8K
 LRGRv/3jpGvPT3+A/m0mI2lTF1+9Am6xFhFQ+GJlJ/m1eyboPosL5sMfZsD2E7ml
 hv9yvQsISyOpL/HtbgLEgCbHnnfv5jE99d7D0WRZhw4yzLWxivyYElI6UKWtnWIL
 CDzgkLOmJk0pLMmTf/7TjNpmoNqnEe3aITv9U777U5qL3g71WshD/1uHl7W8Y+K/
 DH1QDKnNOv1eYCEjeGrtLqsyVTp5VxykUZbRZE+2ODLnKaCdRHcjmB1nitUMghSQ
 ==
X-ME-Sender: <xms:QCyOYLOqARGH_TSs3y_nwlpD2BKpKBPoGcxTQzojma46S5mPXYcKpQ>
 <xme:QCyOYF-cDJx9lzSaem_mfiWGksaZ8zF1nxfoZ9xmXRg0v6RMfsHOrjVMQonnZ1bn6
 PByOAgESphrW9a-WA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdefuddgtdeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesthdtre
 dttddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvddvudegffefiedttdfhfedvuefhgf
 ekieekgeekveetgefhfeetgfegueduffeinecuffhomhgrihhnpehgnhhurdhorhhgnecu
 kfhppeduiedvrddvudejrdeffedrudduvdenucevlhhushhtvghrufhiiigvpedtnecurf
 grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:QCyOYKRG0EZYZoZgG6huKrKsuTds5x0_A3UfeRfF_VowmjLS9nlu2w>
 <xmx:QCyOYPvXOOJMjxiJbDk7N9lb0YHNC7stHTkmbGari4ggxh3F3EK_sA>
 <xmx:QCyOYDc852UEvLjcXHtsBNzb_be-0RscJzL49gNAnt83EAU68JWh7Q>
 <xmx:QSyOYNqYa59yXvHdi4_6MWa0FVZmd7GaDD0OKaxYTJpZAhARtGxLUQ>
Received: from localhost (d-162-217-33-112.ct.cpe.atlanticbb.net
 [162.217.33.112]) by mail.messagingengine.com (Postfix) with ESMTPA
 for <47979 <at> debbugs.gnu.org>; Sun,  2 May 2021 00:36:16 -0400 (EDT)
Date: Sun, 2 May 2021 00:36:14 -0400
From: Leo Famulari <leo@HIDDEN>
To: 47979 <at> debbugs.gnu.org
Subject: Re: [PATCH v3] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YI4sPu8mD8UKwG9d@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN> <YINOJ3HMdKFFKASf@HIDDEN>
 <YINsy8LNhQd4NYmq@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <YINsy8LNhQd4NYmq@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)

On Fri, Apr 23, 2021 at 08:56:43PM -0400, Leo Famulari wrote:
> With Leo Prikler's help on #guix [0], I got it to work :)
> 
> I've attached the working patch, as well as a patch to offer the GPM
> "console mouse" service on non-graphical systems.
> 
> [0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921

> From 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001
> From: Leo Famulari <leo@HIDDEN>
> Date: Fri, 23 Apr 2021 14:50:15 -0400
> Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphical
>  systems.
> 
> We had several bug reports with a root cause of "the clock was
> incorrect" from users who used the installer to install a non-graphical
> Guix System.
> 
> * gnu/installer/services.scm (%system-services): Add the ntp-service-type.
> * gnu/installer/newt/services.scm (run-system-administration-cbt-page): New
> variable.
> (run-services-page): Use run-system-administration-cbt-page when not
> installing a desktop.

Ping!

I suppose it's too late for 1.3.0, due to the string freeze.

But I am asking for review anyways.




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 24 Apr 2021 14:50:32 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Sat Apr 24 10:50:32 2021
Received: from localhost ([127.0.0.1]:41284 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1laJc8-0007NP-C1
	for submit <at> debbugs.gnu.org; Sat, 24 Apr 2021 10:50:32 -0400
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52099)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1laJc5-0007NA-Rn
 for 47979 <at> debbugs.gnu.org; Sat, 24 Apr 2021 10:50:31 -0400
Received: from compute2.internal (compute2.nyi.internal [10.202.2.42])
 by mailout.west.internal (Postfix) with ESMTP id 17BDF1B23;
 Sat, 24 Apr 2021 10:50:23 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute2.internal (MEProxy); Sat, 24 Apr 2021 10:50:23 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=TBdTQy4eXOmdNVe48HQ/6/pT
 puwn+/CJuZWnq9UZM80=; b=Nz82fCNzVAsWLPvNwhtGHXEH66KCmavNKS5h3/NZ
 b+ZlE63HJIAVxfaGi7fcpsBfs6kfbkKCddGxfIiHh+cUofwp790D1oS/yL2d5Tfu
 tDcfzBucywcHLpiuEa4g0N961G45m4hRbJqYJqFWV3TnKP/AgGwtQ8S2T7yz/JkH
 auQ=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=TBdTQy
 4eXOmdNVe48HQ/6/pTpuwn+/CJuZWnq9UZM80=; b=ugwfYW+MOOyy04ivqM6mve
 mf/byAJf+vEdQLhW63rH+inCa0MyxDCoyqzKcLQMP63oca05h7Sra3olXRNpTzc/
 0OcKYqDii0RgX2AqIE0DRriI5a9xT16GTFsK/GcJGIcnfJVj8QX19Me+wMG5VKgI
 VDIrPy4V6nZhBTJ49dTNYuva7OmHvrh8mplGjTodQRiHm82C3By/L/a6PKrS1CXN
 ANFeo8vUcyixx95vMEESAuJDPAoLPWoHS5TraWYHJmMsOvvOFYiP0BJLmE/8gJE0
 xdf6w1uMzpe9WaDu/XKCZGn+h/F6hQacondEcWcZtwirCuqPU52XuusMP4OPHShw
 ==
X-ME-Sender: <xms:LjCEYPijmo9PLhUGcbhDVBx3d4ku9CPERScYR-CRgfElZIXfr_0E5Q>
 <xme:LjCEYL8hPrXKLzoT4GVeXjF_vRv1kQdtQ5qz1lmuqSosZz3IPX9oqc72VzZTq-JoQ
 RulHxfALluK9dtKoQ>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddugedgkedvucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre
 ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepvdevgeekudeivdeileduveekuefgue
 euleehtdffgefftdefkeevleffueefudeknecuffhomhgrihhnpehgnhhurdhorhhgnecu
 kfhppedutddtrdduuddrudeiledruddukeenucevlhhushhtvghrufhiiigvpedtnecurf
 grrhgrmhepmhgrihhlfhhrohhmpehlvghosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:LjCEYL_t_lyLFlW6nu0yDM5Mx_oS4T51Svj6mxnKUFsR9d4yN2bpwg>
 <xmx:LjCEYEDB4zHw7-QDsL0iCCGj-qiJm61YbP_VnK8H8AVM6fE2rb67uw>
 <xmx:LjCEYLzRl5MwHwtPc3mjV_prDuBZ42KRC8CEJ5oNUknlNKUp5RHYUA>
 <xmx:LjCEYPkhgJkRTZQE0BK_s4E-MIGsWxxBPRzwDxZwUBO7lLGqtbO6ZQ>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118])
 by mail.messagingengine.com (Postfix) with ESMTPA id 774B9240066
 for <47979 <at> debbugs.gnu.org>; Sat, 24 Apr 2021 10:50:22 -0400 (EDT)
Date: Fri, 23 Apr 2021 20:56:43 -0400
From: Leo Famulari <leo@HIDDEN>
To: 47979 <at> debbugs.gnu.org
Subject: Re: [PATCH v3] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YINsy8LNhQd4NYmq@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN>
 <YINOJ3HMdKFFKASf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="dHkJjldvz7gEzIKb"
Content-Disposition: inline
In-Reply-To: <YINOJ3HMdKFFKASf@HIDDEN>
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: 47979
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -0.9 (/)


--dHkJjldvz7gEzIKb
Content-Type: multipart/mixed; boundary="eqwIqxzZxv0Qks4S"
Content-Disposition: inline


--eqwIqxzZxv0Qks4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote:
> ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in position 1 (expecting struct): (#<<system-service> name: "Network time service, to set the clock automatically" type: administration recommended?: #t snippet: ((service ntp-service-type)) packages: ()>)

With Leo Prikler's help on #guix [0], I got it to work :)

I've attached the working patch, as well as a patch to offer the GPM
"console mouse" service on non-graphical systems.

[0] http://logs.guix.gnu.org/guix/2021-04-24.log#012921

--eqwIqxzZxv0Qks4S
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: attachment;
	filename="0001-installer-Recommend-ntp-service-type-for-non-graphic.patch"
Content-Transfer-Encoding: quoted-printable

=46rom 6f2f131551247aa20794007c43ae61b82f6e34d6 Mon Sep 17 00:00:00 2001
=46rom: Leo Famulari <leo@HIDDEN>
Date: Fri, 23 Apr 2021 14:50:15 -0400
Subject: [PATCH 1/2] installer: Recommend 'ntp-service-type' for non-graphi=
cal
 systems.

We had several bug reports with a root cause of "the clock was
incorrect" from users who used the installer to install a non-graphical
Guix System.

* gnu/installer/services.scm (%system-services): Add the ntp-service-type.
* gnu/installer/newt/services.scm (run-system-administration-cbt-page): New
variable.
(run-services-page): Use run-system-administration-cbt-page when not
installing a desktop.
---
 gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++-
 gnu/installer/services.scm      |  8 ++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.=
scm
index 74f28e41ba..ee003b24b1 100644
--- a/gnu/installer/newt/services.scm
+++ b/gnu/installer/newt/services.scm
@@ -3,6 +3,7 @@
 ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s <ludo@HIDDEN>
 ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
 ;;; Copyright =A9 2021 Tobias Geerinckx-Rice <me@HIDDEN>
+;;; Copyright =A9 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,6 +69,25 @@ system.")
         (condition
          (&installer-step-abort)))))))
=20
+(define (run-system-administration-cbt-page)
+  "Run a page to select various system adminstration services."
+  (let ((items (filter (lambda (service)
+                         (eq? 'administration
+                              (system-service-type service)))
+                       %system-services)))
+    (run-checkbox-tree-page
+      #:title (G_ "Miscellaneous services")
+      #:info-text (G_ "Select miscellaneous services to run on your system=
=2E")
+      #:items items
+      #:selection (map system-service-recommended? items)
+      #:item->text (compose G_ system-service-name)
+      #:checkbox-tree-height 5
+      #:exit-button-callback-procedure
+      (lambda ()
+        (raise
+          (condition
+            (&installer-step-abort)))))))
+
 (define (run-network-management-page)
   "Run a page to select among several network management methods."
   (let ((title (G_ "Network management")))
@@ -99,5 +119,6 @@ client may be enough for a server.")
     (append desktop
             (run-networking-cbt-page)
             (if (null? desktop)
-                (list (run-network-management-page))
+                (cons (run-network-management-page)
+                      (run-system-administration-cbt-page))
                 '()))))
diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index ec5ea30594..b50bd3e412 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -2,6 +2,7 @@
 ;;; Copyright =A9 2018 Mathieu Othacehe <m.othacehe@HIDDEN>
 ;;; Copyright =A9 2019 Ludovic Court=E8s <ludo@HIDDEN>
 ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
+;;; Copyright =A9 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -104,6 +105,13 @@
       (packages '((specification->package "nss-certs")))
       (recommended? #t))
=20
+     ;; Miscellaneous system administration services.
+     (system-service
+       (name (G_ "Network time service, to set the clock automatically"))
+       (type 'administration)
+       (recommended? #t)
+       (snippet '((service ntp-service-type))))
+
      ;; Network connectivity management.
      (system-service
       (name (G_ "NetworkManager network connection manager"))
--=20
2.31.1


--eqwIqxzZxv0Qks4S
Content-Type: text/plain; charset=us-ascii
Content-Disposition: attachment;
	filename="0002-installer-Offer-gpm-service-type-for-non-graphical-s.patch"
Content-Transfer-Encoding: quoted-printable

=46rom a00274e70d700b9325ad9ab7cd1804d444a5dc37 Mon Sep 17 00:00:00 2001
=46rom: Leo Famulari <leo@HIDDEN>
Date: Fri, 23 Apr 2021 20:42:28 -0400
Subject: [PATCH 2/2] installer: Offer 'gpm-service-type' for non-graphical
 systems.

* gnu/installer/services.scm (%system-services): Add the gpm-service-type.
---
 gnu/installer/services.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index b50bd3e412..27beb5da66 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -111,6 +111,10 @@
        (type 'administration)
        (recommended? #t)
        (snippet '((service ntp-service-type))))
+     (system-service
+       (name (G_ "GPM mouse daemon, to use the mouse in the console"))
+       (type 'administration)
+       (snippet '((service gpm-service-type))))
=20
      ;; Network connectivity management.
      (system-service
--=20
2.31.1


--eqwIqxzZxv0Qks4S--

--dHkJjldvz7gEzIKb
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDbMgACgkQJkb6MLrK
fwhyVQ/+I4Z9bPvlS/m9+XhUARgOepoymiLl3ykv4fdS6os5LSqdxDQp5LcaGyrL
1FM1AOUrQZ0rd2ZO0XGpYh/eyvE+edaBP1Bpnd0/LTjzZqCn4z8fQo6xn1O6rDyO
MuurlXYMlGivSZtngH0UeEcOi85JQaF6eBVIk9+yH4OCzS/e2HiFQhzmpE032vx8
MLaJ5HycJFrmKmPCB53Zp+rkvjqwRL9S8b51afYp5hABxoGfSX2JkGARRSSfZxRD
ARtqvwqCgU3DzB6X7BmWBEa9MU5WWRGSc7wOX2CCPag6A6RbXcTO3rQV8P+xi8SD
SkQB7WAlvHTx7ueLsn3SK/OBqKTVgtf98kFTtzBQiNfN4p+NFDPSQ/MpowNAO6NI
WhZAQNNE/jMoZBVmOxKBbdDxCJk41K86Vvv4QV/IvXJC03s1eyraM/91cXgTG8+o
IVr/q6Vbs3QErrsoZg2E/NVeS6rQaa/8vmiSkzM1+gel66NLBGVZBcOVKQayfc+A
ITKcr2fo6tPM3LxnHA/tKn44kFmGNeutGrcjeijHThYGHR1An/d51y1M5vVLaLEI
/O/wNigTWVgAhHcmH64Y9zk1SSxJsFS4OzTpBs4CV3xZq8rTL8GXx+g8wux3sgLw
/wMBlIJPgHd2KJdeFAUgIpAsHTflmXSa/H0kAbstw5QiV5bCCfI=
=U8RK
-----END PGP SIGNATURE-----

--dHkJjldvz7gEzIKb--




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 23 Apr 2021 23:20:47 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 23 19:20:46 2021
Received: from localhost ([127.0.0.1]:39154 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1la56M-0003Lv-JJ
	for submit <at> debbugs.gnu.org; Fri, 23 Apr 2021 19:20:46 -0400
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:59965)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1la56K-0003Lg-Iv
 for 47979 <at> debbugs.gnu.org; Fri, 23 Apr 2021 19:20:45 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id AFC3F3868;
 Fri, 23 Apr 2021 19:20:38 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Fri, 23 Apr 2021 19:20:38 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=AjgWhCZaned1CHbZBVLuzKyI
 SChbNDDqXHz69eWVElw=; b=1E5vA8ty9UhuGOWwHCsqT1skqF+6GlLZ+5+QFVlh
 nMb96OyQ3wpowEkJlK4GOrw8EZbvZzareDIDcKGWdKcTG3Z9P39h5RKpIawn8T/S
 /60pXpY7OZgt9AdFwMx2W0O/f/FH/dE6sJtZpEqk8FtGjhEuiXrfClzvCfbbh92M
 660=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=AjgWhC
 Zaned1CHbZBVLuzKyISChbNDDqXHz69eWVElw=; b=RehAZcaMMAOoYMx7ZfKNXh
 WYce5WaT2/LSGKLfKRQ6RPrv7HLSJ7lIw0jtfmTQoX0iAVeTmrUX+um4freoWnam
 3Y4JtqbtiACNPG3nHMph/ZUpgOKyVWq6AzsETScWhTWtfk7yjapRbE39sg7Ctx0k
 Yy/KFYRpSwWj5edmtCKXH9mVZQyEMjtuhBt3wHINC6NEWGin8I8xxun0pBbn1Q9s
 EvWS0UFOJ8pTdS6J4vw7QR5SOA3/QC7es94Y3cBd+rhesXbkN2MR0x0jqTPHvzSr
 kwoqENTPwJOHVqNKvyL1t6WpkuQlkoyGeL+5fSOPwqbaGuOJx1Sklty7di01c83A
 ==
X-ME-Sender: <xms:RVaDYFWy_RGI0rujLoLISEwlCT3M-hKnfjpbnP5eS_Xrfe6rg_UuOg>
 <xme:RVaDYFloj_uHVHz7Nc-lHWd5Vhwd_9Xms5K9le9xvxM0bYMeROUcehSadVTzI5Qjl
 0GxlZRa_AmrHDm1Bw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddufedgudefucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre
 ertddtvdenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepudekveegteekleetgfeitdejgfejke
 ffudethedvhfeukeduleeikeejfeehffetnecukfhppedutddtrdduuddrudeiledruddu
 keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg
 hosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:RVaDYBa8O0v1KWLpQ7V2aklCjeUFPClSq_TfrFw9kHRDZ4BBAamRmQ>
 <xmx:RVaDYIVFlnBZ7Z-kzkfZySdeoPhsUzsJeo-9R1LWjbradgok4sC3ug>
 <xmx:RVaDYPnbUJvNln-5LAg06883d0TN48V0HgfA3-EQ002OnGglv_Nlhw>
 <xmx:RlaDYLwyEAEuP8eBX1ldm5B7Pd9RknwLmXEJ2zVv9qfg4B9xHJPJbQ>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118])
 by mail.messagingengine.com (Postfix) with ESMTPA id E08D11080066
 for <47979 <at> debbugs.gnu.org>; Fri, 23 Apr 2021 19:20:37 -0400 (EDT)
Date: Fri, 23 Apr 2021 19:20:35 -0400
From: Leo Famulari <leo@HIDDEN>
To: 47979 <at> debbugs.gnu.org
Subject: Re: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YINWQz00YwrQP2l1@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN>
 <YINOJ3HMdKFFKASf@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="JBlACcxucxP3sLMg"
Content-Disposition: inline
In-Reply-To: <YINOJ3HMdKFFKASf@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--JBlACcxucxP3sLMg
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

On Fri, Apr 23, 2021 at 06:45:59PM -0400, Leo Famulari wrote:
> However, with this patch, the installer crashes after partitioning, like
> this:

By the way, I'm testing this by building the installer in the same way
as our Makefile:

$ guix environment guix -- ./pre-inst-env guix system image -t iso9660 --label="GUIX_x86_64-linux-leo" --system=x86_64-linux gnu/system/install.scm

I create a QEMU disk:

$ qemu-img create -f qcow2 guix-system.img 50G

And then I use the ISO I built, after copying it out of the store:

$ qemu-system-x86_64 -m 1024 -smp 1 -enable-kvm -nic user,model=virtio-net-pci -boot menu=on,order=d -drive file=guix-system.img -drive media=cdrom,file=image.iso

--JBlACcxucxP3sLMg
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDVkMACgkQJkb6MLrK
fwhBEA//e+eWdYCUeYAmyNXyaqocDSnOEd98VVhskGHjql4YChsow2JlIODHRWW0
fghagCxtQrgrHs/YRnDbGTTuvKVTXckox3T+uAAIwWNGXNOaN3B46nPQp2dZX6So
FzyYelO7MmIlxh+p22GPT3cwaaIP1PsqcEMHNX1zi9Nz6+eGqbO4VbHnY2G/t9Vy
JSS8v001cOwpNsbFfh2kIUz3+5SQp8K6MSvpIC5v/JdvcaS9zODy7wTH1UjKz/kz
hdj2YrMJEMwxz57mN8mlEKp2wa1c+5wyZktwIjL5qeYiEm4zVdXN+k38kT3ttZeF
oNzqlDVNFcXWmYxDaniU05erbdvx06CNzpvHb6FZmvj0VHFrpV3/P3rUfEAgbPkk
V4dwRGwbRd5WMp4NBnmWAo9n6X1nAAHyHsUtxKbm/Y5P12N37hx+pnvmoxYuOPwa
EwfBcAz0r7656ZGYvKyDBfe3PTTJg9XUPDV423+doH5k1gyx8h0zL23FWUl4JI9i
sAcAFwRdaS5WwSsWe9fJ3IuJOzCXxz06Vl4tuD9J0FyzKSfId/y3WrtSD8lNqGqt
XUd/C9/1sUSQJbGyZ0aebGpGL+nBG/blpAXcY9x+7IfxO5b335v3ExP8djb9Bxse
u2XfQ4NoZt2pB5gEzwPb3wywasLUVWrGW0Usfcw8UXz7/bEmYSw=
=Vbie
-----END PGP SIGNATURE-----

--JBlACcxucxP3sLMg--




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 23 Apr 2021 22:46:11 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 23 18:46:11 2021
Received: from localhost ([127.0.0.1]:39131 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1la4Yt-0002Qz-2j
	for submit <at> debbugs.gnu.org; Fri, 23 Apr 2021 18:46:11 -0400
Received: from wout3-smtp.messagingengine.com ([64.147.123.19]:52711)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1la4Yr-0002Qe-4S
 for 47979 <at> debbugs.gnu.org; Fri, 23 Apr 2021 18:46:10 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 216863628;
 Fri, 23 Apr 2021 18:46:03 -0400 (EDT)
Received: from mailfrontend1 ([10.202.2.162])
 by compute3.internal (MEProxy); Fri, 23 Apr 2021 18:46:03 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:subject:message-id:references:mime-version
 :content-type:in-reply-to; s=mesmtp; bh=jkVETC9nd3YaKb6TjDPg7IRk
 gQ6YElHsDINI9nv27yQ=; b=U9aZxA4PddFbyLUf6os6TIN92SM+yJ79K5yLm7oy
 bYJEPLy68byxJjxNzdpjxy/Idz87rJlbRg2SXim6vIiR3GNNkeZjpT/TJuXXHNjo
 xKtKOEdumWmIZClLheurC9S7Kc8P7HRxC8vSrmhyQTu7skKtiPffNtvj9/Cuy4ph
 Nv0=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:in-reply-to
 :message-id:mime-version:references:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=jkVETC
 9nd3YaKb6TjDPg7IRkgQ6YElHsDINI9nv27yQ=; b=nzfTzedfRh+OUDEamCH6VX
 g+R9MuoC0lchMZ9sZGIcAF3q59gsvmCcKPAkmMUPMI5glbVRWk61qdPNBoXUapBc
 LUyL2xkGbZjk2t+Kt7DOVRQ5O2Dmu82+xdZ07WItX0na61IX07hyqOAlLHVD0g0d
 UqeyB7zEijt+sfXNLCohro3dKZ82fCUJpv3+B019nfoSI8jJBZzxikNov/kaYYkP
 bebndygZkgxMp9H9KgX/R5XhLoLUZgx4FYhuZc4vXLwWaxf0XPoOdBCZ1ZmociFL
 y7yz7BRBqtwJQ+xcDMW3GmAz3OohN6Gx5r0Op1OAOUP4PsL/AoF/ZY59PFf+MPtw
 ==
X-ME-Sender: <xms:Kk6DYGlPiR0GCnsB2PoJqFmCEs6iSASLopW5tMlLNoDPDKcsio4bZA>
 <xme:Kk6DYN1BkXuBSR9sA5LCamwdeMCs4HEODnAIt5kRWAw9bxynvL9av_fHoSmQaNuvT
 KTl4owHiqlDw7nN-w>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvddufedgtdeiucetufdoteggodetrfdotf
 fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen
 uceurghilhhouhhtmecufedttdenucenucfjughrpeffhffvuffkfhggtggujgesghdtre
 ertddtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepiefghfeffedtffekveektddtieekfe
 ffledtgfevkeekteeufedtfefhgefhkeefnecukfhppedutddtrdduuddrudeiledruddu
 keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg
 hosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:Kk6DYErxIXMdXZ4NIec-VJsQlY0Qyq7Cawrzx-mF97LY-5AYP-AZSw>
 <xmx:Kk6DYKmkV2X70Wi-wjH4Lns39QhW_YQOMSOwmPpoyCfxiBXFtArOYQ>
 <xmx:Kk6DYE22UHp9VpcjISe5FRA7EUr52FPL8sman_8A3ldTx9nqi1MIKQ>
 <xmx:Kk6DYFDeglQ9_cb82JZNRIHZkXxS-MHMzEoqCtW6OnSOFjnAr90f8A>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118])
 by mail.messagingengine.com (Postfix) with ESMTPA id 5F09A24005D
 for <47979 <at> debbugs.gnu.org>; Fri, 23 Apr 2021 18:46:02 -0400 (EDT)
Date: Fri, 23 Apr 2021 18:45:59 -0400
From: Leo Famulari <leo@HIDDEN>
To: 47979 <at> debbugs.gnu.org
Subject: Re: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YINOJ3HMdKFFKASf@HIDDEN>
References: <YIMYaG4+hTJj5/s9@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="t0ubvqyjGjrAhPNs"
Content-Disposition: inline
In-Reply-To: <YIMYaG4+hTJj5/s9@HIDDEN>
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--t0ubvqyjGjrAhPNs
Content-Type: multipart/mixed; boundary="BKTfMUvwn05mzvcF"
Content-Disposition: inline


--BKTfMUvwn05mzvcF
Content-Type: text/plain; charset=utf-8
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Okay, here is a patch that does what I want.

That is, when the user does not select any desktop environments, it
prompts them about enabling NTP, with the checkbox already checked.

However, with this patch, the installer crashes after partitioning, like
this:

------
In ./gnu/installer/services.scm:
     38:0 19 (%system-service-snippet-procedure (#<<system-service> name: "=
Network time service, to set the clock automatically" type: administration =
recommended?: #t snippet: ((service ntp-servi=E2=80=A6>))
In ice-9/boot-9.scm:
  1669:16 18 (raise-exception _ #:continuable? _)
  1667:16 17 (raise-exception _ #:continuable? _)
  1667:16 16 (raise-exception _ #:continuable? _)
  1667:16 15 (raise-exception _ #:continuable? _)
  1667:16 14 (raise-exception _ #:continuable? _)
  1667:16 13 (raise-exception _ #:continuable? _)
  1667:16 12 (raise-exception _ #:continuable? _)
  1667:16 11 (raise-exception _ #:continuable? _)
  1667:16 10 (raise-exception _ #:continuable? _)
  1667:16  9 (raise-exception _ #:continuable? _)
  1667:16  8 (raise-exception _ #:continuable? _)
  1667:16  7 (raise-exception _ #:continuable? _)
  1764:13  6 (_ #<&compound-exception components: (#<&assertion-failure> #<=
&origin origin: "struct-vtable"> #<&message message: "Wrong type argument i=
n position 1 (expecting struct): ~S"> #<&irrit=E2=80=A6>)
In ice-9/eval.scm:
    619:8  5 (_ #(#(#<directory (guile-user) 7f8be12f4c80> #<<installer> na=
me: newt init: #<procedure init ()> exit: #<procedure exit ()> exit-error: =
#<procedure exit-error (file key args)> f=E2=80=A6>) =E2=80=A6))
    619:8  4 (_ #(#(#(#<directory (guile-user) 7f8be12f4c80> #<<installer> =
name: newt init: #<procedure init ()> exit: #<procedure exit ()> exit-error=
: #<procedure exit-error (file key arg=E2=80=A6>) =E2=80=A6) #))
In ice-9/ports.scm:
   463:17  3 (call-with-output-file _ _ #:binary _ #:encoding _)
In ice-9/eval.scm:
    619:8  2 (_ #(#(#<directory (guile-user) 7f8be12f4c80> wrong-type-arg (=
"struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" =
((#<<system-service> name: "Network =E2=80=A6>)) =E2=80=A6)) #))
    159:9  1 (_ #(#(#<directory (guile-user) 7f8be12f4c80> wrong-type-arg (=
"struct-vtable" "Wrong type argument in position 1 (expecting struct): ~S" =
((#<<system-service> name: "Network =E2=80=A6>)) =E2=80=A6)) #))
In unknown file:
           0 (make-stack #t)
ice-9/eval.scm:159:9: In procedure struct-vtable: Wrong type argument in po=
sition 1 (expecting struct): (#<<system-service> name: "Network time servic=
e, to set the clock automatically" type: administration recommended?: #t sn=
ippet: ((service ntp-service-type)) packages: ()>)
------

So, I've done something wrong. But I don't know what :)

I'm going to keep trying but hopefully somebody can help me.

--BKTfMUvwn05mzvcF
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: attachment;
	filename="0001-installer-Recommend-ntp-service-type-for-non-graphic.patch"
Content-Transfer-Encoding: quoted-printable

=46rom c70ed1b6ed621a56ab258cf5cfce45c50cb1831f Mon Sep 17 00:00:00 2001
=46rom: Leo Famulari <leo@HIDDEN>
Date: Fri, 23 Apr 2021 14:50:15 -0400
Subject: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical
 systems.

We had several bug reports with a root cause of "the clock was
incorrect" from users who used the installer to install a non-graphical
Guix System.

* gnu/installer/services.scm (%system-services): Add the ntp-service-type.
* gnu/installer/newt/services.scm (run-system-administration-cbt-page): New
variable.
(run-services-page): Use run-system-administration-cbt-page when not
installing a desktop.
---
 gnu/installer/newt/services.scm | 23 ++++++++++++++++++++++-
 gnu/installer/services.scm      |  8 ++++++++
 2 files changed, 30 insertions(+), 1 deletion(-)

diff --git a/gnu/installer/newt/services.scm b/gnu/installer/newt/services.=
scm
index 74f28e41ba..60c62a52b1 100644
--- a/gnu/installer/newt/services.scm
+++ b/gnu/installer/newt/services.scm
@@ -3,6 +3,7 @@
 ;;; Copyright =A9 2019, 2020 Ludovic Court=E8s <ludo@HIDDEN>
 ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
 ;;; Copyright =A9 2021 Tobias Geerinckx-Rice <me@HIDDEN>
+;;; Copyright =A9 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -68,6 +69,25 @@ system.")
         (condition
          (&installer-step-abort)))))))
=20
+(define (run-system-administration-cbt-page)
+  "Run a page to select various system adminstrative services."
+  (let ((items (filter (lambda (service)
+                         (eq? 'administration
+                              (system-service-type service)))
+                       %system-services)))
+    (run-checkbox-tree-page
+      #:title (G_ "Miscellaneous services")
+      #:info-text (G_ "Select miscellaneous system services to run on your=
 system.")
+      #:items items
+      #:selection (map system-service-recommended? items)
+      #:item->text (compose G_ system-service-name)
+      #:checkbox-tree-height 5
+      #:exit-button-callback-procedure
+      (lambda ()
+        (raise
+          (condition
+            (&installer-step-abort)))))))
+
 (define (run-network-management-page)
   "Run a page to select among several network management methods."
   (let ((title (G_ "Network management")))
@@ -99,5 +119,6 @@ client may be enough for a server.")
     (append desktop
             (run-networking-cbt-page)
             (if (null? desktop)
-                (list (run-network-management-page))
+                (list (run-network-management-page)
+                      (run-system-administration-cbt-page))
                 '()))))
diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index ec5ea30594..17ff31d2ec 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -2,6 +2,7 @@
 ;;; Copyright =A9 2018 Mathieu Othacehe <m.othacehe@HIDDEN>
 ;;; Copyright =A9 2019 Ludovic Court=E8s <ludo@HIDDEN>
 ;;; Copyright =A9 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
+;;; Copyright =A9 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -104,6 +105,13 @@
       (packages '((specification->package "nss-certs")))
       (recommended? #t))
=20
+     ;; System administration
+     (system-service
+       (name (G_ "Network time service, to set the clock automatically"))
+       (type 'administration)
+       (snippet '((service ntp-service-type)))
+       (recommended? #t))
+
      ;; Network connectivity management.
      (system-service
       (name (G_ "NetworkManager network connection manager"))
--=20
2.31.1


--BKTfMUvwn05mzvcF--

--t0ubvqyjGjrAhPNs
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDTicACgkQJkb6MLrK
fwjlRw/+MK0M4CWE8ia/QcGVtvBR4OBUVF+TE+cvTrpL+mmSKY+OND00IHOngicI
mhh7qUZcwlIIYFseox+IPO4Yw29SxYGOctyE+k2DqTkYJ8QFUKVetO9WKIqYdQF9
LTEaG8wZQLakSPCvfZpw3FtD7D+//gwH9ncu42Z+4OXcGCugT2STurfzbTWioHnO
4q+ASbbqAqO2rRxTaJg4jhEeUOTV2hDwGmCegtvHYJfukbLiuZyq6MU/bB1tWaDl
BN2Yb5Kn9Apn8Nere1xGA/+3cUonrP/v85+eZ4VnwCpSEJb/8jlhLQEqTWSTbZ63
1sODXTIJWrXwbl8LaKStV4NmhSOYje7HwHRnksWzBLa5Ht+Kg6pb+zEEBubs0E06
LFFT9akSestWqIngxDXCOUn9I3Cd3lXlpzvd4yT05zpbvJdzcOUtZbxb9R1hAdQ2
lYUpfP7LK9S2kbPLtTugqoppIGs6dlezhONbwym8nDXZup/btgv0xObp2UcPu2FY
KCk/O/oD50gK7Gbnk8cXUoMNZhlhgngXYCc+JW1XE/FhLN6o32C2d5yQuavdFo56
DZ6JC2hVD+KfdmNcrwMRvlGb/euzu3R6AAJ27EAdrwGc8KD/Ba1v1fXhDWcHpg1l
/KtCLKUrR7I1c21VopBjL4B9wvsu+Ti44rfXpMzxECNNK6FXGt0=
=gQrc
-----END PGP SIGNATURE-----

--t0ubvqyjGjrAhPNs--




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at 47979 <at> debbugs.gnu.org:


Received: (at 47979) by debbugs.gnu.org; 23 Apr 2021 18:56:51 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 23 14:56:51 2021
Received: from localhost ([127.0.0.1]:38840 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1la0yx-0005HX-Jf
	for submit <at> debbugs.gnu.org; Fri, 23 Apr 2021 14:56:51 -0400
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:51811)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1la0yv-0005HL-FR
 for 47979 <at> debbugs.gnu.org; Fri, 23 Apr 2021 14:56:50 -0400
Received: from compute3.internal (compute3.nyi.internal [10.202.2.43])
 by mailout.west.internal (Postfix) with ESMTP id 6BF503062;
 Fri, 23 Apr 2021 14:56:43 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute3.internal (MEProxy); Fri, 23 Apr 2021 14:56:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=date:from:to:subject:message-id:mime-version:content-type; s=
 mesmtp; bh=tkxOXxKG+Q3sjqlCWMkNBTvEnXSNgCYpDP6hSCaR4t8=; b=qQQTt
 DMN9PZ77wdctrxJnjZhNiMfEdo1D3MZ8XRGnzCQO9ztmpUsPoUCkqnG5m+bpkQ7K
 qZdLl2hmZ9JNfba/Nzjr8+OLD4Fop+SnGu9Qu9u5KPuxqfNXZ9zYP+fh9+j/k+rR
 Ox/74vnri9WX2YJ6xvMILnFoP1LhpB07SkJmlY=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-type:date:from:message-id
 :mime-version:subject:to:x-me-proxy:x-me-proxy:x-me-sender
 :x-me-sender:x-sasl-enc; s=fm2; bh=tkxOXxKG+Q3sjqlCWMkNBTvEnXSNg
 CYpDP6hSCaR4t8=; b=vt3p7VLyfYAvdSw3uLBeU56AnFr3TCNLUBjySFyT2OSxR
 8EmcDWqDqKLibTj4mlA7XZV5vdXzd96/KojnTobUNPQxK/EAuxIYEsEuJg8Ycgiz
 nbZTMnqK6ZDuo8uprDAMoQ1o4wDhGEIkAWiQUNhmJaFZNLr/7rZAjR9CqPX2IYkS
 DlKJs0pM9Ew4oW0cbWsVq/0XC4VLW6580rgzQ/vIHaCdWkHOyOegNkd9v18dBQDb
 uqpRJnw2rwIL6eFl28xbEIAsq6a7YOjPYvL24Av3mAMEx1ZPqePlZXSzoVeK8RX1
 e7TZeN127vKRNoXJ9jOjVM+vRuPxEuMyARc+sNHmw==
X-ME-Sender: <xms:ahiDYKGeyKXvvLtg1pif1I8t_aCN5LBQks1QZwEJSYeKqCks_AsoJg>
 <xme:ahiDYLVMUvdNGrYV33NAuKPpRch-VuFpvTzTFqj7RwYDeLtxD4Oe19qt1-moPOTbH
 YanQyQshl1palhJlA>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduvddgudefudcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecunecujfgurhepfffhvffukfggtggusehgtderre
 dttddvnecuhfhrohhmpefnvghoucfhrghmuhhlrghrihcuoehlvghosehfrghmuhhlrghr
 ihdrnhgrmhgvqeenucggtffrrghtthgvrhhnpeejieeutdffleegudehgefhhfduueeule
 evveeggeehveffkeeihfevvdfhkeefvdenucfkphepuddttddruddurdduieelrdduudek
 necuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheplhgvoh
 esfhgrmhhulhgrrhhirdhnrghmvg
X-ME-Proxy: <xmx:ahiDYEKfMePVLJoi3vfkEzApARfdm7n2tPp8iKYpgixnCJwnOB_bEw>
 <xmx:ahiDYEGH8aJ_P7WhvHPiY0okaTa-5QI4X9QrhkQj12VUqgSwAi6w1A>
 <xmx:ahiDYAXBiqplkAdTeOHZ4017zwogLBr6CzbqWPIx2I8gmofuXxjgdg>
 <xmx:axiDYIjc93GeiSe9287KKJzKxm7bI4btoMkYw3XBIcOP_9Pd0mv8DQ>
Received: from localhost (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118])
 by mail.messagingengine.com (Postfix) with ESMTPA id 6DC1B1080064
 for <47979 <at> debbugs.gnu.org>; Fri, 23 Apr 2021 14:56:42 -0400 (EDT)
Date: Fri, 23 Apr 2021 14:56:40 -0400
From: Leo Famulari <leo@HIDDEN>
To: 47979 <at> debbugs.gnu.org
Subject: Re: [PATCH] installer: Recommend 'ntp-service-type' for
 non-graphical systems.
Message-ID: <YIMYaG4+hTJj5/s9@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha256;
 protocol="application/pgp-signature"; boundary="/W+bpfFPT4zmGquK"
Content-Disposition: inline
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 47979
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)


--/W+bpfFPT4zmGquK
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline

Hey everyone, please disregard this patch.

It doesn't do what I meant. Sorry for being hasty and sending the wrong
thing.

--/W+bpfFPT4zmGquK
Content-Type: application/pgp-signature; name="signature.asc"

-----BEGIN PGP SIGNATURE-----

iQIzBAABCAAdFiEEsFFZSPHn08G5gDigJkb6MLrKfwgFAmCDGGgACgkQJkb6MLrK
fwgzhBAA0Ii0++wXRQ0v0mbjyDVWkP4dU/+eEEuiuYeBlByM+7o0VI/K/T+VBPmr
rOGnyA9Wt+t8Q3HeJnatDP81pkHbDoN4alj7CAgit+c4ZqJG2P607Q2RlcqxaFsI
W9SRRa1/AjtFL/K3acABPJGBlYMEBqbNf4x5qLFuEzJVE91MBDZtrsqOo1HLgyiy
8be8+KgVYBhrSbqKzyaMJBxBn61X8lanvNZ4MsIPHS7KbLKgA4IXrYFYk0XMEDxG
Z2JUBeLAVT0PRFdOEzsMi4836gPh8lzSDzCFGbjvkNYEFYrVNoetNcWz3U6jfrhM
1EHNIQgEYW5RzmYCMzbZQLnWh44IUSLNRoiz503ibB3lyWMOw+5Nh/yCwsfrYv82
og/ndo1skIpe3NnXdiX5ySYxpJyf9eTM3IepXIUgt0Ht1K7/FuERHUWzUwFcCdVs
HCl4ju/dqm6lXGBaJ9zEFB2NS5qj/YhuDJeYmF1dbbUjYtzqvDVcZe1SmxiWVm5O
f59jRlQdi6jEiJnvrylO6r4m/KVfIrxzHKq2lSvRIJ23lLytwJ15sSoMpyPOkFn3
OPoRWxtRk22Mu5JvCs1zyWTviNOeebYMV8HeR4z9MXxq2sDUV5OOY2ZeCOR9XO1f
YkFm696HhYnkfHaAs97DvCEKQ3YVpovCLy+RmeYDy+rwgZTpxeE=
=u6bC
-----END PGP SIGNATURE-----

--/W+bpfFPT4zmGquK--




Information forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.

Message received at submit <at> debbugs.gnu.org:


Received: (at submit) by debbugs.gnu.org; 23 Apr 2021 18:53:53 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Fri Apr 23 14:53:53 2021
Received: from localhost ([127.0.0.1]:38834 helo=debbugs.gnu.org)
	by debbugs.gnu.org with esmtp (Exim 4.84_2)
	(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
	id 1la0w5-0005Cj-2c
	for submit <at> debbugs.gnu.org; Fri, 23 Apr 2021 14:53:53 -0400
Received: from lists.gnu.org ([209.51.188.17]:60740)
 by debbugs.gnu.org with esmtp (Exim 4.84_2)
 (envelope-from <leo@HIDDEN>) id 1la0w3-0005Cc-Qm
 for submit <at> debbugs.gnu.org; Fri, 23 Apr 2021 14:53:52 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:33602)
 by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1la0w3-0007YV-Iq
 for guix-patches@HIDDEN; Fri, 23 Apr 2021 14:53:51 -0400
Received: from wout2-smtp.messagingengine.com ([64.147.123.25]:39883)
 by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
 (Exim 4.90_1) (envelope-from <leo@HIDDEN>) id 1la0vv-0001gK-Jz
 for guix-patches@HIDDEN; Fri, 23 Apr 2021 14:53:51 -0400
Received: from compute1.internal (compute1.nyi.internal [10.202.2.41])
 by mailout.west.internal (Postfix) with ESMTP id D6F5E3059;
 Fri, 23 Apr 2021 14:53:41 -0400 (EDT)
Received: from mailfrontend2 ([10.202.2.163])
 by compute1.internal (MEProxy); Fri, 23 Apr 2021 14:53:42 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=famulari.name;
 h=from:to:subject:date:message-id:mime-version:content-type
 :content-transfer-encoding; s=mesmtp; bh=LflpN3IKgze2migbwdUwfBf
 VwAphjdl+Eof0yU8LPPQ=; b=DW+2KCwWXP7f+9Py8fpV28pNzM1rXMHt3/g+UN5
 QpYCd2zAFbJaIDVXmN0JpiMTsUwXjXRFYIMAF3ioJDcxY5A6tdajbumXXX3GRXIe
 UsT2+VXu35Hp5VBOpgogDw+Qz5UAKj4jYzr8o3apmWdvx1XEXp4Ec/8RheNMV/+V
 pE9k=
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=
 messagingengine.com; h=content-transfer-encoding:content-type
 :date:from:message-id:mime-version:subject:to:x-me-proxy
 :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; bh=LflpN3
 IKgze2migbwdUwfBfVwAphjdl+Eof0yU8LPPQ=; b=N2zPePt6bLI1AvnBKp1Of7
 Ly22QW1CiyGIFYIqr/lI1076MrI5TbQzOkzODi1iL8HIu/gMPXWMpvCleMgbQJQ/
 47niW6g0a43NXPEzXMO/2EXoiuRCaxZ3NvDmBWGf9GQOgGiD9FmovhIpDD10udfm
 L0Mho+sVN4cR6EULNJWyVjaoHnLmtrsjDaYAQDkF+s4A3idtrfS031oluya5VoSw
 OTMOj+GRq1KsjBOUL49KK9CBqqLFtDW490LTiF283vKOsXELIwnv5Wmsiy173qMn
 Ptyf3M/AfkaHIlltB/m3gt26v94IXzWr2b+0GHtpJ6Odm4TxPYY4GHguGuCdJMGw
 ==
X-ME-Sender: <xms:tReDYOG9dZo74YV6oa3WJZTYMQ262jICcbuLgTBuQaFPNjvZXe8s7A>
 <xme:tReDYKMI-SNlsg9KONAk96Y7ZiKSEsB78XLr0rPsnvZPGxRfdtz0aAFj8llxfIepl
 VDM6OkHp0_VZrGTqw>
X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduledrvdduvddgudeftdcutefuodetggdotefrod
 ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh
 necuuegrihhlohhuthemuceftddtnecunecujfgurhephffvufffkffogggtgfesthekre
 dtredtjeenucfhrhhomhepnfgvohcuhfgrmhhulhgrrhhiuceolhgvohesfhgrmhhulhgr
 rhhirdhnrghmvgeqnecuggftrfgrthhtvghrnhepgfetjeetjedtfefggfelheevleejte
 fhleevveetkedtheeugedtgfekueekheejnecukfhppedutddtrdduuddrudeiledruddu
 keenucevlhhushhtvghrufhiiigvpedtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehlvg
 hosehfrghmuhhlrghrihdrnhgrmhgv
X-ME-Proxy: <xmx:tReDYP_fPcL6JdDQ0uTZfWeK8uUkpXe8mga3U2I_QJrnXoq_nem6RA>
 <xmx:tReDYGSHlVrD0tH_KXVmVWE0b_l5aw_tI4_wX_UOty-N5IO5fJCcMw>
 <xmx:tReDYJmLnkpeJP-8tkp9l_V2qonhG-RNJBclOjALI1s4NofJEd1utg>
 <xmx:tReDYOdVmPREuk_wVqr5Ck5lm6kPVMq6lDghMVkO9XJsrgXsglyzbg>
Received: from jasmine.lan (pool-100-11-169-118.phlapa.fios.verizon.net
 [100.11.169.118])
 by mail.messagingengine.com (Postfix) with ESMTPA id 2403F108005C
 for <guix-patches@HIDDEN>; Fri, 23 Apr 2021 14:53:41 -0400 (EDT)
From: Leo Famulari <leo@HIDDEN>
To: guix-patches@HIDDEN
Subject: [PATCH] installer: Recommend 'ntp-service-type' for non-graphical
 systems.
Date: Fri, 23 Apr 2021 14:53:15 -0400
Message-Id: <b0a1ebc01ab84f43d5bddff5f54cea44dc04e513.1619203994.git.leo@HIDDEN>
X-Mailer: git-send-email 2.31.1
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit
Received-SPF: pass client-ip=64.147.123.25; envelope-from=leo@HIDDEN;
 helo=wout2-smtp.messagingengine.com
X-Spam_score_int: -27
X-Spam_score: -2.8
X-Spam_bar: --
X-Spam_report: (-2.8 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
 DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1,
 RCVD_IN_DNSWL_LOW=-0.7, SPF_HELO_PASS=-0.001,
 SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: -1.4 (-)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, 
 <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)

We had several bug reports with a root cause of "the clock was
incorrect" from users who used the installer to install a non-graphical
Guix System.

* gnu/installer/services.scm (%system-services): Add the ntp-service-type.
---
 gnu/installer/services.scm | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/gnu/installer/services.scm b/gnu/installer/services.scm
index ec5ea30594..440b8c67db 100644
--- a/gnu/installer/services.scm
+++ b/gnu/installer/services.scm
@@ -2,6 +2,7 @@
 ;;; Copyright © 2018 Mathieu Othacehe <m.othacehe@HIDDEN>
 ;;; Copyright © 2019 Ludovic Courtès <ludo@HIDDEN>
 ;;; Copyright © 2020 Jan (janneke) Nieuwenhuizen <janneke@HIDDEN>
+;;; Copyright © 2021 Leo Famulari <leo@HIDDEN>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -103,6 +104,11 @@
       (type 'networking)
       (packages '((specification->package "nss-certs")))
       (recommended? #t))
+     (system-service
+       (name (G_ "Network time service, to set the clock automatically"))
+       (type 'network-management)
+       (snippet '((service ntp-service-type)))
+       (recommended? #t))
 
      ;; Network connectivity management.
      (system-service
-- 
2.31.1





Acknowledgement sent to Leo Famulari <leo@HIDDEN>:
New bug report received and forwarded. Copy sent to guix-patches@HIDDEN. Full text available.
Report forwarded to guix-patches@HIDDEN:
bug#47979; Package guix-patches. Full text available.
Please note: This is a static page, with minimal formatting, updated once a day.
Click here to see this page with the latest information and nicer formatting.
Last modified: Thu, 10 Jun 2021 08:45:01 UTC

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997 nCipher Corporation Ltd, 1994-97 Ian Jackson.