GNU bug report logs - #48027
[PATCH] gnu: Add volctl.

Previous Next

Package: guix-patches;

Reported by: Simon Streit <simon <at> netpanic.org>

Date: Mon, 26 Apr 2021 08:08:02 UTC

Severity: normal

Tags: patch

Done: Ludovic Courtès <ludo <at> gnu.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48027 in the body.
You can then email your comments to 48027 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox


Report forwarded to guix-patches <at> gnu.org:
bug#48027; Package guix-patches. (Mon, 26 Apr 2021 08:08:02 GMT) Full text and rfc822 format available.

Acknowledgement sent to Simon Streit <simon <at> netpanic.org>:
New bug report received and forwarded. Copy sent to guix-patches <at> gnu.org. (Mon, 26 Apr 2021 08:08:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Simon Streit <simon <at> netpanic.org>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add volctl.
Date: Mon, 26 Apr 2021 09:00:30 +0200
* gnu/packages/gtk.scm: New Variable.
---
 gnu/packages/gtk.scm | 46 ++++++++++++++++++++++++++++++++++++++++++++
 1 file changed, 46 insertions(+)

diff --git a/gnu/packages/gtk.scm b/gnu/packages/gtk.scm
index 542e274ce3..b4b7dbb785 100644
--- a/gnu/packages/gtk.scm
+++ b/gnu/packages/gtk.scm
@@ -26,6 +26,7 @@
 ;;; Copyright © 2020 Guillaume Le Vaillant <glv <at> posteo.net>
 ;;; Copyright © 2020 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
 ;;; Copyright © 2021 Leo Famulari <leo <at> famulari.name>
+;;; Copyright © 2021 Simon Streit <simon <at> netpanic.org>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -90,6 +91,7 @@
   #:use-module (gnu packages xml)
   #:use-module (gnu packages xorg)
   #:use-module (gnu packages xdisorg)
+  #:use-module (gnu packages pulseaudio)
   #:use-module (srfi srfi-1)
   #:use-module (srfi srfi-26)
   #:use-module (ice-9 match))
@@ -2371,3 +2373,47 @@ linear or logarithmic scales, as dots or lines, with markers/labels) as well as
 user interaction (e.g.  measuring distances).")
     (home-page "https://sourceforge.net/projects/gtkdatabox/")
     (license license:lgpl2.1+)))
+
+(define-public volctl
+  (package
+    (name "volctl")
+    (version "0.8.2")
+    (source (origin
+              (method url-fetch)
+              (uri (string-append "https://github.com/buzz/" name
+                                  "/archive/v" version ".tar.gz"))
+              (sha256
+               (base32
+                "1xanqn6s2i6s2n6wysvgz6l58lsdkl3zmzz4hccla01gx7h4yx4f"))))
+    (build-system python-build-system)
+    (arguments
+     `(#:tests? #t
+       #:phases
+       (modify-phases %standard-phases
+         (add-after 'unpack 'patch-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (let ((pulse (assoc-ref inputs "pulseaudio"))
+                   (xfixes (assoc-ref inputs "libxfixes")))
+               (substitute* "volctl/lib/xwrappers.py"
+                 (("libXfixes.so")
+                  (string-append xfixes "/lib/libXfixes.so")))
+               (substitute* "volctl/lib/pulseaudio.py"
+                 (("libpulse.so.0")
+                  (string-append pulse "/lib/libpulse.so.0")))
+               #t))))))
+    (inputs
+     `(("gtk+" ,gtk+)
+       ("libxfixes" ,libxfixes)
+       ("pulseaudio" ,pulseaudio)))
+    (propagated-inputs
+     `(("python-click" ,python-click)
+       ("python-pycairo" ,python-pycairo)
+       ("python-pygobject" ,python-pygobject)
+       ("python-pyyaml" ,python-pyyaml)))
+    (home-page "https://buzz.github.io/volctl/")
+    (synopsis "Per-application volume control and OSD for Linux desktops")
+    (description "Volctl is a PulseAudio-enabled tray icon volume control and
+OSD applet for Linux desktops.  It's not meant to be an replacement for a
+full-featured mixer application.  If you're looking for that check out the
+excellent pavucontrol.")
+    (license license:gpl2)))
-- 
2.31.1





Information forwarded to guix-patches <at> gnu.org:
bug#48027; Package guix-patches. (Mon, 03 May 2021 21:10:02 GMT) Full text and rfc822 format available.

Message #8 received at 48027 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Streit <simon <at> netpanic.org>
Cc: 48027 <at> debbugs.gnu.org
Subject: Re: bug#48027: [PATCH] gnu: Add volctl.
Date: Mon, 03 May 2021 23:09:22 +0200
Hi Simon,

Simon Streit <simon <at> netpanic.org> skribis:

> * gnu/packages/gtk.scm: New Variable.

[...]

> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append "https://github.com/buzz/" name
> +                                  "/archive/v" version ".tar.gz"))
> +              (sha256
> +               (base32
> +                "1xanqn6s2i6s2n6wysvgz6l58lsdkl3zmzz4hccla01gx7h4yx4f"))))

To placate ‘guix lint’, could you (1) use ‘git-fetch’ instead of
referring to an autogenerated tarball, and (2) add a ‘file-name’ field
as done elsewhere?

> +    (arguments
> +     `(#:tests? #t

You can remove this line, it’s the default.

> +    (synopsis "Per-application volume control and OSD for Linux desktops")
> +    (description "Volctl is a PulseAudio-enabled tray icon volume control and
> +OSD applet for Linux desktops.  It's not meant to be an replacement for a

I’d suggest:

  s/OSD/on-screen display (OSD)/
  s/Linux desktops/graphical desktops/

Could you send an updated patch?

Thank you,
Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#48027; Package guix-patches. (Thu, 06 May 2021 09:40:02 GMT) Full text and rfc822 format available.

Message #11 received at 48027 <at> debbugs.gnu.org (full text, mbox):

From: Simon Streit <simon <at> netpanic.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48027 <at> debbugs.gnu.org
Subject: Re: bug#48027: [PATCH] gnu: Add volctl.
Date: Thu, 06 May 2021 11:39:27 +0200
[Message part 1 (text/plain, inline)]
Hi Ludovic,

Ludovic Courtès <ludo <at> gnu.org> writes:
>> +    (source (origin
>> +              (method url-fetch)
>> +              (uri (string-append "https://github.com/buzz/" name
>> +                                  "/archive/v" version ".tar.gz"))
>> +              (sha256
>> +               (base32
>> +                "1xanqn6s2i6s2n6wysvgz6l58lsdkl3zmzz4hccla01gx7h4yx4f"))))
>
> To placate ‘guix lint’, could you (1) use ‘git-fetch’ instead of
> referring to an autogenerated tarball, and (2) add a ‘file-name’ field
> as done elsewhere?

Thanks for your reply.  I was using guix lint, but there I wasn't quite sure
how to it the correct way.  Yes, looking at other definitions I simply
copied it from there.  The linter is quiet now.  Thanks for your tip!

> Could you send an updated patch?

Applied the suggestions.  Please find the updated patch as attachment.
I'm well chuffed having this posted now.


Cheers,
Simon

[0001-gnu-Add-volctl.patch (text/x-patch, attachment)]

Reply sent to Ludovic Courtès <ludo <at> gnu.org>:
You have taken responsibility. (Sat, 08 May 2021 12:49:02 GMT) Full text and rfc822 format available.

Notification sent to Simon Streit <simon <at> netpanic.org>:
bug acknowledged by developer. (Sat, 08 May 2021 12:49:02 GMT) Full text and rfc822 format available.

Message #16 received at 48027-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Streit <simon <at> netpanic.org>
Cc: 48027-done <at> debbugs.gnu.org
Subject: Re: bug#48027: [PATCH] gnu: Add volctl.
Date: Sat, 08 May 2021 14:48:20 +0200
Hi Simon,

Simon Streit <simon <at> netpanic.org> skribis:

> From 64730108ee4900836637fe2b37619652e2252606 Mon Sep 17 00:00:00 2001
> From: Simon Streit <simon <at> netpanic.org>
> Date: Thu, 6 May 2021 11:22:08 +0200
> Subject: [PATCH] gnu: Add volctl.
>
> * gnu/packages/gtk.scm (volctl): New Variable.

Applied, thanks!

I followed up with a comment: it’s not clear to me whether it’s
GPLv2-only or GPLv2-or-any-later-version, given that ‘setup.py’ just
says GPLv2.  Thoughts?

Ludo’.




Information forwarded to guix-patches <at> gnu.org:
bug#48027; Package guix-patches. (Sat, 08 May 2021 22:30:02 GMT) Full text and rfc822 format available.

Message #19 received at 48027 <at> debbugs.gnu.org (full text, mbox):

From: Simon Streit <simon <at> netpanic.org>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48027 <at> debbugs.gnu.org
Subject: Re: bug#48027: [PATCH] gnu: Add volctl.
Date: Sun, 09 May 2021 00:30:30 +0200
Ludovic Courtès <ludo <at> gnu.org> writes:
> Applied, thanks!

Thanks as well! 

> I followed up with a comment: it’s not clear to me whether it’s
> GPLv2-only or GPLv2-or-any-later-version, given that ‘setup.py’ just
> says GPLv2.  Thoughts?

I was wondering this as well, and concluded that the auther is simply
using v2 [1]. Nothing else is stated. 

We might just leave it as it is for the time being?


Cheers! 

[1] https://github.com/buzz/volctl/blob/master/LICENSE.txt




Information forwarded to guix-patches <at> gnu.org:
bug#48027; Package guix-patches. (Mon, 10 May 2021 07:59:01 GMT) Full text and rfc822 format available.

Message #22 received at 48027 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Simon Streit <simon <at> netpanic.org>
Cc: 48027 <at> debbugs.gnu.org
Subject: Re: bug#48027: [PATCH] gnu: Add volctl.
Date: Mon, 10 May 2021 09:58:02 +0200
Hi,

Simon Streit <simon <at> netpanic.org> skribis:

> Ludovic Courtès <ludo <at> gnu.org> writes:
>> Applied, thanks!
>
> Thanks as well! 
>
>> I followed up with a comment: it’s not clear to me whether it’s
>> GPLv2-only or GPLv2-or-any-later-version, given that ‘setup.py’ just
>> says GPLv2.  Thoughts?
>
> I was wondering this as well, and concluded that the auther is simply
> using v2 [1]. Nothing else is stated. 
>
> We might just leave it as it is for the time being?

Yes, sounds good.

Thanks,
Ludo’.




bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Mon, 07 Jun 2021 11:24:06 GMT) Full text and rfc822 format available.

This bug report was last modified 2 years and 295 days ago.

Previous Next


GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.