GNU bug report logs - #48033
[PATCH] gnu: public-inbox: Update to 1.6.1.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48033 in the body.
You can then email your comments to 48033 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: guix-patches <at> gnu.org
Cc: Kyle Meyer <kyle <at> kyleam.com>
Subject: [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Mon, 26 Apr 2021 14:35:17 +0200

* gnu/packages/mail.scm (public-inbox): Update to 1.6.1.
[synopsis]: Capitalize “git”.
[description]: Likewise.
---
I haven’t tested it thoroughly; ‘public-inbox-init‘ and
‘public-inbox-index’ seem to work fine.

Cc: Kyle since you have been somewhat active on the public-inbox ML. :)

 gnu/packages/mail.scm | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 64c84d145d..43291ac267 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -4082,7 +4082,7 @@ Git and exports them in maildir format or to an MDA through a pipe.")
 (define-public public-inbox
   (package
     (name "public-inbox")
-    (version "1.5.0")
+    (version "1.6.1")
     (source
      (origin (method git-fetch)
              (uri (git-reference
@@ -4090,7 +4090,7 @@ Git and exports them in maildir format or to an MDA through a pipe.")
                    (commit (string-append "v" version))))
              (sha256
               (base32
-               "03zj7shdl3vibs7k5lr673bwcf8j1xx8is3mjz34ca4cdh6p5j2k"))
+               "0mlwnp5knr7rk9kv8grlh342wsq2193m22zs83cjn9p7x9r2x5f9"))
              (file-name (git-file-name name version))))
     (build-system perl-build-system)
     (arguments
@@ -4156,9 +4156,9 @@ Git and exports them in maildir format or to an MDA through a pipe.")
        ("perl-ipc-run" ,perl-ipc-run)
        ("perl-xml-feed" ,perl-xml-feed)))
     (home-page "https://public-inbox.org/README.html")
-    (synopsis "Archive mailing lists in git repositories")
+    (synopsis "Archive mailing lists in Git repositories")
     (description
-     "public-inbox implements the sharing of an email inbox via git to
+     "public-inbox implements the sharing of an email inbox via Git to
 complement or replace traditional mailing lists.  Readers may read via NNTP,
 Atom feeds or HTML archives.")
     (license license:agpl3+)))

base-commit: f365d48909156ad754a2ade45375f45b54b06bbc
-- 
2.31.1

Message #8 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Mon, 26 Apr 2021 20:59:11 -0400

Xinglu Chen writes:

> * gnu/packages/mail.scm (public-inbox): Update to 1.6.1.
> [synopsis]: Capitalize “git”.
> [description]: Likewise.
> ---
> I haven’t tested it thoroughly; ‘public-inbox-init‘ and
> ‘public-inbox-index’ seem to work fine.
>
> Cc: Kyle since you have been somewhat active on the public-inbox ML. :)

Thanks for updating this.

To add to your manual checks above (and to the passing test suite), I
tested out public-inbox-httpd with some inboxes I have locally, and
everything there seems to be working as expected.

I think the perl-filesys-notify-simple input should be dropped because
Filesys::Notify::Simple isn't used as of v1.6.0.  Linux::Inotify2 is
used instead, but it doesn't look like that's packaged for Guix yet.  I
believe public-inbox has some fallback behavior here so that
public-inbox-watch is still functional, but ideally Linux::Inotify2
would be added as an input with this update to 1.6.1.

Otherwise, this patch looks good to me, but fwiw there are a few
optional dependencies (already packaged in Guix) that could be added:

 * highlight (syntax highlight for associated code repositories)
 * perl-inline-c (nice to have for performance reasons)
 * perl-parse-recdescent (as of v1.6.0, used only for public-inbox-imapd)

Message #11 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Mon, 26 Apr 2021 21:09:38 -0400

Xinglu Chen writes:

>      (description
> -     "public-inbox implements the sharing of an email inbox via git to
> +     "public-inbox implements the sharing of an email inbox via Git to
>  complement or replace traditional mailing lists.  Readers may read via NNTP,
>  Atom feeds or HTML archives.")

As of 1.6.0, public-inbox supports running an anonymous IMAP server, so
it may be worth adding IMAP to this list.

Message #14 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Tue, 27 Apr 2021 22:21:22 +0200

On Mon, Apr 26 2021, Kyle Meyer wrote:

> Thanks for updating this.
>
> To add to your manual checks above (and to the passing test suite), I
> tested out public-inbox-httpd with some inboxes I have locally, and
> everything there seems to be working as expected.

Good to know.

> I think the perl-filesys-notify-simple input should be dropped because
> Filesys::Notify::Simple isn't used as of v1.6.0.  Linux::Inotify2 is
> used instead, but it doesn't look like that's packaged for Guix yet.  I
> believe public-inbox has some fallback behavior here so that
> public-inbox-watch is still functional, but ideally Linux::Inotify2
> would be added as an input with this update to 1.6.1.

Ok, I don't know much about Perl, but I will try to package
Linux::Inotify2.

> Otherwise, this patch looks good to me, but fwiw there are a few
> optional dependencies (already packaged in Guix) that could be added:
>
> * highlight (syntax highlight for associated code repositories)
> * perl-inline-c (nice to have for performance reasons)
> * perl-parse-recdescent (as of v1.6.0, used only for public-inbox-imapd)

Thanks for pointing these out, I will make sure to add them.

>>      (description
>> -     "public-inbox implements the sharing of an email inbox via git to
>> +     "public-inbox implements the sharing of an email inbox via Git to
>>  complement or replace traditional mailing lists.  Readers may read via NNTP,
>>  Atom feeds or HTML archives.")
>
> As of 1.6.0, public-inbox supports running an anonymous IMAP server, so
> it may be worth adding IMAP to this list.

Yeah, will do.

Thanks for the review!

Message #17 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Tue, 27 Apr 2021 23:03:11 +0200

On Tue, Apr 27 2021, Xinglu Chen wrote:

>> Otherwise, this patch looks good to me, but fwiw there are a few
>> optional dependencies (already packaged in Guix) that could be added:
>>
>> * highlight (syntax highlight for associated code repositories)
>> * perl-inline-c (nice to have for performance reasons)
>> * perl-parse-recdescent (as of v1.6.0, used only for public-inbox-imapd)
>
> Thanks for pointing these out, I will make sure to add them.

When adding ‘highlight’ to the inputs, one of the tests fail.

--8<---------------cut here---------------start------------->8---
[...]
t/filter_subjecttag.t ........ ok
t/filter_vger.t .............. ok
t/git.t ...................... ok
t/gzip_filter.t .............. ok
failed to open(filetypes.conf): No such file or directory at /tmp/guix-build-public-inbox-1.6.1.drv-0/source/blib/lib/PublicInbox/HlMod.pm line 25.
# Tests were run but no plan was declared and done_testing() was not seen.
# Looks like your test exited with 2 just after 1.
t/hl_mod.t ................... 
Dubious, test returned 2 (wstat 512, 0x200)
All 1 subtests passed 
t/html_index.t ............... ok
t/httpd-corner.t ............. ok
[...]

Test Summary Report
-------------------
t/hl_mod.t                 (Wstat: 512 Tests: 1 Failed: 0)
  Non-zero exit status: 2
  Parse errors: No plan found in TAP output
Files=108, Tests=4046, 241 wallclock secs ( 2.26 usr  0.33 sys + 98.46 cusr 114.51 csys = 215.56 CPU)
Result: FAIL
Failed 1/108 test programs. 0/4046 subtests failed.
make: *** [Makefile:1060: test_dynamic] Error 255
--8<---------------cut here---------------end--------------->8---

Any ideas?

Message #20 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Wed, 28 Apr 2021 00:22:27 -0400

Xinglu Chen writes:

> When adding ‘highlight’ to the inputs, one of the tests fail.
>
[...]
> failed to open(filetypes.conf): No such file or directory at /tmp/guix-build-public-inbox-1.6.1.drv-0/source/blib/lib/PublicInbox/HlMod.pm line 25.
> # Tests were run but no plan was declared and done_testing() was not seen.
> # Looks like your test exited with 2 just after 1.

Hmm, HlMod.pm is calling highlight's getFiletypesConfPath(), and it
looks like that returns a bare "filetypes.conf" (which doesn't exist)
rather than
"/gnu/store/...-highlight-3.62/share/highlight/config/filetypes.conf".

Here's what public-inbox's call boils down to:

--8<---------------cut here---------------start------------->8---
use highlight;
my $dir = highlight::DataDir->new;
$dir->initSearchDirectories('');
print $dir->getFiletypesConfPath('filetypes')."\n";
--8<---------------cut here---------------end--------------->8---

On my Debian Buster system that prints

  $ perl scratch.pl
  /etc/highlight/filetypes.conf

And when I go through Guix:

  $ guix environment -C --ad-hoc perl highlight -- perl scratch.pl
  filetypes.conf


I'm not sure why that would be.  Guix's highlight definition sets
HL_CONFIG_DIR, and that seems to get wired up correctly:

  $ guix environment -C --ad-hoc highlight -- highlight --print-config

  Config file search directories:
  /gnu/store/6a3jjm38qs80miyqpcb6j9madzy26plg-highlight-3.62/share/highlight/
  /gnu/store/6a3jjm38qs80miyqpcb6j9madzy26plg-highlight-3.62/share/highlight/config/

  Filetype config file:
  /gnu/store/6a3jjm38qs80miyqpcb6j9madzy26plg-highlight-3.62/share/highlight/config/filetypes.conf

  Compiler directive HL_DATA_DIR = /gnu/store/6a3jjm38qs80miyqpcb6j9madzy26plg-highlight-3.62/share/highlight/
  Compiler directive HL_CONFIG_DIR = /gnu/store/6a3jjm38qs80miyqpcb6j9madzy26plg-highlight-3.62/share/highlight/config/

Message #23 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Wed, 28 Apr 2021 15:16:07 +0200

On Wed, Apr 28 2021, Kyle Meyer wrote:

> Hmm, HlMod.pm is calling highlight's getFiletypesConfPath(), and it
> looks like that returns a bare "filetypes.conf" (which doesn't exist)
> rather than
> "/gnu/store/...-highlight-3.62/share/highlight/config/filetypes.conf".
>
> Here's what public-inbox's call boils down to:
> [...]

Thanks for looking into this.  I played around with the make flags for
‘highlight’, but that didn’t get me anywhere.

Maybe we could remove ‘highlight’ for now?  Also,
lib/PublicInbox/WwwHighlight.pm has this comment:

  # TODO: support highlight(1) for distros which don't package the
  # SWIG extension.  Also, there may be admins who don't want to
  # have ugly SWIG-generated code in a long-lived Perl process.

Maybe this will become true in the future. :)

Message #26 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Wed, 28 Apr 2021 17:53:52 -0400

Xinglu Chen writes:

> Maybe we could remove ‘highlight’ for now?

Sure, not adding it to the current definition sounds fine to me.

> Also,
> lib/PublicInbox/WwwHighlight.pm has this comment:
>
>   # TODO: support highlight(1) for distros which don't package the
>   # SWIG extension.  Also, there may be admins who don't want to
>   # have ugly SWIG-generated code in a long-lived Perl process.
>
> Maybe this will become true in the future. :)

Yeah :)  Or even pygments support:
https://public-inbox.org/meta/20191008215321.GA23962 <at> dcvr/

Message #29 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Thu, 29 Apr 2021 14:18:05 +0200

On Wed, Apr 28 2021, Kyle Meyer wrote:

>> Also,
>> lib/PublicInbox/WwwHighlight.pm has this comment:
>>
>>   # TODO: support highlight(1) for distros which don't package the
>>   # SWIG extension.  Also, there may be admins who don't want to
>>   # have ugly SWIG-generated code in a long-lived Perl process.
>>
>> Maybe this will become true in the future. :)
>
> Yeah :)  Or even pygments support:
> https://public-inbox.org/meta/20191008215321.GA23962 <at> dcvr/

That would be even better :)

I will send an updated series for this.

Message #32 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 48033 <at> debbugs.gnu.org
Subject: [PATCH v2 0/2] Update public-inbox to 1.6.1
Date: Thu, 29 Apr 2021 14:37:36 +0200

Changes since v1:
- Add some optional dependencies for ‘public-inbox’.

- Follow upstream and replace ‘perl-filesys-notify-simple’ with
  ‘perl-linux-inotify2’.

- Mention IMAP support in the description.

Xinglu Chen (2):
  gnu: Add perl-linux-inotify2.
  gnu: public-inbox: Update to 1.6.1.

 gnu/packages/mail.scm | 19 +++++++++++++------
 gnu/packages/perl.scm | 23 +++++++++++++++++++++++
 2 files changed, 36 insertions(+), 6 deletions(-)


base-commit: 510fbf7f9360ec5c7b93a45c2fa7ce168a15d9ae
-- 
2.31.1

Message #35 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 48033 <at> debbugs.gnu.org
Subject: [PATCH v2 1/2] gnu: Add perl-linux-inotify2.
Date: Thu, 29 Apr 2021 14:37:37 +0200

* gnu/packages/perl.scm (perl-linux-inotify2): New variable.
---
 gnu/packages/perl.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 559e6ad9e0..f0750e5620 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2020 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2020 Malte Frank Gerdes <malte.f.gerdes <at> gmail.com>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5905,6 +5906,28 @@ writing system to another, based on national or international transliteration
 tables.  Where possible a reverse transliteration is supported.")
     (license (package-license perl))))
 
+(define-public perl-linux-inotify2
+  (package
+    (name "perl-linux-inotify2")
+    (version "2.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/ML/MLEHMANN/Linux-Inotify2-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0crlxmaa4lsgdjm5p9ib8rdxiy70qj1s68za3q3v57v8ll6s4hfx"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-common-sense" ,perl-common-sense)))
+    (home-page "https://metacpan.org/release/Linux-Inotify2")
+    (synopsis "Scalable file change notification")
+    (description "This module implements an interface to the Linux 2.6.13 and
+later Inotify file change notification system.")
+    (license (package-license perl))))
+
 (define-public perl-list-allutils
   (package
     (name "perl-list-allutils")
-- 
2.31.1

Message #38 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 48033 <at> debbugs.gnu.org
Subject: [PATCH v2 2/2] gnu: public-inbox: Update to 1.6.1.
Date: Thu, 29 Apr 2021 14:37:41 +0200

* gnu/packages/mail.scm (public-inbox)[version]: Update to 1.6.1.
[inputs]: Add optional dependencies.  ‘perl-filesys-notify-simple’ has been
superseded by ‘perl-linux-inotify2’ by upstream.
[synopsis]: Capitalize “git”.
[description]: Likewise.  Mention IMAP support.
---
 gnu/packages/mail.scm | 19 +++++++++++++------
 1 file changed, 13 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index dc9c21f361..8d3d63fe37 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -123,6 +123,7 @@
   #:use-module (gnu packages perl-web)
   #:use-module (gnu packages pkg-config)
   #:use-module (gnu packages protobuf)
+  #:use-module (gnu packages pretty-print)
   #:use-module (gnu packages python)
   #:use-module (gnu packages python-check)
   #:use-module (gnu packages python-crypto)
@@ -4082,7 +4083,7 @@ Git and exports them in maildir format or to an MDA through a pipe.")
 (define-public public-inbox
   (package
     (name "public-inbox")
-    (version "1.5.0")
+    (version "1.6.1")
     (source
      (origin (method git-fetch)
              (uri (git-reference
@@ -4090,7 +4091,7 @@ Git and exports them in maildir format or to an MDA through a pipe.")
                    (commit (string-append "v" version))))
              (sha256
               (base32
-               "03zj7shdl3vibs7k5lr673bwcf8j1xx8is3mjz34ca4cdh6p5j2k"))
+               "0mlwnp5knr7rk9kv8grlh342wsq2193m22zs83cjn9p7x9r2x5f9"))
              (file-name (git-file-name name version))))
     (build-system perl-build-system)
     (arguments
@@ -4145,22 +4146,28 @@ Git and exports them in maildir format or to an MDA through a pipe.")
        ("perl-email-mime" ,perl-email-mime)
        ("perl-email-simple" ,perl-email-simple)
        ("perl-net-server" ,perl-net-server)
-       ("perl-filesys-notify-simple" ,perl-filesys-notify-simple)
        ("perl-plack-middleware-deflater" ,perl-plack-middleware-deflater)
        ("perl-plack-middleware-reverseproxy" ,perl-plack-middleware-reverseproxy)
        ("perl-plack" ,perl-plack)
        ("perl-search-xapian" ,perl-search-xapian)
        ("perl-timedate" ,perl-timedate)
        ("perl-uri-escape" ,perl-uri-escape)
+       ("perl-inline-c" ,perl-inline-c)
+       ("perl-parse-recdescent" ,perl-parse-recdescent)
+       ("perl-linux-inotify2" ,perl-linux-inotify2)
+       ;; FIXME: Perl modules are unable to find the config file for highlight
+       ;; https://issues.guix.gnu.org/48033#4
+       ;; ("highlight" ,highlight)
+
        ;; For testing.
        ("perl-ipc-run" ,perl-ipc-run)
        ("perl-xml-feed" ,perl-xml-feed)))
     (home-page "https://public-inbox.org/README.html")
-    (synopsis "Archive mailing lists in git repositories")
+    (synopsis "Archive mailing lists in Git repositories")
     (description
-     "public-inbox implements the sharing of an email inbox via git to
+     "public-inbox implements the sharing of an email inbox via Git to
 complement or replace traditional mailing lists.  Readers may read via NNTP,
-Atom feeds or HTML archives.")
+IMAP, Atom feeds or HTML archives.")
     (license license:agpl3+)))
 
 (define-public sylpheed
-- 
2.31.1

Message #41 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Kyle Meyer <kyle <at> kyleam.com>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH v2 2/2] gnu: public-inbox: Update to 1.6.1.
Date: Fri, 30 Apr 2021 19:49:58 -0400

Xinglu Chen writes:

> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
> index dc9c21f361..8d3d63fe37 100644
> --- a/gnu/packages/mail.scm
> +++ b/gnu/packages/mail.scm
> @@ -123,6 +123,7 @@
>    #:use-module (gnu packages perl-web)
>    #:use-module (gnu packages pkg-config)
>    #:use-module (gnu packages protobuf)
> +  #:use-module (gnu packages pretty-print)

Should this be dropped given that the `highlight' input is left as a
FIXME comment?  Otherwise this and the first patch look good to me.

Thanks.

Message #44 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: Kyle Meyer <kyle <at> kyleam.com>
Cc: 48033 <at> debbugs.gnu.org
Subject: Re: [bug#48033] [PATCH v2 2/2] gnu: public-inbox: Update to 1.6.1.
Date: Sat, 01 May 2021 14:01:35 +0200

On Fri, Apr 30 2021, Kyle Meyer wrote:

> Xinglu Chen writes:
>
>> diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
>> index dc9c21f361..8d3d63fe37 100644
>> --- a/gnu/packages/mail.scm
>> +++ b/gnu/packages/mail.scm
>> @@ -123,6 +123,7 @@
>>    #:use-module (gnu packages perl-web)
>>    #:use-module (gnu packages pkg-config)
>>    #:use-module (gnu packages protobuf)
>> +  #:use-module (gnu packages pretty-print)
>
> Should this be dropped given that the `highlight' input is left as a
> FIXME comment?  Otherwise this and the first patch look good to me.

Ah, good catch!

Message #47 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 48033 <at> debbugs.gnu.org
Subject: [PATCH v3 0/2] Update public-inbox to 1.6.1
Date: Sat, 01 May 2021 14:04:59 +0200

Changes since v2:
- Removed unused import (gnu packages pretty-print) from (gnu packages
mail).

Xinglu Chen (2):
  gnu: Add perl-linux-inotify2.
  gnu: public-inbox: Update to 1.6.1.

 gnu/packages/mail.scm | 18 ++++++++++++------
 gnu/packages/perl.scm | 23 +++++++++++++++++++++++
 2 files changed, 35 insertions(+), 6 deletions(-)


base-commit: c04dfb39f62f764b1c3988d9b0fcedc8221afa67
-- 
2.31.1

Message #50 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 48033 <at> debbugs.gnu.org
Subject: [PATCH v3 1/2] gnu: Add perl-linux-inotify2.
Date: Sat, 01 May 2021 14:05:00 +0200

* gnu/packages/perl.scm (perl-linux-inotify2): New variable.
---
 gnu/packages/perl.scm | 23 +++++++++++++++++++++++
 1 file changed, 23 insertions(+)

diff --git a/gnu/packages/perl.scm b/gnu/packages/perl.scm
index 559e6ad9e0..f0750e5620 100644
--- a/gnu/packages/perl.scm
+++ b/gnu/packages/perl.scm
@@ -29,6 +29,7 @@
 ;;; Copyright © 2020 Nicolas Goaziou <mail <at> nicolasgoaziou.fr>
 ;;; Copyright © 2020 Malte Frank Gerdes <malte.f.gerdes <at> gmail.com>
 ;;; Copyright © 2021 Maxim Cournoyer <maxim.cournoyer <at> gmail.com>
+;;; Copyright © 2021 Xinglu Chen <public <at> yoctocell.xyz>
 ;;;
 ;;; This file is part of GNU Guix.
 ;;;
@@ -5905,6 +5906,28 @@ writing system to another, based on national or international transliteration
 tables.  Where possible a reverse transliteration is supported.")
     (license (package-license perl))))
 
+(define-public perl-linux-inotify2
+  (package
+    (name "perl-linux-inotify2")
+    (version "2.2")
+    (source
+     (origin
+       (method url-fetch)
+       (uri (string-append
+             "mirror://cpan/authors/id/M/ML/MLEHMANN/Linux-Inotify2-"
+             version ".tar.gz"))
+       (sha256
+        (base32
+         "0crlxmaa4lsgdjm5p9ib8rdxiy70qj1s68za3q3v57v8ll6s4hfx"))))
+    (build-system perl-build-system)
+    (propagated-inputs
+     `(("perl-common-sense" ,perl-common-sense)))
+    (home-page "https://metacpan.org/release/Linux-Inotify2")
+    (synopsis "Scalable file change notification")
+    (description "This module implements an interface to the Linux 2.6.13 and
+later Inotify file change notification system.")
+    (license (package-license perl))))
+
 (define-public perl-list-allutils
   (package
     (name "perl-list-allutils")
-- 
2.31.1

Message #53 received at 48033 <at> debbugs.gnu.org (full text, mbox):

From: Xinglu Chen <public <at> yoctocell.xyz>
To: 48033 <at> debbugs.gnu.org
Subject: [PATCH v3 2/2] gnu: public-inbox: Update to 1.6.1.
Date: Sat, 01 May 2021 14:05:03 +0200

* gnu/packages/mail.scm (public-inbox)[version]: Update to 1.6.1.
[inputs]: Add optional dependencies.  ‘perl-filesys-notify-simple’ has been
superseded by ‘perl-linux-inotify2’ by upstream.
[synopsis]: Capitalize “git”.
[description]: Likewise.  Mention IMAP support.
---
 gnu/packages/mail.scm | 18 ++++++++++++------
 1 file changed, 12 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/mail.scm b/gnu/packages/mail.scm
index 5d307df124..2f2cfef543 100644
--- a/gnu/packages/mail.scm
+++ b/gnu/packages/mail.scm
@@ -4081,7 +4081,7 @@ Git and exports them in maildir format or to an MDA through a pipe.")
 (define-public public-inbox
   (package
     (name "public-inbox")
-    (version "1.5.0")
+    (version "1.6.1")
     (source
      (origin (method git-fetch)
              (uri (git-reference
@@ -4089,7 +4089,7 @@ Git and exports them in maildir format or to an MDA through a pipe.")
                    (commit (string-append "v" version))))
              (sha256
               (base32
-               "03zj7shdl3vibs7k5lr673bwcf8j1xx8is3mjz34ca4cdh6p5j2k"))
+               "0mlwnp5knr7rk9kv8grlh342wsq2193m22zs83cjn9p7x9r2x5f9"))
              (file-name (git-file-name name version))))
     (build-system perl-build-system)
     (arguments
@@ -4144,22 +4144,28 @@ Git and exports them in maildir format or to an MDA through a pipe.")
        ("perl-email-mime" ,perl-email-mime)
        ("perl-email-simple" ,perl-email-simple)
        ("perl-net-server" ,perl-net-server)
-       ("perl-filesys-notify-simple" ,perl-filesys-notify-simple)
        ("perl-plack-middleware-deflater" ,perl-plack-middleware-deflater)
        ("perl-plack-middleware-reverseproxy" ,perl-plack-middleware-reverseproxy)
        ("perl-plack" ,perl-plack)
        ("perl-search-xapian" ,perl-search-xapian)
        ("perl-timedate" ,perl-timedate)
        ("perl-uri-escape" ,perl-uri-escape)
+       ("perl-inline-c" ,perl-inline-c)
+       ("perl-parse-recdescent" ,perl-parse-recdescent)
+       ("perl-linux-inotify2" ,perl-linux-inotify2)
+       ;; FIXME: Perl modules are unable to find the config file for highlight
+       ;; https://issues.guix.gnu.org/48033#4
+       ;; ("highlight" ,highlight)
+
        ;; For testing.
        ("perl-ipc-run" ,perl-ipc-run)
        ("perl-xml-feed" ,perl-xml-feed)))
     (home-page "https://public-inbox.org/README.html")
-    (synopsis "Archive mailing lists in git repositories")
+    (synopsis "Archive mailing lists in Git repositories")
     (description
-     "public-inbox implements the sharing of an email inbox via git to
+     "public-inbox implements the sharing of an email inbox via Git to
 complement or replace traditional mailing lists.  Readers may read via NNTP,
-Atom feeds or HTML archives.")
+IMAP, Atom feeds or HTML archives.")
     (license license:agpl3+)))
 
 (define-public sylpheed
-- 
2.31.1

Message #58 received at 48033-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Xinglu Chen <public <at> yoctocell.xyz>
Cc: 48033-done <at> debbugs.gnu.org
Subject: Re: bug#48033: [PATCH] gnu: public-inbox: Update to 1.6.1.
Date: Mon, 03 May 2021 18:27:04 +0200

Hi,

Xinglu Chen <public <at> yoctocell.xyz> skribis:

> Xinglu Chen (2):
>   gnu: Add perl-linux-inotify2.
>   gnu: public-inbox: Update to 1.6.1.
>
>  gnu/packages/mail.scm | 18 ++++++++++++------
>  gnu/packages/perl.scm | 23 +++++++++++++++++++++++
>  2 files changed, 35 insertions(+), 6 deletions(-)

Applied both patches, thank you, and thanks Kyle for reviewing!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.