GNU bug report logs - #48062
make check fails if configured with --program-prefix

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48062 in the body.
You can then email your comments to 48062 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Jun T <takimoto-j <at> kba.biglobe.ne.jp>
To: bug-diffutils <at> gnu.org
Subject: make check fails if configured with --program-prefix
Date: Tue, 27 Apr 2021 20:09:01 +0900

$ ./configure --program-prefix=g
$ make
$ make check

then two tests diff3 and help-version fail.
The reason is quite simple; the log contains lines like

+diff3: subsidiary program 'gdiff' not found

If I run

$ cd src
$ ln -s diff gdiff

then 'make check' succeeds.

If there were a program named 'gdiff' in my PATH then it would
have been used for the test.

Message #8 received at 48062 <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: 48062 <at> debbugs.gnu.org
Subject: Re: make check fails if configured with --program-prefix
Date: Sun, 23 Jun 2024 03:14:48 -0700

[Message part 1 (text/plain, inline)]

Hi,

Jun T says:
> $ ./configure --program-prefix=g
> $ make
> $ make check
>
> then two tests diff3 and help-version fail.
> The reason is quite simple; the log contains lines like
>
> +diff3: subsidiary program 'gdiff' not found

I noticed this since I use --program-prefix=g too. More generally
--program-{prefix,suffix} are simpler forms of
--program-transform-name.

The error is because the sed pattern given to that option is only used
on the executable after 'make install'. I've attached a patch that
invokes diff3 and sdiff with --diff-program=diff which should make the
tests pass regardless of the options passed to ./configure.

Collin

[0001-tests-Don-t-fail-when-program-transform-name-is-used.patch (text/x-patch, attachment)]

Message #11 received at 48062 <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: 48062 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#48062: make check fails if configured with
 --program-prefix
Date: Sun, 23 Jun 2024 22:52:23 -0700

On Sun, Jun 23, 2024 at 3:16 AM Collin Funk <collin.funk1 <at> gmail.com> wrote:
> Hi,
>
> Jun T says:
> > $ ./configure --program-prefix=g
> > $ make
> > $ make check
> >
> > then two tests diff3 and help-version fail.
> > The reason is quite simple; the log contains lines like
> >
> > +diff3: subsidiary program 'gdiff' not found
>
> I noticed this since I use --program-prefix=g too. More generally
> --program-{prefix,suffix} are simpler forms of
> --program-transform-name.
>
> The error is because the sed pattern given to that option is only used
> on the executable after 'make install'. I've attached a patch that
> invokes diff3 and sdiff with --diff-program=diff which should make the
> tests pass regardless of the options passed to ./configure.

Thank you. Applied and pushed.
Unrelated, I noticed that a gnulib test failed on Fedora 40:

$ make check
...
/bin/ld: test-pthread-cond.o: in function `pthread_cond_timedwait_routine':
/home/j/w/co/diffutils/gnulib-tests/test-pthread-cond.c:146:(.text+0x103):
undefined reference to `__pthread_cond_timedwait64'
collect2: error: ld returned 1 exit status
  CCLD     test-putenv
make[4]: *** [Makefile:5745: test-pthread-cond] Error 1

Message #14 received at 48062 <at> debbugs.gnu.org (full text, mbox):

From: Paul Eggert <eggert <at> cs.ucla.edu>
To: Jim Meyering <jim <at> meyering.net>, Collin Funk <collin.funk1 <at> gmail.com>
Cc: 48062 <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#48062: bug#48062: make check fails if
 configured with --program-prefix
Date: Mon, 24 Jun 2024 10:00:01 -0400

On 6/24/24 01:52, Jim Meyering wrote:
> Unrelated, I noticed that a gnulib test failed on Fedora 40:
> 
> $ make check
> ...
> /bin/ld: test-pthread-cond.o: in function `pthread_cond_timedwait_routine':
> /home/j/w/co/diffutils/gnulib-tests/test-pthread-cond.c:146:(.text+0x103):
> undefined reference to `__pthread_cond_timedwait64'
> collect2: error: ld returned 1 exit status

I'm not seeing that on my Fedora 40 build of diffutils. There is no file 
diffutils/gnulib-tests/test-pthread-cond.c in my source tree, after 
running './bootstrap --gnulib-refdir=$HOME/src/gnu/gnulib' in a fresh 
diffutils clone. Also, in a current Gnulib the command './gnulib-tool 
--test pthread-cond' works for me.

Perhaps some files left over from one of your previous diffutils builds 
need to be cleaned out?

Message #17 received at 48062 <at> debbugs.gnu.org (full text, mbox):

From: Collin Funk <collin.funk1 <at> gmail.com>
To: Paul Eggert <eggert <at> cs.ucla.edu>
Cc: 48062 <at> debbugs.gnu.org, Jim Meyering <jim <at> meyering.net>
Subject: Re: [bug-diffutils] bug#48062: bug#48062: make check fails if
 configured with --program-prefix
Date: Mon, 24 Jun 2024 15:57:02 -0700

Paul Eggert <eggert <at> cs.ucla.edu> writes:

> I'm not seeing that on my Fedora 40 build of diffutils. There is no
> file diffutils/gnulib-tests/test-pthread-cond.c in my source tree,
> after running './bootstrap --gnulib-refdir=$HOME/src/gnu/gnulib' in a
> fresh diffutils clone. Also, in a current Gnulib the command
> './gnulib-tool --test pthread-cond' works for me.
>
> Perhaps some files left over from one of your previous diffutils
> builds need to be cleaned out?

Mine works fine on Fedora 40 as well. Probably old files like Paul said.
I habitually run 'git clean -xdf' and './boostrap && ./configure' so I'm
not sure how possible that is. :)

Also, feel free to close this bug. I'm not very familiar with debbugs,
sorry.

Collin

Message #22 received at 48062-done <at> debbugs.gnu.org (full text, mbox):

From: Jim Meyering <jim <at> meyering.net>
To: Collin Funk <collin.funk1 <at> gmail.com>
Cc: Paul Eggert <eggert <at> cs.ucla.edu>, 48062-done <at> debbugs.gnu.org
Subject: Re: [bug-diffutils] bug#48062: bug#48062: make check fails if
 configured with --program-prefix
Date: Mon, 24 Jun 2024 18:20:01 -0700

On Mon, Jun 24, 2024 at 3:57 PM Collin Funk <collin.funk1 <at> gmail.com> wrote:
>
> Paul Eggert <eggert <at> cs.ucla.edu> writes:
>
> > I'm not seeing that on my Fedora 40 build of diffutils. There is no
> > file diffutils/gnulib-tests/test-pthread-cond.c in my source tree,
> > after running './bootstrap --gnulib-refdir=$HOME/src/gnu/gnulib' in a
> > fresh diffutils clone. Also, in a current Gnulib the command
> > './gnulib-tool --test pthread-cond' works for me.
> >
> > Perhaps some files left over from one of your previous diffutils
> > builds need to be cleaned out?
>
> Mine works fine on Fedora 40 as well. Probably old files like Paul said.
> I habitually run 'git clean -xdf' and './boostrap && ./configure' so I'm
> not sure how possible that is. :)
>
> Also, feel free to close this bug. I'm not very familiar with debbugs,
> sorry.

Thank you both for confirming.
I too have confirmed that in a clean clone, there's no problem.

I'm closing this bug by changing my reply-all recipient address
48062 <at> debbugs.gnu.org to 48062-done <at> debbugs.gnu.org

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.