Lars Ingebrigtsen <larsi@HIDDEN>
to control <at> debbugs.gnu.org.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 17:10:15 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 13:10:15 2021 Received: from localhost ([127.0.0.1]:53983 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbnhX-0003LP-EW for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 13:10:15 -0400 Received: from mout.gmx.net ([212.227.15.15]:39367) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1lbnhS-0003L5-BR for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 13:10:14 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619629803; bh=2cG0mH11x6yzmRejzXMU/Uw9Zd+sqNKauu+rGbiWhx8=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=VGaUNqzzx/ARX1A/X/IbyM/5Ldp9awrqkGe6vh9EHo16VWUGnD9aEcM8/64g3JBuG 5JNMMtZ+rQ1AMpHbSUrlzBMdGl8aSNA57zKyjvFu4E6vjhQMwvtcvlhGlbHDwgNmB+ PgCFYramD2PzWCIR+VKbtZvXcvQoPOQ/PVjOMe48= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.93]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MIMbO-1lq72N0DnY-00ELOJ; Wed, 28 Apr 2021 19:10:03 +0200 From: Michael Albinus <michael.albinus@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> <838s52hb7h.fsf@HIDDEN> <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> <83mttiftnl.fsf@HIDDEN> <20210428150144.4uxrcguggkh7vrjx@HIDDEN> <83a6pifnnc.fsf@HIDDEN> <20210428152136.dggvck4is57wyavd@HIDDEN> <838s52flu5.fsf@HIDDEN> Date: Wed, 28 Apr 2021 19:10:00 +0200 In-Reply-To: <838s52flu5.fsf@HIDDEN> (Eli Zaretskii's message of "Wed, 28 Apr 2021 18:52:18 +0300") Message-ID: <87k0om1gk7.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:Fz1sV4xwmIs36S9iOaEUyPeRx60lu8ahbU8GuvGJG9iAlCU3JH3 CW3RD+yHGNNg3cGi05V4xQTS1WKQ7XV/qh//bb9HBIVdp+NQHdlBk8EOhDehZEukskP0IB2 Di8+wMb9t7ZzA+bsVGQj8qgL5DecMuo/FPQBOz0QrbBRRHq4i6ZKuYBArhWnc9G73T3Y72H JHV6Tv3ADN/BfdYUvo39g== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:ATcBGVO/8ag=:CKbItSgDma3XK3J2iFkEZz TOlYwL2DGuidHy+tD7td5YJT6E7vCfIn2K/qu/5ZUWFfSliEuPMUKK3TVBOi68BLoBuz6Rotx OM8V73zO70FBVdQWkuSv/FqsV5jm+skVFihJrfEI0MqWFzBBSLt9809W86itNp4WNT8sjlNTL bcFzRYFkSbHI8XMQ6Qnbd8gCN3Vd/Xd6aGLppmvfB6AesOvdcTCaAK9Ukxma2YJFbVR7ZbiNY JUWHMXtN6ZQJrR3BkTHSf7b3I8dMIDlXgTukjyvns7xfqDynzlIjVKzuv3WGEFOFALuYeesJL AV7VCC7bDnQg8VF20d0B1qjWm3i5bsUoYaS3ciwtM4a4+Wth+QnfdBCtqtQ6wDCCim9+3OwCV lLv7m/H35TqX5xt1bRP7Wjndfeocd9kTC6iARLzDiDxJoEZxHRJ3sW8lT4cRq6Oq6iAi/4JIw VfPKX/Gq7dokr4VwXG4HO5zfPdzSWU/3NXirznDyE7sbCXqqLDHFtYE8tKclAofqrc/dHISUp dxX1qPT/o+uyRANC1c0FXGWDHtKDgq9lf33fPp3dyUo45atcglqaxUAU+eeP5USfS6L2xuLSM 21mA5A7G/sd7Qd1aPo834td2To6ICQ9xSKQZke9G3+U8TasZyRze8+rUAF0EqNdFniCpp40u2 AJcxiVELH8sEG4hCQV3vDBWf+MG3kgOhKagfOl9cl+I7Efbq0Fg5Ggy8pNFsnlQ7j6QmJDxfd /eIOva1hW4GyJ2EbLknTuSHgeH0TXgR8M9bvFwA1Uo2mU5Sq2mftCVCveLN16J8nv95GLyFv9 BUCxqLsbthMYiOKAt9DZkVHf9MX1p1J0/3otiQ89S4TsClAsQRXi8P4lkuO4UagQSARWSoSTo 0/xMMi4P3kX9ebT9iTjV8dDXp+k64niTIn2kTo2bNv5tMfvgZItvvAQVvFalsxNkjGp/YmUhB UHSdgFAV0RmKlB5b/9yjKoqBdgQHVOR5T6nLW4r3WHNCWQIikqNHyXxhA2ZMNJx0xfwf43JO7 x1UbMP1KLt85fn3m+aYxSFXfdEvdPHKo+87/fMI+mJw1dlr8vrxsAjRD+8a40qPxADoicYUYy Lr6pA9vLd4d33SO+4tndENlnk+8Q7L3xPh96Zbav70rlJaPhR753mycS3LBcj1/91WTpxmq9T qeJKhXMFqHiQWvnrrcIQTrUFFn4+LTX+4X/Z8+n7HEm4Gwe92MGFGh9xWYAFr3l0uSvubZqpc exTLz0olRljk/KiZ9 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, Boruch Baum <boruch_baum@HIDDEN>, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Eli Zaretskii <eliz@HIDDEN> writes: >> > I think the message comes from process.c:status_notify, which is >> > called when the process is deleted after it exits. >> >> Thanks. It was frustrating not being able to find it. >> >> 1) Is there a way to make it user-extensible? >> >> 2) Can it report some indication of STDERR or shell variable '$?' ? >> >> 3) The '&wait' shouldn't be reported. It's just confusing cruft to a us= er. > > I guess you can define your own sentinel function, and then do there > what you want. The default mechanism to hide this message is to take #'ignore as sentinel :-) > For STDERR, you could redirect it as you see fit. Yes, although I must confess there are limitations for STDERR for remote processes. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 15:52:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 11:52:47 2021 Received: from localhost ([127.0.0.1]:53851 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbmUZ-0001Iy-4H for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:52:47 -0400 Received: from eggs.gnu.org ([209.51.188.92]:60468) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lbmUW-0001Ik-4m for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:52:46 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45880) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lbmUL-0002lj-1z; Wed, 28 Apr 2021 11:52:35 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4221 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lbmUJ-0001nb-2u; Wed, 28 Apr 2021 11:52:32 -0400 Date: Wed, 28 Apr 2021 18:52:18 +0300 Message-Id: <838s52flu5.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> In-Reply-To: <20210428152136.dggvck4is57wyavd@HIDDEN> (message from Boruch Baum on Wed, 28 Apr 2021 11:21:36 -0400) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> <838s52hb7h.fsf@HIDDEN> <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> <83mttiftnl.fsf@HIDDEN> <20210428150144.4uxrcguggkh7vrjx@HIDDEN> <83a6pifnnc.fsf@HIDDEN> <20210428152136.dggvck4is57wyavd@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 28 Apr 2021 11:21:36 -0400 > From: Boruch Baum <boruch_baum@HIDDEN> > Cc: kevin.legouguec@HIDDEN, 48072 <at> debbugs.gnu.org > > > I think the message comes from process.c:status_notify, which is > > called when the process is deleted after it exits. > > Thanks. It was frustrating not being able to find it. > > 1) Is there a way to make it user-extensible? > > 2) Can it report some indication of STDERR or shell variable '$?' ? > > 3) The '&wait' shouldn't be reported. It's just confusing cruft to a user. I guess you can define your own sentinel function, and then do there what you want. For STDERR, you could redirect it as you see fit.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 15:21:48 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 11:21:47 2021 Received: from localhost ([127.0.0.1]:53810 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbm0Z-0000Z1-Ll for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:21:47 -0400 Received: from mout.gmx.net ([212.227.15.19]:33991) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <boruch_baum@HIDDEN>) id 1lbm0X-0000Yn-G2 for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:21:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619623299; bh=GbubX3ohPSZFHHcHlByj/pV9kCeSb0T3tiuv27AhDgw=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=kJP6CLzPILCWDj7Su3p+MqU5n4IhX75LGJCmijWA69Wh5mQ5R6LIsQDr7wy0XVrbA Mn8yFxOdd3CEpPBfAN0rAafYx7INw1TGbXLlEOUa1GWZwkN+sgj8wC/hhdPO/gqGOm 1p7R+/qYxuJTPKPWACP2icfqIOcAj2w9M8foXV/4= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx004 [212.227.17.184]) with ESMTPSA (Nemesis) id 1MqJqD-1lG8W147BD-00nNhs; Wed, 28 Apr 2021 17:21:39 +0200 Date: Wed, 28 Apr 2021 11:21:36 -0400 From: Boruch Baum <boruch_baum@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Message-ID: <20210428152136.dggvck4is57wyavd@HIDDEN> References: <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> <838s52hb7h.fsf@HIDDEN> <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> <83mttiftnl.fsf@HIDDEN> <20210428150144.4uxrcguggkh7vrjx@HIDDEN> <83a6pifnnc.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83a6pifnnc.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:1ADN91jRcK98IntTLmmQncDua3tcEiSdxv55MZsKsqID0RRc73H fl0NObgvLrbeBqkwG6kNPlgb4BBatyjD7GTMM63eJ4F1dioSlXtU5/5kwiSdFbmp09oJK3r swnESpE4arYzfT8ZjH/wacJaX0xLu0cBj1KSKzc1lmA+1UXhacBSbTnDtSvsLP2xL3bYsEw GRoevMx7jjceR+Cl/W5/w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:7tSHnV2kRt4=:epf+FDvxhZj+M/BuOfZ+4L 4KOFv1SquBhsmtJXgmFoNwu/+uF1gnpWvh3AZLdG+bYI5z3ahsW6l5K9VJSZmiEe8NlNzXeRU 9cXjZF59T2f0+/IJB0y3hqwGLaHLjhI0ZOHCD7DZTlTHqfztwva8Qu6OkT3M4hHkZRYrn1Ifi oibDPsvAk79pLvNomiy9Sk52n7pI07/Qds1bh7cTRoYVPJptYbDthcU5abfSCl+Hb5CHgKWRu L9vU8szFfNA5vuzalmvFoEFtY7cR1+BH9ue8kfYRICltR1rWXbdHloQ/Vxb9zmo7ymKrxX+Gj VBJ+rDcKHjUhxLtBM41fDjqpdvIldPXAU9AhHfiYbZeFOzArVbA2683aG4HNrlLr1sYDiFq3w vKQB/wd4xb1ffy1SmDweEsYV5d2QXf7vT4tlYILViUsxNfnw4aUfhvQxQH0DoivmsYhRFyGyi IDryo4356H6+f0k1UrKzFGo3MahHzVAazDMXibH6OAspCkaUG7cFrbUyV7y4fxyAeqdiB3z1f oGhLuF/D+2Df1DNSrT1IHg8z6SctwXfLrScqBYsnxZJQ3002Ms+OHJEScbNpdxhxDi5ToAF1P REq6gmSBoUWIpIAxlOWzG8uYyqZCgpLy9xLWKahMgJOocQrRiOy3sF0psR7eRMXW55CRgd5f9 D/1DKTUoZlux9A3r3yq3k5vtNPvL8e/Voyd6Tzje8036PmdSjs0SIEPY39F/+kZhTp6XRfmdr 7XByoDNupTKgGIf1FJrThOFBfufzQp5K0U/QgTsCnXo7/SXzfVaeZgw6ktKXp4LXdIox2fm8S d3LU+P0doJyJpoMs8vtHu+lxt4z93J7ZUNxb0LHm8ljjc+rlc33tb8xYs+j3MID3UV7gbxwB/ xhm3+dirJohVl5ZkUuiRwy6qTsahU+97AN9nb0mKQbdme6nnXaYABlQNUisSeilxr85rtNe0W Zy1cmcl+iySqstymaqC6ikAwaR5UXd8hJYEMiwJ8AOUmAiE72MdLXavDYm733Mj3W46dYN7bR UHpxmplNi04sWLzNhJRacZ021LjMZgPZ+lRHHg9LvaiO8CGyZYkqcowKRlFHWQw/IQbk3+GPs Omn7Uc/wAlCflJAUEREacqeCQNSCNK32oMeozydu+DCVLhihJ8kgT6W/MwUZYtTnGj5zaqB90 7Uth/s/qTuOpb6shgbt/kooU4zbLF2ee+FnSQBeMQAcxzKOu9RqFz2Ftz8SiHDhQs6kuY= Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.3 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 2021-04-28 18:13, Eli Zaretskii wrote: > > Date: Wed, 28 Apr 2021 11:01:44 -0400 > > From: Boruch Baum <boruch_baum@HIDDEN> > > Cc: kevin.legouguec@HIDDEN, 48072 <at> debbugs.gnu.org > > > > 2.1.1) Try the following in a vanilla dired buffer: Navigate POINT to = a file, > > let's say 'bar', and press '&' for the async command. Then type= in some > > garbage command, let's say 'foo', and <RET>. The response I get= is a > > message in the mini-buffer: "foo bar&wait: finished." (BTW, I h= aven't > > figured out where that message is being generated; anyone's hel= p would be > > appreciated; I would like to see if it can report errors). > > I think the message comes from process.c:status_notify, which is > called when the process is deleted after it exits. Thanks. It was frustrating not being able to find it. 1) Is there a way to make it user-extensible? 2) Can it report some indication of STDERR or shell variable '$?' ? 3) The '&wait' shouldn't be reported. It's just confusing cruft to a user. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.
Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 15:16:45 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 11:16:45 2021
Received: from localhost ([127.0.0.1]:53794 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lblvg-0000R5-VV
for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:16:45 -0400
Received: from mout.gmx.net ([212.227.17.20]:53443)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <boruch_baum@HIDDEN>) id 1lblve-0000Qr-Jc
for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:16:43 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1619622996;
bh=0RWtB7ZQwbY36uPx9ZffsMFosozRT8oPfylMumkImHM=;
h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
b=iZypgguV2Y0UVuiCLJbDMTCHHlpybv65El27728D/oRHmAF4lw2IOLh6o9zizKaoT
XBIYlnlVjMU3RWAQG1Rz+Odgk+u+ABiyJ/HIIM0IV7cSBeCXWcTB1eGvxVwm37FUjT
Qc9M9+Xrs7HziJMSCyS+m87aXiW2H9HeRETS0LwE=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104
[212.227.17.174]) with ESMTPSA (Nemesis) id 1MfHEJ-1l5AGO3cjr-00grmE; Wed, 28
Apr 2021 17:16:36 +0200
Date: Wed, 28 Apr 2021 11:16:33 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input
properly [PATCH]
Message-ID: <20210428151633.smexarr74kosy63y@HIDDEN>
References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN>
<83lf93h6x1.fsf@HIDDEN>
<20210427193253.ourhlr3nxdem3e6t@HIDDEN>
<83k0ongnc7.fsf@HIDDEN>
<20210428030025.75hiu5zgrll2qzeq@HIDDEN>
<87fszbnd70.fsf@HIDDEN>
<20210428095054.wkpyxl2axhdx26dq@HIDDEN>
<838s52hb7h.fsf@HIDDEN>
<20210428124952.anyz3ddhgvlcxyj3@HIDDEN>
<83mttiftnl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83mttiftnl.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:IgyN1GboGx+G+HfWaSGQLcPiFC3BPIEt53oLZQCYStPrFa20Osv
ipLWq+VAgkAWr594L+OnkbjIdFaXSLkULZkPafbiZOAmB9EFnJ+rvOR5XXPeS+ZX7xbfnlT
XOGi/zPN4NKP04OTeiXqLnBA7GAKj44zeYTZHhIZ1V0wZg+SsSBx5IyavLJT85FSH9ttC3L
4dxlpVprv8MA1PuKuEZXw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:AqHOgVVX+y0=:B8q+TZxxW9+ZlLavJHWFR8
pEceui2aTUh26zlW+xBgOx0G7dHnGQQMfoPUF8GXsEYOsIT6jN17GozNqP8Z5mmYDGMP3noci
AMXB77xut11DU6ziMNU/Q0ShyS57Hd2YqfMIJ6i0H/2kMog2UA6kas+3rzOe9UnJrgKQH0dvz
BnctwvuA/LYgBy9x/RSv8yUooWPhlf8H2LhT5+99P/Ofhg42aDkTiO70nH4qG4NGkXC6MQyeP
TWRKLpqXHgkZ0ZstzGrIXa2TNqQa3M3rw3R2EyKvZz/DloxDOqqtDpRJ8pGT7OdY4GMjgI/3J
GzWNbkBeYZKyZB8491ZWxx+NZoWCgnvZWvhwxv781jgCyEjE26yKwq6KDGxIXsQOycN3DW6BC
s3VVCaqQgza18AkX7ShpxSs3cW0BEdft7CsvyWnUnnuEWTv7l4GACSZUoboKJii5Kbe4MnhTR
2bqbt5pk2BiSDIEZh3AWMmpnTfkFsmjM+PCDe4KRO+vSOXtyYlzv/UUJc2wkmuLETfusg0Tr6
oD/8nL/4X3lH/qHv70RBwU0gAmfcNgAb8bxi3wo5NyDJ/2D8aTItMULA2AWrJvD4a4lNxh1PU
Oj+mTkO/KSxIle8/M8LmgFgS/743LP/S2F8kCdcNnmuyufXqnYaYPhtbmYZhx4a7Ltgm0Am6U
KVFGw+U10ufMPNCQBj7zYeRebTMXTFpgJroasm9jOTVJKRThLHIKOEjW4UlK/SG3RLdnr+0zD
wIkP8zzJHITC3/yivxvOajYL4T7FPW9Bm2Pdkrhj2gp4oHrESv1cN07rAPlMfT8O+NlM3aYPb
1WFaY37Ev4AWLOmLNuAMUiZj9NnG3kVEZ1xEFMKdXrFj1M/t9YlgY5h9Q/jh0eCQ92/ZJ/WHD
sczqVPOoyjrp4DddXNIk5xmxQGBhFpm/XI5JyH8db8g9vI6BspaCfMUhqfhixNU+cSCun9PSL
fv2Zc+t25TG7QjerZHGmAxeITm+7/bZN4nqT1N0Iu7HxLoucHh8rVD2MigNgES7iCVxzVsYXs
w3+XHhH7505dyO+YN8PBHgpFeDRKkgx7AT9K2IROWpx+FSGVNkxAl6KowiFhquhOa6DqoDrrZ
YMnrwX+2UvRSi2Jn2GW5VRX11VK0or0SewJ2gm8cGsQ3ZhCQYHHNMmp64wvZ1KhqQO1of5qCG
9zujcLo4VsKJOW4dyAdnvNFZ26IYU1f6MW7QAgbTYVbhpFIG0wedrT9gzGfKSw33NBAN4=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48072
Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
[Continued]
2.3) Though what we're considering is how undesirable it would be to
restrict a user from using shell built-ins, what I feel would be
much more useful and natural for users would be to be enable them
to use their personal shell aliases and functions. Under the
current dired implementation this is impossible. In diredc, it is
possible for persistent asynchronous commands (the default for '&')
because diredc opens an interactive shell buffer and uses function
comint-send-input instead of using emacs shell-* commands. This
would be an argument for me not to perform the constraint check as
currently written because function executable-find wouldn't find
them.
=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 15:13:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 11:13:38 2021 Received: from localhost ([127.0.0.1]:53788 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lblsg-0000Lr-FP for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:13:38 -0400 Received: from eggs.gnu.org ([209.51.188.92]:48320) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lblsb-0000La-P7 for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:13:37 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:45318) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lblsW-0000q4-7A; Wed, 28 Apr 2021 11:13:28 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1782 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lblsP-0000TP-Jq; Wed, 28 Apr 2021 11:13:25 -0400 Date: Wed, 28 Apr 2021 18:13:11 +0300 Message-Id: <83a6pifnnc.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> In-Reply-To: <20210428150144.4uxrcguggkh7vrjx@HIDDEN> (message from Boruch Baum on Wed, 28 Apr 2021 11:01:44 -0400) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> <838s52hb7h.fsf@HIDDEN> <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> <83mttiftnl.fsf@HIDDEN> <20210428150144.4uxrcguggkh7vrjx@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 28 Apr 2021 11:01:44 -0400 > From: Boruch Baum <boruch_baum@HIDDEN> > Cc: kevin.legouguec@HIDDEN, 48072 <at> debbugs.gnu.org > > > > > I'm not sure I understand what you are suggesting. Do you mean set up > > > > the completion candidates so that they would only include executable > > > > files found on the system, but allow users also to type commands that > > > > are not among the completion candidates? I think this could be > > > > confusing, and I don't think we have a precedent for such a behavior > > > > elsewhere. > > You had that idea correct in your prior paragraph, where your wrote: > > "set up the completion candidates so that they would only include > executable files found on the system, but allow users also to type > commands that are not among the completion candidates" Then I already stated my opinion about this above. I wonder what do others think about such a feature. > 2.1.1) Try the following in a vanilla dired buffer: Navigate POINT to a file, > let's say 'bar', and press '&' for the async command. Then type in some > garbage command, let's say 'foo', and <RET>. The response I get is a > message in the mini-buffer: "foo bar&wait: finished." (BTW, I haven't > figured out where that message is being generated; anyone's help would be > appreciated; I would like to see if it can report errors). I think the message comes from process.c:status_notify, which is called when the process is deleted after it exits.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.
Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 15:01:58 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 11:01:58 2021
Received: from localhost ([127.0.0.1]:53784 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lblhO-00086a-4A
for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:01:58 -0400
Received: from mout.gmx.net ([212.227.17.22]:40349)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <boruch_baum@HIDDEN>) id 1lblhL-0007za-2J
for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 11:01:57 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1619622107;
bh=wvWJiPz+Ku4P3Pz7R+BBWK7tytXCsA9Te6xjrexklgI=;
h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
b=Y2YiLxdewJeP3ZXgJWilyFNm6O6XDIYdWkcrkQjTFkY/I54xzrLV09ni3zmJDDM4v
HN+brC7RS6VEa4VkgkkPBEgHGO2TbofZlG+8x1Z/qn1rxB1JN0OTqb9HSYf6m7RHq9
D0H6fibKWyGpPOQqNa56SNXfYQ3d8uH1drVSAV0w=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105
[212.227.17.174]) with ESMTPSA (Nemesis) id 1N0XD2-1lPixD14eS-00wY3Q; Wed, 28
Apr 2021 17:01:47 +0200
Date: Wed, 28 Apr 2021 11:01:44 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Eli Zaretskii <eliz@HIDDEN>
Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input
properly [PATCH]
Message-ID: <20210428150144.4uxrcguggkh7vrjx@HIDDEN>
References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN>
<83lf93h6x1.fsf@HIDDEN>
<20210427193253.ourhlr3nxdem3e6t@HIDDEN>
<83k0ongnc7.fsf@HIDDEN>
<20210428030025.75hiu5zgrll2qzeq@HIDDEN>
<87fszbnd70.fsf@HIDDEN>
<20210428095054.wkpyxl2axhdx26dq@HIDDEN>
<838s52hb7h.fsf@HIDDEN>
<20210428124952.anyz3ddhgvlcxyj3@HIDDEN>
<83mttiftnl.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <83mttiftnl.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:XsNaw9qexGVGCgpfWrq2hcnbW1TD0BpEf4BpLb+S9Geq8qfOlkR
MW1Z0uVaERTEUD5LO8MQUwyrfeP897kcgAI64rRqCsvXNSI5OTywzHHev4Tw7gGDW8FUy9V
Jb+/xUtfhH6G9MZVt6SH4T6tCT6azxINpjqrav5VWYpP1+X5quUlj7wjZAUsDr6UG6Znp5i
kGWeTKFt66TdomnYCeVeA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:jfJBKIGJfAE=:na4y+GYEchsq8wwYi/kKm2
+KmguMuwu6oZFj61yDOXDudK/bHHsZhA0bhOu3KE3lbhkBs7HflqbxKjoQPLtijGAt3aJUDiR
MREwb2wLbpI/VTskNVdS70LZfNQjDmCx26x5WQHMYdRFZXm7Qg5cGkqtobkSx1ZkpzVzeiJAt
B1pmK7tPMFmqZcnXrOKfheDIQuekm9T+RGcVNRT0+Mb8OrIEJwSKew73qHNIDHwjbEptIfyaS
CZRvqsqbyjQdoCG+KPRSSz+6mwcE2Zxd/npDN28iSvzP0FZGloNXxjgN99yL9UiPvZX2ddl8I
Art4BRrexcvgawI6TfKqezWRSFIRx3WCR2QXIiE9/mbfOp/OGy5s+CGpbKfbr9Eli3QGwnzha
HT5NX3z4KT1c4gCcY3V311LDF8pM1gJ9HuYhbtenT+8hv+JAm9h9LrQVuK1YJIf+LREdmZLDL
jj/gic+IGSSriucIJjNgCRnXf1yXch5VCG0z3ySCJWqZRHu0tNdymj+TJ0fm5yhFPGbLuYe+2
Rtv2vP6LW8AhSHfEnhLNv19LqexKKxlg0j7vF84HR6EtTZl/LrKyn/lBAB2KJYHsoAjaULm/G
N6LNoGQ1aCnTO2davLZyWzdMkV1zlN67wHFAaIi5ljsLYo9GiyBMZxBVL7ufEgPg0QVYrhH3O
nFGUSlmIAjdirlsDtvylYdyL9ExGs4Bwhc0qJuDiykiolOhkIjrhFOPplQDMh/+CXhzTIjF42
2lnQNgjwFtV/TwJaXYm0k01gPPaI2phP+fXpNXhh3lcPXF+2bCeTQse1gFqKW4Bexs2KE449y
kS9bgEdLd+yt5UshfmacJgtA0Xu+IxRbnuSVcN101Vr3BPzu7w1Iv3a8EVO69EBqJ2XtMLm0s
oQ48cg39Lrga+63tv9shKDz78j4yeQ5bUjIdrkaYmDOecdtjYqNgvGjHpzcv9XdpO9BXS46TK
Jr5rKjO4fuv4tnacOvE9TkjC4Y+adlhV9gbk3Idh2lilv8N3zWNpFuNM67tNREyUTHyf6Ff1P
oYr188xLKNij7R5l3/F8GPzXP+zWyAaNqSntDlQpj0JhbVFHyyOd5QKxBvqZF52lHtzv4gj59
6E23Y6KW+gWbIIOlB9ydCax1BttbjJpgxy4WpR0O8rj9F9ThbDEx5ljON9lr4Th4izaEmjWpZ
LxWJm96rWjVHE1LPesd964kLEj2u1BLx23kkqGb95e02qFZdKbqa9L55hzH/wT3GlqW1c=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: 0.3 (/)
X-Debbugs-Envelope-To: 48072
Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On 2021-04-28 16:03, Eli Zaretskii wrote:
> > Date: Wed, 28 Apr 2021 08:49:52 -0400
> > From: Boruch Baum <boruch_baum@HIDDEN>
> > Cc: kevin.legouguec@HIDDEN, 48072 <at> debbugs.gnu.org
> >
> > On 2021-04-28 14:58, Eli Zaretskii wrote:
> > > > Date: Wed, 28 Apr 2021 05:50:54 -0400
> > > > From: Boruch Baum <boruch_baum@HIDDEN>
> > > > Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org
> > > >
> > > > I could restrict the check to the preparation of list of completio=
n
> > > > candidates for the defaults put into the mini-buffer history (alre=
ady
> > > > done in diredc, as an advice around function dired-guess-default),=
and
> > > > give dired users feedback when a command returns an error conditio=
n (on
> > > > this week's plan anyway).
> > >
> > > I'm not sure I understand what you are suggesting. Do you mean set =
up
> > > the completion candidates so that they would only include executable
> > > files found on the system, but allow users also to type commands tha=
t
> > > are not among the completion candidates? I think this could be
> > > confusing, and I don't think we have a precedent for such a behavior
> > > elsewhere.
> >
> > I don't understand what your point of confusion is, but it's your call=
,
> > of course. Your position has emacs offering users impossible choices,
> > choices guaranteed to fail.
>
> I'm asking you to help me understand the details of restricting the
> check that you are proposing. Once I understand that, I could make up
> my mind about the proposal. Right now I simply don't understand it.
You had that idea correct in your prior paragraph, where your wrote:
"set up the completion candidates so that they would only include
executable files found on the system, but allow users also to type
commands that are not among the completion candidates"
What I can add is:
1) the completion candidates would be the subset of elements of the emacs
variables `dired-guess-shell-alist-user' and
`dired-guess-shell-alist-default' (diredc adds `diredc-shell-guess-fall=
back')
which satisfy function `executable-find';
2) the user would face no constraint whatsoever in what could be entered.
2.1) I have mixed feelings about this, because for asynchronous operations
any typographic error silently fails and yields a misleading message
that can easily be interpreted as a successful completion.
2.1.1) Try the following in a vanilla dired buffer: Navigate POINT to a fi=
le,
let's say 'bar', and press '&' for the async command. Then type in =
some
garbage command, let's say 'foo', and <RET>. The response I get is =
a
message in the mini-buffer: "foo bar&wait: finished." (BTW, I haven=
't
figured out where that message is being generated; anyone's help wo=
uld be
appreciated; I would like to see if it can report errors).
2.1.2) It would be nice to get feedback from dired power users about how t=
hey
use the '!' and '&' commands in practice. My experience and observa=
tion
is that even power users use those commands for straightforward
operations and use shell built-ins from either a shell buffer or a
shell-script buffer. (note that some built-ins also have correspond=
ing
executables, eg '[').
2.1.3) My gut feeling is that everyone will appreciate getting feedback on=
an
invalid command, and no-one would mind not being able to use shell
built-ins. Thus, I prefer having the constraint.
2.2) The constraint as written only checks the initial atom of the command=
line,
so it wouldn't catch "sort ? | uniqqq".
=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 13:03:50 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 09:03:50 2021 Received: from localhost ([127.0.0.1]:52029 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbjr3-0007G9-Tf for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 09:03:50 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35322) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lbjqz-0007Ft-6E for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 09:03:48 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:42883) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lbjqt-0000Oz-Pk; Wed, 28 Apr 2021 09:03:39 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1414 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lbjqr-0005AX-RP; Wed, 28 Apr 2021 09:03:38 -0400 Date: Wed, 28 Apr 2021 16:03:26 +0300 Message-Id: <83mttiftnl.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> In-Reply-To: <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> (message from Boruch Baum on Wed, 28 Apr 2021 08:49:52 -0400) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> <838s52hb7h.fsf@HIDDEN> <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 28 Apr 2021 08:49:52 -0400 > From: Boruch Baum <boruch_baum@HIDDEN> > Cc: kevin.legouguec@HIDDEN, 48072 <at> debbugs.gnu.org > > On 2021-04-28 14:58, Eli Zaretskii wrote: > > > Date: Wed, 28 Apr 2021 05:50:54 -0400 > > > From: Boruch Baum <boruch_baum@HIDDEN> > > > Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org > > > > > > I could restrict the check to the preparation of list of completion > > > candidates for the defaults put into the mini-buffer history (already > > > done in diredc, as an advice around function dired-guess-default), and > > > give dired users feedback when a command returns an error condition (on > > > this week's plan anyway). > > > > I'm not sure I understand what you are suggesting. Do you mean set up > > the completion candidates so that they would only include executable > > files found on the system, but allow users also to type commands that > > are not among the completion candidates? I think this could be > > confusing, and I don't think we have a precedent for such a behavior > > elsewhere. > > I don't understand what your point of confusion is, but it's your call, > of course. Your position has emacs offering users impossible choices, > choices guaranteed to fail. I'm asking you to help me understand the details of restricting the check that you are proposing. Once I understand that, I could make up my mind about the proposal. Right now I simply don't understand it.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 12:50:05 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 08:50:05 2021 Received: from localhost ([127.0.0.1]:52017 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbjdl-0006w2-21 for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:50:05 -0400 Received: from mout.gmx.net ([212.227.17.21]:43065) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <boruch_baum@HIDDEN>) id 1lbjdi-0006vL-2e for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:50:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619614195; bh=H07WKEobMI9Ri51t/VEF1psXsG2sIUtDS/8SaMKJlj8=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=KYiwzi3WkyjWMpPey4zk7HTzAso20y8godnf21lQzN6zk/7I53RMA2vm9AJJZK+RM UP0WSSTVm4zhOu3P8XgVJ2Eym0YxM8QX39DncQAfHoazMD2ZypYEVbmrWDnryILwCO NhLD2ksPhBl4unzXqJigA/MyPPXE1uAXPH18go5U= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1Mlf4c-1lC3mq3seo-00in64; Wed, 28 Apr 2021 14:49:55 +0200 Date: Wed, 28 Apr 2021 08:49:52 -0400 From: Boruch Baum <boruch_baum@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Message-ID: <20210428124952.anyz3ddhgvlcxyj3@HIDDEN> References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> <838s52hb7h.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <838s52hb7h.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:oSoqEZVplJEPGpGcK/UXpLpjazco7JQRhWfvrEo+XDNSwN11BWM g9PO6E2tXGVdDyEfMeaDmdIAWD/4FBMyxkDU7y75TpLBwWhLYvAIrsdhNAsdKleIbRvwT91 CRXwpYwZUtRdKN9turCLtjBBZICeNb8MR7hOiiplL8AG5YV2Wwy/PwujI1cSZrsfgb71GKp nnVgPdSlCH4Tl8erxtdHQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:w4+4QawBCGs=:wSPPb2Fqw+SIDpxhakQxkI AZ1Ymx6WU6ldtzvGfI+4DPsH0jqCtgiPQGPOHzyZGLHhpVF7ic3KkpONoFpjfBm7ErDWJ0E1E 0BXY+g/p0cgr6EJKKyoiOHYtHb/JupFzLvZWYj72fpqAN13f6b0/1HezIN805jtvDUqj3QdvG LUwuBpXemEXMYAbX9ksL0FQ1RZQU/+O2s2MdbELt9JCnwthD7iz6SpmvPGwu4MGScg6FVwwPI AHxfZCItqT3lukrtVRmeyCSQQqbBIzJwEjUMiu3eibFS5dCW2gcw3lKcIhyaz72dB4Ko+1cWI 2A/xzThx0ZZ862R8jaywk3MqAFIl4xj48huPjwZRznv0u7dYyf75D6DsLs6lABZpZK3lih6i2 METBci3cUsQsK6yZrZYpCeqCRGRSSCpTnt4o0sIKFp/UTElooALWSlqIIc+64/SM0Vf5RUFoT ziom8OqT7jl6PJsDwumYD0iYKZLXlUFlAX2kyO8c4xkN+l9XB2L1Q5QtjkXmn203EDxaq0KyT pI/rlnZp6WzuFn9U56VV+vnhZDm0EuCBzavNASGCGLE11xudhn9hu9yWpKwSHS24VPW1wP2mR TmcKyTElCZTcAkP0AkSE9XhpO4xUsH9Zji4OYmon6MEFcag4XSvX4bBZcM4jNyMxPoqKzd2rs tiXTsp50NR1oxRaZ/wDcEzbBxJveqT1IS5Y0xLsFnAsKPIaVc9FyrijhjpITxuB9by/aNXxtn mM9Nn2PTEc+eXxAJIVDJ5cnZ1fnEbMdznh5aDrD2dGSXmiRA+hJXrGdaiqiAi/ZjqdwVyFRf9 +js8EACSU/Tmwt4LjsxzBbvwY+IxkgZjYU1aXrp8TZxZoTe/9aEQrmztXKgU04gsW0EwPaMWR oe4wlBbn9zw1pB0HuucDuvXfH4gUdMHRqENsliwEMK8uPTa4BTSJMg3xlfxLfDu402lUWR4PI DSTqFWwaDATImhebVmcS4rsmJhQQcMC8B/N8PTJlw45RnRt7vfjRhGlJ0O5hUxz4R+cb83O5e TCUpfN7VTuis1SP03GndAWNMksM2pMxBCE2OnNsc5VvE/syvkGw0b6KI7ECbcxnLWO5mbxCC6 MCjEBwTf/k7V93/s6CPByyPW/JLLeTDvlAylDCLLE2Hsboaght85+5FOyM/WT09R2AAx/XbOY tYvXWczbJEw+EnS4XEVIxMg7qvz/b2OsGloF48BUNy1qM24dpDuibOtGeu+j0X2TEca0Y= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 2021-04-28 14:58, Eli Zaretskii wrote: > > Date: Wed, 28 Apr 2021 05:50:54 -0400 > > From: Boruch Baum <boruch_baum@HIDDEN> > > Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org > > > > I could restrict the check to the preparation of list of completion > > candidates for the defaults put into the mini-buffer history (already > > done in diredc, as an advice around function dired-guess-default), and > > give dired users feedback when a command returns an error condition (o= n > > this week's plan anyway). > > I'm not sure I understand what you are suggesting. Do you mean set up > the completion candidates so that they would only include executable > files found on the system, but allow users also to type commands that > are not among the completion candidates? I think this could be > confusing, and I don't think we have a precedent for such a behavior > elsewhere. I don't understand what your point of confusion is, but it's your call, of course. Your position has emacs offering users impossible choices, choices guaranteed to fail. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 12:46:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 08:46:37 2021 Received: from localhost ([127.0.0.1]:52007 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbjaG-0006qM-KT for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:46:37 -0400 Received: from mout.gmx.net ([212.227.17.20]:37845) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <boruch_baum@HIDDEN>) id 1lbjaD-0006q8-LZ for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:46:27 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619613979; bh=4evNCIlYdB1GkVUICRWFK7hmaW9z/WBDnsIBeq7Ht20=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=A5C/R+FrgIB3p8nehJ28cfMPt7wAUSg5G3D8qURKP2o8dUvLnkf/51zokNV5E2OjG 4dbalYMW2z/fFCw8ki1tBCOspM0MoHex83axMOK2azdEzmtmVQm3BNqr3YZRCDZUy2 Txiv3zivQS44rq64Lo9PfvVwH/wITHKPvhXqfDAU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MAfUe-1liMMM3HnU-00B5WE; Wed, 28 Apr 2021 14:46:19 +0200 Date: Wed, 28 Apr 2021 08:46:16 -0400 From: Boruch Baum <boruch_baum@HIDDEN> To: Michael Albinus <michael.albinus@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Message-ID: <20210428124616.2zrarzrttihf5ned@HIDDEN> References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <87y2d2brhy.fsf@HIDDEN> <20210428120011.5g73ctmekbff42gf@HIDDEN> <87im4661zh.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <87im4661zh.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:ZEqT+PYNaHUJloPjqRabv4oapkpAlQffcxr8LCNm6oc/ohFOdtm vDbQqDHqC/T3YG6g2FSs7A7syk4kuHmEukO80kZZDuStgfOvUNjjhv30MIYnVMTUgGPvgit kOsOGeU+6baa9F0PiTS9lZ2JyxoPuniKgEOif+QYdnq9zG5fDb2vLt7ywwi+5d1D8163COu S/e9h5hFzWja8olk9hkdw== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:gI3+emnrRRA=:76BdHFPDu1SiZuYCdVpr0u gsFDXGQ6X5VnXAx0f1jL5GH2cAtT4Q/hjGQ5MqFVr6ECnD34ru4retLOrP/xPe7j0annFio2H HXPq4dBIYEj+YGSRym4hTUpH/a/K12UxkrR6qqaHI6IG1ADTtTkvF3J9Vz0MCMWgLZSjFP5Cb BQDhyicwV1JBGeMe31oO8YutTL9z1ok0gWG3DQtDSorb9kph2fm3O44QYX89t8BAvRKlrGAW6 X/5mwID/pLEGAZzzFOe+Bukeh8W2xYDPt6Fcv/RYUgT+QSlD8e+E0UTmFNyok6BX+K9AVQm4Q GqiGFrAWgEmvyDNGbzusZnHxO92JQZfYFXeMY2DfaWjpuKouprNjygMhO4QalSKGFrLj/C7nN ubCh9fodkRg6SLF8OC9LgE4myAJaz7Rfu8HQikORhP7MAp07RX138CFYHdZrShqunA/w063po nE8yM/oA9BLyLBP4O2VsTBlfpuOjLpaUuwl5/IVMib1exOY/UJ7uQmCozvuu2bg0Y9oS6N3Xs Uf8D0khE2pExf2GJ9Uwq5WDGYS/lDJ35msNXSsMq+Fsi2lPGnBLyzGW34cB7+uZ/J0B9Nhdl4 gwPvCH/WK9lxCKrTgu1iq3Mt0TfJzeqv/u1SuntDdWxnexqYQ4MSJOJ//bSgkPIlStBZ4DXPk UbkIGE//aEpYooRzryD2wg8AeQg9RJwa2FfIDQrdhPbnRVH+xciRQsKZxl3plsdPB+XgxGmqN 6W/ytauCQWoW4DUvHgSI/RY0/wnAce+VDM2P+u/jVBi3McZPUyuHlVCPCsezj7FvkPiZ7lsRc qs+O53IIFO11CAoNB9JGhxXj33dwpsEoNPX1tdlhywIWGJ1O+wbsWthXSNgvLWw6UisKQT0Xa pvCNMxxVeQYLBgCXWeXihCdUqMztF4EK9A9fQs/kZPI7RS46k7gVWDe+aCWejcuNf4R357Bnb /6xYCpku4CHc3xIBa76b2VezNRxJde8rK/RpHfT71T/Az+LQ8FysZ8AcLsLq4WrQnhVjH0u2t xuW8MGEnRGzgVnVLWQXrN7QtvtssixUKjAiPaikG9kep3OzZDpJErP6zfcrSY+XsvUgHHZax5 /iT74/HKH6+KYSKtq3BOMPOzY8eVg06JFx3sqQ1TE20TUCveyo5e77hKTPEtuVEMP66HPBYvm SGvlkqDgLjF6v6QHyVsM0ZOi73t3pKhU8Ts3nAUzG/pfQWSkCr79Y5xYJwhv4x+QErM8w= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 2021-04-28 14:13, Michael Albinus wrote: > Instead of (file-remote-p file) you could always use t. If > default-directory is local, it doesn't hurt. Thanks for the tip and input. Much appreciated. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 12:13:51 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 08:13:51 2021 Received: from localhost ([127.0.0.1]:51957 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbj4g-00062q-RQ for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:13:51 -0400 Received: from mout.gmx.net ([212.227.15.15]:56815) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1lbj4c-00062X-CD for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:13:49 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619612020; bh=U2WsUN/YP0u/UC4jAUqwu3qrwZTzUBRFCOXu2MOEDlg=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=QP/YSM05z2xHudXJGAUJYvpsMhXdNDfsMpS+jPn6YD/ABpFfeODpB0IjjkPv3wGmY iiErj+1l2uqHzrB4d/CifvLRcG9EHbLMQEeYEzxnXavz7zcZ7X79ue6VifamdIPEXx SZdhVfuO04fDoaHW28hnm0+dRnLl/HeX9d0JZP6Y= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.93]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MLi8g-1ltFvH3QvY-00HhTV; Wed, 28 Apr 2021 14:13:39 +0200 From: Michael Albinus <michael.albinus@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <87y2d2brhy.fsf@HIDDEN> <20210428120011.5g73ctmekbff42gf@HIDDEN> Date: Wed, 28 Apr 2021 14:13:38 +0200 In-Reply-To: <20210428120011.5g73ctmekbff42gf@HIDDEN> (Boruch Baum's message of "Wed, 28 Apr 2021 08:00:11 -0400") Message-ID: <87im4661zh.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:l9UofiIEZF8fZrXxxwZzy1mFONh9T1OlX18W6mBhset+JHbkU34 RSFFnZoFE1/rD+BhL0SR4HELpYtdqvH2kpk3x5pupmgvzvD7FWUVCIBg4SCkWF9lt4UHjpw Sm/E6r93lcsFXfkwdh/QWV/e/ZWGMGsj4aC1llZ+Ds/mSN0i7/VFyoAxcl38tFX/kU1Ny8I rhFAbTGySUh+l666te54w== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:fOMemH9JmHw=:Ni3o6KuaB6Qowo6LFThYae 8FrOGmAS3W8hkwsGt/zaYIBD2Mj9vMy2dlrh9NZEypxlBg9gEEgEpb7IBrBWxinBxeBirC6Oy r6qlWJgf3FC01gE4SqqCMG0hgQGDMNvM40HznqYn8okVDMjwVW0xlGXkjYqMPurkjQ7hxy0Rq mZGrgvToNnqzBXw+4n5CYfc0LJOCWVt3sZOiGnogopVAqjlIhcRIGOlgwNp2LQBJtm3ipYn8C kdPBoec/Cg+o5fBzzDWoY7dmU4BUrxwQkoZLv7p4+7qbZgTIY8OWSe4uuFOU0Vld2UU/JJpv1 pDAznH3uJcp12PQnKChD2GxU74Rw/ldRxLC84/QYkBGnw90NeeG0FE7mxQ2GCOKBROYLvbYA6 NGg8W3WZBR9uF9LSNKYoPQWwwFCSQQYg9rcxAOTMkbsZwUwGPG9J/suTIxhExJl1qJFS4tFcs Jm38HDT5SQVVb7VGsr+q36wzFlkYIe9BsZ25gCV/LlmfCOBLhDUPMa1bVx3BJzHeMu5nxvr0y OWK/+peqUEgYpF1OCCe8l2qYrVKOz0MyjPlwMsQFIeHWrJGg+OopjNskvf0WZSLasRgon30Xl nkcKDJiQv9p/rkXaTHSu8/4+UakaHa8QdeeNNl5BnVl0qLZEoz1VMWTJ1Z1KinI+vwRK2G2qM 2yD9Mprik2VEwWuWeWhlNQtZoea7qSircF0xIrTbEJGTlcYT9+YnG3pW+Q/U3EgteMPvUW5Mm qqlxPmwPwcWpuYI87s5+bPuUvxew9UTEqIGV3YIsoTbpZpMhnl2P/ARu2WeZPutP+yqw041R6 1f0AGITfmYo4A32OaaGs9wEqScUMnoHqMXxqZrYT0fezQMAIWaZGL6MfNwrEJzLeJ+Xk5pQj9 +YEruhfm1oXqMyQCpTPlpeEk0lhdII+leNgQ43Dpma7I+we465FteXAKiEnGZWzZTH1mZXSLZ 9v95VNynqL1Ek0AJd6kHHpX6NsDp54LY+tPFeIod/GAS7tzFoDIuC5QS3VVjjqkHNyhuuaNFC x/GTV4Cv9CSPSxsusBfw32w5fLxkw9DVFuhpODR7plcjpSzFMg/Ci6AMc8WRg6lWDmdWG/zSS tTEIUELMLdxXb8wTmXkH5eRZSGgU5PkAQAL3oNYEcKUsMlMRpS9VJfofAytKItEketY7obnuH P6lzhCiFdz/b822GtiBSIEF1WqNuMj5H0tnRXS4QJul/foalTaXfW+PXS/sRUH0spmdq+pn3T bTlyXB4xn2l0/rkSS X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Boruch Baum <boruch_baum@HIDDEN> writes: Hi Boruch, >> > + (unless (executable-find command) >> > + (user-error "Not a valid command!")) >> >> This doesn't check the remote case. > > Good point. It's an area of dired I'm weak in because I don't use it. > How about the following (with the update diredc regex): > > (unless (executable-find > (if (string-match "^ *\\([^ ]+\\) " command) > (substring command (match-beginning 1) (match-end 1)) > command) > (file-remote-p file)) > (user-error "Not a valid command!")) Instead of (file-remote-p file) you could always use t. If default-directory is local, it doesn't hurt. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.
Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 12:00:23 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 08:00:23 2021
Received: from localhost ([127.0.0.1]:51938 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lbirf-0005jl-Jk
for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:00:23 -0400
Received: from mout.gmx.net ([212.227.17.21]:49339)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <boruch_baum@HIDDEN>) id 1lbirc-0005jU-Vu
for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 08:00:21 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1619611214;
bh=E+wQ0nhZ9K2MYEB2CWO12YBrhaqkkXuswdlXgCpmtQo=;
h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
b=gO8uAN5cSjDblDf00zZWPni0hzKnQWb8QS1xKbgfCJyO6MywF5Ia8VbGHDuAFsJ97
DOChChuUQhJAtbuQ9ld2Ghw1GVcu9hediroHxoTB7wmaxmoXG3DTeQDA5qL/mivp3d
S6m25vSu022U/qgFdIHBUhkbAiI9X22f3NNo05qE=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104
[212.227.17.174]) with ESMTPSA (Nemesis) id 1MmDEm-1lBUre1VHE-00iENy; Wed, 28
Apr 2021 14:00:14 +0200
Date: Wed, 28 Apr 2021 08:00:11 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Michael Albinus <michael.albinus@HIDDEN>
Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input
properly [PATCH]
Message-ID: <20210428120011.5g73ctmekbff42gf@HIDDEN>
References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN>
<87y2d2brhy.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <87y2d2brhy.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:HWqyS7mKegl3Gd4+XIOFt3b9v30RCvxL0MqB/jUnq1HSfYayjrE
xvazTkK9fB4D+AoUkxas0TA9AdE5lFY51D378Z4VaaUanCJzqqBQKBJa8a0OSbLTL9rWSVG
mpn0PQsquh3/bHVS06IXiiGtmC/nOZ+8sG1UVdBWPffi6am5q7j+PaIxweojfobl7rFioAi
bRwLQUYuxn8H/wrSp8ZMw==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:zOC+FMCaLoE=:z4gH5ZWW2XAgsCJp4+//cA
c+NeX/3QZEliCkc4O8KhcZIB1K4jvJsCk4YII6AnmrruIbxk2sQjahcjqo4bd+BYGaCUmfQ8K
hHSem+l77iemC0yKEaGgLMqLluKilWJhn3vUPa39Ien0fUBIqr3yY46uMXCo+9OTSb3El+zCj
Oe+5eu2634uKO26OTxdUvHbQC+AF4GKgkKPAOZ9IQIFNSYL2TkgkZUx/hRJRzsv5EJ4Zw+mhv
PQLzV7rZhRih36sqdrMp8Ckp1ioBNxRLjypyPSt5X8hStwruHV9FCqA2Q/89LRGXIxYOCL8fl
bECFQOxD81rcpNzDNKoBif2SubGW5hE3MJ2HIaBhzzxzaThDeDGEAifzDU/KRGIu6V5iqZ+4O
XCtEeINc69QTez6kolVqkjh5gbyHHCjIP6d+XDglkRJyaJIXVLvlKAa6kWXPyOBT9xd9eN4RW
Nu9vDPKXT3OjAicDiGAzkZZw0i5kdNeqmF5GnAbQ1vdDnZvjyWJ9lTclpKW1MUmZ6AQvmqkXG
UNN/RZUkmqU9j1Cb5k1T08fr5omZjA709I3RNqgmcrStm8sfUGkUPIXVWgO9gHqs0YLisZmNG
BuEnpTboWWg/2ou796b59+xOSAjIxPNWAhdlS7YcKXHdv2hNognv06g9KjrIF33phja9SgiFu
YRWGL5JjguGpIV0i/inJ8R8d4TKInAwdpkUBuzFwOQwWC1CyaMzbS7bHWkX9fKcnPUth6Qry3
L0Q+T5JP5IsI4AiPeE3PM/iDnR2bs+0T+tGx6oVXeph25ThzOXvx7XSlYk4TSaGaEGBB0Rcx+
PbbtiiGC6b67xFAgjePTCypNR7oSumnbfa4L7HtEImwXJFfPbAQ8QQ4SE75RfFJDBnlzybPPk
7/im2ri+4VlgBbG3wneSCuoPtnPvBIYX/ptqyGiJSZPPv28W18zi936t8GuRyEnT0GNaogxW3
ybpH6epwPu1fIuMZaR334KzIaoKRwGrPLsug0e1ORXDrrp1OYdgPXoyEZW7pBlEUa3ocAeWPF
jlWeTkAOcLLFosUDr3Rp3txkSYP0HkefUAnqsM1KRvixqns4bDYsoLT9l3JMrodOn6GtInnd7
68WT+qRRV1iR2E/i4QmMNCBgiO5XABh1Mgq2Ooi6iM5cYabK93upoa1+1zQmJQ1k+qNv1qUve
g/hJDD1sNT9lARQVJR5zb6h2gwLlt7y5YmJ2NcNpiXcoqr0DnEQ6mKjMQ/KP1MO1tcxK0=
Content-Transfer-Encoding: quoted-printable
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48072
Cc: 48072 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On 2021-04-28 13:03, Michael Albinus wrote:
> Boruch Baum <boruch_baum@HIDDEN> writes:
> >
> > + (unless (executable-find command)
> > + (user-error "Not a valid command!"))
>
> This doesn't check the remote case.
Good point. It's an area of dired I'm weak in because I don't use it.
How about the following (with the update diredc regex):
(unless (executable-find
(if (string-match "^ *\\([^ ]+\\) " command)
(substring command (match-beginning 1) (match-end 1))
command)
(file-remote-p file))
(user-error "Not a valid command!"))
The snippet is currently in three separate points in diredc with slight
differences (defsubst called-for). For preparing the completion
candidates, the snippet is there at function
diredc--advice--shell-guess-fallback.
For the post-input check (`diredc--advice--dired-read-shell-command',
and with a tweak, also `diredc-do-async-shell-command'), how about this
for checking that the command is valid for all selected file:
(unless (executable-find
(if (string-match "^ *\\([^ ]+\\) " command)
(substring command (match-beginning 1) (match-end 1))
command)
(let ((f files)
remote-found)
(while (and f (not (setq remote-found (file-remote-p (po=
p f))))))
remote-found))
(user-error "Not a valid command!"))
ref: https://github.com/Boruch-Baum/emacs-diredc
=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 11:59:22 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 07:59:22 2021 Received: from localhost ([127.0.0.1]:51925 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbiqg-0005fz-6U for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 07:59:22 -0400 Received: from eggs.gnu.org ([209.51.188.92]:42532) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lbiqe-0005fm-2w for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 07:59:20 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41732) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lbiqY-0005Oc-LQ; Wed, 28 Apr 2021 07:59:14 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:1418 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lbiqS-0004J0-Th; Wed, 28 Apr 2021 07:59:11 -0400 Date: Wed, 28 Apr 2021 14:58:58 +0300 Message-Id: <838s52hb7h.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> In-Reply-To: <20210428095054.wkpyxl2axhdx26dq@HIDDEN> (message from Boruch Baum on Wed, 28 Apr 2021 05:50:54 -0400) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> <20210428095054.wkpyxl2axhdx26dq@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, kevin.legouguec@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Wed, 28 Apr 2021 05:50:54 -0400 > From: Boruch Baum <boruch_baum@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org > > I could restrict the check to the preparation of list of completion > candidates for the defaults put into the mini-buffer history (already > done in diredc, as an advice around function dired-guess-default), and > give dired users feedback when a command returns an error condition (on > this week's plan anyway). I'm not sure I understand what you are suggesting. Do you mean set up the completion candidates so that they would only include executable files found on the system, but allow users also to type commands that are not among the completion candidates? I think this could be confusing, and I don't think we have a precedent for such a behavior elsewhere.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 11:48:01 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 07:48:01 2021 Received: from localhost ([127.0.0.1]:51912 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbifh-0005QK-H2 for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 07:48:01 -0400 Received: from eggs.gnu.org ([209.51.188.92]:39622) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lbife-0005Q4-Vg for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 07:48:00 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:41602) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lbifZ-0006Ni-La; Wed, 28 Apr 2021 07:47:53 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4700 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lbifZ-0007If-1J; Wed, 28 Apr 2021 07:47:53 -0400 Date: Wed, 28 Apr 2021 14:47:40 +0300 Message-Id: <83eeeuhbqb.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: =?utf-8?Q?K=C3=A9vin?= Le Gouguec <kevin.legouguec@HIDDEN> In-Reply-To: <87fszbnd70.fsf@HIDDEN> (message from =?utf-8?Q?K=C3=A9vin?= Le Gouguec on Wed, 28 Apr 2021 08:19:31 +0200) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> MIME-version: 1.0 Content-type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org, boruch_baum@HIDDEN X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > From: Kévin Le Gouguec <kevin.legouguec@HIDDEN> > Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org > Date: Wed, 28 Apr 2021 08:19:31 +0200 > > Boruch Baum <boruch_baum@HIDDEN> writes: > > >> > > This is certainly a mistake: a valid shell command doesn't have to be > >> > > a file that executable-find is able to find. Shells are known to > >> > > support all kinds of internal and magic commands. > >> > > >> > My testing indicates otherwise. > >> > >> Would you care to share the details of that testing, please? > > > > I evaluated shell-command-to-string for shell aliases and shell > > functions, all of which returned error of type 'command not found'. That > > would indicate that the class of 'internal commands' aren't valid in the > > current state of emacs. > > Shell builtins seem to work though: Yes, I meant builtins when I said "internal commands". Sorry for my sloppy wording.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 11:03:47 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 07:03:47 2021 Received: from localhost ([127.0.0.1]:51837 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbhyt-0002BV-7h for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 07:03:47 -0400 Received: from mout.gmx.net ([212.227.15.19]:58093) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <michael.albinus@HIDDEN>) id 1lbhyq-0002BF-Ef for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 07:03:45 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619607818; bh=+0nkS+PovFQXFPXu51Ur+jKx/T/dLFbnjfiuPX/IKRo=; h=X-UI-Sender-Class:From:To:Cc:Subject:References:Date:In-Reply-To; b=X8XlTyOqDjbv6XiIWRkMp1tLoeAX4yp6fQPe8aLqXJQlEvoJCvv+nGjoXszn6cyHK OijhxnCu9jKXE+WN1MyhBDwsxxNQonh6szqqvmX/tvma9OHAEtTC7PR/LIaUBpS2x6 cIHd6BmKWdOznrJgNgUOA/HzzvKEk17/bgLnW6nQ= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from gandalf.gmx.de ([213.220.147.93]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1MDQeK-1lmCNQ1sUI-00AVes; Wed, 28 Apr 2021 13:03:38 +0200 From: Michael Albinus <michael.albinus@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> Date: Wed, 28 Apr 2021 13:03:37 +0200 In-Reply-To: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> (Boruch Baum's message of "Tue, 27 Apr 2021 15:02:43 -0400") Message-ID: <87y2d2brhy.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Provags-ID: V03:K1:8T+llJu/XyEOjsIYwpfwVgRIC+d6EK3vcYpvNy1k/NLmuX9dIHc Bqj+dgHflALs43LqzS6c6X1AkXVPvSaVFZnfd7v+i18ayDOv0U8hm5vMPk/AvVGVxlAqJt+ 4dhordD+h2kXtVQiR/iYMCYNFPHYA35cEL0oHr2IK4NoyhLr1OrIb43Z53e4q3PIrTS+zxQ IFbtB8tr+sBP9mKRbBIEQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:oWHnHYKkipY=:bArj5FOtOQX5KOYT+eYRhN Dlr37gW2xpXcieowmYLCCLpaycrKWKWPb6W30EYi+CD9pYzaaV63ZHtioJNgHOdnnP39Yy0Qb wr07r1B8FcF1LSPwc+0XPRLO+bF1rk0CnJgEQXZNuQJMMunFfe/7LLvg0qTFI7kY3lSQioiND y2S09paZnEsx4q8rOtn5FoopONfwPRqfQbgEQJNlu+wzx5pFooxqr39eMeSxh+nwvsW3bpVxQ FKdnJhXWuO5td7P9c9nSO4G01QbkzNiGDajpCTQAP+jCQ/c67yYkueDOCIpwqAtpefWJatBzF gqF4hh3JnFYk49NQ3aTgntfA1+aozRmetGbSI/1GhSlWG6IkXpqpxov1+WsF6KdIL4W9l4R52 IooVRaL/gyus/NO9GIfeo+/hAk/DL/iSL2CVonGW0/tNZJpR7nGeO2URr7W9oi0RFooq1N8dX rlACbNy0Fe1SC0o2QxiurkGZneIR2nUDjkKu1y/2X49yRxTmm5m3cSmjtrjOkUcojAhyV4QeK 5GQlb0jY6oaxLv6RWoztyVv6HmgT2yAN6LZfqR0Ri5HV/GjA+JZWJS5yHVdfoRzA1Ipzd1uRK WLZO3nkKBM8A1RHWi5NHCkWMuSW98MKWoUrS+1ojUHgp1Au06LLJ67NWE33GfmQwSEnkj4Q/M tmwH2+tD6kBhqLJtNaqOVlpsZS3xVyKFKHbHhO1hYxy5lcIhZexYOGhoujQ0z79/eruzc8FuL 2G61Hb9Bp5mXcbVhg9neFBeVfzgyL10uYwvqvppR7LjwnIHfcnk5aEGH7vl09M2GM4HmCLTCJ +fxaJBrGtGDvAcHd9hNGwhi+LUSxjwnhXP9aJurcDfswdkvt60FMyt+cZnrQKOQU8U3SyLP/v ah0vCxvPkTYIpyPiw0toFkcDQxfMERWP5XxAMKLkS4taOnA0egWUnyjm4NP4z2xBQX8Of/PlJ WCyUSNPdKpuQdOkM3OK+088jHXIsRfJT+RZ0GwRoW64UIHPMh0sx58BhqqqKnQwYiLV/CoeCE 6JTEu9dAQz3YdFohVnsLcuJQ538Jl4xjOmNbVUPLGKgP/1TzBZEHyXSvL+/oXY0+zeMRCUCtN B6N0hcymm0Ixyjpx/qRknH9dvdtLwoRANsuC92XBaXKqS/nMxmPxw83PYcrCqjPalGaGXiDeK JnHCbofuzuSvM94tEUEce5N/icAfyL6owOJgArvt92CkBzjjwTS/GqrXAOvYW/sv+1egZfe/I sy4S4oVFoNp/PIJeE X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) Boruch Baum <boruch_baum@HIDDEN> writes: Hi, > The attached patch fixes that, and also validates the entered command as > a valid shell executable. > > + (unless (executable-find command) > + (user-error "Not a valid command!")) This doesn't check the remote case. Best regards, Michael.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 09:51:06 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 05:51:06 2021 Received: from localhost ([127.0.0.1]:51765 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbgqY-0004SF-IQ for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 05:51:06 -0400 Received: from mout.gmx.net ([212.227.17.22]:41719) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <boruch_baum@HIDDEN>) id 1lbgqW-0004Rc-Ih for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 05:51:05 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619603457; bh=Bhhj/JpcL4EV46yQ8/1Vh82H34Y/R9fBtjvQWyp1aYU=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=BOUHnns9yOz+HpBO6JiXa+NvmSWiaU/64A3PbKdWESr4pYfQ0CHqP2TDlJtBb/lgw VwBh4Nw/N4aNw3uC5vwN1c1LimsBcaCgnm8f83eW6L4EuWTigJFjMLHZ9f6ynFQSE6 C+FjWK/tjjHe2M42l+NVKfI5Q+uqd90dSKKB9wJE= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1MxDou-1lMUPo47my-00xdxy; Wed, 28 Apr 2021 11:50:57 +0200 Date: Wed, 28 Apr 2021 05:50:54 -0400 From: Boruch Baum <boruch_baum@HIDDEN> To: =?utf-8?B?S8Opdmlu?= Le Gouguec <kevin.legouguec@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Message-ID: <20210428095054.wkpyxl2axhdx26dq@HIDDEN> References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> <87fszbnd70.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: quoted-printable In-Reply-To: <87fszbnd70.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:ULERczWdpymIHP/+fVzckAzBXc9wD+FZOPLMhu8jlDvxRRRL0M7 ThdVr0a/Q+NllQoxc2+1fwAlNzTT/5er6SEGvSKTih8eJa80l5acx7th24CW74QerdxGk87 OzRbdYDtGuRnzPYvwVzADhTGAHYNcsfmzdwuRDFAHNtA5PoVHVLee6EMGMo+ZptuNiLQaKa 4uSkWTWaayT9EDDydDWGQ== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:8vR81m9l/fQ=:jMipiqwVoYbGHYlTtDH3Un 5i59lw6bLhLIPuS8+Yao8oNURIDw8LYIgcnZTcAO+p5Fd8Dt3DV4rk8WkzYhn6SvAjdXQMdY0 JZ9rgTfI2eGwwmQHt4eYAqNQ/d4Uek0Ei7TfybzLMrHTCCQTuF4l46CN5Wy6pIYbM4nST/94Q YaXFMc4spatjEexsyImYQ7HLkFImE69YfnLGDhKutXgBg5WFIa7KguDaYXWFwU1oSo1ns1/xo 4bMoDB06osJ3M/SvuhgkK7700gKagVH4X85oU4GUvRjtfzWPvzW01iBUD0zU7RdWzibKg1sT3 9mmcybuiyNcBrN0dg6NsYg9jiyhBxcqXer0UD7LpKsOKBn1leI8TkTgO8wDdTTYyA6LiPNK/T 2GBpn+/JIp6DXudS3wiE7zd7vyea3wOvjKCUqZXrWXwM7pVAnn3vVmVVW+S6AWiepPMMyOQSH T3yVze03uvMnSlqu5PqwxczZWWnytIYWrPhe5P5WZS1dfrJHfHIgT5CrL0KSLWlF2/EPRHGz9 rN/d6gw4x9H0fwT1ptEvmOyKo3Mwz8WKXyUWkF9R5y45Co9dfymFtXZJvDwy4R32cGYAbU1XY vIIzyD/DaISJSl98hu0u7SV3aWC/sH1D5KWxlJViNTLa/4FME+hnkvV2ssxycm11OwBNELltb QIavQJfP6/wzI3KKLp9ysBx06PAikxPMIG9AH8KLAnj7/r5ba8StbqCOJg3qIIbhBKrlz3RZQ gWB5C92Tn2lNsWeNlbI6bZ+AQ4e+ECflZeAudtRmd6XLcGCSiyxB+6w63NnK/L1JkhcX8O5eT omCV6TM/1Hz3Ti+IBuhtJmsGhCJaPcTRxmILVN8F8grxaxiGJ1fRCYEeEP5AUqjdnzsOR2fdu eHywtIBOSkVjgE30dCkAY71zVVz0QBG3ZgxC8EBYLk6tqORZ06bgKLhbPNKDeSMbTVvtKymvb zs+AzWWvb/aEDVkIM09UTIqZ+alR9+4cs2quEsfNevuisQQ5sIP4iyevf1rxrRtQRlsYd+tEB uzFFpIRM7b5ubqCZcDdu5eLDj6Mx1FuypYdN6ps6pfMvufR/gPXWifv/w/cS4M7RbvyeQR4Pb LF5/5OX7mxNes5oB2d0jrZHBsX3GD8r+lwy2WSpua3pa9LXjKYYdInfj9lOlUzRIv5LJ59IEz LcJVUBipQJRd+U46wu6WP7MBtZXt0X0Bbueicq7/8ar+qbNZZauy8VWKrI1tKQf1VfhrI= X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48072 Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 2021-04-28 08:19, K=E9vin Le Gouguec wrote: > Boruch Baum <boruch_baum@HIDDEN> writes: > Shell builtins seem to work though: I could restrict the check to the preparation of list of completion candidates for the defaults put into the mini-buffer history (already done in diredc, as an advice around function dired-guess-default), and give dired users feedback when a command returns an error condition (on this week's plan anyway). =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.
Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 09:34:03 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 05:34:03 2021
Received: from localhost ([127.0.0.1]:51737 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lbga3-0003xc-2j
for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 05:34:03 -0400
Received: from mout.gmx.net ([212.227.17.21]:39339)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <boruch_baum@HIDDEN>) id 1lbga0-0003x5-Ih
for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 05:34:01 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1619602433;
bh=0V849C1uBfy3GRIrYrNeMUeJ5I8U2xYUwOh0TibOyQ4=;
h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To;
b=baqpB0ZbsTbEBeA86YFCn8BfFj3o5odsCRgsPcbbWcZtFqhipzn0dn7vEmiw8vIzm
5XWXmWf1IYP5Ts+6em9k5d2dUUKRdfhiYPJ+R0QvaPBV6eBNf1Ycrz68mBtQeQHT3S
wmkKhrVyu5djPgxJTcDSGDkAiHDkcJLYGjm6yq3k=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104
[212.227.17.174]) with ESMTPSA (Nemesis) id 1N4z6q-1lU9em45rQ-010rRa; Wed, 28
Apr 2021 11:33:53 +0200
Date: Wed, 28 Apr 2021 05:33:50 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: =?utf-8?B?S8Opdmlu?= Le Gouguec <kevin.legouguec@HIDDEN>
Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input
properly [PATCH]
Message-ID: <20210428093349.pevawwg2fvui26fz@HIDDEN>
References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN>
<83lf93h6x1.fsf@HIDDEN>
<20210427193253.ourhlr3nxdem3e6t@HIDDEN>
<83k0ongnc7.fsf@HIDDEN>
<20210428030025.75hiu5zgrll2qzeq@HIDDEN>
<87fszbnd70.fsf@HIDDEN>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
In-Reply-To: <87fszbnd70.fsf@HIDDEN>
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:watBV20JddvabA5UpTi1RtFysFxlMs7YgcG6D8iu0iYOJJoRH/m
ps6U1xVZi5Cpkvse4dj53paZU/ad7i0yJCnN7Caud2SA9mK86oWIvEzxrd28xHzUidOMcdl
oiEvgnqmpahzx2YGUuJeoIkq6qLGI/bU8bssklYOY0f4/ZRtHwcvcU+EUM6VARHJVq0ZuhW
z0uUfOwyrvZH+HYNqA7BQ==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:B9Hq78kWJ9k=:4/37/t7MtZQp4KmlsrHXij
k4Z4ozrmBJZezl9UtIn862PQR+4Q9rcYy3Xzj94hF5+PqH0lxql+vp+R42lK0I3Od9s0xkYfc
AlvlpV/HYXIKDi+1WB09jIL5+o5SGTk+W9g2KCDCyJRhi5IpOrRhPOfI10rt62PV6jEXRMFTW
uZ32mrQnS9tX9BXv4rdQObPHLRVBHJn4Irqfbb0p7j5WOjPBlxMGvpWR3HwG9nDGI6uPxWZBO
LgQyx4ZdXVELMXF51cGmUKi+GYX0B2ojWUZPPVX+KQ/s9795sIReMg5Yq7uKCz+eVa5aZ6YIL
zSkaPQyQd+x3eNDTz00JdYi8wiU4FVNFt3UevRfuBBEgRTpW9OQOoDdt+2SOcoddkr/QtXFLi
WabqV2b7J/DBhVOMZ/7LdMI0HAVI354YDbV04PG30P57NdMgmWmPG8mSobIhrKqcwtkQqQeaX
iWc6GpDKIjJzXhoaQ+8hX2F58dMR5KkuhpURYUrG4Qsgp0z4UquQW8V9AGWBA8TC5Yqsuw3G+
oijc5xk//mYn7F6/3RlTroxKBHRtE96NY6SMHRew3pSEANaHxfyox5wgNXSwNGOxmgkm72ltE
qEv1EDvDjidcv0bZQHc4oPktY4Vat8g7auObEMi//lmyioGCoHZd+JVGAvO4NYvMDdtcJzhVb
EUIKfwppwbC3Zt+l7msHcppmFzW7/09WXS19odcDW2hxgbBsZHKUaUXXh75I9Fr7IvssE7GMZ
E1QQKJYQ9A/Fla7OigntlSRV85Gz0d93ppt5uvybKK6lk9vZAnlT4s2wE5Hm5nOaKb95S8hcA
HBbie/bWayocgAhNrsdqQF/KAQNkcoHToawZO/lIOCOMRxem/vkx0u0Fewof1zAQQThk1DisQ
dC3GoYki6OVj5YpQwpNJqL7wdLzFdHBimdBmFvYJReNXm9vz+sDSq/pLUIaLPQ7Ai+qll/gfR
127gI15XWR1XyWH1TSKImeM1tP3wPgUzYRceWJ8hy1Kjpwjr6jd3cXwSfABZk26q4DIW3wdSZ
KWvmpeZj3k2cgQKsXhki5IG105jfBkHNZHNDtsve1kZc4FreRE7RnhujEpPYC/BN3+fjx45A0
suc5HggYo8BNH9iQBm70c8yASnfw0SzSbjCwgkbbV2jwh0I4AVZ4tReINeLXwMCE2r56PudZe
0l5l3Uv3Y8rn2tSW4+6QAO42NhvIuZr/GEyGMQ3unfVNtsMEt1vYntm1AtT/3img/Y3h4=
X-Spam-Score: -0.7 (/)
X-Debbugs-Envelope-To: 48072
Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -1.7 (-)
On 2021-04-28 08:19, K=E9vin Le Gouguec wrote:
> Shell builtins seem to work though:
Oooo. Thanks. Function shell-command-to-string is using a
non-interactive shell (echo $- results in no 'i") while function shell
isn't.
Now I definitely need to re-think my position for the diredc package,
and possibly also for this bug report. For dired{,c} use, the judgment
for me is to weigh OTOH the common (my experience) case of uninstalled
programs appearing in the default lists for "&" and "!", versus OTOH the
rare (never in my experience) use of "&" and "!" for shell built-ins.
For diredc the call is easier in favor of limiting '&' and '!' because
diredc has a shell pop-up window "'" with midnight-commander type variable=
s
($d1 $d2 $f1 $f2 $t1 $t2) for the current directories, files, and marked
files.
=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 06:19:42 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Wed Apr 28 02:19:42 2021 Received: from localhost ([127.0.0.1]:51556 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbdXx-00056T-Rq for submit <at> debbugs.gnu.org; Wed, 28 Apr 2021 02:19:42 -0400 Received: from mail-wm1-f51.google.com ([209.85.128.51]:33552) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <kevin.legouguec@HIDDEN>) id 1lbdXu-00056D-Vh for 48072 <at> debbugs.gnu.org; Wed, 28 Apr 2021 02:19:40 -0400 Received: by mail-wm1-f51.google.com with SMTP id a22-20020a05600c2256b0290142870824e9so2009107wmm.0 for <48072 <at> debbugs.gnu.org>; Tue, 27 Apr 2021 23:19:38 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:references:date:in-reply-to:message-id :user-agent:mime-version:content-transfer-encoding; bh=WHemVZQ+1JWlLemEMB+4cFminULz5+E9H4sAu6xQ/7A=; b=I+RPIajRzPNpuXPBYeoe/UTrCbgWMpSMX6khCGQYnlGkrHeMiGdspBzMdsXuyW7lmj VWWlCLFoDCqOZZVg2AdgE6DmlG41t22RYLKxUMXYiyrb/A6mYBdnG8C1zhWe8t+xe2MG DA2po9ffOkzWar2u2jVsdM9cov/VVLbDZgnj0DG02YKZeFpYNSX73U6/VXMGQNOUH795 2ifVNKcER84T/x5anJyZWwvof/XOLvH7KVXs/1VAqO4ZW59gJ7oSplE6K1JRTlzeBzTA L6g42X0TBxaAz/jEPvDPzbHGlDE+OxNSMmX28U05EiFD1GYlGpSHDapmQMC+QMU1JQHG fUEQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:references:date:in-reply-to :message-id:user-agent:mime-version:content-transfer-encoding; bh=WHemVZQ+1JWlLemEMB+4cFminULz5+E9H4sAu6xQ/7A=; b=IyvpJN5jq/9mwkWNEKEGv+UHrYsGrnoR7syzTL7zoSSujCUdaEszjW4YjBfsMsDBoL 0d2pSoQkfHmEFVWifiETSekBLO8LlAPoiac4XhiDPOEdklawOH9LfMrwT+CDnak4Sa7l jrRlSdOABT+D6Yrx96Zrm41ug2c+VmhlExMnej6Fn5fg55YNCZZh/h1Wd5t0GKeM25f1 lIE0pQer0JiVaSytlh5j5oXcZAjmlImoUVublRdA55cFJI/cuAoXs+l3CLbbNUlIar8U xET7NI/YRvBRYTqylC4RBdrEY8T74HRhY08MCTiG7wl0r8NxgTdK7bF9XvYTtkVv9hVh 89BA== X-Gm-Message-State: AOAM533R0s0L9/X83KvsNzB9fax3fy0NitjxuNCHYBAjOkGYva1o/Qus VKFRpKPY2qXsdqL9CxUKOTTZ7yxQJsA= X-Google-Smtp-Source: ABdhPJwz0ONj31dru9jj7fZhGSAh3cqOSHEAnDvkWmrTeTtQCnRO25whv2gK/gAHP7MXxAbMJwL74A== X-Received: by 2002:a05:600c:b4b:: with SMTP id k11mr2486381wmr.129.1619590772867; Tue, 27 Apr 2021 23:19:32 -0700 (PDT) Received: from amdahl30 ([2a01:e0a:20e:d340:2ef0:5dff:fed2:7b49]) by smtp.gmail.com with ESMTPSA id y5sm7072366wrm.61.2021.04.27.23.19.32 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 27 Apr 2021 23:19:32 -0700 (PDT) From: =?utf-8?Q?K=C3=A9vin_Le_Gouguec?= <kevin.legouguec@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> <20210428030025.75hiu5zgrll2qzeq@HIDDEN> Date: Wed, 28 Apr 2021 08:19:31 +0200 In-Reply-To: <20210428030025.75hiu5zgrll2qzeq@HIDDEN> (Boruch Baum's message of "Tue, 27 Apr 2021 23:00:25 -0400") Message-ID: <87fszbnd70.fsf@HIDDEN> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: 0.0 (/) X-Debbugs-Envelope-To: 48072 Cc: Eli Zaretskii <eliz@HIDDEN>, 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.0 (-) Boruch Baum <boruch_baum@HIDDEN> writes: >> > > This is certainly a mistake: a valid shell command doesn't have to be >> > > a file that executable-find is able to find. Shells are known to >> > > support all kinds of internal and magic commands. >> > >> > My testing indicates otherwise. >> >> Would you care to share the details of that testing, please? > > I evaluated shell-command-to-string for shell aliases and shell > functions, all of which returned error of type 'command not found'. That > would indicate that the class of 'internal commands' aren't valid in the > current state of emacs. Shell builtins seem to work though: M-: (shell-command-to-string "type echo") "echo is a shell builtin " M-: (shell-command-to-string "which type") "which: no type in (=E2=80=A6) "
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 03:00:38 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 27 23:00:38 2021 Received: from localhost ([127.0.0.1]:51414 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbaRK-0008Dp-CF for submit <at> debbugs.gnu.org; Tue, 27 Apr 2021 23:00:38 -0400 Received: from mout.gmx.net ([212.227.17.21]:46383) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <boruch_baum@HIDDEN>) id 1lbaRH-0008Da-6R for 48072 <at> debbugs.gnu.org; Tue, 27 Apr 2021 23:00:37 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619578828; bh=GhvOZ7dcIdhpgh34uUcDxDacuLPx47D4QPzIN5giZ9Y=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=INfWbEljvkRPlA1MhT79oovwFZ7s1IOQFTFQcUrgXGCvlfzP1FCUxkZhpNfHrYfMj SGqKye8knQHJzlcBWLZJ291m5IIaO7EiMPfqL3ZZCK3tvNvOe5Otl12rKpy7bkZzKC DWli5K0AnYcm3IXURnhJONuCuCYzU2eZ+tH47bw8= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N2mBQ-1lRVB20agm-0133BB; Wed, 28 Apr 2021 05:00:28 +0200 Date: Tue, 27 Apr 2021 23:00:25 -0400 From: Boruch Baum <boruch_baum@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Message-ID: <20210428030025.75hiu5zgrll2qzeq@HIDDEN> References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> <83k0ongnc7.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83k0ongnc7.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:vSzA0RGeOuOE4ACxeRyVi3IoVSgIX2UpAxodscbjJz0hoLEhCv4 a03VqHtry3UWCYwu2j2NET6J3AYGvOtM7bRQzkbObN2EG1oudnc8A7nalyCPoC0dGfD5tU3 ORZTtmC4mZCakLlb8XLhjOizVuKczbpJdE+/BQzdeggyuRdjpM1PkS3VlMrpOGV2H7N95Yp uGCE5HIu0lPB0G+HGzwCg== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:Y0fVFtQIIaE=:eXxYjdnDoCy1ogmbdjAaah PLaBT4T+wVOiBVfXITwUvckbQootWRiIDVEx0MDZbfhfcGq8CivRcI+zsFo6jGELzN45jE+Aj YyfHJyYdj6TDufACRU+bhaG7IT7ldedXFiK9dtf/B8GxttT6vTV2MCvAY5DweBGfLdbpqxhmO 0zoPNVAmXbedVHSa7PqOsoE55NeWfOgusVZlBtHPl9jtRP8jHtGzRlnoV7I/xl7khNaAxL9lp ZQkCz8nFPMpk5c51MLy6XduiC9AZqEbzV1VisXDb0avSay51xbTEvJo4noh7QPEhfyT+htRf+ Xq892N22NHhrQX8IvEC9547FaqI1VE8IbwDkMZPIFIHgwD5QTsH3rrLjDTtLwY3gB3kzrS+5v j50abJvKv1jYcU2vDtcf1SyXnS12yPMpkbk591wWb5Tlg+JR8xYdtK30xwKtM3xsDtzEH21cv yrppGeSH4DiJSsIpGxExTrz96bSyDDxOjZ7McohZLIY8G34OL7W1ZPQ3yaawNPIB7kDWHkIq7 t7vwL/gxiU57qz0TEfVnl6tYh2y4NYVVtWq70ejCEFBgIg2S/atjROwpAv6hqQZv8ncipHGHW LK2Cs6wsmRkyxCyaH2/2iLONN9n/c6AA4/P5VjOxBL7BBupMkcZdnCoH0944U2Flnv7NtLZvY Z7TWbz5FU+wRS8F25nrLnNQFv3i6Sukr2/47/5Q75hPdrqT2dWlJVYZm5fwoSdcJigj/B5Zsr 4Xo+8u/B/l196rTC/4KGBti9lM3JDOJ97nU8YwpJi1GDalanvLVPj5XCE7ug43T1K78IM+Pga j4Sm3cJL+YCkQn9pCcHHQYlVqQ21pl9P8XxfbVworPUd3bqB9eUSaQQ8tjYr0v7/CiReB8ukx 2fN/6fxrqvWv460Vd+r9CVLYMCg8uc8CaURsDNwbODwTSV9sg5hkSx5BWPmLult6OxxYqzEt0 bjsbmeGD0PdA7GQ5Y9lN6J6bMfDTpEGUlC7nvZ3qNGbIk1YwGFjAr3mw1Q2kITcEdokRAg3YC ku7MsmHfghgvjb4VQgUMVRYOQ4T22i5q3vmlzrTEsIiuWH5yAvGy2QTNpHyWpLNyoqXbV4Dk7 g+30DrBlSoOdRqtJ7GlU00uIotsPr6G3mBVUA0k0rmShhVx/Z6Xq7SFK+1no5kBTjfFJRaq8d PlwZvnVQLyWUA27fRYqC3SgxaX0aImv9NmJ77stJKAkyIwBulx5QxfPqEyvPc05rEmn/Y= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 2021-04-28 05:22, Eli Zaretskii wrote: > > Date: Tue, 27 Apr 2021 15:32:53 -0400 > > From: Boruch Baum <boruch_baum@HIDDEN> > > Cc: 48072 <at> debbugs.gnu.org > > > > > > validates the entered command as a valid shell executable. > > > > > > This is certainly a mistake: a valid shell command doesn't have to b= e > > > a file that executable-find is able to find. Shells are known to > > > support all kinds of internal and magic commands. > > > > My testing indicates otherwise. > > Would you care to share the details of that testing, please? I evaluated shell-command-to-string for shell aliases and shell functions, all of which returned error of type 'command not found'. That would indicate that the class of 'internal commands' aren't valid in the current state of emacs. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 28 Apr 2021 02:22:37 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 27 22:22:36 2021 Received: from localhost ([127.0.0.1]:51365 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbZqW-0007A3-O3 for submit <at> debbugs.gnu.org; Tue, 27 Apr 2021 22:22:36 -0400 Received: from eggs.gnu.org ([209.51.188.92]:33068) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lbZqU-00079n-G7 for 48072 <at> debbugs.gnu.org; Tue, 27 Apr 2021 22:22:35 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:35836) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lbZqO-00080u-Vu; Tue, 27 Apr 2021 22:22:29 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:2078 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lbZqO-0001B1-9G; Tue, 27 Apr 2021 22:22:28 -0400 Date: Wed, 28 Apr 2021 05:22:16 +0300 Message-Id: <83k0ongnc7.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> In-Reply-To: <20210427193253.ourhlr3nxdem3e6t@HIDDEN> (message from Boruch Baum on Tue, 27 Apr 2021 15:32:53 -0400) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> <20210427193253.ourhlr3nxdem3e6t@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 27 Apr 2021 15:32:53 -0400 > From: Boruch Baum <boruch_baum@HIDDEN> > Cc: 48072 <at> debbugs.gnu.org > > > > validates the entered command as a valid shell executable. > > > > This is certainly a mistake: a valid shell command doesn't have to be > > a file that executable-find is able to find. Shells are known to > > support all kinds of internal and magic commands. > > My testing indicates otherwise. Would you care to share the details of that testing, please?
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 27 Apr 2021 19:33:04 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 27 15:33:04 2021 Received: from localhost ([127.0.0.1]:50976 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbTSC-0005ph-Km for submit <at> debbugs.gnu.org; Tue, 27 Apr 2021 15:33:04 -0400 Received: from mout.gmx.net ([212.227.17.20]:45089) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <boruch_baum@HIDDEN>) id 1lbTSA-0005ov-Hr for 48072 <at> debbugs.gnu.org; Tue, 27 Apr 2021 15:33:03 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1619551976; bh=sEoebJbM/Cta5X/dynGQaZj2Y81nPYzkwXO8QcIMylA=; h=X-UI-Sender-Class:Date:From:To:Cc:Subject:References:In-Reply-To; b=NmbxsJAXhqp8FVtNu8JRFsQvr7RVEhAZvGiyxPRYzFVlthmJ/4jzJ+ZmRVeoqbato z3Rqz4/rk0iH3yW1EfBbN6ww2p2kl7T24iSTvhnld4DrkM/o6zXnC+otvl5hNY/m2G jHhUlbBWhl7WrNdCM+itj/y1AkiKVaq2rJihwess= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx105 [212.227.17.174]) with ESMTPSA (Nemesis) id 1N1wll-1lQnDN0Mu1-012INy; Tue, 27 Apr 2021 21:32:56 +0200 Date: Tue, 27 Apr 2021 15:32:53 -0400 From: Boruch Baum <boruch_baum@HIDDEN> To: Eli Zaretskii <eliz@HIDDEN> Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] Message-ID: <20210427193253.ourhlr3nxdem3e6t@HIDDEN> References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> <83lf93h6x1.fsf@HIDDEN> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <83lf93h6x1.fsf@HIDDEN> User-Agent: NeoMutt/20180716 X-Provags-ID: V03:K1:JNuWEAxrtRLJ0tM/QZrf1pecZfWjadWUNEqN7jQkUwY8/ra8Z+F s/zloPRdvuTpZPTOyvfsF/Ac2SkIWDOlMHEROKUEnRvMM549NnMqeD3bu5s7NBSSn2Ym7dC OIbJarhojes3BGa3v6uuk/nlpLg1Xp+/zWY8MBdcM5WlUfbRAOzIAd2iCv+fGLGJ9fIAjJf xcpok9S/2oKITeVSCBG7Q== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:BaFyEY+7lB8=:xUJ4VLxLRkpTMG+uNjyih1 zpydGyhIqu5tkOe9jeGagdlgeH9wtlDPMLNYzmjbwOt5J3dMexQJisSJz0cBbdegVXYNzomp4 pJO4FO+7KvAQW8vJlCWawAKyIO6iSxjo0Ztihz0VMB/ZoqY+0RrYVU+JhaJvf4I7nq7x/jHaL 0BEDb8TrBXPuzz6QfiXvQbJP4fs1HN/XcOxCQeHUUbCcCfw0dBsHMl7bXSpVdlv+r4ssBwMIS Fjhsvazob52XkNVLJBS1PVFOMFC7ozopjKzdjus+35+tJ0I+MEEySqAHbFk0v5SIeNDM/W8Rf Ir3Il036re8z2cOQS4SlTfJhooErbNbOCAQLR6zfYWYVV+7B+GJSRQ/Z377xMMCLl8Ep5bbHK U++cf7W580JEYtjXoLQTq4463qDBQgpmSap5DAnboAsqsqiQxDRVFsAp2pDvEkWuRu4kJqtS5 /kCBQ5J00zeQ6k+sFzj3g+fGQqDzDLgGV0Vc9YI6pcLjhJKnCcas3NavsNT/VjCABvi/yxIzE ORqvQ5wPtUsIxkGjeco8mr2x81EHiVEhnP0N0vh71pSjKI3SkUsYjWFYGwtNAG6jh/SMZ2C5Y sBjJYXtqFp2T9JYYc5KojNViUK2DYR5A2me8aK1/2Y4csSQVvyTsJK4/1PqzF30WERSwFiQX6 Vj/pCivUL8EEDtwP9pOnRFDCvV/ylvE2YM3DJYvlEh/9s7E/b3P0Jc9nU7WsZkMxYYtU/II2E wGZMKM9/vdDu+Pi/oNh86v2rd3qUf4Gcse3USEEpZpGPDyKyYwEokFnHisEl15jIIwjqdSEZi mGvR1hJB0wZObkh7c2orNAvshNqnRQoqlQRnqqD5RsPZCS01Nw2r7KEEyJk+97eTK1zM/NL1A h5Lvfcz0LjaJbVFQ+DRjy52gBorKDQfbE4/z4DX5jfyH1C6kj3JnT+0OZNl+0P1E64JbaqhzW IIuDThcjaf4g1Qyo4+qBoxJPTrxMafCGbjP5EH2wbzodf54XK6ZB8Vp5PPloY+g9MB/b5i36B gBGTYyeNBkL+BNp02mkjZAOVrG5/1GN96Ilg7w185Oa41JE+sh8Ee4IWpd625Q2j0bGoA+Wwm RTwsDoACidxMpOYw1sXOKTToDoA2GlBHziyWy/X3Al37dUzWwzbCB6G4jE7HOzQ3UiLMB3bA3 5Q7gOwHSLv0FXxz+sNqP+rVcjWJWBzBFvB+bSVKuUy77CPLO76mZBc+M1NHO4MyW08bRI= Content-Transfer-Encoding: quoted-printable X-Spam-Score: -0.7 (/) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -1.7 (-) On 2021-04-27 22:19, Eli Zaretskii wrote: > > Date: Tue, 27 Apr 2021 15:02:43 -0400 > > From: Boruch Baum <boruch_baum@HIDDEN> > > > > Function dired-read-shell-command was accepting an empty input. This i= s > > a bug because it then passes the empty input as a legitimate command > > which is silently processed (in error) by dired, eventually to return = a > > completion message. > > I'm not sure we want to disallow this. Well, that's not anything for me to respond to. > (Wasn't there a similar discussion recently?) I don't follow the mailing lists, so I have no idea. > > validates the entered command as a valid shell executable. > > This is certainly a mistake: a valid shell command doesn't have to be > a file that executable-find is able to find. Shells are known to > support all kinds of internal and magic commands. My testing indicates otherwise. > > Thanks. =2D- hkp://keys.gnupg.net CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.Received: (at 48072) by debbugs.gnu.org; 27 Apr 2021 19:19:46 +0000 From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 27 15:19:46 2021 Received: from localhost ([127.0.0.1]:50949 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>) id 1lbTFK-0005Sh-7D for submit <at> debbugs.gnu.org; Tue, 27 Apr 2021 15:19:46 -0400 Received: from eggs.gnu.org ([209.51.188.92]:35090) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from <eliz@HIDDEN>) id 1lbTFE-0005SR-S5 for 48072 <at> debbugs.gnu.org; Tue, 27 Apr 2021 15:19:44 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:57176) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from <eliz@HIDDEN>) id 1lbTF9-0003jx-Ei; Tue, 27 Apr 2021 15:19:35 -0400 Received: from 84.94.185.95.cable.012.net.il ([84.94.185.95]:4141 helo=home-c4e4a596f7) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from <eliz@HIDDEN>) id 1lbTF8-00051Z-Pi; Tue, 27 Apr 2021 15:19:35 -0400 Date: Tue, 27 Apr 2021 22:19:22 +0300 Message-Id: <83lf93h6x1.fsf@HIDDEN> From: Eli Zaretskii <eliz@HIDDEN> To: Boruch Baum <boruch_baum@HIDDEN> In-Reply-To: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> (message from Boruch Baum on Tue, 27 Apr 2021 15:02:43 -0400) Subject: Re: bug#48072: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH] References: <20210427190243.n5yg3gywd5wma3jl@HIDDEN> X-Spam-Score: -2.3 (--) X-Debbugs-Envelope-To: 48072 Cc: 48072 <at> debbugs.gnu.org X-BeenThere: debbugs-submit <at> debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list List-Id: <debbugs-submit.debbugs.gnu.org> List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe> List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/> List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org> List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help> List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>, <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe> Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org> X-Spam-Score: -3.3 (---) > Date: Tue, 27 Apr 2021 15:02:43 -0400 > From: Boruch Baum <boruch_baum@HIDDEN> > > Function dired-read-shell-command was accepting an empty input. This is > a bug because it then passes the empty input as a legitimate command > which is silently processed (in error) by dired, eventually to return a > completion message. I'm not sure we want to disallow this. (Wasn't there a similar discussion recently?) > validates the entered command as a valid shell executable. This is certainly a mistake: a valid shell command doesn't have to be a file that executable-find is able to find. Shells are known to support all kinds of internal and magic commands. Thanks.
bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.
Received: (at submit) by debbugs.gnu.org; 27 Apr 2021 19:02:55 +0000
From debbugs-submit-bounces <at> debbugs.gnu.org Tue Apr 27 15:02:55 2021
Received: from localhost ([127.0.0.1]:50929 helo=debbugs.gnu.org)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <debbugs-submit-bounces <at> debbugs.gnu.org>)
id 1lbSz1-00054g-Gw
for submit <at> debbugs.gnu.org; Tue, 27 Apr 2021 15:02:55 -0400
Received: from lists.gnu.org ([209.51.188.17]:48252)
by debbugs.gnu.org with esmtp (Exim 4.84_2)
(envelope-from <boruch_baum@HIDDEN>) id 1lbSyx-00054W-FD
for submit <at> debbugs.gnu.org; Tue, 27 Apr 2021 15:02:53 -0400
Received: from eggs.gnu.org ([2001:470:142:3::10]:40460)
by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
id 1lbSyw-0006Ab-Ur
for bug-gnu-emacs@HIDDEN; Tue, 27 Apr 2021 15:02:51 -0400
Received: from mout.gmx.net ([212.227.17.20]:45629)
by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256)
(Exim 4.90_1) (envelope-from <boruch_baum@HIDDEN>)
id 1lbSyu-00020k-Iz
for bug-gnu-emacs@HIDDEN; Tue, 27 Apr 2021 15:02:50 -0400
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net;
s=badeba3b8450; t=1619550166;
bh=ESKMd+CU0JQ4BoHIz+SxOG9vyBNKdOx3jtCWdyHC/40=;
h=X-UI-Sender-Class:Date:From:To:Subject;
b=iorK+I84qPAmria+pEXyABL3SNMD8lMt6kbSBkjVQd8im5oUx+kvfG62k7em/w+jI
2ay7h80aH5l4MSTMn+7cX15Zf+YIMqQFLWhTHFw+ObrRNpH6KJEX9X8ehOREKPuUxO
wdH2rHMpfoO0/7Hz/ZwNpl3A9e4G46xMWK++CNoY=
X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c
Received: from E15-2016.optimum.net ([70.19.86.82]) by mail.gmx.net (mrgmx104
[212.227.17.174]) with ESMTPSA (Nemesis) id 1MmDEm-1lBEus0Rwe-00iAfT
for <bug-gnu-emacs@HIDDEN>; Tue, 27 Apr 2021 21:02:46 +0200
Date: Tue, 27 Apr 2021 15:02:43 -0400
From: Boruch Baum <boruch_baum@HIDDEN>
To: Emacs Bug Reporting <bug-gnu-emacs@HIDDEN>
Subject: 28.0.50: dired-read-shell-command: handle empty input properly [PATCH]
Message-ID: <20210427190243.n5yg3gywd5wma3jl@HIDDEN>
MIME-Version: 1.0
Content-Type: multipart/mixed; boundary="mhgi27fezbpzjmsj"
Content-Disposition: inline
User-Agent: NeoMutt/20180716
X-Provags-ID: V03:K1:AwOW+QHyqYojSk/1ei71t1ebIVNtyEdeS5A/o4Da/y8x/FW7wFv
b0WroEvb5ffSAZiQchyGOIabZZ4rYQjI3BiOEI8Eo76fof0owMCQFuW9soLH2quNOqQJq/p
4nIDqR/138rIjw61PmqMAQv4uMbQYqsYjKQKITIzO5fW0oKZIis8dJbNLFuGn4MKogp+H4v
oN8lcC9K7gfDMkq7/ItYA==
X-Spam-Flag: NO
X-UI-Out-Filterresults: notjunk:1;V03:K0:L06RcBppdJU=:Do097oJ3MBcHPRmKfyt0nS
qhgGP3AWtvAxJGkntrALykPJQgMH2BduMdCkHNSl+rISisfdl4LcE8rKMI7fsaoUzQPij+eIg
XqZTJBSjMybIhUbgBlpk2A/vErvU0IN+YOzxo2W2ueBAZ5VdPUrliq+A+P6Bn4xGKOs5zKO4G
EpKL1BSLPzo7Edlt+8wkG2d4BGYnpTydPd55O9KZyffFK6PgnHdeSqGAkpTIvIXKh671TCcQ9
17Q2fJurZPLoOkg5N9b1DWiT258zbZ4hSLIlS2Zb5R2u2l9hRmFSQprFZWh9XQXWRltPCeKY8
0Mzq6xiyOPQ8lSMvDuVHHMDHJTiB5pDXhlHs4+N9qjMzosO8LrDkEyjGijK3vfqJuav7I8t1x
3nqUxjQ6L1erAtHVsIeE8yckydLSqVy0cUJwrwCFL4l08NUBV5Ffg9LHtW5IyoDV4mwDZfPOn
cstoPJNQ+W5ReBmvAnXUb33lbx/BtUrLQybYCf7ectPwDW9RddP9zZceDK0IlJ9wH0OKYkaQb
pR9CGk4oUF9eg3+OlazvujpZFDDoj2kodWg5VLu6dtWLckbhFRCjjqAKikoi2DB4DX8JeOyN/
Wj/ralugd7BowXSjy6mZGiZeA8dCtsszsOTRjSvpGUtPuZpiIS+XEcuLWY+leTtfVfOStxwBR
iFyde1lE9TaQ2zdFqEtTFkTxaW5s4wZq7zYZxheae5xowD63dlpIwAbzUjXUGMrGFXcq24TCX
v5LSc1ZCg+nU05YuhPNLf9yxOAV31RAcKBuRK2VyDwm63+U9NgGSySHTK7ddC5cDj19Kr345G
YN0Eu/ljTp5WWNMlCPWucGyqB9uPDBjKpZUxuZwMB+nSfjSLqPjSfp5R+nSx/byCdXGmmJvUt
Nf6CIDBW8/afcaCIwVaoKekOQfh1UWe3WJKB/Xw0UI0bsmE7yM5Vm64UvwypTaeoso2v0tk3Z
GrkOtcmzsOcc7gf6LZWyeidZGA2IXbZWqe+h6K7yVNzpOmUw87GLnB5BrH95eNUexykrEahOv
3HYF30qUMz71Fga6rA4eMCahO51ze6o6sKae9ZSko7K4K865ze7UfnZz6cqdShK22UAWZfKU7
7B4bq7jNspx2+k5sEpGiZvRmVa2C+vq7NrVPcETeAQhdXFbvYXjpTilZcLBzXE5X4tPzdGRq3
ynAR85XgPZy+3pQby8oB+FpHZaB5JYGMmsqFuCmiXp67HpIAiDGww2si+1HpmEJPJ6dmI=
Received-SPF: pass client-ip=212.227.17.20; envelope-from=boruch_baum@HIDDEN;
helo=mout.gmx.net
X-Spam_score_int: -25
X-Spam_score: -2.6
X-Spam_bar: --
X-Spam_report: (-2.6 / 5.0 requ) BAYES_00=-1.9, DKIM_SIGNED=0.1,
DKIM_VALID=-0.1, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_LOW=-0.7,
RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001,
SPF_PASS=-0.001 autolearn=ham autolearn_force=no
X-Spam_action: no action
X-Spam-Score: 0.1 (/)
X-Debbugs-Envelope-To: submit
X-BeenThere: debbugs-submit <at> debbugs.gnu.org
X-Mailman-Version: 2.1.18
Precedence: list
List-Id: <debbugs-submit.debbugs.gnu.org>
List-Unsubscribe: <https://debbugs.gnu.org/cgi-bin/mailman/options/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=unsubscribe>
List-Archive: <https://debbugs.gnu.org/cgi-bin/mailman/private/debbugs-submit/>
List-Post: <mailto:debbugs-submit <at> debbugs.gnu.org>
List-Help: <mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=help>
List-Subscribe: <https://debbugs.gnu.org/cgi-bin/mailman/listinfo/debbugs-submit>,
<mailto:debbugs-submit-request <at> debbugs.gnu.org?subject=subscribe>
Errors-To: debbugs-submit-bounces <at> debbugs.gnu.org
Sender: "Debbugs-submit" <debbugs-submit-bounces <at> debbugs.gnu.org>
X-Spam-Score: -2.4 (--)
--mhgi27fezbpzjmsj
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable
Function dired-read-shell-command was accepting an empty input. This is
a bug because it then passes the empty input as a legitimate command
which is silently processed (in error) by dired, eventually to return a
completion message.
The attached patch fixes that, and also validates the entered command as
a valid shell executable.
=2D-
hkp://keys.gnupg.net
CA45 09B5 5351 7C11 A9D1 7286 0036 9E45 1595 8BC0
--mhgi27fezbpzjmsj
Content-Type: text/x-diff; charset=us-ascii
Content-Disposition: attachment; filename="dired-aux-read-shell-command.patch"
Content-Transfer-Encoding: quoted-printable
diff --git a/dired-aux.el b/dired-aux.el
index 1c10990..7f5775c 100644
=2D-- a/dired-aux.el
+++ b/dired-aux.el
@@ -674,15 +674,22 @@ This normally reads using `read-shell-command', but =
if the
offer a smarter default choice of shell command."
(minibuffer-with-setup-hook
(lambda ()
- (setq-local dired-aux-files files)
- (setq-local minibuffer-default-add-function
- #'minibuffer-default-add-dired-shell-commands))
+ (setq-local dired-aux-files files)
+ (setq-local minibuffer-default-add-function
+ #'minibuffer-default-add-dired-shell-commands))
(setq prompt (format prompt (dired-mark-prompt arg files)))
- (if (functionp 'dired-guess-shell-command)
- (dired-mark-pop-up nil 'shell files
- 'dired-guess-shell-command prompt files)
- (dired-mark-pop-up nil 'shell files
- 'read-shell-command prompt nil nil))))
+ (let (command)
+ (setq command
+ (if (functionp 'dired-guess-shell-command)
+ (dired-mark-pop-up nil 'shell files
+ 'dired-guess-shell-command prompt files)
+ (dired-mark-pop-up nil 'shell files
+ 'read-shell-command prompt nil nil)))
+ (when (string-empty-p command)
+ (user-error "No command entered. Nothing to do!"))
+ (unless (executable-find command)
+ (user-error "Not a valid command!"))
+ command)))
;;;###autoload
(defun dired-do-async-shell-command (command &optional arg file-list)
--mhgi27fezbpzjmsj--
Boruch Baum <boruch_baum@HIDDEN>:bug-gnu-emacs@HIDDEN.
Full text available.bug-gnu-emacs@HIDDEN:bug#48072; Package emacs.
Full text available.
GNU bug tracking system
Copyright (C) 1999 Darren O. Benham,
1997 nCipher Corporation Ltd,
1994-97 Ian Jackson.