GNU bug report logs - #48101
[PATCH] gnu: Add aspell-dict-ro.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48101 in the body.
You can then email your comments to 48101 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] gnu: Add aspell-dict-ro.
Date: Thu, 29 Apr 2021 10:17:05 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

Please find attached my first ever patch adding the Romanian
aspell dictionary.

The addition seems very simple and I tested building and installing it
in my custom channel and building within a Git checkout of Guix.

Do tell me if there are any improvement opportunities, I am here to
learn :-)

-
Sergiu

[0001-gnu-Add-aspell-dict-ro.patch (text/x-patch, attachment)]

Message #10 received at 48101-done <at> debbugs.gnu.org (full text, mbox):

From: Julien Lepiller <julien <at> lepiller.eu>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 48101-done <at> debbugs.gnu.org
Subject: Re: [bug#48101] [PATCH] gnu: Add aspell-dict-ro.
Date: Fri, 30 Apr 2021 12:54:16 +0200

Le Thu, 29 Apr 2021 10:17:05 +0200,
Sergiu Ivanov <sivanov <at> colimite.fr> a écrit :

> Dear Guix,
> 
> Please find attached my first ever patch adding the Romanian
> aspell dictionary.
> 
> The addition seems very simple and I tested building and installing it
> in my custom channel and building within a Git checkout of Guix.
> 
> Do tell me if there are any improvement opportunities, I am here to
> learn :-)
> 
> -
> Sergiu

Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
changes:

I added a copyright line for you at the top of the file.

There was an alignment issue, caused by tabulations. I replaced them
with spaces (please don't use tabs).

You should be able to use the package after running "guix pull". Thanks
for your contribution!

Message #13 received at 48101-done <at> debbugs.gnu.org (full text, mbox):

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: Julien Lepiller <julien <at> lepiller.eu>
Cc: 48101-done <at> debbugs.gnu.org
Subject: Re: [bug#48101] [PATCH] gnu: Add aspell-dict-ro.
Date: Fri, 30 Apr 2021 15:17:43 +0200

Thus quoth  Julien Lepiller  on Fri Apr 30 2021 at 12:54 (+0200):
> Le Thu, 29 Apr 2021 10:17:05 +0200,
> Sergiu Ivanov <sivanov <at> colimite.fr> a écrit :
>
>> Dear Guix,
>> 
>> Please find attached my first ever patch adding the Romanian
>> aspell dictionary.
>> 
>> The addition seems very simple and I tested building and installing it
>> in my custom channel and building within a Git checkout of Guix.
>> 
>> Do tell me if there are any improvement opportunities, I am here to
>> learn :-)
>> 
>> -
>> Sergiu
>
> Pushed as 847f523381f79e46d151257bf5f9a636a85db8ac with some small
> changes:
>
> I added a copyright line for you at the top of the file.

Oh, thank you, I completely forgot about that!

> There was an alignment issue, caused by tabulations. I replaced them
> with spaces (please don't use tabs).

Ooops, sorry, I've just disabled tabs in my Emacs configuration.
Not sure why I kept them enabled anyway.

> You should be able to use the package after running "guix pull". Thanks
> for your contribution!

Thank you for your time!

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.