GNU bug report logs - #48102
[PATCH] * yasnippet-tests.el: Fix failing tests by adding lisp-data-mode

Previous Next

Package: emacs;

Reported by: Morgan.J.Smith <at> outlook.com

Date: Thu, 29 Apr 2021 14:33:02 UTC

Severity: normal

Tags: fixed, patch

Fixed in version 28.1

Done: Lars Ingebrigtsen <larsi <at> gnus.org>

Bug is archived. No further changes may be made.

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48102 in the body.
You can then email your comments to 48102 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

View this report as an mbox folder, status mbox, maintainer mbox

Report forwarded to bug-gnu-emacs <at> gnu.org:
bug#48102; Package emacs. (Thu, 29 Apr 2021 14:33:02 GMT) Full text and rfc822 format available.
Acknowledgement sent to Morgan.J.Smith <at> outlook.com:
New bug report received and forwarded. Copy sent to bug-gnu-emacs <at> gnu.org. (Thu, 29 Apr 2021 14:33:02 GMT) Full text and rfc822 format available.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Morgan.J.Smith <at> outlook.com
To: bug-gnu-emacs <at> gnu.org
Cc: Morgan Smith <Morgan.J.Smith <at> outlook.com>, npostavs <at> gmail.com
Subject: [PATCH] * yasnippet-tests.el: Fix failing tests by adding
 lisp-data-mode
Date: Thu, 29 Apr 2021 10:12:55 -0400

From: Morgan Smith <Morgan.J.Smith <at> outlook.com>

---

I have done my copyright paperwork (not that it's needed for something this small).

lisp-data-mode was added to master on April 18th in commit 43fded12d544ab68f493142debc5b3e437317f35

---
 yasnippet-tests.el | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/yasnippet-tests.el b/yasnippet-tests.el
index b8a7980..fdc5395 100644
--- a/yasnippet-tests.el
+++ b/yasnippet-tests.el
@@ -1389,6 +1389,9 @@ (ert-deftest loading-with-cyclic-parenthood ()
                           ;; prog-mode doesn't exist in emacs 23.4
                           ,@(if (fboundp 'prog-mode)
                                 '(prog-mode))
+                          ;; lisp-data-mode doesn't exist in emacs 27.1
+                          ,@(if (fboundp 'lisp-data-mode)
+                                '(lisp-data-mode))
                           emacs-lisp-mode
                           lisp-interaction-mode))
               (observed (yas--modes-to-activate)))
@@ -1416,6 +1419,9 @@ (ert-deftest extra-modes-parenthood ()
                                ;; prog-mode doesn't exist in emacs 23.4
                                ,@(if (fboundp 'prog-mode)
                                      '(prog-mode))
+                               ;; lisp-data-mode doesn't exist in emacs 27.1
+                               ,@(if (fboundp 'lisp-data-mode)
+                                     '(lisp-data-mode))
                                emacs-lisp-mode
                                and-also-this-one
                                lisp-interaction-mode))
-- 
2.31.1
Information forwarded to bug-gnu-emacs <at> gnu.org:
bug#48102; Package emacs. (Sun, 02 May 2021 07:54:02 GMT) Full text and rfc822 format available.

Message #8 received at 48102 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Morgan.J.Smith <at> outlook.com
Cc: 48102 <at> debbugs.gnu.org, npostavs <at> gmail.com
Subject: Re: bug#48102: [PATCH] * yasnippet-tests.el: Fix failing tests by
 adding lisp-data-mode
Date: Sun, 02 May 2021 09:53:40 +0200

Morgan.J.Smith <at> outlook.com writes:

> +                          ;; lisp-data-mode doesn't exist in emacs 27.1
> +                          ,@(if (fboundp 'lisp-data-mode)
> +                                '(lisp-data-mode))

Thanks; applied to GNU ELPA now.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no
Added tag(s) fixed. Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 02 May 2021 07:54:02 GMT) Full text and rfc822 format available.
bug marked as fixed in version 28.1, send any further explanations to 48102 <at> debbugs.gnu.org and Morgan.J.Smith <at> outlook.com Request was from Lars Ingebrigtsen <larsi <at> gnus.org> to control <at> debbugs.gnu.org. (Sun, 02 May 2021 07:54:02 GMT) Full text and rfc822 format available.
bug archived. Request was from Debbugs Internal Request <help-debbugs <at> gnu.org> to internal_control <at> debbugs.gnu.org. (Sun, 30 May 2021 11:24:04 GMT) Full text and rfc822 format available.
This bug report was last modified 2 years and 329 days ago.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.