GNU bug report logs - #48128
[PATCH] Add font-montserrat.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48128 in the body.
You can then email your comments to 48128 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: guix-patches <at> gnu.org
Subject: [PATCH] Add font-montserrat.
Date: Fri, 30 Apr 2021 22:47:38 +0200

[Message part 1 (text/plain, inline)]

Dear Guix,

Here's a patch adding the font Montserrat.

I retrieve the release zipball from GitHub using a direct url-fetch
rather than git-fetch, because I've seen both in fonts.scm. If you think
git-fetch is more appropriate, I'll change the method.

Thank you!

[0001-Add-font-montserrat.patch (text/x-patch, attachment)]

Message #8 received at 48128 <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 48128 <at> debbugs.gnu.org
Subject: Re: bug#48128: [PATCH] Add font-montserrat.
Date: Mon, 03 May 2021 18:13:45 +0200

Hi Sergiu,

Sergiu Ivanov <sivanov <at> colimite.fr> skribis:

> I retrieve the release zipball from GitHub using a direct url-fetch
> rather than git-fetch, because I've seen both in fonts.scm. If you think
> git-fetch is more appropriate, I'll change the method.


[...]

> +              (method url-fetch)
> +              (uri (string-append
> +                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))

This is a generated tarball that may change over time, which is why
‘guix lint’ warns about it.  So yes, I think you should use ‘git-fetch’
instead.

You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
lint’ suggests.

There are also a couple of ‘guix lint’ warnings that I’ll let you
check.  :-)

> +    (synopsis "The Montserat font")
                            ^
Missing ‘r’.

Could you send an updated patch?

Thanks in advance,
Ludo’.

Message #13 received at 48128 <at> debbugs.gnu.org (full text, mbox):

From: Sergiu Ivanov <sivanov <at> colimite.fr>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48128 <at> debbugs.gnu.org
Subject: Re: bug#48128: [PATCH] Add font-montserrat.
Date: Wed, 05 May 2021 22:17:25 +0200

[Message part 1 (text/plain, inline)]

Hi Ludovic,

Thank you for taking the time to answer and giving me the opportunity
to learn!

Also, sorry for the delay.


Thus quoth  Ludovic Courtès  on Mon May 03 2021 at 18:13 (+0200):
> Hi Sergiu,
>
> Sergiu Ivanov <sivanov <at> colimite.fr> skribis:
>
>> I retrieve the release zipball from GitHub using a direct url-fetch
>> rather than git-fetch, because I've seen both in fonts.scm. If you think
>> git-fetch is more appropriate, I'll change the method.
>
>
> [...]
>
>> +              (method url-fetch)
>> +              (uri (string-append
>> +                    "https://github.com/JulietaUla/Montserrat/archive/refs/tags/v" version ".zip"))
>
> This is a generated tarball that may change over time, which is why
> ‘guix lint’ warns about it.  So yes, I think you should use ‘git-fetch’
> instead.

I changed that, thank you.

> You’ll also have to add a ‘file-name’ field to the origin, as ‘guix
> lint’ suggests.

Indeed, I added that field.

> There are also a couple of ‘guix lint’ warnings that I’ll let you
> check.  :-)

I left closing parens on a separate line :O :O :O

I remember thinking how guix lint was wonderful when I read the Guix
Manual, and now I forgot to run it :D

>> +    (synopsis "The Montserat font")
>                             ^
> Missing ‘r’.

Fixed, thank you.

> Could you send an updated patch?

I attach the update.

-
Sergiu

[0001-Add-font-montserrat.patch (text/x-patch, attachment)]

Message #18 received at 48128-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Sergiu Ivanov <sivanov <at> colimite.fr>
Cc: 48128-done <at> debbugs.gnu.org
Subject: Re: bug#48128: [PATCH] Add font-montserrat.
Date: Sat, 08 May 2021 12:14:01 +0200

Hi Sergiu,

Sergiu Ivanov <sivanov <at> colimite.fr> skribis:

> Thank you for taking the time to answer and giving me the opportunity
> to learn!

You’re welcome.  :-)

> From fcec43e6a60081c2041f5827f22bcccec3c17bfd Mon Sep 17 00:00:00 2001
> From: Sergiu Ivanov <sivanov <at> colimite.fr>
> Date: Fri, 30 Apr 2021 22:20:16 +0200
> Subject: [PATCH] Add font-montserrat.
>
> ---
>  gnu/packages/fonts.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)

I added a ChangeLog-style commit message and committed it.

Thank you!

Ludo’.

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.