GNU bug report logs - #48145
Quoting of when argument in expansion of declare obsolete

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48145 in the body.
You can then email your comments to 48145 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #3 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Glenn Morris <rgm <at> gnu.org>
To: submit <at> debbugs.gnu.org
Subject: Quoting of when argument in expansion of declare obsolete
Date: Sat, 01 May 2021 13:12:14 -0400

Package: emacs
Version: 28.0.50
Severity: wishlist

I noticed statements like these in loaddefs.el, and found the quoting of
the final WHEN argument a bit unexpected:

(make-obsolete 'gnus-intersection 'seq-intersection '"28.1")

I guess it is because of how byte-run--set-obsolete (and friends) is defined.
Does it need to quote the `when' argument, since `when' is documented to
be a string?

Message #6 received at 48145 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 48145 <at> debbugs.gnu.org
Subject: Re: bug#48145: Quoting of when argument in expansion of declare
 obsolete
Date: Sun, 02 May 2021 09:03:11 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> I noticed statements like these in loaddefs.el, and found the quoting of
> the final WHEN argument a bit unexpected:
>
> (make-obsolete 'gnus-intersection 'seq-intersection '"28.1")
>
> I guess it is because of how byte-run--set-obsolete (and friends) is defined.
> Does it need to quote the `when' argument, since `when' is documented to
> be a string?

Grepping through the tree, we seem to have no non-string `when's, so
removing the ' should be safe.

We could also tweak things like

(function-put 'defmethod 'doc-string-elt '3)

I guess...

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #9 received at 48145 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Glenn Morris <rgm <at> gnu.org>
Cc: 48145 <at> debbugs.gnu.org
Subject: Re: bug#48145: Quoting of when argument in expansion of declare
 obsolete
Date: Fri, 17 Jun 2022 18:13:32 +0200

Glenn Morris <rgm <at> gnu.org> writes:

> I noticed statements like these in loaddefs.el, and found the quoting of
> the final WHEN argument a bit unexpected:
>
> (make-obsolete 'gnus-intersection 'seq-intersection '"28.1")
>
> I guess it is because of how byte-run--set-obsolete (and friends) is defined.
> Does it need to quote the `when' argument, since `when' is documented to
> be a string?

I've now changed it to not quote the when in Emacs 29 -- doesn't seem to
have any odd side effects as far as I can tell.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #14 received at 48145 <at> debbugs.gnu.org (full text, mbox):

From: Stefan Monnier <monnier <at> iro.umontreal.ca>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 48145 <at> debbugs.gnu.org
Subject: Re: bug#48145: Quoting of when argument in expansion of declare
 obsolete
Date: Fri, 17 Jun 2022 12:32:19 -0400

> We could also tweak things like
>
> (function-put 'defmethod 'doc-string-elt '3)

Indeed, this should also refrain from quoting.


        Stefan

Message #17 received at 48145 <at> debbugs.gnu.org (full text, mbox):

From: Andreas Schwab <schwab <at> linux-m68k.org>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: Glenn Morris <rgm <at> gnu.org>, 48145 <at> debbugs.gnu.org
Subject: Re: bug#48145: Quoting of when argument in expansion of declare
 obsolete
Date: Fri, 17 Jun 2022 18:46:20 +0200

On Mai 02 2021, Lars Ingebrigtsen wrote:

> Grepping through the tree, we seem to have no non-string `when's, so
> removing the ' should be safe.

It's not a matter of being a string or not, but whether it is a
self-evaluating expression or not.

-- 
Andreas Schwab, schwab <at> linux-m68k.org
GPG Key fingerprint = 7578 EB47 D4E5 4D69 2510  2552 DF73 E780 A9DA AEC1
"And now for something completely different."

Message #20 received at 48145 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Stefan Monnier <monnier <at> iro.umontreal.ca>
Cc: Glenn Morris <rgm <at> gnu.org>, 48145 <at> debbugs.gnu.org
Subject: Re: bug#48145: Quoting of when argument in expansion of declare
 obsolete
Date: Fri, 17 Jun 2022 19:11:35 +0200

Stefan Monnier <monnier <at> iro.umontreal.ca> writes:

>> We could also tweak things like
>>
>> (function-put 'defmethod 'doc-string-elt '3)
>
> Indeed, this should also refrain from quoting.

Now fixed.

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.