GNU bug report logs - #48158
[PATCH] gnu: xboard: Patch path to aplay.

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48158 in the body.
You can then email your comments to 48158 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: guix-patches <at> gnu.org
Cc: Michael Rohleder <mike <at> rohleder.de>
Subject: [PATCH] gnu: xboard: Patch path to aplay.
Date: Sun,  2 May 2021 13:46:20 +0200

Fixes <http://issues.guix.gnu.org/47195>.

* gnu/packages/games.scm (xboard): Patch path to aplay.
[inputs]: Add alsa-utils.
[arguments]: Add phase patch-aplay-path.
---
 gnu/packages/games.scm | 13 ++++++++++++-
 1 file changed, 12 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/games.scm b/gnu/packages/games.scm
index 3227b3e6fc..8bd3c95ebb 100644
--- a/gnu/packages/games.scm
+++ b/gnu/packages/games.scm
@@ -3323,8 +3323,19 @@ exec ~a/bin/freedink -refdir ~a/share/dink\n"
         (base32
          "1mkh36xnnacnz9r00b5f9ld9309k32jv6mcavklbdnca8bl56bib"))))
     (build-system gnu-build-system)
+    (arguments
+     `(#:phases
+       (modify-phases %standard-phases
+         ;; Fixes https://issues.guix.gnu.org/47195.
+         (add-after 'unpack 'patch-aplay-path
+           (lambda* (#:key inputs #:allow-other-keys)
+             (substitute* "xboard.conf"
+               (("aplay -q")
+                (string-append (assoc-ref inputs "alsa-utils") "/bin/aplay -q")))
+             #t)))))
     (inputs
-     `(("gtk+" ,gtk+-2)
+     `(("alsa-utils" ,alsa-utils)
+       ("gtk+" ,gtk+-2)
        ("librsvg" ,librsvg)))
     (native-inputs
      `(("texinfo" ,texinfo)
-- 
2.31.1

Message #10 received at 48158-done <at> debbugs.gnu.org (full text, mbox):

From: Ludovic Courtès <ludo <at> gnu.org>
To: Michael Rohleder <mike <at> rohleder.de>
Cc: 48158-done <at> debbugs.gnu.org
Subject: Re: bug#48158: [PATCH] gnu: xboard: Patch path to aplay.
Date: Mon, 03 May 2021 18:02:51 +0200

Hi,

Michael Rohleder <mike <at> rohleder.de> skribis:

> Fixes <http://issues.guix.gnu.org/47195>.
>
> * gnu/packages/games.scm (xboard): Patch path to aplay.
> [inputs]: Add alsa-utils.
> [arguments]: Add phase patch-aplay-path.

Applied, thanks!

Incidentally, the following still breaks on the first move:

  $ guix environment --ad-hoc xboard -- xboard
  […]
  xboard: Error writing to first chess program: Broken pipe

At first sight the reason may be that it doesn’t find ‘fairymax’ (what’s
that?) in $PATH.  I’m sure I’m missing something obvious, but I wonder
if we could make it work out of the box.

Thoughts?

Ludo’.

Message #13 received at 48158 <at> debbugs.gnu.org (full text, mbox):

From: Michael Rohleder <mike <at> rohleder.de>
To: Ludovic Courtès <ludo <at> gnu.org>
Cc: 48158 <at> debbugs.gnu.org
Subject: Re: bug#48158: [PATCH] gnu: xboard: Patch path to aplay.
Date: Mon, 03 May 2021 18:13:32 +0200

[Message part 1 (text/plain, inline)]

Hi Ludo,

Thank you for reviewing!

Ludovic Courtès <ludo <at> gnu.org> writes:
> Incidentally, the following still breaks on the first move:
>
>   $ guix environment --ad-hoc xboard -- xboard
>   […]
>   xboard: Error writing to first chess program: Broken pipe
>
> At first sight the reason may be that it doesn’t find ‘fairymax’ (what’s
> that?) in $PATH.  I’m sure I’m missing something obvious, but I wonder
> if we could make it work out of the box.
>
> Thoughts?
>

Yes, I think that is https://issues.guix.gnu.org/45236

fairymax is a (simple) chessengine.

I plan to fix this issue (also via the xboard.conf), so that gnuchess
gets the default configured engine, after this one here is merged...

-- 
Wenn Du denkst, Abenteuer sind gefährlich, dann versuch´s doch mal mit Routine.
Die ist tödlich.    - Paulo Coelho

[signature.asc (application/pgp-signature, inline)]

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.