GNU bug report logs - #48176
28.0.50; loadup.el leaves some variables in the lexical environment

Previous Next

To add a comment to this bug, you must first unarchive it, by sending
a message to control AT debbugs.gnu.org, with unarchive 48176 in the body.
You can then email your comments to 48176 AT debbugs.gnu.org in the normal way.

Toggle the display of automated, internal messages from the tracker.

Message #5 received at submit <at> debbugs.gnu.org (full text, mbox):

From: Philipp Stephani <p.stephani2 <at> gmail.com>
To: bug-gnu-emacs <at> gnu.org
Subject: 28.0.50; loadup.el leaves some variables in the lexical environment
Date: Sun, 02 May 2021 23:44:08 +0200

After starting Emacs, some spurious variables like `output' or `success'
are bound.  It looks like they come from loadup.el.  This can cause
practical issues, for example, in a file such as

;; -*- lexical-binding: t; -*-
(setq foo 123)
(setq output 123)

the byte compiler warns only about the variable `foo', but not `output'.


In GNU Emacs 28.0.50 (build 91, x86_64-pc-linux-gnu, GTK+ Version 3.24.24, cairo version 1.16.0)
 of 2021-05-02
Repository revision: 3768efdb926952cce85021e370c354e948b98ad0
Repository branch: master
Windowing system distributor 'The X.Org Foundation', version 11.0.12010000
System Description: Debian GNU/Linux rodete

Configured using:
 'configure --enable-gcc-warnings=warn-only
 --enable-gtk-deprecation-warnings --without-pop --with-mailutils
 --enable-checking=all --enable-check-lisp-object-type --with-modules
 'CFLAGS=-O0 -ggdb3''

Configured features:
CAIRO DBUS FREETYPE GIF GLIB GMP GNUTLS GSETTINGS HARFBUZZ JPEG JSON
LIBSELINUX LIBSYSTEMD MODULES NOTIFY INOTIFY PDUMPER PNG SECCOMP SOUND
THREADS TIFF TOOLKIT_SCROLL_BARS X11 XDBE XIM XPM GTK3 ZLIB

Important settings:
  value of $LC_TIME: en_DK.utf8
  value of $LANG: en_US.utf8
  value of $XMODIFIERS: @im=ibus
  locale-coding-system: utf-8-unix

Major mode: Lisp Interaction

Minor modes in effect:
  tooltip-mode: t
  global-eldoc-mode: t
  eldoc-mode: t
  electric-indent-mode: t
  mouse-wheel-mode: t
  tool-bar-mode: t
  menu-bar-mode: t
  file-name-shadow-mode: t
  global-font-lock-mode: t
  font-lock-mode: t
  blink-cursor-mode: t
  auto-composition-mode: t
  auto-encryption-mode: t
  auto-compression-mode: t
  line-number-mode: t
  transient-mark-mode: t

Load-path shadows:
None found.

Features:
(shadow sort mail-extr emacsbug message rmc dired dired-loaddefs rfc822
mml mml-sec epa epg epg-config gnus-util rmail rmail-loaddefs time-date
mm-decode mm-bodies mm-encode mail-parse rfc2231 mailabbrev gmm-utils
mailheader sendmail rfc2047 rfc2045 ietf-drums mm-util mail-prsvr
mail-utils phst skeleton derived edmacro kmacro pcase ffap thingatpt url
url-proxy url-privacy url-expand url-methods url-history url-cookie
url-domsuf url-util url-parse auth-source cl-seq eieio eieio-core
cl-macs eieio-loaddefs password-cache json map url-vars mailcap rx
gnutls puny dbus xml subr-x seq byte-opt gv bytecomp byte-compile cconv
compile text-property-search comint ansi-color ring cl-loaddefs cl-lib
iso-transl tooltip eldoc electric uniquify ediff-hook vc-hooks
lisp-float-type mwheel term/x-win x-win term/common-win x-dnd tool-bar
dnd fontset image regexp-opt fringe tabulated-list replace newcomment
text-mode elisp-mode lisp-mode prog-mode register page tab-bar menu-bar
rfn-eshadow isearch easymenu timer select scroll-bar mouse jit-lock
font-lock syntax font-core term/tty-colors frame minibuffer cl-generic
cham georgian utf-8-lang misc-lang vietnamese tibetan thai tai-viet lao
korean japanese eucjp-ms cp51932 hebrew greek romanian slovak czech
european ethiopic indian cyrillic chinese composite charscript charprop
case-table epa-hook jka-cmpr-hook help simple abbrev obarray
cl-preloaded nadvice button loaddefs faces cus-face macroexp files
window text-properties overlay sha1 md5 base64 format env code-pages
mule custom widget hashtable-print-readable backquote threads dbusbind
inotify dynamic-setting system-font-setting font-render-setting cairo
move-toolbar gtk x-toolkit x multi-tty make-network-process emacs)

Memory information:
((conses 16 69290 8084)
 (symbols 48 8419 3)
 (strings 32 24379 1940)
 (string-bytes 1 789215)
 (vectors 16 15071)
 (vector-slots 8 195720 4876)
 (floats 8 26 32)
 (intervals 56 223 0)
 (buffers 992 11))

-- 
Google Germany GmbH
Erika-Mann-Straße 33
80636 München

Geschäftsführer: Paul Manicle, Halimah DeLaine Prado
Registergericht und -nummer: Hamburg, HRB 86891
Sitz der Gesellschaft: Hamburg

Diese E-Mail ist vertraulich.  Falls Sie diese fälschlicherweise erhalten haben
sollten, leiten Sie diese bitte nicht an jemand anderes weiter, löschen Sie
alle Kopien und Anhänge davon und lassen Sie mich bitte wissen, dass die E-Mail
an die falsche Person gesendet wurde.

This e-mail is confidential.  If you received this communication by mistake,
please don’t forward it to anyone else, please erase all copies and
attachments, and please let me know that it has gone to the wrong person.

Message #8 received at 48176 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 48176 <at> debbugs.gnu.org
Subject: Re: bug#48176: 28.0.50; loadup.el leaves some variables in the
 lexical environment
Date: Mon, 03 May 2021 10:09:00 +0200

Philipp Stephani <p.stephani2 <at> gmail.com> writes:

> After starting Emacs, some spurious variables like `output' or `success'
> are bound.  It looks like they come from loadup.el. 

Oh, interesting.  So it's these that are in the lexical environment when
we're dumping:

    (let ((output (cond ((equal dump-mode "pdump") "emacs.pdmp")
[...]
      (let (success)
        (unwind-protect
             (let ((tmp-dump-mode dump-mode)
                   (dump-mode nil))
               (if (member tmp-dump-mode '("pdump" "pbootstrap"))
                   (dump-emacs-portable (expand-file-name output invocation-directory))
                 (dump-emacs output "temacs")

I guess we could rename the variables to something with a private
prefix, but that's kinda hacky.  Do we have a way to remove some symbols
from the lexical environment?  I.e., extend `dump-emacs-portable' to
take a list of symbols to remove from the dumped lexical environment?
Or...  should the dumper just set the variable to (t)?  (I'm not very
familiar with the internals of how that's supposed to work...)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Message #11 received at 48176 <at> debbugs.gnu.org (full text, mbox):

From: Philipp <p.stephani2 <at> gmail.com>
To: Lars Ingebrigtsen <larsi <at> gnus.org>
Cc: 48176 <at> debbugs.gnu.org
Subject: Re: bug#48176: 28.0.50; loadup.el leaves some variables in the
 lexical environment
Date: Mon, 3 May 2021 10:19:00 +0200

> Am 03.05.2021 um 10:09 schrieb Lars Ingebrigtsen <larsi <at> gnus.org>:
> should the dumper just set the variable to (t)?

You mean specbinding `internal-interpreter-environment'?  That might work, though I haven't tried.

Message #14 received at 48176 <at> debbugs.gnu.org (full text, mbox):

From: Lars Ingebrigtsen <larsi <at> gnus.org>
To: Philipp Stephani <p.stephani2 <at> gmail.com>
Cc: 48176 <at> debbugs.gnu.org
Subject: Re: bug#48176: 28.0.50; loadup.el leaves some variables in the
 lexical environment
Date: Fri, 01 Jul 2022 13:20:56 +0200

Lars Ingebrigtsen <larsi <at> gnus.org> writes:

>> After starting Emacs, some spurious variables like `output' or `success'
>> are bound.  It looks like they come from loadup.el. 
>
> Oh, interesting.  So it's these that are in the lexical environment when
> we're dumping:
>
>     (let ((output (cond ((equal dump-mode "pdump") "emacs.pdmp")
> [...]
>       (let (success)
>         (unwind-protect
>              (let ((tmp-dump-mode dump-mode)
>                    (dump-mode nil))
>                (if (member tmp-dump-mode '("pdump" "pbootstrap"))
>                    (dump-emacs-portable (expand-file-name output invocation-directory))
>                  (dump-emacs output "temacs")

I'm no longer able to reproduce this problem in Emacs 29, so I'm
guessing it's been fixed in the meantime, and I'm closing this bug
report.  (`output' is still bound around the `dump-emacs' call, so it's
not just a variable rename thing.)

-- 
(domestic pets only, the antidote for overdose, milk.)
   bloggy blog: http://lars.ingebrigtsen.no

Previous Next

GNU bug tracking system
Copyright (C) 1999 Darren O. Benham, 1997,2003 nCipher Corporation Ltd, 1994-97 Ian Jackson.